150732 2015-10-30 13:27:41 -0700 Use convenience function in sandbox profile 2015-11-01 17:02:22 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build iPhone / iPad All RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham andersca bfulgham commit-queue ddkilzer thorton webkit-bug-importer oldest_to_newest 1137941 0 bfulgham 2015-10-30 13:27:41 -0700 This bug cleans up one of the sandbox profiles by using a convenience function to define the proper logging setup, rather than manually specifying each piece of the log directory permissions required. 1137942 1 264412 bfulgham 2015-10-30 13:36:30 -0700 Created attachment 264412 Patch 1137943 2 bfulgham 2015-10-30 13:37:14 -0700 <rdar://problem/23287894> 1137947 3 264412 ggaren 2015-10-30 13:42:20 -0700 Comment on attachment 264412 Patch Is awd-log-directory available on older OS's? 1138002 4 bfulgham 2015-10-30 15:30:44 -0700 (In reply to comment #3) > Comment on attachment 264412 [details] > Patch > > Is awd-log-directory available on older OS's? This profile is only used on iOS. The function was added in iOS 9, so it's really only usable on current builds. But I'm not sure if we support building WebKit on older iOS revisions. 1138110 5 264412 ap 2015-10-30 20:35:14 -0700 Comment on attachment 264412 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264412&action=review > Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:-84 > -(allow mach-lookup (global-name "com.apple.awdd")) Is this unnecessary? 1138403 6 264412 bfulgham 2015-11-01 15:51:26 -0800 Comment on attachment 264412 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264412&action=review >> Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:-84 >> -(allow mach-lookup (global-name "com.apple.awdd")) > > Is this unnecessary? It's done as part of the (awd-log-directory ...) function. 1138424 7 264412 commit-queue 2015-11-01 17:02:19 -0800 Comment on attachment 264412 Patch Clearing flags on attachment: 264412 Committed r191872: <http://trac.webkit.org/changeset/191872> 1138425 8 commit-queue 2015-11-01 17:02:22 -0800 All reviewed patches have been landed. Closing bug. 264412 2015-10-30 13:36:30 -0700 2015-11-01 17:02:19 -0800 Patch bug-150732-20151030133537.patch text/plain 1457 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MTgwOSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTEwLTMwICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIFVzZSBjb252ZW5pZW5jZSBm dW5jdGlvbiBpbiBzYW5kYm94IHByb2ZpbGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE1MDczMgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjMyODc4 OTQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBS ZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQu c2I6IFN3aXRjaCB0bworICAgICAgICB0aGUgJ2F3ZC1sb2ctZGlyZWN0b3J5JyBjb252ZW5pZW5j ZSBmdW5jdGlvbi4KKwogMjAxNS0xMC0zMCAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+ CiAKICAgICAgICAgQW5vdGhlciBzcGVjdWxhdGl2ZSBidWlsZCBmaXguCkluZGV4OiBTb3VyY2Uv V2ViS2l0Mi9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0Lldl YkNvbnRlbnQuc2IKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvUmVzb3VyY2VzL1NhbmRi b3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiCShyZXZpc2lvbiAx OTE3NTQpCisrKyBTb3VyY2UvV2ViS2l0Mi9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9j b20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2IJKHdvcmtpbmcgY29weSkKQEAgLTgxLDEwICs4 MSw2IEBACiAoZGVueSBmaWxlLXJlYWQteGF0dHIgZmlsZS13cml0ZS14YXR0ciAoeGF0dHItcmVn ZXggIyJeY29tXC5hcHBsZVwuc2VjdXJpdHlcLnByaXZhdGVcLiIpKQogCiA7OyBBV0QgbG9nZ2lu ZwotKGFsbG93IG1hY2gtbG9va3VwIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmF3ZGQiKSkKLShh bGxvdy1jcmVhdGUtZGlyZWN0b3J5Ci0gICAgKGxpdGVyYWwgIi9wcml2YXRlL3Zhci9tb2JpbGUv TGlicmFyeS9Mb2dzL2F3ZCIpKQotKGFsbG93IGZpbGUtcmVhZCogZmlsZS13cml0ZSoKLSAgICAo c3VicGF0aCAiL3ByaXZhdGUvdmFyL21vYmlsZS9MaWJyYXJ5L0xvZ3MvYXdkIikpCisoYXdkLWxv Zy1kaXJlY3RvcnkgImNvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudCIpCiAKIChuZXR3b3JrLWNs aWVudCAocmVtb3RlIHRjcCkgKHJlbW90ZSB1ZHApKQo=