15073 2007-08-24 13:36:35 -0700 REGRESSION: Often can't drag text out of textareas. 2007-08-25 09:41:19 -0700 1 1 1 Unclassified WebKit Forms 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED InRadar P1 Normal --- 1 adele webkit-unassigned mitz oldest_to_newest 1533 0 adele 2007-08-24 13:36:35 -0700 In the attached test case, select the word "test" and try to drag it out of the textarea and into the text field. I think this is caused by the change in hit testing for text controls. Now we get the inner div as the hit test result, and when EventHandler::shouldDragAutoNode gets called (eventually on the textarea itself), it fails because the textarea isn't a leaf node. <rdar://problem/5426557> 1530 1 16109 adele 2007-08-24 13:37:55 -0700 Created attachment 16109 testcase 1519 2 mitz 2007-08-24 17:06:50 -0700 (In reply to comment #0) > I think this is caused by the change in hit testing for text controls. Now we > get the inner div as the hit test result, and when > EventHandler::shouldDragAutoNode gets called (eventually on the textarea > itself), it fails because the textarea isn't a leaf node. I agree. I think the special hit-testing should be reserved to text controls while they're actually displaying placeholder text. I am going to make that patch. 1513 3 16114 adele 2007-08-24 19:36:26 -0700 Created attachment 16114 patch I took a stab at this... Still needs a layout test though. Passes existing tests. 1508 4 16114 mitz 2007-08-24 23:30:13 -0700 Comment on attachment 16114 patch r=me assuming you add a test 1481 5 adele 2007-08-25 09:41:19 -0700 Committed revision 25245. 16109 2007-08-24 13:37:55 -0700 2007-08-24 13:37:55 -0700 testcase text_area.html text/html 42 adele PHA+PHRleHRhcmVhPnRlc3Q8L3RleHRhcmVhPjwvcD4NPGlucHV0Pg0N 16114 2007-08-24 19:36:26 -0700 2007-08-24 23:30:13 -0700 patch patch.txt text/plain 2004 adele SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI1MjMw KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDctMDgt MjQgIEFkZWxlIFBldGVyc29uICA8YWRlbGVAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBmb3IgaHR0cDovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwNzMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU0MjY1 NTc+IFJFR1JFU1NJT046IENhbiBubyBsb25nZXIgZHJhZyB0ZXh0IGZyb20gdGV4dGFyZWFzCisg ICAgICAgIAorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUZXh0Q29udHJvbC5jcHA6IChXZWJD b3JlOjpSZW5kZXJUZXh0Q29udHJvbElubmVyQmxvY2s6Om5vZGVBdFBvaW50KToKKyAgICAgICAg ICBPbmx5IHJlc3RyaWN0cyBoaXQgdGVzdGluZyBpZiB0aGUgcGxhY2Vob2xkZXIgdGV4dCBpcyB2 aXNpYmxlLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUZXh0Q29udHJvbC5oOiAoV2ViQ29y ZTo6UmVuZGVyVGV4dENvbnRyb2w6OnBsYWNlaG9sZGVySXNWaXNpYmxlKTogQWRkZWQuIAorCiAy MDA3LTA4LTIzICBKdXN0aW4gR2FyY2lhICA8anVzdGluLmdhcmNpYUBhcHBsZS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4uCkluZGV4OiByZW5kZXJpbmcvUmVuZGVyVGV4dENvbnRy b2wuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIHJlbmRlcmluZy9SZW5kZXJUZXh0Q29udHJvbC5jcHAJKHJl dmlzaW9uIDI1MjI4KQorKysgcmVuZGVyaW5nL1JlbmRlclRleHRDb250cm9sLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNjIsNyArNjIsOSBAQCBwdWJsaWM6CiAKIGJvb2wgUmVuZGVyVGV4dENvbnRy b2xJbm5lckJsb2NrOjpub2RlQXRQb2ludChjb25zdCBIaXRUZXN0UmVxdWVzdCYgcmVxdWVzdCwg SGl0VGVzdFJlc3VsdCYgcmVzdWx0LCBpbnQgeCwgaW50IHksIGludCB0eCwgaW50IHR5LCBIaXRU ZXN0QWN0aW9uIGhpdFRlc3RBY3Rpb24pCiB7Ci0gICAgcmV0dXJuIFJlbmRlckJsb2NrOjpub2Rl QXRQb2ludChyZXF1ZXN0LCByZXN1bHQsIHgsIHksIHR4LCB0eSwgSGl0VGVzdEJsb2NrQmFja2dy b3VuZCk7CisgICAgUmVuZGVyVGV4dENvbnRyb2wqIHJlbmRlcmVyID0gc3RhdGljX2Nhc3Q8UmVu ZGVyVGV4dENvbnRyb2wqPihub2RlKCktPnNoYWRvd0FuY2VzdG9yTm9kZSgpLT5yZW5kZXJlcigp KTsKKyAgICAKKyAgICByZXR1cm4gUmVuZGVyQmxvY2s6Om5vZGVBdFBvaW50KHJlcXVlc3QsIHJl c3VsdCwgeCwgeSwgdHgsIHR5LCByZW5kZXJlci0+cGxhY2Vob2xkZXJJc1Zpc2libGUoKSA/IEhp dFRlc3RCbG9ja0JhY2tncm91bmQgOiBoaXRUZXN0QWN0aW9uKTsKIH0KIAogUmVuZGVyVGV4dENv bnRyb2w6OlJlbmRlclRleHRDb250cm9sKE5vZGUqIG5vZGUsIGJvb2wgbXVsdGlMaW5lKQpJbmRl eDogcmVuZGVyaW5nL1JlbmRlclRleHRDb250cm9sLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcmVuZGVyaW5n L1JlbmRlclRleHRDb250cm9sLmgJKHJldmlzaW9uIDI1MjI4KQorKysgcmVuZGVyaW5nL1JlbmRl clRleHRDb250cm9sLmgJKHdvcmtpbmcgY29weSkKQEAgLTk5LDYgKzk5LDggQEAgcHVibGljOgog ICAgIHZvaWQgaGlkZVBvcHVwKCk7CiAKICAgICB2b2lkIHN0b3BTZWFyY2hFdmVudFRpbWVyKCk7 CisgICAgCisgICAgYm9vbCBwbGFjZWhvbGRlcklzVmlzaWJsZSgpIGNvbnN0IHsgcmV0dXJuIG1f cGxhY2Vob2xkZXJWaXNpYmxlOyB9CiAKIHByaXZhdGU6CiAgICAgLy8gUG9wdXBNZW51Q2xpZW50 IG1ldGhvZHMK