150713 2015-10-29 23:03:52 -0700 REGRESSION(r191776): EFL build broken. 2015-10-30 06:17:31 -0700 1 1 1 Unclassified WebKit WebKit EFL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 150695 1 hs85.jeong hs85.jeong achristensen alecflett beidson commit-queue gyuyoung.kim jsbell lucas.de.marchi ossy oldest_to_newest 1137814 0 hs85.jeong 2015-10-29 23:03:52 -0700 ../../Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp: In member function ‘void WebCore::IDBServer::UniqueIDBDatabase::performPutOrAdd(uint64_t, const WebCore::IDBResourceIdentifier&, uint64_t, const WebCore::IDBKeyData&, const WebCore::ThreadSafeDataBuffer&, WebCore::IndexedDB::ObjectStoreOverwriteMode)’: ../../Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp:316:10: error: variable ‘keyWasGenerated’ set but not used [-Werror=unused-but-set-variable] bool keyWasGenerated = false; ^ 1137815 1 264382 hs85.jeong 2015-10-29 23:09:43 -0700 Created attachment 264382 Patch 1137816 2 hs85.jeong 2015-10-29 23:10:10 -0700 EFL build failed because 'keyWasGenerated' was unused. Do you have additional patch to use the 'keyWasGenerated'? 1137821 3 264382 achristensen 2015-10-30 00:09:12 -0700 Comment on attachment 264382 Patch Just remove keyWasGenerated completely. It is indeed not used, and if we need to use it, we will add it. rs=me for doing that. 1137822 4 264384 hs85.jeong 2015-10-30 00:12:23 -0700 Created attachment 264384 Patch 1137823 5 hs85.jeong 2015-10-30 00:13:03 -0700 (In reply to comment #3) > Comment on attachment 264382 [details] > Patch > > Just remove keyWasGenerated completely. It is indeed not used, and if we > need to use it, we will add it. rs=me for doing that. Okay, I removed it. 1137827 6 264384 commit-queue 2015-10-30 01:02:06 -0700 Comment on attachment 264384 Patch Clearing flags on attachment: 264384 Committed r191781: <http://trac.webkit.org/changeset/191781> 1137828 7 commit-queue 2015-10-30 01:02:10 -0700 All reviewed patches have been landed. Closing bug. 1137859 8 beidson 2015-10-30 06:17:31 -0700 Sorry, didn't see this because the EFL bot was in the "build broken even without this patch" state 264382 2015-10-29 23:09:43 -0700 2015-10-30 00:12:13 -0700 Patch bug-150713-20151030150850.patch text/plain 1286 hs85.jeong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MTc3OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE1LTEwLTI5ICBIdW5zZW9w IEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIx OTE3NzYpOiBFRkwgYnVpbGQgYnJva2VuLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTUwNzEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBNb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIvVW5pcXVlSURCRGF0 YWJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SURCU2VydmVyOjpVbmlxdWVJREJEYXRhYmFz ZTo6cGVyZm9ybVB1dE9yQWRkKToKKwogMjAxNS0xMC0yOSAgQnJhZHkgRWlkc29uICA8YmVpZHNv bkBhcHBsZS5jb20+CiAKICAgICAgICAgTW9kZXJuIElEQjogYXV0b0luY3JlbWVudCBzdXBwb3J0 LgpJbmRleDogU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL1VuaXF1ZUlE QkRhdGFiYXNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4 ZWRkYi9zZXJ2ZXIvVW5pcXVlSURCRGF0YWJhc2UuY3BwCShyZXZpc2lvbiAxOTE3NzgpCisrKyBT b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIvVW5pcXVlSURCRGF0YWJhc2Uu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMzQsOCArMzM0LDEwIEBAIHZvaWQgVW5pcXVlSURCRGF0 YWJhc2U6OnBlcmZvcm1QdXRPckFkZCgKICAgICAgICAgCiAgICAgICAgIHVzZWRLZXkuc2V0TnVt YmVyVmFsdWUoa2V5TnVtYmVyKTsKICAgICAgICAga2V5V2FzR2VuZXJhdGVkID0gdHJ1ZTsKLSAg ICB9IGVsc2UKKyAgICB9IGVsc2UgewogICAgICAgICB1c2VkS2V5ID0ga2V5RGF0YTsKKyAgICAg ICAgVU5VU0VEX1BBUkFNKGtleVdhc0dlbmVyYXRlZCk7CisgICAgfQogCiAgICAgaWYgKG92ZXJ3 cml0ZU1vZGUgPT0gSW5kZXhlZERCOjpPYmplY3RTdG9yZU92ZXJ3cml0ZU1vZGU6Ok5vT3Zlcndy aXRlKSB7CiAgICAgICAgIGJvb2wga2V5RXhpc3RzOwo= 264384 2015-10-30 00:12:23 -0700 2015-10-30 01:02:06 -0700 Patch bug-150713-20151030161130.patch text/plain 1343 hs85.jeong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MTc4MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE1LTEwLTMwICBIdW5zZW9w IEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIx OTE3NzYpOiBFRkwgYnVpbGQgYnJva2VuLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTUwNzEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBNb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIvVW5pcXVlSURCRGF0 YWJhc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SURCU2VydmVyOjpVbmlxdWVJREJEYXRhYmFz ZTo6cGVyZm9ybVB1dE9yQWRkKToKKwogMjAxNS0xMC0yOSAgQnJhZHkgRWlkc29uICA8YmVpZHNv bkBhcHBsZS5jb20+CiAKICAgICAgICAgTW9kZXJuIElEQjogYXV0b0luY3JlbWVudCBzdXBwb3J0 LgpJbmRleDogU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvc2VydmVyL1VuaXF1ZUlE QkRhdGFiYXNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4 ZWRkYi9zZXJ2ZXIvVW5pcXVlSURCRGF0YWJhc2UuY3BwCShyZXZpc2lvbiAxOTE3NzgpCisrKyBT b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9zZXJ2ZXIvVW5pcXVlSURCRGF0YWJhc2Uu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMTMsNyArMzEzLDYgQEAgdm9pZCBVbmlxdWVJREJEYXRh YmFzZTo6cGVyZm9ybVB1dE9yQWRkKAogICAgIEFTU0VSVChtX2JhY2tpbmdTdG9yZSk7CiAgICAg QVNTRVJUKG9iamVjdFN0b3JlSWRlbnRpZmllcik7CiAKLSAgICBib29sIGtleVdhc0dlbmVyYXRl ZCA9IGZhbHNlOwogICAgIElEQktleURhdGEgdXNlZEtleTsKICAgICBJREJFcnJvciBlcnJvcjsK IApAQCAtMzMzLDcgKzMzMiw2IEBAIHZvaWQgVW5pcXVlSURCRGF0YWJhc2U6OnBlcmZvcm1QdXRP ckFkZCgKICAgICAgICAgfQogICAgICAgICAKICAgICAgICAgdXNlZEtleS5zZXROdW1iZXJWYWx1 ZShrZXlOdW1iZXIpOwotICAgICAgICBrZXlXYXNHZW5lcmF0ZWQgPSB0cnVlOwogICAgIH0gZWxz ZQogICAgICAgICB1c2VkS2V5ID0ga2V5RGF0YTsKIAo=