150711 2015-10-29 22:02:42 -0700 Modern IDB: IDBObjectStore.add() support 2015-10-30 10:17:59 -0700 1 1 1 Unclassified WebKit WebCore Misc. Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 149117 1 beidson webkit-unassigned achristensen alecflett commit-queue jsbell oldest_to_newest 1137797 0 beidson 2015-10-29 22:02:42 -0700 Modern IDB: IDBObjectStore.add() support 1137861 1 264394 beidson 2015-10-30 06:20:38 -0700 Created attachment 264394 Patch v1 1137883 2 264394 commit-queue 2015-10-30 10:17:56 -0700 Comment on attachment 264394 Patch v1 Clearing flags on attachment: 264394 Committed r191795: <http://trac.webkit.org/changeset/191795> 1137884 3 commit-queue 2015-10-30 10:17:59 -0700 All reviewed patches have been landed. Closing bug. 264394 2015-10-30 06:20:38 -0700 2015-10-30 10:17:56 -0700 Patch v1 patch text/plain 6914 beidson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxNDZiNDhlLi5kY2FjYjRiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTUtMTAt MzAgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIE1vZGVybiBJ REI6IElEQk9iamVjdFN0b3JlLmFkZCgpIHN1cHBvcnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTA3MTEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0b3JhZ2UvaW5kZXhlZGRiL21vZGVybi9iYXNp Yy1hZGQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBzdG9yYWdlL2luZGV4ZWRkYi9t b2Rlcm4vYmFzaWMtYWRkLmh0bWw6IEFkZGVkLgorCiAyMDE1LTEwLTI5ICBCcmFkeSBFaWRzb24g IDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBNb2Rlcm4gSURCOiBhdXRvSW5jcmVtZW50 IHN1cHBvcnQuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9tb2Rl cm4vYmFzaWMtYWRkLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRi L21vZGVybi9iYXNpYy1hZGQtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAuLjMyZTk0MmUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9zdG9yYWdl L2luZGV4ZWRkYi9tb2Rlcm4vYmFzaWMtYWRkLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDEwIEBA CitBTEVSVDogVXBncmFkZSBuZWVkZWQ6IE9sZCB2ZXJzaW9uIC0gMCBOZXcgdmVyc2lvbiAtIDEK K0FMRVJUOiBbb2JqZWN0IElEQlRyYW5zYWN0aW9uXSAtIHZlcnNpb25jaGFuZ2UKK0FMRVJUOiBb b2JqZWN0IElEQkRhdGFiYXNlXQorQUxFUlQ6IHB1dCAxIHN1Y2NlZWRlZCAtIGtleSB3YXMgJ2Zv bycKK0FMRVJUOiBwdXQgMiBmYWlsZWQgLSBlcnJvcgorQUxFUlQ6IGdldCBzdWNjZWVkZWQgLSBr ZXkgd2FzICdiYXInCitBTEVSVDogdmVyc2lvbiBjaGFuZ2UgdHJhbnNhY3Rpb24gY29tcGxldGVk CitBTEVSVDogRG9uZQorVGhpcyB0ZXN0IGRvZXMgYmFzaWMgdGVzdGluZyBvZiBJREJPYmplY3RT dG9yZS5hZGQoKSwgbWFraW5nIHN1cmUgdGhhdCBhbiBhdHRlbXB0IHRvIG92ZXJ3cml0ZSBhbiBh bHJlYWR5LWV4aXN0aW5nIGtleSBmYWlscyB3aXRoIHRoZSBhcHByb3ByaWF0ZSBlcnJvci4KKwpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvbW9kZXJuL2Jhc2ljLWFk ZC5odG1sIGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvbW9kZXJuL2Jhc2ljLWFkZC5o dG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmY3YzllYTQKLS0tIC9kZXYv bnVsbAorKysgYi9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9tb2Rlcm4vYmFzaWMtYWRk Lmh0bWwKQEAgLTAsMCArMSw3NyBAQAorVGhpcyB0ZXN0IGRvZXMgYmFzaWMgdGVzdGluZyBvZiBJ REJPYmplY3RTdG9yZS5hZGQoKSwgbWFraW5nIHN1cmUgdGhhdCBhbiBhdHRlbXB0IHRvIG92ZXJ3 cml0ZSBhbiBhbHJlYWR5LWV4aXN0aW5nIGtleSBmYWlscyB3aXRoIHRoZSBhcHByb3ByaWF0ZSBl cnJvci48YnI+Cis8c2NyaXB0PgorCitpZiAod2luZG93LnRlc3RSdW5uZXIpIHsKKyAgICB0ZXN0 UnVubmVyLndhaXRVbnRpbERvbmUoKTsKKyAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKK30K KwordmFyIHJlcXVlc3QgPSB3aW5kb3cuaW5kZXhlZERCLm9wZW4oIk5ld0RhdGFiYXNlQWRkVGVz dERhdGFiYXNlIik7CisKK2Z1bmN0aW9uIGRvbmUoKQoreworICAgIGFsZXJ0KCJEb25lIik7Cisg ICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgICAgICB0ZXN0UnVubmVyLm5vdGlmeURvbmUo KTsKK30KKworcmVxdWVzdC5vbnVwZ3JhZGVuZWVkZWQgPSBmdW5jdGlvbihldmVudCkgeworICAg IGFsZXJ0KCJVcGdyYWRlIG5lZWRlZDogT2xkIHZlcnNpb24gLSAiICsgZXZlbnQub2xkVmVyc2lv biArICIgTmV3IHZlcnNpb24gLSAiICsgZXZlbnQubmV3VmVyc2lvbik7CisgICAgCisgICAgdmFy IHR4ID0gcmVxdWVzdC50cmFuc2FjdGlvbjsKKyAgICB2YXIgZGIgPSBldmVudC50YXJnZXQucmVz dWx0OworCisgICAgYWxlcnQodHggKyAiIC0gIiArIHR4Lm1vZGUpOworICAgIGFsZXJ0KGRiKTsK KworICAgIHZhciBvcyA9IGRiLmNyZWF0ZU9iamVjdFN0b3JlKCJUZXN0T2JqZWN0U3RvcmUiKTsK KyAgICB2YXIgcHV0UmVxdWVzdDEgPSBvcy5hZGQoImJhciIsICJmb28iKTsKKyAgICB2YXIgcHV0 UmVxdWVzdDIgPSBvcy5hZGQoImJheiIsICJmb28iKTsKKworICAgIHB1dFJlcXVlc3QxLm9uc3Vj Y2VzcyA9IGZ1bmN0aW9uKGV2ZW50KSB7CisgICAgICAgIGFsZXJ0KCJwdXQgMSBzdWNjZWVkZWQg LSBrZXkgd2FzICciICsgcHV0UmVxdWVzdDEucmVzdWx0ICsgIiciKTsKKyAgICB9CisKKyAgICBw dXRSZXF1ZXN0MS5vbmVycm9yID0gZnVuY3Rpb24oZXZlbnQpIHsKKyAgICAgICAgYWxlcnQoInB1 dCAxIHVuZXhwZWN0ZWRseSBmYWlsZWQgLSAiICsgZXZlbnQpOworICAgICAgICBkb25lKCk7Cisg ICAgfQorCisgICAgcHV0UmVxdWVzdDIub25zdWNjZXNzID0gZnVuY3Rpb24oZXZlbnQpIHsKKyAg ICAgICAgYWxlcnQoInB1dCAyIHVuZXhwZWN0ZWRseSBzdWNjZWVkZWQgLSBrZXkgd2FzICciICsg cHV0UmVxdWVzdDIucmVzdWx0ICsgIiciKTsKKyAgICAgICAgZG9uZSgpOworICAgIH0KKworICAg IHB1dFJlcXVlc3QyLm9uZXJyb3IgPSBmdW5jdGlvbihldmVudCkgeworICAgICAgICBhbGVydCgi cHV0IDIgZmFpbGVkIC0gIiArIGV2ZW50LnR5cGUpOworCisgICAgICAgIHZhciBnZXRSZXF1ZXN0 ID0gb3MuZ2V0KCJmb28iKTsKKyAgICAgICAgCisgICAgICAgIGdldFJlcXVlc3Qub25zdWNjZXNz ID0gZnVuY3Rpb24oZXZlbnQpIHsKKyAgICAgICAgICAgIGFsZXJ0KCJnZXQgc3VjY2VlZGVkIC0g a2V5IHdhcyAnIiArIGdldFJlcXVlc3QucmVzdWx0ICsgIiciKTsKKyAgICAgICAgfQorCisgICAg ICAgIGdldFJlcXVlc3Qub25lcnJvciA9IGZ1bmN0aW9uKGV2ZW50KSB7CisgICAgICAgICAgICBh bGVydCgiZ2V0IHVuZXhwZWN0ZWRseSBmYWlsZWQgLSAiICsgZXZlbnQudHlwZSk7CisgICAgICAg ICAgICBkb25lKCk7CisgICAgICAgIH0KKyAgICAgICAgCisgICAgICAgIGV2ZW50LnN0b3BQcm9w YWdhdGlvbigpOworICAgIH0KKyAgICAgICAgCisgICAgdHgub25hYm9ydCA9IGZ1bmN0aW9uKGV2 ZW50KSB7CisgICAgICAgIGFsZXJ0KCJ2ZXJzaW9uIGNoYW5nZSB0cmFuc2FjdGlvbiB1bmV4cGVj dGVkIGFib3J0Iik7CisgICAgICAgIGRvbmUoKTsKKyAgICB9CisKKyAgICB0eC5vbmNvbXBsZXRl ID0gZnVuY3Rpb24oZXZlbnQpIHsKKyAgICAgICAgYWxlcnQoInZlcnNpb24gY2hhbmdlIHRyYW5z YWN0aW9uIGNvbXBsZXRlZCIpOworICAgICAgICBkb25lKCk7CisgICAgfQorCisgICAgdHgub25l cnJvciA9IGZ1bmN0aW9uKGV2ZW50KSB7CisgICAgICAgIGFsZXJ0KCJ2ZXJzaW9uIGNoYW5nZSB0 cmFuc2FjdGlvbiB1bmV4cGVjdGVkIGVycm9yIC0gIiArIGV2ZW50KTsKKyAgICAgICAgZG9uZSgp OworICAgIH0KK30KKzwvc2NyaXB0PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDg1ODhmMGUuLjg5MGNkOTUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxNS0xMC0zMCAgQnJhZHkgRWlkc29uICA8YmVp ZHNvbkBhcHBsZS5jb20+CisKKyAgICAgICAgTW9kZXJuIElEQjogSURCT2JqZWN0U3RvcmUuYWRk KCkgc3VwcG9ydC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE1MDcxMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRlc3Q6IHN0b3JhZ2UvaW5kZXhlZGRiL21vZGVybi9iYXNpYy1hZGQuaHRtbAorCisgICAg ICAgICogTW9kdWxlcy9pbmRleGVkZGIvY2xpZW50L0lEQk9iamVjdFN0b3JlSW1wbC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpJREJDbGllbnQ6OklEQk9iamVjdFN0b3JlOjphZGQpOgorCisgICAg ICAgICogTW9kdWxlcy9pbmRleGVkZGIvY2xpZW50L0lEQlRyYW5zYWN0aW9uSW1wbC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpJREJDbGllbnQ6OklEQlRyYW5zYWN0aW9uOjpyZXF1ZXN0R2V0UmVj b3JkKToKKwogMjAxNS0xMC0yOSAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAK ICAgICAgICAgTW9kZXJuIElEQjogYXV0b0luY3JlbWVudCBzdXBwb3J0LgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvY2xpZW50L0lEQk9iamVjdFN0b3JlSW1w bC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9jbGllbnQvSURCT2JqZWN0 U3RvcmVJbXBsLmNwcAppbmRleCBhYzU4ZTU1Li5jY2UyYjFkIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9jbGllbnQvSURCT2JqZWN0U3RvcmVJbXBsLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9jbGllbnQvSURCT2JqZWN0U3Rv cmVJbXBsLmNwcApAQCAtODYsOSArODYsOSBAQCBib29sIElEQk9iamVjdFN0b3JlOjphdXRvSW5j cmVtZW50KCkgY29uc3QKICAgICByZXR1cm4gbV9pbmZvLmF1dG9JbmNyZW1lbnQoKTsKIH0KIAot UmVmUHRyPFdlYkNvcmU6OklEQlJlcXVlc3Q+IElEQk9iamVjdFN0b3JlOjphZGQoSlNDOjpFeGVj U3RhdGUmLCBEZXByZWNhdGVkOjpTY3JpcHRWYWx1ZSYsIEV4Y2VwdGlvbkNvZGUmKQorUmVmUHRy PFdlYkNvcmU6OklEQlJlcXVlc3Q+IElEQk9iamVjdFN0b3JlOjphZGQoSlNDOjpFeGVjU3RhdGUm IHN0YXRlLCBEZXByZWNhdGVkOjpTY3JpcHRWYWx1ZSYgdmFsdWUsIEV4Y2VwdGlvbkNvZGUmIGVj KQogewotICAgIFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgcmV0dXJuIHB1dE9y QWRkKHN0YXRlLCB2YWx1ZSwgbnVsbHB0ciwgSW5kZXhlZERCOjpPYmplY3RTdG9yZU92ZXJ3cml0 ZU1vZGU6Ok5vT3ZlcndyaXRlLCBlYyk7CiB9CiAKIFJlZlB0cjxXZWJDb3JlOjpJREJSZXF1ZXN0 PiBJREJPYmplY3RTdG9yZTo6cHV0KEpTQzo6RXhlY1N0YXRlJiBzdGF0ZSwgRGVwcmVjYXRlZDo6 U2NyaXB0VmFsdWUmIHZhbHVlLCBFeGNlcHRpb25Db2RlJiBlYykKQEAgLTE1Niw5ICsxNTYsMTAg QEAgUmVmUHRyPFdlYkNvcmU6OklEQlJlcXVlc3Q+IElEQk9iamVjdFN0b3JlOjpnZXQoU2NyaXB0 RXhlY3V0aW9uQ29udGV4dCosIElEQktleVIKICAgICBSRUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hF RCgpOwogfQogCi1SZWZQdHI8V2ViQ29yZTo6SURCUmVxdWVzdD4gSURCT2JqZWN0U3RvcmU6OmFk ZChKU0M6OkV4ZWNTdGF0ZSYsIERlcHJlY2F0ZWQ6OlNjcmlwdFZhbHVlJiwgY29uc3QgRGVwcmVj YXRlZDo6U2NyaXB0VmFsdWUmLCBFeGNlcHRpb25Db2RlJikKK1JlZlB0cjxXZWJDb3JlOjpJREJS ZXF1ZXN0PiBJREJPYmplY3RTdG9yZTo6YWRkKEpTQzo6RXhlY1N0YXRlJiBleGVjU3RhdGUsIERl cHJlY2F0ZWQ6OlNjcmlwdFZhbHVlJiB2YWx1ZSwgY29uc3QgRGVwcmVjYXRlZDo6U2NyaXB0VmFs dWUmIGtleSwgRXhjZXB0aW9uQ29kZSYgZWMpCiB7Ci0gICAgUkVMRUFTRV9BU1NFUlRfTk9UX1JF QUNIRUQoKTsKKyAgICBhdXRvIGlkYktleSA9IHNjcmlwdFZhbHVlVG9JREJLZXkoZXhlY1N0YXRl LCBrZXkpOworICAgIHJldHVybiBwdXRPckFkZChleGVjU3RhdGUsIHZhbHVlLCBpZGJLZXksIElu ZGV4ZWREQjo6T2JqZWN0U3RvcmVPdmVyd3JpdGVNb2RlOjpOb092ZXJ3cml0ZSwgZWMpOwogfQog CiBSZWZQdHI8V2ViQ29yZTo6SURCUmVxdWVzdD4gSURCT2JqZWN0U3RvcmU6OnB1dChKU0M6OkV4 ZWNTdGF0ZSYgZXhlY1N0YXRlLCBEZXByZWNhdGVkOjpTY3JpcHRWYWx1ZSYgdmFsdWUsIGNvbnN0 IERlcHJlY2F0ZWQ6OlNjcmlwdFZhbHVlJiBrZXksIEV4Y2VwdGlvbkNvZGUmIGVjKQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvY2xpZW50L0lEQlRyYW5zYWN0 aW9uSW1wbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9jbGllbnQvSURC VHJhbnNhY3Rpb25JbXBsLmNwcAppbmRleCBmMDhjMjQyLi5iYmFmNjZiIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9jbGllbnQvSURCVHJhbnNhY3Rpb25JbXBs LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2luZGV4ZWRkYi9jbGllbnQvSURCVHJh bnNhY3Rpb25JbXBsLmNwcApAQCAtMzg3LDcgKzM4Nyw3IEBAIHZvaWQgSURCVHJhbnNhY3Rpb246 OmRpZENyZWF0ZU9iamVjdFN0b3JlT25TZXJ2ZXIoY29uc3QgSURCUmVzdWx0RGF0YSYgcmVzdWx0 RGF0CiAKIFJlZjxJREJSZXF1ZXN0PiBJREJUcmFuc2FjdGlvbjo6cmVxdWVzdEdldFJlY29yZChT Y3JpcHRFeGVjdXRpb25Db250ZXh0JiBjb250ZXh0LCBJREJPYmplY3RTdG9yZSYgb2JqZWN0U3Rv cmUsIElEQktleSYga2V5KQogewotICAgIExPRyhJbmRleGVkREIsICJJREJUcmFuc2FjdGlvbjo6 cmVxdWVzdFB1dE9yQWRkIik7CisgICAgTE9HKEluZGV4ZWREQiwgIklEQlRyYW5zYWN0aW9uOjpy ZXF1ZXN0R2V0UmVjb3JkIik7CiAgICAgQVNTRVJUKGlzQWN0aXZlKCkpOwogICAgIEFTU0VSVChr ZXkuaXNWYWxpZCgpKTsKIAo=