15071 2007-08-24 10:44:20 -0700 [cairo] SVG skews are incorrect 2007-08-24 13:17:30 -0700 1 1 1 Unclassified WebKit New Bugs 523.x (Safari 3) All All RESOLVED FIXED http://www.croczilla.com/svg/samples/skew1/skew1.xml Cairo, Gtk P2 Normal --- 1 alp webkit-unassigned oldest_to_newest 1537 0 alp 2007-08-24 10:44:20 -0700 The SVG sample at http://www.croczilla.com/svg/samples/skew1/skew1.xml exhibits incorrect skewing, suggesting a problem with shear transforms in the Cairo graphics backend. 1538 1 16107 gwright 2007-08-24 10:52:58 -0700 Created attachment 16107 Proposed fix 1540 2 16107 aroben 2007-08-24 11:18:18 -0700 Comment on attachment 16107 Proposed fix The fix looks fine, but this needs a regression test. I'll r+ the patch once we have a test with results. 1542 3 16107 oliver 2007-08-24 12:32:21 -0700 Comment on attachment 16107 Proposed fix This is gtk only and the gtk port does not yet support drt. 1543 4 oliver 2007-08-24 12:43:38 -0700 Sending ChangeLog Sending platform/graphics/cairo/AffineTransformCairo.cpp Transmitting file data .. Committed revision 25214. 1535 5 aroben 2007-08-24 13:17:30 -0700 Oliver says that we have 3 tests that already cover SVG skew: svg/W3C-SVG-1.1/coords-trans-01-b, svg/W3C-SVG-1.1/pservers-grad-07-b, svg/W3C-SVG-1.1/linking-a-05-t. Presumably those tests would have failed on Gtk if Gtk were able to run the regression tests. So that's why we don't need a new test for this fix. 16107 2007-08-24 10:52:58 -0700 2007-08-24 12:32:21 -0700 Proposed fix affinetransform.patch text/plain 1279 gwright SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI1MjEz KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDctMDgt MjQgIEdlb3JnZSBXcmlnaHQgIDxnZW9yZ2Uud3JpZ2h0QGNvbGxhYm9yYS5jby51az4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTA3MQorICAgICAgICBbY2Fpcm9dIFNWRyBza2V3 cyBhcmUgaW5jb3JyZWN0CisKKyAgICAgICAgRml4IENhaXJvIGltcGxlbWVudGF0aW9uIG9mIEFm ZmluZVRyYW5zZm9ybTo6c2hlYXIgc28gdGhhdCBzaGVhcmluZyBpcworICAgICAgICBkb25lIGlu IHRoZSBjb3JyZWN0IGRpcmVjdGlvbi4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nh aXJvL0FmZmluZVRyYW5zZm9ybUNhaXJvLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFmZmluZVRy YW5zZm9ybTo6c2hlYXIpOgorCiAyMDA3LTA4LTIzICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNj YUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU3RldmUuCkluZGV4OiBwbGF0Zm9y bS9ncmFwaGljcy9jYWlyby9BZmZpbmVUcmFuc2Zvcm1DYWlyby5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g cGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vQWZmaW5lVHJhbnNmb3JtQ2Fpcm8uY3BwCShyZXZpc2lv biAyNTIxMykKKysrIHBsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0FmZmluZVRyYW5zZm9ybUNhaXJv LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjIxLDcgKzIyMSw3IEBAIEFmZmluZVRyYW5zZm9ybSAm QWZmaW5lVHJhbnNmb3JtOjp0cmFuc2wKIEFmZmluZVRyYW5zZm9ybSAmQWZmaW5lVHJhbnNmb3Jt OjpzaGVhcihkb3VibGUgc3gsIGRvdWJsZSBzeSkKIHsKICAgICBjYWlyb19tYXRyaXhfdCBzaGVh cjsKLSAgICBjYWlyb19tYXRyaXhfaW5pdCgmc2hlYXIsIDEsIHN4LCBzeSwgMSwgMCwgMCk7Cisg ICAgY2Fpcm9fbWF0cml4X2luaXQoJnNoZWFyLCAxLCBzeSwgc3gsIDEsIDAsIDApOwogCiAgICAg Y2Fpcm9fbWF0cml4X3QgcmVzdWx0OwogICAgIGNhaXJvX21hdHJpeF9tdWx0aXBseSgmcmVzdWx0 LCAmc2hlYXIsICZtX3RyYW5zZm9ybSk7Cg==