150700 2015-10-29 16:41:49 -0700 [Win] build-jsc and run-javascriptcore-tests do not work 2015-12-01 11:02:02 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build PC All RESOLVED FIXED P2 Normal --- 150707 1 bfulgham bfulgham achristensen bfulgham commit-queue dbates lforschler mark.lam msaboff ossy peavo oldest_to_newest 1137710 0 bfulgham 2015-10-29 16:41:49 -0700 The "run-javascript-core" script does not work following our switch to CMake on Windows, because it attempts to build using the increasingly-out-of-date "Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.sln" solution to build the various pieces of JSC. The actual failure was in the "build-jsc" script, which does not use the new CMake build system for Windows. This patch corrects this oversight, allowing JSC developers to build only the JavaScript-related files. (820 files instead of 3500 files!) 1137714 1 264365 bfulgham 2015-10-29 16:49:08 -0700 Created attachment 264365 Patch 1137715 2 264365 mark.lam 2015-10-29 16:52:00 -0700 Comment on attachment 264365 Patch r=me 1137718 3 achristensen 2015-10-29 16:55:04 -0700 lgtm, too 1137724 4 bfulgham 2015-10-29 17:09:48 -0700 The windows EWS failure looks like a bot problem. I'm investigating. 1137726 5 bfulgham 2015-10-29 17:20:55 -0700 Committed r191766: <http://trac.webkit.org/changeset/191766> 1137735 6 msaboff 2015-10-29 18:16:32 -0700 After this change, I now can't build JavaScriptCore or WebKit. I get: $ build-webkit --release --64-bit Use of uninitialized value $expectedVersion in scalar chomp at Tools/Scripts/update-webkit-support-libs line 113. Falling back to existing version of WebKitSupportLibrary. Error: /home/msaboff/src/OpenSource/WebKitBuild/Release is not a directory The directory does exist. $ ls /home/msaboff/src/OpenSource/WebKitBuild/Release ALL_BUILD.vcxproj* cmakeconfig.h* INSTALL.vcxproj* RUN_TESTS.vcxproj* x64/ ALL_BUILD.vcxproj.filters* CMakeFiles/ INSTALL.vcxproj.filters* RUN_TESTS.vcxproj.filters* ZERO_CHECK.vcxproj* bin64/ CPackConfig.cmake* lib32/ Source/ ZERO_CHECK.vcxproj.filters* buildfailed* CPackSourceConfig.cmake* lib64/ Tools/ build-webkit-options.txt CTestTestfile.cmake* obj64/ WebKit.sln* cmake_install.cmake* DerivedSources/ PACKAGE.vcxproj* webkit_errors.log* CMakeCache.txt* include/ PACKAGE.vcxproj.filters* webkit_warnings.log* If I roll back to r191765, I can build. 1137753 7 bfulgham 2015-10-29 19:42:48 -0700 I'll fix ASAP! 1137846 8 ossy 2015-10-30 03:23:45 -0700 (In reply to comment #5) > Committed r191766: <http://trac.webkit.org/changeset/191766> Apple Windows and WinCairo build is still broken. 1137880 9 bfulgham 2015-10-30 10:06:46 -0700 Committed r191793: <http://trac.webkit.org/changeset/191793> 1140727 10 ossy 2015-11-10 03:52:55 -0800 (In reply to comment #9) > Committed r191793: <http://trac.webkit.org/changeset/191793> Originally you landed this change in r191766: - buildCMakeProjectOrExit(0, cmakeBasedPortName(), undef, "jsc $makeArgs", (cmakeBasedPortArguments(), $cmakeArgs)); + my $testapi = (isAnyWindows() ? "testapi" : ""); + buildCMakeProjectOrExit(0, cmakeBasedPortName(), undef, "jsc $testapi $makeArgs", (cmakeBasedPortArguments(), $cmakeArgs)); And this one in r191793: - # By default we build using all of the available CPUs - $makeArgs .= ($makeArgs ? " " : "") . "-j" . numberOfCPUs() if $makeArgs !~ /-j\s*\d+/; + + my $buildTarget = ""; + unless (isAnyWindows()) { + # By default we build using all of the available CPUs + $makeArgs .= ($makeArgs ? " " : "") . "-j" . numberOfCPUs() if $makeArgs !~ /-j\s*\d+/; + $buildTarget = "jsc $makeArgs"; + } elsif (canUseNinja()) { + $buildTarget .= "jsc testapi"; + } Could you explain why -jN causes problem for Windows-ninja ? 1141448 11 ossy 2015-11-12 03:58:26 -0800 Brent? 1142531 12 ossy 2015-11-17 05:23:19 -0800 (In reply to comment #11) > Brent? ping? 1142791 13 ossy 2015-11-18 02:36:26 -0800 (In reply to comment #11) > Brent? ping? 1143261 14 ossy 2015-11-19 04:42:00 -0800 (In reply to comment #11) > Brent? ping? 1144355 15 ossy 2015-11-24 10:09:37 -0800 (In reply to comment #11) > Brent? ping? 1144434 16 ossy 2015-11-25 08:54:28 -0800 (In reply to comment #11) > Brent? ping? 1144487 17 ossy 2015-11-26 04:42:25 -0800 Brent, it's not fair that you landed an unreviewed hack 2 weeks before and you don't answer my question. Please answer as soon as possible. 1145184 18 ossy 2015-12-01 01:09:30 -0800 ping? 1145284 19 achristensen 2015-12-01 11:02:02 -0800 The unless isAnyWindows is not necessary. It works without it. The canUseNinja is necessary because our bots use CMake and Visual Studio without Ninja. If we change it, though, the testb3 that is there now shouldn't be a target on Windows because b3 isn't enabled on Windows. 264365 2015-10-29 16:49:08 -0700 2015-10-29 16:52:00 -0700 Patch bug-150700-20151029170601.patch text/plain 5557 bfulgham SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE5MTc2MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDI4IEBACisyMDE1LTEwLTI5ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29t PgorCisgICAgICAgIFtXaW5dIGJ1aWxkLWpzYyBhbmQgcnVuLWphdmFzY3JpcHRjb3JlLXRlc3Rz IGRvIG5vdCB3b3JrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNTA3MDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAg ICAgCisgICAgICAgIENvcnJlY3Qgb3VyIGJ1aWxkIHN5c3RlbSBzbyB0aGF0IGl0IGV4cGVjdHMg V2luZG93cyB0byBiZSB1c2luZyBDTWFrZSwKKyAgICAgICAgYW5kIHRvIGJ1aWxkIHRoZSBjb3Jy ZWN0IHN1Yi1wcm9qZWN0cyBmb3Igb3VyIEpTQyBoZWxwZXIgc2NyaXB0cy4KKworICAgICAgICAq IFNjcmlwdHMvYnVpbGQtanNjOiBNYWtlIHN1cmUgdG8gYnVpbGQgdGhlIHRlc3RhcGkgaGFybmVz cyB3aGVuCisgICAgICAgICAgYnVpbGRpbmcgZm9yIFdpbmRvd3MuCisgICAgICAgICogU2NyaXB0 cy9idWlsZC13ZWJraXQ6CisgICAgICAgICAgKDEpIFVzZSB0aGUgZXhpc3RpbmcgJ2NtYWtlQmFz ZWRQb3J0TmFtZSgpJworICAgICAgICAgICgyKSBVc2UgRmlsZTo6U3BlYyByYXRoZXIgdGhhbiBo YXJkLWNvZGluZyBwYXRoIGRlbGltZXRlcnMuCisgICAgICAgICAgKDMpIFJlZmVyIHRvIFZpc3Vh bCBTdHVkaW8gMTQuMCwgcmF0aGVyIHRoYW4gdGhlIHVuc3VwcG9ydGVkIDEyLjAuCisgICAgICAg IG1ldGhvZCByYXRoZXIgdGhhbiBoYXJkLWNvZGluZyB0aGUgbmFtZSBiYXNlZCBvbiBjb25kaXRp b25hbC4KKyAgICAgICAgKiBTY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0czoKKyAgICAg ICAgKHRlc3RhcGlQYXRoKTogVXNlIEZpbGU6OlNwZWMgcmF0aGVyIHRoYW4gaGFyZC1jb2Rpbmcg cGF0aCBkZWxpbWV0ZXJzLgorICAgICAgICAqIFNjcmlwdHMvcnVuLWpzYzogRGl0dG8uCisgICAg ICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAoY21ha2VCYXNlZFBvcnROYW1l KTogVXBkYXRlIHRvIHJldHVybiB0aGUgcmlnaHQgdmFsdWUgZm9yIHRoZSBBcHBsZQorICAgICAg ICBXaW5kb3dzIHBvcnQgYW5kIHRoZSBXaW5DYWlybyBwb3J0LgorICAgICAgICAoaXNDTWFrZUJ1 aWxkKTogRXhwZWN0IENNYWtlIGJ1aWxkIGZvciBhbGwgV2luZG93cyBwb3J0cy4KKwogMjAxNS0x MC0yOSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAg ICAgIEZpeCBidWlsZC1qc2Mgb24gTWFjIGFmdGVyIHIxOTE3NDkuCkluZGV4OiBUb29scy9TY3Jp cHRzL2J1aWxkLWpzYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2J1aWxkLWpzYwkocmV2 aXNpb24gMTkxNzU2KQorKysgVG9vbHMvU2NyaXB0cy9idWlsZC1qc2MJKHdvcmtpbmcgY29weSkK QEAgLTEwMSw3ICsxMDEsOCBAQCBpZiAoaXNDTWFrZUJ1aWxkKCkpIHsKICAgICAkbWFrZUFyZ3Mg Lj0gKCRtYWtlQXJncyA/ICIgIiA6ICIiKSAuICItaiIgLiBudW1iZXJPZkNQVXMoKSBpZiAkbWFr ZUFyZ3MgIX4gLy1qXHMqXGQrLzsKIAogICAgICMgVGhpcyBjYWxsIG9ubHkgcmV0dXJucyBpZiBu b3RoaW5nIHdyb25nIGhhcHBlbmVkCi0gICAgYnVpbGRDTWFrZVByb2plY3RPckV4aXQoMCwgY21h a2VCYXNlZFBvcnROYW1lKCksIHVuZGVmLCAianNjICRtYWtlQXJncyIsIChjbWFrZUJhc2VkUG9y dEFyZ3VtZW50cygpLCAkY21ha2VBcmdzKSk7CisgICAgbXkgJHRlc3RhcGkgPSAoaXNBbnlXaW5k b3dzKCkgPyAidGVzdGFwaSIgOiAiIik7CisgICAgYnVpbGRDTWFrZVByb2plY3RPckV4aXQoMCwg Y21ha2VCYXNlZFBvcnROYW1lKCksIHVuZGVmLCAianNjICR0ZXN0YXBpICRtYWtlQXJncyIsIChj bWFrZUJhc2VkUG9ydEFyZ3VtZW50cygpLCAkY21ha2VBcmdzKSk7CiAgICAgd3JpdGVDb25ncmF0 cygpOwogICAgIGV4aXQgZXhpdFN0YXR1cygwKTsKIH0KSW5kZXg6IFRvb2xzL1NjcmlwdHMvYnVp bGQtd2Via2l0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CShyZXZp c2lvbiAxOTE3NTYpCisrKyBUb29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdAkod29ya2luZyBjb3B5 KQpAQCAtMjUyLDE1ICsyNTIsMTUgQEAgaWYgKGlzQ01ha2VCdWlsZCgpKSB7CiBteSAkYmFzZVBy b2R1Y3REaXIgPSBiYXNlUHJvZHVjdERpcigpOwogaWYgKGlzQXBwbGVXaW5XZWJLaXQoKSB8fCBp c1dpbkNhaXJvKCkpIHsKICAgICBjaGRpcldlYktpdCgpOwotICAgIGlmIChleGl0U3RhdHVzKGdl bmVyYXRlQnVpbGRTeXN0ZW1Gcm9tQ01ha2VQcm9qZWN0KGlzV2luQ2Fpcm8oKSA/ICJXaW5DYWly byIgOiAiQXBwbGVXaW4iKSkpIHsKLSAgICAgICAgZGllICJSdW4gXCJDOi9Qcm9ncmFtIEZpbGVz ICh4ODYpL01pY3Jvc29mdCBWaXN1YWwgU3R1ZGlvIDEyLjAvVkMvdmN2YXJzYWxsLmJhdFwiIGJl Zm9yZSBidWlsZC13ZWJraXQgd2hlbiB1c2luZyBuaW5qYSI7CisgICAgaWYgKGV4aXRTdGF0dXMo Z2VuZXJhdGVCdWlsZFN5c3RlbUZyb21DTWFrZVByb2plY3QoY21ha2VCYXNlZFBvcnROYW1lKCkp KSkgeworICAgICAgICBkaWUgIlJ1biBcIkM6L1Byb2dyYW0gRmlsZXMgKHg4NikvTWljcm9zb2Z0 IFZpc3VhbCBTdHVkaW8gMTQuMC9WQy92Y3ZhcnNhbGwuYmF0XCIgYmVmb3JlIGJ1aWxkLXdlYmtp dCB3aGVuIHVzaW5nIG5pbmphIjsKICAgICB9CiAgICAgY2hkaXJXZWJLaXQoKTsKICAgICBpZiAo Y2FuVXNlTmluamEoKSkgewotICAgICAgICBjaGRpciAiV2ViS2l0QnVpbGQvIiAuIGNvbmZpZ3Vy YXRpb24oKTsKKyAgICAgICAgY2hkaXIgRmlsZTo6U3BlYy0+Y2F0ZGlyKCJXZWJLaXRCdWlsZCIs IGNvbmZpZ3VyYXRpb24oKSk7CiAgICAgICAgICRyZXN1bHQgPSBzeXN0ZW0oIm5pbmphIik7CiAg ICAgfSBlbHNlIHsKLSAgICAgICAgJHJlc3VsdCA9IGJ1aWxkVmlzdWFsU3R1ZGlvUHJvamVjdCgi V2ViS2l0QnVpbGQvIiAuIGNvbmZpZ3VyYXRpb24oKSAuICIvV2ViS2l0LnNsbiIsICRjbGVhbik7 CisgICAgICAgICRyZXN1bHQgPSBidWlsZFZpc3VhbFN0dWRpb1Byb2plY3QoRmlsZTo6U3BlYy0+ Y2F0ZmlsZSgiV2ViS2l0QnVpbGQiLCBjb25maWd1cmF0aW9uKCksICJXZWJLaXQuc2xuIiksICRj bGVhbik7CiAgICAgfQogICAgIGlmIChleGl0U3RhdHVzKCRyZXN1bHQpKSB7CiAgICAgICAgIG15 ICRzY3JpcHREaXIgPSByZWxhdGl2ZVNjcmlwdHNEaXIoKTsKSW5kZXg6IFRvb2xzL1NjcmlwdHMv cnVuLWphdmFzY3JpcHRjb3JlLXRlc3RzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvcnVu LWphdmFzY3JpcHRjb3JlLXRlc3RzCShyZXZpc2lvbiAxOTE3NTYpCisrKyBUb29scy9TY3JpcHRz L3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cwkod29ya2luZyBjb3B5KQpAQCAtMTQ1LDcgKzE0NSw3 IEBAIGlmICghZGVmaW5lZCgkcm9vdCkgJiYgJGJ1aWxkSlNDKSB7CiAgICAgcHVzaChAYnVpbGRB cmdzLCBhcmd1bWVudHNGb3JDb25maWd1cmF0aW9uKCkpOwogCiAgICAgcHJpbnQgIlJ1bm5pbmc6 IGJ1aWxkLWpzYyAiIC4gam9pbigiICIsIEBidWlsZEFyZ3MpIC4gIlxuIjsKLSAgICBteSAkYnVp bGRSZXN1bHQgPSBzeXN0ZW0gInBlcmwiLCAiVG9vbHMvU2NyaXB0cy9idWlsZC1qc2MiLCBAYnVp bGRBcmdzOworICAgIG15ICRidWlsZFJlc3VsdCA9IHN5c3RlbSAicGVybCIsIEZpbGU6OlNwZWMt PmNhdGZpbGUoIlRvb2xzIiwgIlNjcmlwdHMiLCAiYnVpbGQtanNjIiksIEBidWlsZEFyZ3M7CiAg ICAgaWYgKCRidWlsZFJlc3VsdCkgewogICAgICAgICBwcmludCBTVERFUlIgIkNvbXBpbGluZyBq c2MgZmFpbGVkIVxuIjsKICAgICAgICAgZXhpdCBleGl0U3RhdHVzKCRidWlsZFJlc3VsdCk7CkBA IC0xNzEsNyArMTcxLDcgQEAgc3ViIHRlc3RhcGlQYXRoKCQpCiAgICAgbXkgKCRwcm9kdWN0RGly KSA9IEBfOwogICAgIG15ICRqc2NOYW1lID0gInRlc3RhcGkiOwogICAgICRqc2NOYW1lIC49ICJf ZGVidWciIGlmIGNvbmZpZ3VyYXRpb24oKSBlcSAiRGVidWdfQWxsIjsKLSAgICByZXR1cm4gIiRw cm9kdWN0RGlyLyRqc2NOYW1lIjsKKyAgICByZXR1cm4gRmlsZTo6U3BlYy0+Y2F0ZmlsZSgkcHJv ZHVjdERpciwgJGpzY05hbWUpOwogfQogCiAjcnVuIGFwaSB0ZXN0cwpJbmRleDogVG9vbHMvU2Ny aXB0cy9ydW4tanNjCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvcnVuLWpzYwkocmV2aXNp b24gMTkxNzU2KQorKysgVG9vbHMvU2NyaXB0cy9ydW4tanNjCSh3b3JraW5nIGNvcHkpCkBAIC00 NCw3ICs0NCw3IEBAIEdldE9wdGlvbnMoImNvdW50fGM9aSIgPT4gXCRjb3VudCk7CiAKIHNldENv bmZpZ3VyYXRpb24oKTsKIAotbXkgJGpzYyA9IGpzY1Byb2R1Y3REaXIoKSAuICIvanNjIEBBUkdW IjsKK215ICRqc2MgPSBGaWxlOjpTcGVjLT5jYXRmaWxlKGpzY1Byb2R1Y3REaXIoKSwgImpzYyAi KSAuICJAQVJHViI7CiAKIG15ICRkeWxkID0ganNjUHJvZHVjdERpcigpOwogCkluZGV4OiBUb29s cy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJr aXRkaXJzLnBtCShyZXZpc2lvbiAxOTE3NTYpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMu cG0JKHdvcmtpbmcgY29weSkKQEAgLTIwNDAsNiArMjA0MCw4IEBAIHN1YiBjbWFrZUJhc2VkUG9y dE5hbWUoKQogICAgIHJldHVybiAiRWZsIiBpZiBpc0VmbCgpOwogICAgIHJldHVybiAiR1RLIiBp ZiBpc0d0aygpOwogICAgIHJldHVybiAiTWFjIiBpZiBpc0FwcGxlTWFjV2ViS2l0KCk7CisgICAg cmV0dXJuICJXaW5DYWlybyIgaWYgaXNXaW5DYWlybygpOworICAgIHJldHVybiAiQXBwbGVXaW4i IGlmIGlzQXBwbGVXaW5XZWJLaXQoKTsKICAgICByZXR1cm4gIiI7CiB9CiAKQEAgLTIwNTEsNyAr MjA1Myw3IEBAIHN1YiBkZXRlcm1pbmVJc0NNYWtlQnVpbGQoKQogCiBzdWIgaXNDTWFrZUJ1aWxk KCkKIHsKLSAgICBpZiAoaXNFZmwoKSB8fCBpc0d0aygpKSB7CisgICAgaWYgKGlzRWZsKCkgfHwg aXNHdGsoKSB8fCBpc0FueVdpbmRvd3MoKSkgewogICAgICAgICByZXR1cm4gMTsKICAgICB9CiAg ICAgZGV0ZXJtaW5lSXNDTWFrZUJ1aWxkKCk7Cg==