150698 2015-10-29 16:22:56 -0700 Animometer computes frame rate incorrectly 2015-10-29 18:29:16 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser commit-queue jonlee lforschler rniwa sabouhallawa simon.fraser oldest_to_newest 1137705 0 simon.fraser 2015-10-29 16:22:56 -0700 The Animator.animate() function tests if (this._frameCount == this._dropFrameCount) before incrementing this._frameCount, causing it to store the wrong this._measureTimeOffset. This causes it to report 90fps when it's actually doing 60fps. 1137727 1 264367 simon.fraser 2015-10-29 17:26:43 -0700 Created attachment 264367 Patch 1137730 2 sabouhallawa 2015-10-29 17:33:22 -0700 unofficial r=me. 1137740 3 264367 commit-queue 2015-10-29 18:29:12 -0700 Comment on attachment 264367 Patch Clearing flags on attachment: 264367 Committed r191768: <http://trac.webkit.org/changeset/191768> 1137741 4 commit-queue 2015-10-29 18:29:16 -0700 All reviewed patches have been landed. Closing bug. 264367 2015-10-29 17:26:43 -0700 2015-10-29 18:29:12 -0700 Patch bug-150698-20151029172552.patch text/plain 1920 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxNTk3CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0FuaW1vbWV0ZXIvdGVzdHMvcmVzb3VyY2VzL21haW4uanMgYi9QZXJmb3JtYW5jZVRlc3RzL0Fu aW1vbWV0ZXIvdGVzdHMvcmVzb3VyY2VzL21haW4uanMKaW5kZXggMzkzZDc5ZmM3M2UzZDQ3NTBm Nzk1YTNhZGM2NjcwMjU5MzkxNjg1NS4uZWE3N2NlYjkzOTdmNzdhMjlmN2Y4ZGNlNTA1MzAwYmNl YjcxOTIwZCAxMDA2NDQKLS0tIGEvUGVyZm9ybWFuY2VUZXN0cy9Bbmltb21ldGVyL3Rlc3RzL3Jl c291cmNlcy9tYWluLmpzCisrKyBiL1BlcmZvcm1hbmNlVGVzdHMvQW5pbW9tZXRlci90ZXN0cy9y ZXNvdXJjZXMvbWFpbi5qcwpAQCAtOTQsMTIgKzk0LDEyIEBAIEFuaW1hdG9yLnByb3RvdHlwZSA9 CiAgICAgICAgIGlmICghdGhpcy5fZnJhbWVDb3VudCkKICAgICAgICAgICAgIHRoaXMuX3N0YXJ0 VGltZU9mZnNldCA9IHRoaXMuX2N1cnJlbnRUaW1lT2Zmc2V0OwogCisgICAgICAgICsrdGhpcy5f ZnJhbWVDb3VudDsKKwogICAgICAgICAvLyBTdGFydCBtZWFzdXJpbmcgYWZ0ZXIgZHJvcHBpbmcg X2Ryb3BGcmFtZUNvdW50IGZyYW1lcy4KICAgICAgICAgaWYgKHRoaXMuX2ZyYW1lQ291bnQgPT0g dGhpcy5fZHJvcEZyYW1lQ291bnQpCiAgICAgICAgICAgICB0aGlzLl9tZWFzdXJlVGltZU9mZnNl dCA9IHRoaXMuX2N1cnJlbnRUaW1lT2Zmc2V0OwogCi0gICAgICAgICsrdGhpcy5fZnJhbWVDb3Vu dDsKLQogICAgICAgICAvLyBEcm9wIF9kcm9wRnJhbWVDb3VudCBmcmFtZXMgYW5kIG1lYXN1cmUg dGhlIGF2ZXJhZ2Ugb2YgX21lYXN1cmVGcmFtZUNvdW50IGZyYW1lcy4KICAgICAgICAgaWYgKHRo aXMuX2ZyYW1lQ291bnQgPCB0aGlzLl9kcm9wRnJhbWVDb3VudCArIHRoaXMuX21lYXN1cmVGcmFt ZUNvdW50KQogICAgICAgICAgICAgcmV0dXJuIHRydWU7CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5j ZVRlc3RzL0NoYW5nZUxvZyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDNlMGE3 ZjAzNTc2MDZmZTZlNWY4YWM0NWQ5ODcyNGZiZjg0YWJkNDEuLjBkOWJhZjM3NzkxNWU4N2IwZWQ0 ZGI5ZWM4NmY0ZTIyYTMzZjg1M2EgMTAwNjQ0Ci0tLSBhL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdl TG9nCisrKyBiL1BlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIw MTUtMTAtMjkgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAg ICAgQW5pbW9tZXRlciBjb21wdXRlcyBmcmFtZSByYXRlIGluY29ycmVjdGx5CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTA2OTgKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFRoZSBleGlzdGlu ZyBjb2RlIGluY3JlbWVudGVkIHRoaXMuX2ZyYW1lQ291bnQgYWZ0ZXIgY2hlY2tpbmcgYWdhaW5z dCB0aGlzLl9kcm9wRnJhbWVDb3VudC4KKyAgICAgICAgVGhpcyBoYXMgdGhlIGVmZmVjdCBvZiBz ZXR0aW5nIHRoaXMuX21lYXN1cmVUaW1lT2Zmc2V0IG9uZSBmcmFtZSB0b28gbGF0ZSwgc28KKyAg ICAgICAgd2Ugd2VyZSBtZWFzdXJpbmcgb25seSB0d28gZnJhbWVzLCBub3QgdGhyZWUsIGFuZCB0 aHVzIGNvbXB1dGluZyBhbiBpbmNvcnJlY3QgZnBzLgorCisgICAgICAgICogQW5pbW9tZXRlci90 ZXN0cy9yZXNvdXJjZXMvbWFpbi5qczoKKyAgICAgICAgKEFuaW1hdG9yLnByb3RvdHlwZS5hbmlt YXRlKToKKwogMjAxNS0xMC0yNiAgU2FpZCBBYm91LUhhbGxhd2EgIDxzYWJvdWhhbGxhd2FAYXBw bGUuY29tPgogCiAgICAgICAgIEFkZCBhbiBvcHRpb24gdG8gb3V0cHV0IHRoZSByZXN1bHRzIG9m IHRoZSBncmFwaGljcyBiZW5jaG1hcmsgaW4gSlNPTiBmb3JtYXQK