150693 2015-10-29 14:36:30 -0700 Tapping and holding a link should have a share option 2015-11-02 10:26:21 -0800 1 1 1 Unclassified WebKit WebKit2 Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin commit-queue enrica mitz thorton oldest_to_newest 1137657 0 bdakin 2015-10-29 14:36:30 -0700 Tapping and holding a link should have a share option rdar://problem/21319702 1137660 1 264347 bdakin 2015-10-29 14:39:12 -0700 Created attachment 264347 Patch 1137661 2 commit-queue 2015-10-29 14:40:57 -0700 Attachment 264347 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/Cocoa/_WKElementAction.mm:132: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style. 1137910 3 264406 bdakin 2015-10-30 11:58:09 -0700 Created attachment 264406 Patch 1137912 4 commit-queue 2015-10-30 11:59:45 -0700 Attachment 264406 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/API/Cocoa/_WKElementAction.mm:132: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style. 1137913 5 264406 thorton 2015-10-30 12:02:29 -0700 Comment on attachment 264406 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264406&action=review > Source/WebKit2/UIProcess/API/Cocoa/_WKElementAction.mm:133 > + NSLog(@"actionInfo._interactionLocation for share item is %@", NSStringFromPoint(actionInfo._interactionLocation)); Please no. > Source/WebKit2/UIProcess/ios/WKPDFView.mm:726 > + if ([_webSelectionAssistant respondsToSelector:@selector(showShareSheetFor:fromRect:)]) Wonder if we still need all these respondsToSelector checks these days. > Source/WebKit2/UIProcess/ios/WKPDFView.mm:727 > + [_webSelectionAssistant showShareSheetFor:[url absoluteString] fromRect:boundingRect]; url.absoluteString (and above too) 1137925 6 264406 enrica 2015-10-30 12:31:11 -0700 Comment on attachment 264406 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264406&action=review >> Source/WebKit2/UIProcess/ios/WKPDFView.mm:726 >> + if ([_webSelectionAssistant respondsToSelector:@selector(showShareSheetFor:fromRect:)]) > > Wonder if we still need all these respondsToSelector checks these days. I don't think we do need the responds to selector here. 1137932 7 bdakin 2015-10-30 12:40:54 -0700 (In reply to comment #6) > Comment on attachment 264406 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=264406&action=review > > >> Source/WebKit2/UIProcess/ios/WKPDFView.mm:726 > >> + if ([_webSelectionAssistant respondsToSelector:@selector(showShareSheetFor:fromRect:)]) > > > > Wonder if we still need all these respondsToSelector checks these days. > > I don't think we do need the responds to selector here. Thank you Enrica and Tim! Checked in http://trac.webkit.org/changeset/191805 1138073 8 264406 mitz 2015-10-30 18:02:14 -0700 Comment on attachment 264406 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264406&action=review > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3388 > + [_textSelectionAssistant showShareSheetFor:[url absoluteString] fromRect:boundingRect]; > + else if (_webSelectionAssistant && [_webSelectionAssistant respondsToSelector:@selector(showShareSheetFor:fromRect:)]) > + [_webSelectionAssistant showShareSheetFor:[url absoluteString] fromRect:boundingRect]; Do these strings get interpreted as URLs by some code on the other side of this API, or do they end up being presented to the user? If it’s the latter, then we shouldn’t use -absoluteString, because it doesn’t give a good representation of certain URLs, such as ones with non-ASCII characters in the host or the path. Instead, -_web_userVisibleString should work. If these strings do get turned back into URLs, and we can’t use an alternative API that takes NSURLs, then we should consider using -_web_originalDataAsString here and the reverse transformation on the receiving end. >> Source/WebKit2/UIProcess/ios/WKPDFView.mm:727 >> + [_webSelectionAssistant showShareSheetFor:[url absoluteString] fromRect:boundingRect]; > > url.absoluteString (and above too) Same comment here. 1138572 9 bdakin 2015-11-02 08:53:00 -0800 (In reply to comment #8) > Comment on attachment 264406 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=264406&action=review > > > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:3388 > > + [_textSelectionAssistant showShareSheetFor:[url absoluteString] fromRect:boundingRect]; > > + else if (_webSelectionAssistant && [_webSelectionAssistant respondsToSelector:@selector(showShareSheetFor:fromRect:)]) > > + [_webSelectionAssistant showShareSheetFor:[url absoluteString] fromRect:boundingRect]; > > Do these strings get interpreted as URLs by some code on the other side of > this API, or do they end up being presented to the user? If it’s the latter, > then we shouldn’t use -absoluteString, because it doesn’t give a good > representation of certain URLs, such as ones with non-ASCII characters in > the host or the path. Instead, -_web_userVisibleString should work. If these > strings do get turned back into URLs, and we can’t use an alternative API > that takes NSURLs, then we should consider using -_web_originalDataAsString > here and the reverse transformation on the receiving end. > > >> Source/WebKit2/UIProcess/ios/WKPDFView.mm:727 > >> + [_webSelectionAssistant showShareSheetFor:[url absoluteString] fromRect:boundingRect]; > > > > url.absoluteString (and above too) > > Same comment here. Thank you Dan! This is presented to the user, and I was able to see the bug you referred to with non-ascii URLs. I will attach a follow-up patch. 1138592 10 264597 bdakin 2015-11-02 10:04:53 -0800 Created attachment 264597 Follow-up fix for non-ascii URLs 1138599 11 bdakin 2015-11-02 10:26:21 -0800 Thanks, Dan! http://trac.webkit.org/changeset/191894 264347 2015-10-29 14:39:12 -0700 2015-10-30 11:58:09 -0700 Patch for-review.txt text/plain 8140 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MTc1NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTEwLTI5ICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBUYXBwaW5nIGFuZCBob2xkaW5nIGEg bGluayBzaG91bGQgaGF2ZSBhIHNoYXJlIG9wdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwNjkzCisgICAgICAgIC1hbmQgY29ycmVzcG9uZGlu Zy0KKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMjEzMTk3MDIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEVuZ2xpc2gubHByb2ovTG9jYWxpemFibGUu c3RyaW5nczoKKwogMjAxNS0xMC0yOSAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxl LmNvbT4KIAogICAgICAgICBEYXRlIGlucHV0IHZhbHVlcyBzaG91bGQgbm90IG92ZXJsYXAgd2l0 aCBtZW51IGxpc3QgZHJvcGRvd24gYnV0dG9uIG9uIGlPUwpJbmRleDogU291cmNlL1dlYkNvcmUv RW5nbGlzaC5scHJvai9Mb2NhbGl6YWJsZS5zdHJpbmdzCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL0VuZ2xpc2gubHByb2ovTG9jYWxpemFibGUuc3RyaW5ncwkocmV2aXNpb24gMTkxNjM0 KQorKysgU291cmNlL1dlYkNvcmUvRW5nbGlzaC5scHJvai9Mb2NhbGl6YWJsZS5zdHJpbmdzCSh3 b3JraW5nIGNvcHkpCkBAIC00OTYsNiArNDk2LDkgQEAKIC8qIFVuZG8gYWN0aW9uIG5hbWUgKi8K ICJTZXQgV3JpdGluZyBEaXJlY3Rpb24gKFVuZG8gYWN0aW9uIG5hbWUpIiA9ICJTZXQgV3JpdGlu ZyBEaXJlY3Rpb24iOwogCisvKiBUaXRsZSBmb3IgU2hhcmUgYWN0aW9uIGJ1dHRvbiAqLworIlNo YXJlIiA9ICJTaGFyZSI7CisKIC8qIFNob3cgY29sb3JzIGNvbnRleHQgbWVudSBpdGVtICovCiAi U2hvdyBDb2xvcnMiID0gIlNob3cgQ29sb3JzIjsKIApJbmRleDogU291cmNlL1dlYktpdDIvQ2hh bmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwkocmV2aXNpb24g MTkxNzU1KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMjcgQEAKKzIwMTUtMTAtMjkgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgor CisgICAgICAgIFRhcHBpbmcgYW5kIGhvbGRpbmcgYSBsaW5rIHNob3VsZCBoYXZlIGEgc2hhcmUg b3B0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NTA2OTMKKyAgICAgICAgLWFuZCBjb3JyZXNwb25kaW5nLQorICAgICAgICByZGFyOi8vcHJvYmxl bS8yMTMxOTcwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tFbGVtZW50QWN0aW9uLmg6CisgICAgICAgICog VUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tFbGVtZW50QWN0aW9uLm1tOgorICAgICAgICAoK1tfV0tF bGVtZW50QWN0aW9uIF9lbGVtZW50QWN0aW9uV2l0aFR5cGU6Y3VzdG9tVGl0bGU6YXNzaXN0YW50 Ol0pOgorICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tBY3Rpb25TaGVldEFzc2lzdGFudC5oOgor ICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tBY3Rpb25TaGVldEFzc2lzdGFudC5tbToKKyAgICAg ICAgKC1bV0tBY3Rpb25TaGVldEFzc2lzdGFudCBkZWZhdWx0QWN0aW9uc0ZvckxpbmtTaGVldDpd KToKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbToK KyAgICAgICAgKC1bV0tDb250ZW50VmlldyBhY3Rpb25TaGVldEFzc2lzdGFudDpvcGVuRWxlbWVu dEF0TG9jYXRpb246XSk6CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgYWN0aW9uU2hlZXRBc3Np c3RhbnQ6c2hhcmVFbGVtZW50V2l0aFVSTDp3aXRoUmVjdDpdKToKKyAgICAgICAgKC1bV0tDb250 ZW50VmlldyBhY3Rpb25TaGVldEFzc2lzdGFudDpzaG91bGRJbmNsdWRlQXBwTGlua0FjdGlvbnNG b3JFbGVtZW50Ol0pOgorICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tQREZWaWV3Lm1tOgorICAg ICAgICAoLVtXS1BERlZpZXcgYWN0aW9uU2hlZXRBc3Npc3RhbnQ6b3BlbkVsZW1lbnRBdExvY2F0 aW9uOl0pOgorICAgICAgICAoLVtXS1BERlZpZXcgYWN0aW9uU2hlZXRBc3Npc3RhbnQ6c2hhcmVF bGVtZW50V2l0aFVSTDp3aXRoUmVjdDpdKToKKyAgICAgICAgKC1bV0tQREZWaWV3IGFjdGlvblNo ZWV0QXNzaXN0YW50OnNob3VsZEluY2x1ZGVBcHBMaW5rQWN0aW9uc0ZvckVsZW1lbnQ6XSk6CisK IDIwMTUtMTAtMjkgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4K IAogICAgICAgICBGaXggTWFjIENNYWtlIGJ1aWxkCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL0NvY29hL19XS0VsZW1lbnRBY3Rpb24uaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL19XS0VsZW1lbnRBY3Rpb24uaAkocmV2aXNpb24g MTkxNjM0KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tFbGVtZW50 QWN0aW9uLmgJKHdvcmtpbmcgY29weSkKQEAgLTQzLDYgKzQzLDcgQEAgdHlwZWRlZiBOU19FTlVN KE5TSW50ZWdlciwgX1dLRWxlbWVudEFjdAogICAgIF9XS0VsZW1lbnRBY3Rpb25UeXBlQWRkVG9S ZWFkaW5nTGlzdCwKICAgICBfV0tFbGVtZW50QWN0aW9uVHlwZU9wZW5JbkRlZmF1bHRCcm93c2Vy IFdLX0VOVU1fQVZBSUxBQkxFKE5BLCA5XzApLAogICAgIF9XS0VsZW1lbnRBY3Rpb25UeXBlT3Bl bkluRXh0ZXJuYWxBcHBsaWNhdGlvbiBXS19FTlVNX0FWQUlMQUJMRShOQSwgOV8wKSwKKyAgICBf V0tFbGVtZW50QWN0aW9uVHlwZVNoYXJlIFdLX0VOVU1fQVZBSUxBQkxFKE5BLCBXS19JT1NfVEJB KSwKICNlbmRpZgogfSBXS19FTlVNX0FWQUlMQUJMRSgxMF8xMCwgOF8wKTsKIApJbmRleDogU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tFbGVtZW50QWN0aW9uLm1tCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLRWxlbWVudEFj dGlvbi5tbQkocmV2aXNpb24gMTkxNjM0KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9Db2NvYS9fV0tFbGVtZW50QWN0aW9uLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xMjcsNiArMTI3 LDEyIEBAICsgKGluc3RhbmNldHlwZSlfZWxlbWVudEFjdGlvbldpdGhUeXBlOigKICAgICAgICAg fTsKICAgICAgICAgYnJlYWs7CiAjZW5kaWYKKyAgICBjYXNlIF9XS0VsZW1lbnRBY3Rpb25UeXBl U2hhcmU6CisgICAgICAgIHRpdGxlID0gV0VCX1VJX1NUUklORygiU2hhcmUiLCAiVGl0bGUgZm9y IFNoYXJlIGFjdGlvbiBidXR0b24iKTsKKyAgICAgICAgaGFuZGxlciA9IF4oV0tBY3Rpb25TaGVl dEFzc2lzdGFudCAqYXNzaXN0YW50LCBfV0tBY3RpdmF0ZWRFbGVtZW50SW5mbyAqYWN0aW9uSW5m bykgeworICAgICAgICAgICAgW2Fzc2lzdGFudC5kZWxlZ2F0ZSBhY3Rpb25TaGVldEFzc2lzdGFu dDphc3Npc3RhbnQgc2hhcmVFbGVtZW50V2l0aFVSTDphY3Rpb25JbmZvLlVSTCB3aXRoUmVjdDph Y3Rpb25JbmZvLmJvdW5kaW5nUmVjdF07CisgICAgICAgIH07CisgICAgICAgIGJyZWFrOwogICAg IGRlZmF1bHQ6CiAgICAgICAgIFtOU0V4Y2VwdGlvbiByYWlzZTpOU0ludmFsaWRBcmd1bWVudEV4 Y2VwdGlvbiBmb3JtYXQ6QCJUaGVyZSBpcyBubyBzdGFuZGFyZCB3ZWIgZWxlbWVudCBhY3Rpb24g b2YgdHlwZSAlbGQuIiwgKGxvbmcpdHlwZV07CiAgICAgICAgIHJldHVybiBuaWw7CkluZGV4OiBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQWN0aW9uU2hlZXRBc3Npc3RhbnQuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQWN0aW9uU2hlZXRBc3Np c3RhbnQuaAkocmV2aXNpb24gMTkxNjM0KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lv cy9XS0FjdGlvblNoZWV0QXNzaXN0YW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTQ1LDYgKzQ1LDcg QEAgc3RydWN0IEludGVyYWN0aW9uSW5mb3JtYXRpb25BdFBvc2l0aW9uOwogLSAoY29uc3QgV2Vi S2l0OjpJbnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQb3NpdGlvbiYpcG9zaXRpb25JbmZvcm1hdGlv bkZvckFjdGlvblNoZWV0QXNzaXN0YW50OihXS0FjdGlvblNoZWV0QXNzaXN0YW50ICopYXNzaXN0 YW50OwogLSAodm9pZClhY3Rpb25TaGVldEFzc2lzdGFudDooV0tBY3Rpb25TaGVldEFzc2lzdGFu dCAqKWFzc2lzdGFudCBwZXJmb3JtQWN0aW9uOihXZWJLaXQ6OlNoZWV0QWN0aW9uKWFjdGlvbjsK IC0gKHZvaWQpYWN0aW9uU2hlZXRBc3Npc3RhbnQ6KFdLQWN0aW9uU2hlZXRBc3Npc3RhbnQgKilh c3Npc3RhbnQgb3BlbkVsZW1lbnRBdExvY2F0aW9uOihDR1BvaW50KWxvY2F0aW9uOworLSAodm9p ZClhY3Rpb25TaGVldEFzc2lzdGFudDooV0tBY3Rpb25TaGVldEFzc2lzdGFudCAqKWFzc2lzdGFu dCBzaGFyZUVsZW1lbnRXaXRoVVJMOihOU1VSTCAqKXVybCB3aXRoUmVjdDooQ0dSZWN0KWJvdW5k aW5nUmVjdDsKICNpZiBIQVZFKEFQUF9MSU5LUykKIC0gKEJPT0wpYWN0aW9uU2hlZXRBc3Npc3Rh bnQ6KFdLQWN0aW9uU2hlZXRBc3Npc3RhbnQgKilhc3Npc3RhbnQgc2hvdWxkSW5jbHVkZUFwcExp bmtBY3Rpb25zRm9yRWxlbWVudDooX1dLQWN0aXZhdGVkRWxlbWVudEluZm8gKillbGVtZW50Owog I2VuZGlmCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQWN0aW9uU2hlZXRB c3Npc3RhbnQubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9X S0FjdGlvblNoZWV0QXNzaXN0YW50Lm1tCShyZXZpc2lvbiAxOTE2MzQpCisrKyBTb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvaW9zL1dLQWN0aW9uU2hlZXRBc3Npc3RhbnQubW0JKHdvcmtpbmcgY29w eSkKQEAgLTM0Myw4ICszNDMsMTAgQEAgLSAoUmV0YWluUHRyPE5TQXJyYXk+KWRlZmF1bHRBY3Rp b25zRm9yTAogICAgIGlmIChbZ2V0U1NSZWFkaW5nTGlzdENsYXNzKCkgc3VwcG9ydHNVUkw6dGFy Z2V0VVJMXSkKICAgICAgICAgW2RlZmF1bHRBY3Rpb25zIGFkZE9iamVjdDpbX1dLRWxlbWVudEFj dGlvbiBfZWxlbWVudEFjdGlvbldpdGhUeXBlOl9XS0VsZW1lbnRBY3Rpb25UeXBlQWRkVG9SZWFk aW5nTGlzdCBhc3Npc3RhbnQ6c2VsZl1dOwogI2VuZGlmCi0gICAgaWYgKCFbW3RhcmdldFVSTCBz Y2hlbWVdIGxlbmd0aF0gfHwgW1t0YXJnZXRVUkwgc2NoZW1lXSBjYXNlSW5zZW5zaXRpdmVDb21w YXJlOkAiamF2YXNjcmlwdCJdICE9IE5TT3JkZXJlZFNhbWUpCisgICAgaWYgKCFbW3RhcmdldFVS TCBzY2hlbWVdIGxlbmd0aF0gfHwgW1t0YXJnZXRVUkwgc2NoZW1lXSBjYXNlSW5zZW5zaXRpdmVD b21wYXJlOkAiamF2YXNjcmlwdCJdICE9IE5TT3JkZXJlZFNhbWUpIHsKICAgICAgICAgW2RlZmF1 bHRBY3Rpb25zIGFkZE9iamVjdDpbX1dLRWxlbWVudEFjdGlvbiBfZWxlbWVudEFjdGlvbldpdGhU eXBlOl9XS0VsZW1lbnRBY3Rpb25UeXBlQ29weSBhc3Npc3RhbnQ6c2VsZl1dOworICAgICAgICBb ZGVmYXVsdEFjdGlvbnMgYWRkT2JqZWN0OltfV0tFbGVtZW50QWN0aW9uIF9lbGVtZW50QWN0aW9u V2l0aFR5cGU6X1dLRWxlbWVudEFjdGlvblR5cGVTaGFyZSBhc3Npc3RhbnQ6c2VsZl1dOworICAg IH0KIAogICAgIHJldHVybiBkZWZhdWx0QWN0aW9uczsKIH0KSW5kZXg6IFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1t CShyZXZpc2lvbiAxOTE2MzQpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29u dGVudFZpZXdJbnRlcmFjdGlvbi5tbQkod29ya2luZyBjb3B5KQpAQCAtMzM4MCw2ICszMzgwLDE0 IEBAIC0gKHZvaWQpYWN0aW9uU2hlZXRBc3Npc3RhbnQ6KFdLQWN0aW9uU2gKICAgICBbc2VsZiBf YXR0ZW1wdENsaWNrQXRMb2NhdGlvbjpsb2NhdGlvbl07CiB9CiAKKy0gKHZvaWQpYWN0aW9uU2hl ZXRBc3Npc3RhbnQ6KFdLQWN0aW9uU2hlZXRBc3Npc3RhbnQgKilhc3Npc3RhbnQgc2hhcmVFbGVt ZW50V2l0aFVSTDooTlNVUkwgKil1cmwgd2l0aFJlY3Q6KENHUmVjdClib3VuZGluZ1JlY3QKK3sK KyAgICBpZiAoX3RleHRTZWxlY3Rpb25Bc3Npc3RhbnQgJiYgW190ZXh0U2VsZWN0aW9uQXNzaXN0 YW50IHJlc3BvbmRzVG9TZWxlY3RvcjpAc2VsZWN0b3Ioc2hvd1NoYXJlU2hlZXRGb3I6ZnJvbVJl Y3Q6KV0pCisgICAgICAgIFtfdGV4dFNlbGVjdGlvbkFzc2lzdGFudCBzaG93U2hhcmVTaGVldEZv cjpbdXJsIGFic29sdXRlU3RyaW5nXSBmcm9tUmVjdDpib3VuZGluZ1JlY3RdOworICAgIGVsc2Ug aWYgKF93ZWJTZWxlY3Rpb25Bc3Npc3RhbnQgJiYgW193ZWJTZWxlY3Rpb25Bc3Npc3RhbnQgcmVz cG9uZHNUb1NlbGVjdG9yOkBzZWxlY3RvcihzaG93U2hhcmVTaGVldEZvcjpmcm9tUmVjdDopXSkK KyAgICAgICAgW193ZWJTZWxlY3Rpb25Bc3Npc3RhbnQgc2hvd1NoYXJlU2hlZXRGb3I6W3VybCBh YnNvbHV0ZVN0cmluZ10gZnJvbVJlY3Q6Ym91bmRpbmdSZWN0XTsKK30KKwogI2lmIEhBVkUoQVBQ X0xJTktTKQogLSAoQk9PTClhY3Rpb25TaGVldEFzc2lzdGFudDooV0tBY3Rpb25TaGVldEFzc2lz dGFudCAqKWFzc2lzdGFudCBzaG91bGRJbmNsdWRlQXBwTGlua0FjdGlvbnNGb3JFbGVtZW50Oihf V0tBY3RpdmF0ZWRFbGVtZW50SW5mbyAqKWVsZW1lbnQKIHsKSW5kZXg6IFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9pb3MvV0tQREZWaWV3Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9pb3MvV0tQREZWaWV3Lm1tCShyZXZpc2lvbiAxOTE2MzQpCisrKyBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLUERGVmlldy5tbQkod29ya2luZyBjb3B5KQpAQCAtNzE4 LDYgKzcxOCwxMCBAQCAtICh2b2lkKWFjdGlvblNoZWV0QXNzaXN0YW50OihXS0FjdGlvblNoCiAg ICAgX3dlYlZpZXctPl9wYWdlLT5uYXZpZ2F0ZVRvUERGTGlua1dpdGhTaW11bGF0ZWRDbGljayhf cG9zaXRpb25JbmZvcm1hdGlvbi51cmwsIHJvdW5kZWRJbnRQb2ludChsb2NhdGlvbiksIHJvdW5k ZWRJbnRQb2ludChzY3JlZW5Qb2ludCkpOwogfQogCistICh2b2lkKWFjdGlvblNoZWV0QXNzaXN0 YW50OihXS0FjdGlvblNoZWV0QXNzaXN0YW50ICopYXNzaXN0YW50IHNoYXJlRWxlbWVudFdpdGhV Ukw6KE5TVVJMICopdXJsIHdpdGhSZWN0OihDR1JlY3QpYm91bmRpbmdSZWN0Cit7Cit9CisKICNp ZiBIQVZFKEFQUF9MSU5LUykKIC0gKEJPT0wpYWN0aW9uU2hlZXRBc3Npc3RhbnQ6KFdLQWN0aW9u U2hlZXRBc3Npc3RhbnQgKilhc3Npc3RhbnQgc2hvdWxkSW5jbHVkZUFwcExpbmtBY3Rpb25zRm9y RWxlbWVudDooX1dLQWN0aXZhdGVkRWxlbWVudEluZm8gKillbGVtZW50CiB7Cg== 264406 2015-10-30 11:58:09 -0700 2015-10-30 12:02:29 -0700 Patch for-review-2.txt text/plain 9022 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MTgwMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE1LTEwLTMwICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBUYXBwaW5nIGFuZCBob2xkaW5nIGEg bGluayBzaG91bGQgaGF2ZSBhIHNoYXJlIG9wdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwNjkzCisgICAgICAgIC1hbmQgY29ycmVzcG9uZGlu Zy0KKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMjEzMTk3MDIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEVuZ2xpc2gubHByb2ovTG9jYWxpemFibGUu c3RyaW5nczoKKwogMjAxNS0xMC0zMCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgogCiAgICAgICAgIFtFRkxdIEZpeCB0aGUgZGVidWcgYnVpbGQgYWZ0ZXIgcjE5MTc1OApJ bmRleDogU291cmNlL1dlYkNvcmUvRW5nbGlzaC5scHJvai9Mb2NhbGl6YWJsZS5zdHJpbmdzCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL0VuZ2xpc2gubHByb2ovTG9jYWxpemFibGUuc3Ry aW5ncwkocmV2aXNpb24gMTkxNjM0KQorKysgU291cmNlL1dlYkNvcmUvRW5nbGlzaC5scHJvai9M b2NhbGl6YWJsZS5zdHJpbmdzCSh3b3JraW5nIGNvcHkpCkBAIC00OTYsNiArNDk2LDkgQEAKIC8q IFVuZG8gYWN0aW9uIG5hbWUgKi8KICJTZXQgV3JpdGluZyBEaXJlY3Rpb24gKFVuZG8gYWN0aW9u IG5hbWUpIiA9ICJTZXQgV3JpdGluZyBEaXJlY3Rpb24iOwogCisvKiBUaXRsZSBmb3IgU2hhcmUg YWN0aW9uIGJ1dHRvbiAqLworIlNoYXJl4oCmIiA9ICJTaGFyZeKApiI7CisKIC8qIFNob3cgY29s b3JzIGNvbnRleHQgbWVudSBpdGVtICovCiAiU2hvdyBDb2xvcnMiID0gIlNob3cgQ29sb3JzIjsK IApJbmRleDogU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQyL0NoYW5nZUxvZwkocmV2aXNpb24gMTkxODAyKQorKysgU291cmNlL1dlYktpdDIvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMzMgQEAKKzIwMTUtMTAtMzAgIEJldGgg RGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgorCisgICAgICAgIFRhcHBpbmcgYW5kIGhvbGRpbmcg YSBsaW5rIHNob3VsZCBoYXZlIGEgc2hhcmUgb3B0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTA2OTMKKyAgICAgICAgLWFuZCBjb3JyZXNwb25k aW5nLQorICAgICAgICByZGFyOi8vcHJvYmxlbS8yMTMxOTcwMgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5ldyBfV0tFbGVtZW50QWN0aW9uVHlwZSBj YWxsZWQgX1dLRWxlbWVudEFjdGlvblR5cGVTaGFyZS4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L0NvY29hL19XS0VsZW1lbnRBY3Rpb24uaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29h L19XS0VsZW1lbnRBY3Rpb24ubW06CisgICAgICAgICgrW19XS0VsZW1lbnRBY3Rpb24gX2VsZW1l bnRBY3Rpb25XaXRoVHlwZTpjdXN0b21UaXRsZTphc3Npc3RhbnQ6XSk6CisKKyAgICAgICAgX1dL RWxlbWVudEFjdGlvblR5cGVTaGFyZSBpcyBwYXJ0IG9mIHRoZSBkZWZhdWx0IGFjdGlvbnMgZm9y IGxpbmtzLgorICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tBY3Rpb25TaGVldEFzc2lzdGFudC5o OgorICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tBY3Rpb25TaGVldEFzc2lzdGFudC5tbToKKyAg ICAgICAgKC1bV0tBY3Rpb25TaGVldEFzc2lzdGFudCBkZWZhdWx0QWN0aW9uc0ZvckxpbmtTaGVl dDpdKToKKworICAgICAgICBIYW5kbGUgdGhlIHNoYXJpbmcgcGFydCEKKyAgICAgICAgKiBVSVBy b2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tDb250 ZW50VmlldyBhY3Rpb25TaGVldEFzc2lzdGFudDpzaGFyZUVsZW1lbnRXaXRoVVJMOnJlY3Q6XSk6 CisKKyAgICAgICAgVG8gc3VwcG9ydCB0aGlzIGluIFBERiwgUERGIG5lZWQgdG8gY3JlYXRlIGEg X3dlYlNlbGVjdGlvbkFzc2lzdGFudC4KKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLUERGVmll dy5tbToKKyAgICAgICAgKC1bV0tQREZWaWV3IHdlYl9pbml0V2l0aEZyYW1lOndlYlZpZXc6XSk6 CisgICAgICAgICgtW1dLUERGVmlldyBhY3Rpb25TaGVldEFzc2lzdGFudDpvcGVuRWxlbWVudEF0 TG9jYXRpb246XSk6CisgICAgICAgICgtW1dLUERGVmlldyBhY3Rpb25TaGVldEFzc2lzdGFudDpz aGFyZUVsZW1lbnRXaXRoVVJMOnJlY3Q6XSk6CisgICAgICAgICgtW1dLUERGVmlldyBhY3Rpb25T aGVldEFzc2lzdGFudDpzaG91bGRJbmNsdWRlQXBwTGlua0FjdGlvbnNGb3JFbGVtZW50Ol0pOgor CiAyMDE1LTEwLTMwICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAg ICAgICAgIFdLVmlldyBiZWluZyBpbnNpZGUgV0tXZWJWaWV3IGxlYWRzIHRvIHdlaXJkIEFQSSBp c3N1ZXMKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLRWxlbWVu dEFjdGlvbi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29j b2EvX1dLRWxlbWVudEFjdGlvbi5oCShyZXZpc2lvbiAxOTE2MzQpCisrKyBTb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL0NvY29hL19XS0VsZW1lbnRBY3Rpb24uaAkod29ya2luZyBjb3B5KQpA QCAtNDMsNiArNDMsNyBAQCB0eXBlZGVmIE5TX0VOVU0oTlNJbnRlZ2VyLCBfV0tFbGVtZW50QWN0 CiAgICAgX1dLRWxlbWVudEFjdGlvblR5cGVBZGRUb1JlYWRpbmdMaXN0LAogICAgIF9XS0VsZW1l bnRBY3Rpb25UeXBlT3BlbkluRGVmYXVsdEJyb3dzZXIgV0tfRU5VTV9BVkFJTEFCTEUoTkEsIDlf MCksCiAgICAgX1dLRWxlbWVudEFjdGlvblR5cGVPcGVuSW5FeHRlcm5hbEFwcGxpY2F0aW9uIFdL X0VOVU1fQVZBSUxBQkxFKE5BLCA5XzApLAorICAgIF9XS0VsZW1lbnRBY3Rpb25UeXBlU2hhcmUg V0tfRU5VTV9BVkFJTEFCTEUoTkEsIFdLX0lPU19UQkEpLAogI2VuZGlmCiB9IFdLX0VOVU1fQVZB SUxBQkxFKDEwXzEwLCA4XzApOwogCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L0NvY29hL19XS0VsZW1lbnRBY3Rpb24ubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tFbGVtZW50QWN0aW9uLm1tCShyZXZpc2lvbiAxOTE2MzQp CisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL19XS0VsZW1lbnRBY3Rpb24u bW0JKHdvcmtpbmcgY29weSkKQEAgLTEyNyw2ICsxMjcsMTMgQEAgKyAoaW5zdGFuY2V0eXBlKV9l bGVtZW50QWN0aW9uV2l0aFR5cGU6KAogICAgICAgICB9OwogICAgICAgICBicmVhazsKICNlbmRp ZgorICAgIGNhc2UgX1dLRWxlbWVudEFjdGlvblR5cGVTaGFyZToKKyAgICAgICAgdGl0bGUgPSBX RUJfVUlfU1RSSU5HKCJTaGFyZeKApiIsICJUaXRsZSBmb3IgU2hhcmUgYWN0aW9uIGJ1dHRvbiIp OworICAgICAgICBoYW5kbGVyID0gXihXS0FjdGlvblNoZWV0QXNzaXN0YW50ICphc3Npc3RhbnQs IF9XS0FjdGl2YXRlZEVsZW1lbnRJbmZvICphY3Rpb25JbmZvKSB7CisgICAgICAgICAgICBOU0xv ZyhAImFjdGlvbkluZm8uX2ludGVyYWN0aW9uTG9jYXRpb24gZm9yIHNoYXJlIGl0ZW0gaXMgJUAi LCBOU1N0cmluZ0Zyb21Qb2ludChhY3Rpb25JbmZvLl9pbnRlcmFjdGlvbkxvY2F0aW9uKSk7Cisg ICAgICAgICAgICBbYXNzaXN0YW50LmRlbGVnYXRlIGFjdGlvblNoZWV0QXNzaXN0YW50OmFzc2lz dGFudCBzaGFyZUVsZW1lbnRXaXRoVVJMOmFjdGlvbkluZm8uVVJMIHJlY3Q6YWN0aW9uSW5mby5i b3VuZGluZ1JlY3RdOworICAgICAgICB9OworICAgICAgICBicmVhazsKICAgICBkZWZhdWx0Ogog ICAgICAgICBbTlNFeGNlcHRpb24gcmFpc2U6TlNJbnZhbGlkQXJndW1lbnRFeGNlcHRpb24gZm9y bWF0OkAiVGhlcmUgaXMgbm8gc3RhbmRhcmQgd2ViIGVsZW1lbnQgYWN0aW9uIG9mIHR5cGUgJWxk LiIsIChsb25nKXR5cGVdOwogICAgICAgICByZXR1cm4gbmlsOwpJbmRleDogU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL2lvcy9XS0FjdGlvblNoZWV0QXNzaXN0YW50LmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0FjdGlvblNoZWV0QXNzaXN0YW50LmgJKHJl dmlzaW9uIDE5MTYzNCkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tBY3Rpb25T aGVldEFzc2lzdGFudC5oCSh3b3JraW5nIGNvcHkpCkBAIC00NSw2ICs0NSw3IEBAIHN0cnVjdCBJ bnRlcmFjdGlvbkluZm9ybWF0aW9uQXRQb3NpdGlvbjsKIC0gKGNvbnN0IFdlYktpdDo6SW50ZXJh Y3Rpb25JbmZvcm1hdGlvbkF0UG9zaXRpb24mKXBvc2l0aW9uSW5mb3JtYXRpb25Gb3JBY3Rpb25T aGVldEFzc2lzdGFudDooV0tBY3Rpb25TaGVldEFzc2lzdGFudCAqKWFzc2lzdGFudDsKIC0gKHZv aWQpYWN0aW9uU2hlZXRBc3Npc3RhbnQ6KFdLQWN0aW9uU2hlZXRBc3Npc3RhbnQgKilhc3Npc3Rh bnQgcGVyZm9ybUFjdGlvbjooV2ViS2l0OjpTaGVldEFjdGlvbilhY3Rpb247CiAtICh2b2lkKWFj dGlvblNoZWV0QXNzaXN0YW50OihXS0FjdGlvblNoZWV0QXNzaXN0YW50ICopYXNzaXN0YW50IG9w ZW5FbGVtZW50QXRMb2NhdGlvbjooQ0dQb2ludClsb2NhdGlvbjsKKy0gKHZvaWQpYWN0aW9uU2hl ZXRBc3Npc3RhbnQ6KFdLQWN0aW9uU2hlZXRBc3Npc3RhbnQgKilhc3Npc3RhbnQgc2hhcmVFbGVt ZW50V2l0aFVSTDooTlNVUkwgKil1cmwgcmVjdDooQ0dSZWN0KWJvdW5kaW5nUmVjdDsKICNpZiBI QVZFKEFQUF9MSU5LUykKIC0gKEJPT0wpYWN0aW9uU2hlZXRBc3Npc3RhbnQ6KFdLQWN0aW9uU2hl ZXRBc3Npc3RhbnQgKilhc3Npc3RhbnQgc2hvdWxkSW5jbHVkZUFwcExpbmtBY3Rpb25zRm9yRWxl bWVudDooX1dLQWN0aXZhdGVkRWxlbWVudEluZm8gKillbGVtZW50OwogI2VuZGlmCkluZGV4OiBT b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQWN0aW9uU2hlZXRBc3Npc3RhbnQubW0KPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0FjdGlvblNoZWV0QXNz aXN0YW50Lm1tCShyZXZpc2lvbiAxOTE2MzQpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv aW9zL1dLQWN0aW9uU2hlZXRBc3Npc3RhbnQubW0JKHdvcmtpbmcgY29weSkKQEAgLTM0Myw4ICsz NDMsMTAgQEAgLSAoUmV0YWluUHRyPE5TQXJyYXk+KWRlZmF1bHRBY3Rpb25zRm9yTAogICAgIGlm IChbZ2V0U1NSZWFkaW5nTGlzdENsYXNzKCkgc3VwcG9ydHNVUkw6dGFyZ2V0VVJMXSkKICAgICAg ICAgW2RlZmF1bHRBY3Rpb25zIGFkZE9iamVjdDpbX1dLRWxlbWVudEFjdGlvbiBfZWxlbWVudEFj dGlvbldpdGhUeXBlOl9XS0VsZW1lbnRBY3Rpb25UeXBlQWRkVG9SZWFkaW5nTGlzdCBhc3Npc3Rh bnQ6c2VsZl1dOwogI2VuZGlmCi0gICAgaWYgKCFbW3RhcmdldFVSTCBzY2hlbWVdIGxlbmd0aF0g fHwgW1t0YXJnZXRVUkwgc2NoZW1lXSBjYXNlSW5zZW5zaXRpdmVDb21wYXJlOkAiamF2YXNjcmlw dCJdICE9IE5TT3JkZXJlZFNhbWUpCisgICAgaWYgKCFbW3RhcmdldFVSTCBzY2hlbWVdIGxlbmd0 aF0gfHwgW1t0YXJnZXRVUkwgc2NoZW1lXSBjYXNlSW5zZW5zaXRpdmVDb21wYXJlOkAiamF2YXNj cmlwdCJdICE9IE5TT3JkZXJlZFNhbWUpIHsKICAgICAgICAgW2RlZmF1bHRBY3Rpb25zIGFkZE9i amVjdDpbX1dLRWxlbWVudEFjdGlvbiBfZWxlbWVudEFjdGlvbldpdGhUeXBlOl9XS0VsZW1lbnRB Y3Rpb25UeXBlQ29weSBhc3Npc3RhbnQ6c2VsZl1dOworICAgICAgICBbZGVmYXVsdEFjdGlvbnMg YWRkT2JqZWN0OltfV0tFbGVtZW50QWN0aW9uIF9lbGVtZW50QWN0aW9uV2l0aFR5cGU6X1dLRWxl bWVudEFjdGlvblR5cGVTaGFyZSBhc3Npc3RhbnQ6c2VsZl1dOworICAgIH0KIAogICAgIHJldHVy biBkZWZhdWx0QWN0aW9uczsKIH0KSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3Mv V0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCShyZXZpc2lvbiAxOTE2 MzQpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFj dGlvbi5tbQkod29ya2luZyBjb3B5KQpAQCAtMzM4MCw2ICszMzgwLDE0IEBAIC0gKHZvaWQpYWN0 aW9uU2hlZXRBc3Npc3RhbnQ6KFdLQWN0aW9uU2gKICAgICBbc2VsZiBfYXR0ZW1wdENsaWNrQXRM b2NhdGlvbjpsb2NhdGlvbl07CiB9CiAKKy0gKHZvaWQpYWN0aW9uU2hlZXRBc3Npc3RhbnQ6KFdL QWN0aW9uU2hlZXRBc3Npc3RhbnQgKilhc3Npc3RhbnQgc2hhcmVFbGVtZW50V2l0aFVSTDooTlNV UkwgKil1cmwgcmVjdDooQ0dSZWN0KWJvdW5kaW5nUmVjdAoreworICAgIGlmIChfdGV4dFNlbGVj dGlvbkFzc2lzdGFudCAmJiBbX3RleHRTZWxlY3Rpb25Bc3Npc3RhbnQgcmVzcG9uZHNUb1NlbGVj dG9yOkBzZWxlY3RvcihzaG93U2hhcmVTaGVldEZvcjpmcm9tUmVjdDopXSkKKyAgICAgICAgW190 ZXh0U2VsZWN0aW9uQXNzaXN0YW50IHNob3dTaGFyZVNoZWV0Rm9yOlt1cmwgYWJzb2x1dGVTdHJp bmddIGZyb21SZWN0OmJvdW5kaW5nUmVjdF07CisgICAgZWxzZSBpZiAoX3dlYlNlbGVjdGlvbkFz c2lzdGFudCAmJiBbX3dlYlNlbGVjdGlvbkFzc2lzdGFudCByZXNwb25kc1RvU2VsZWN0b3I6QHNl bGVjdG9yKHNob3dTaGFyZVNoZWV0Rm9yOmZyb21SZWN0OildKQorICAgICAgICBbX3dlYlNlbGVj dGlvbkFzc2lzdGFudCBzaG93U2hhcmVTaGVldEZvcjpbdXJsIGFic29sdXRlU3RyaW5nXSBmcm9t UmVjdDpib3VuZGluZ1JlY3RdOworfQorCiAjaWYgSEFWRShBUFBfTElOS1MpCiAtIChCT09MKWFj dGlvblNoZWV0QXNzaXN0YW50OihXS0FjdGlvblNoZWV0QXNzaXN0YW50ICopYXNzaXN0YW50IHNo b3VsZEluY2x1ZGVBcHBMaW5rQWN0aW9uc0ZvckVsZW1lbnQ6KF9XS0FjdGl2YXRlZEVsZW1lbnRJ bmZvICopZWxlbWVudAogewpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS1BE RlZpZXcubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS1BE RlZpZXcubW0JKHJldmlzaW9uIDE5MTYzNCkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9p b3MvV0tQREZWaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xMDUsNiArMTA1LDggQEAgLSAodm9p ZClfcmVzZXRab29tQW5pbWF0ZWQ6KEJPT0wpYW5pbWF0ZQogICAgIF9XS0ZpbmRPcHRpb25zIF9u ZXh0Q2FjaGVkRmluZE9wdGlvbnNBZmZlY3RpbmdSZXN1bHRzOwogCiAgICAgZGlzcGF0Y2hfcXVl dWVfdCBfZmluZFF1ZXVlOworCisgICAgUmV0YWluUHRyPFVJV0tTZWxlY3Rpb25Bc3Npc3RhbnQ+ IF93ZWJTZWxlY3Rpb25Bc3Npc3RhbnQ7CiB9CiAKIC0gKGluc3RhbmNldHlwZSl3ZWJfaW5pdFdp dGhGcmFtZTooQ0dSZWN0KWZyYW1lIHdlYlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcKQEAgLTcx OCw2ICs3MjAsMTQgQEAgLSAodm9pZClhY3Rpb25TaGVldEFzc2lzdGFudDooV0tBY3Rpb25TaAog ICAgIF93ZWJWaWV3LT5fcGFnZS0+bmF2aWdhdGVUb1BERkxpbmtXaXRoU2ltdWxhdGVkQ2xpY2so X3Bvc2l0aW9uSW5mb3JtYXRpb24udXJsLCByb3VuZGVkSW50UG9pbnQobG9jYXRpb24pLCByb3Vu ZGVkSW50UG9pbnQoc2NyZWVuUG9pbnQpKTsKIH0KIAorLSAodm9pZClhY3Rpb25TaGVldEFzc2lz dGFudDooV0tBY3Rpb25TaGVldEFzc2lzdGFudCAqKWFzc2lzdGFudCBzaGFyZUVsZW1lbnRXaXRo VVJMOihOU1VSTCAqKXVybCByZWN0OihDR1JlY3QpYm91bmRpbmdSZWN0Cit7CisgICAgX3dlYlNl bGVjdGlvbkFzc2lzdGFudCA9IGFkb3B0TlMoW1tVSVdLU2VsZWN0aW9uQXNzaXN0YW50IGFsbG9j XSBpbml0V2l0aFZpZXc6c2VsZl0pOworICAgIGlmIChbX3dlYlNlbGVjdGlvbkFzc2lzdGFudCBy ZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVjdG9yKHNob3dTaGFyZVNoZWV0Rm9yOmZyb21SZWN0Oild KQorICAgICAgICBbX3dlYlNlbGVjdGlvbkFzc2lzdGFudCBzaG93U2hhcmVTaGVldEZvcjpbdXJs IGFic29sdXRlU3RyaW5nXSBmcm9tUmVjdDpib3VuZGluZ1JlY3RdOworICAgIF93ZWJTZWxlY3Rp b25Bc3Npc3RhbnQgPSBuaWw7Cit9CisKICNpZiBIQVZFKEFQUF9MSU5LUykKIC0gKEJPT0wpYWN0 aW9uU2hlZXRBc3Npc3RhbnQ6KFdLQWN0aW9uU2hlZXRBc3Npc3RhbnQgKilhc3Npc3RhbnQgc2hv dWxkSW5jbHVkZUFwcExpbmtBY3Rpb25zRm9yRWxlbWVudDooX1dLQWN0aXZhdGVkRWxlbWVudElu Zm8gKillbGVtZW50CiB7Cg== 264597 2015-11-02 10:04:53 -0800 2015-11-02 10:05:48 -0800 Follow-up fix for non-ascii URLs for-review.txt text/plain 3186 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MTg4OSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE1LTExLTAyICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBUYXBwaW5nIGFuZCBob2xkaW5nIGEg bGluayBzaG91bGQgaGF2ZSBhIHNoYXJlIG9wdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwNjkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBpcyBhIGZvbGxvdy11cCB0byB0aGUgb3JpZ2lu YWwgY2hhbmdlLiBUaGlzIGNoYW5nZSBmaXhlcyBub24tYXNjaWkgVVJMcy4gCisgICAgICAgIFRo ZXkgc2hvdWxkIG1haW50YWluIHRoZWlyIG5vbi1hc2NpaSBjaGFyYWN0ZXJzIHdoZW4gdGhleSBh cmUgc2hhcmVkLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJh Y3Rpb24ubW06CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgYWN0aW9uU2hlZXRBc3Npc3RhbnQ6 c2hhcmVFbGVtZW50V2l0aFVSTDpyZWN0Ol0pOgorICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tQ REZWaWV3Lm1tOgorICAgICAgICAoLVtXS1BERlZpZXcgYWN0aW9uU2hlZXRBc3Npc3RhbnQ6c2hh cmVFbGVtZW50V2l0aFVSTDpyZWN0Ol0pOgorCiAyMDE1LTExLTAyICBZb3Vlbm4gRmFibGV0ICA8 eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CiAKICAgICAgICAgUmVuYW1lIEpTRE9NV3JhcHBl ci5pbXBsIHRvIEpTRE9NV3JhcHBlci53cmFwcGVkCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQkocmV2 aXNpb24gMTkxODMwKQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRW aWV3SW50ZXJhY3Rpb24ubW0JKHdvcmtpbmcgY29weSkKQEAgLTY5LDYgKzY5LDcgQEAKICNpbXBv cnQgPFdlYkNvcmUvU2Nyb2xsYmFyLmg+CiAjaW1wb3J0IDxXZWJDb3JlL1NvZnRMaW5raW5nLmg+ CiAjaW1wb3J0IDxXZWJDb3JlL1RleHRJbmRpY2F0b3IuaD4KKyNpbXBvcnQgPFdlYkNvcmUvV2Vi Q29yZU5TVVJMRXh0cmFzLmg+CiAjaW1wb3J0IDxXZWJDb3JlL1dlYkV2ZW50Lmg+CiAjaW1wb3J0 IDxXZWJLaXQvV2ViU2VsZWN0aW9uUmVjdC5oPiAvLyBGSVhNRTogV0syIHNob3VsZCBub3QgaW5j bHVkZSBXZWJLaXQgaGVhZGVycyEKICNpbXBvcnQgPFdlYktpdFN5c3RlbUludGVyZmFjZUlPUy5o PgpAQCAtMzM3NCw5ICszMzc1LDkgQEAgLSAodm9pZClhY3Rpb25TaGVldEFzc2lzdGFudDooV0tB Y3Rpb25TaAogLSAodm9pZClhY3Rpb25TaGVldEFzc2lzdGFudDooV0tBY3Rpb25TaGVldEFzc2lz dGFudCAqKWFzc2lzdGFudCBzaGFyZUVsZW1lbnRXaXRoVVJMOihOU1VSTCAqKXVybCByZWN0OihD R1JlY3QpYm91bmRpbmdSZWN0CiB7CiAgICAgaWYgKF90ZXh0U2VsZWN0aW9uQXNzaXN0YW50KQot ICAgICAgICBbX3RleHRTZWxlY3Rpb25Bc3Npc3RhbnQgc2hvd1NoYXJlU2hlZXRGb3I6dXJsLmFi c29sdXRlU3RyaW5nIGZyb21SZWN0OmJvdW5kaW5nUmVjdF07CisgICAgICAgIFtfdGV4dFNlbGVj dGlvbkFzc2lzdGFudCBzaG93U2hhcmVTaGVldEZvcjp1c2VyVmlzaWJsZVN0cmluZyh1cmwpIGZy b21SZWN0OmJvdW5kaW5nUmVjdF07CiAgICAgZWxzZSBpZiAoX3dlYlNlbGVjdGlvbkFzc2lzdGFu dCkKLSAgICAgICAgW193ZWJTZWxlY3Rpb25Bc3Npc3RhbnQgc2hvd1NoYXJlU2hlZXRGb3I6dXJs LmFic29sdXRlU3RyaW5nIGZyb21SZWN0OmJvdW5kaW5nUmVjdF07CisgICAgICAgIFtfd2ViU2Vs ZWN0aW9uQXNzaXN0YW50IHNob3dTaGFyZVNoZWV0Rm9yOnVzZXJWaXNpYmxlU3RyaW5nKHVybCkg ZnJvbVJlY3Q6Ym91bmRpbmdSZWN0XTsKIH0KIAogI2lmIEhBVkUoQVBQX0xJTktTKQpJbmRleDog U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS1BERlZpZXcubW0KPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS1BERlZpZXcubW0JKHJldmlzaW9uIDE5MTgw NSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tQREZWaWV3Lm1tCSh3b3JraW5n IGNvcHkpCkBAIC00MSw2ICs0MSw3IEBACiAjaW1wb3J0IDxNb2JpbGVDb3JlU2VydmljZXMvVVRD b3JlVHlwZXMuaD4KICNpbXBvcnQgPFdlYkNvcmUvRmxvYXRSZWN0Lmg+CiAjaW1wb3J0IDxXZWJD b3JlL0xvY2FsaXplZFN0cmluZ3MuaD4KKyNpbXBvcnQgPFdlYkNvcmUvV2ViQ29yZU5TVVJMRXh0 cmFzLmg+CiAjaW1wb3J0IDx3dGYvUmV0YWluUHRyLmg+CiAjaW1wb3J0IDx3dGYvVmVjdG9yLmg+ CiAKQEAgLTcyMyw3ICs3MjQsNyBAQCAtICh2b2lkKWFjdGlvblNoZWV0QXNzaXN0YW50OihXS0Fj dGlvblNoCiAtICh2b2lkKWFjdGlvblNoZWV0QXNzaXN0YW50OihXS0FjdGlvblNoZWV0QXNzaXN0 YW50ICopYXNzaXN0YW50IHNoYXJlRWxlbWVudFdpdGhVUkw6KE5TVVJMICopdXJsIHJlY3Q6KENH UmVjdClib3VuZGluZ1JlY3QKIHsKICAgICBfd2ViU2VsZWN0aW9uQXNzaXN0YW50ID0gYWRvcHRO UyhbW1VJV0tTZWxlY3Rpb25Bc3Npc3RhbnQgYWxsb2NdIGluaXRXaXRoVmlldzpzZWxmXSk7Ci0g ICAgW193ZWJTZWxlY3Rpb25Bc3Npc3RhbnQgc2hvd1NoYXJlU2hlZXRGb3I6dXJsLmFic29sdXRl U3RyaW5nIGZyb21SZWN0OmJvdW5kaW5nUmVjdF07CisgICAgW193ZWJTZWxlY3Rpb25Bc3Npc3Rh bnQgc2hvd1NoYXJlU2hlZXRGb3I6dXNlclZpc2libGVTdHJpbmcodXJsKSBmcm9tUmVjdDpib3Vu ZGluZ1JlY3RdOwogICAgIF93ZWJTZWxlY3Rpb25Bc3Npc3RhbnQgPSBuaWw7CiB9CiAK