150687 2015-10-29 12:59:16 -0700 cdjs-tests.yaml/main.js.ftl fails due to FTL ArithSub code for supporting UntypedUse operands 2015-10-29 16:41:50 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 150562 1 mark.lam mark.lam benjamin commit-queue fpizlo ggaren keith_miller msaboff saam oldest_to_newest 1137622 0 mark.lam 2015-10-29 12:59:16 -0700 For example, see https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20JSC%20%28Tests%29/builds/422. This issue does not always reproduces. But on the machines where they do reproduce, it reproduces consistently. Will disable the feature temporarily until I figure out what the issue is. 1137624 1 mark.lam 2015-10-29 13:02:11 -0700 This issue is strictly in the FTL and 64-bit only. There were some 32-bit JSC bots that appeared to be failing due to this. That was due to a configuration bug on those bots where they were accidentally building 64-bit instead of 32-bit. That issue has been fixed in http://trac.webkit.org/changeset/191747. 1137626 2 264336 mark.lam 2015-10-29 13:05:39 -0700 Created attachment 264336 patch to disable the feature. 1137629 3 264336 commit-queue 2015-10-29 13:10:51 -0700 Comment on attachment 264336 patch to disable the feature. Rejecting attachment 264336 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 264336, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/JavaScriptCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.webkit.org/results/354537 1137631 4 264338 mark.lam 2015-10-29 13:12:44 -0700 Created attachment 264338 Fixed ChangeLog comment. 1137639 5 264338 commit-queue 2015-10-29 14:08:54 -0700 Comment on attachment 264338 Fixed ChangeLog comment. Clearing flags on attachment: 264338 Committed r191753: <http://trac.webkit.org/changeset/191753> 1137640 6 commit-queue 2015-10-29 14:09:00 -0700 All reviewed patches have been landed. Closing bug. 1137711 7 fpizlo 2015-10-29 16:41:50 -0700 Disabling this optimization by checking the result type is super unusual and likely very fragile. Can you please use the use kinds instead? 264336 2015-10-29 13:05:39 -0700 2015-10-29 13:12:44 -0700 patch to disable the feature. bug-150687.patch text/plain 1592 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTkxNzQ4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE1LTEwLTI5ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBj ZGpzLXRlc3RzLnlhbWwvbWFpbi5qcy5mdGwgZmFpbHMgZHVlIHRvIEZUTCBBcml0aFN1YiBjb2Rl IGZvciBzdXBwb3J0aW5nIFVudHlwZWRVc2Ugb3BlcmFuZHMuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTA2ODcKKworICAgICAgICBOb3QgcmV2aWV3 ZWQuCisKKyAgICAgICAgRGlzYWJsaW5nIHRoZSBmZWF0dXJlIHdoaWxlIGl0IGlzIGJlaW5nIGRl YnVnZ2VkLiAgSSdtIGRvaW5nIHRoaXMgYnkgZWZmZWN0aXZlbHkKKyAgICAgICAgcm9sbGluZyBv dXQgb25seSB0aGUgY2hhbmdlcyBpbiBGVExDYXBhYmlsaXRpZXMuY3BwLgorCisgICAgICAgICog ZnRsL0ZUTENhcGFiaWxpdGllcy5jcHA6CisgICAgICAgIChKU0M6OkZUTDo6Y2FuQ29tcGlsZSk6 CisKIDIwMTUtMTAtMjkgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAg ICBBaXIgbmVlZHMgc3ludGF4IGZvciBlc2NhcGluZyBTdGFja1Nsb3RzCkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvZnRsL0ZUTENhcGFiaWxpdGllcy5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExDYXBhYmlsaXRpZXMuY3BwCShyZXZpc2lvbiAxOTE3 NDgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTENhcGFiaWxpdGllcy5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTg0LDcgKzg0LDYgQEAgaW5saW5lIENhcGFiaWxpdHlMZXZlbCBjYW5D b21waWxlKE5vZGUqIAogICAgIGNhc2UgU3RyQ2F0OgogICAgIGNhc2UgQXJpdGhBZGQ6CiAgICAg Y2FzZSBBcml0aENsejMyOgotICAgIGNhc2UgQXJpdGhTdWI6CiAgICAgY2FzZSBBcml0aE11bDoK ICAgICBjYXNlIEFyaXRoRGl2OgogICAgIGNhc2UgQXJpdGhNb2Q6CkBAIC0yMTIsNiArMjExLDEw IEBAIGlubGluZSBDYXBhYmlsaXR5TGV2ZWwgY2FuQ29tcGlsZShOb2RlKiAKICAgICBjYXNlIFB1 dFNldHRlckJ5VmFsOgogICAgICAgICAvLyBUaGVzZSBhcmUgT0suCiAgICAgICAgIGJyZWFrOwor ICAgIGNhc2UgQXJpdGhTdWI6CisgICAgICAgIGlmIChub2RlLT5yZXN1bHQoKSA9PSBOb2RlUmVz dWx0SlMpCisgICAgICAgICAgICByZXR1cm4gQ2Fubm90Q29tcGlsZTsKKyAgICAgICAgYnJlYWs7 CiAKICAgICBjYXNlIElkZW50aXR5OgogICAgICAgICAvLyBObyBiYWNrZW5kIGhhbmRsZXMgdGhp cyBiZWNhdXNlIGl0IHdpbGwgYmUgb3B0aW1pemVkIG91dC4gQnV0IHdlIG1heSBjaGVjawo= 264338 2015-10-29 13:12:44 -0700 2015-10-29 14:08:54 -0700 Fixed ChangeLog comment. bug-150687.patch text/plain 1590 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTkxNzQ4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE1LTEwLTI5ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBj ZGpzLXRlc3RzLnlhbWwvbWFpbi5qcy5mdGwgZmFpbHMgZHVlIHRvIEZUTCBBcml0aFN1YiBjb2Rl IGZvciBzdXBwb3J0aW5nIFVudHlwZWRVc2Ugb3BlcmFuZHMuCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTA2ODcKKworICAgICAgICBVbnJldmlld2Vk LgorCisgICAgICAgIERpc2FibGluZyB0aGUgZmVhdHVyZSB3aGlsZSBpdCBpcyBiZWluZyBkZWJ1 Z2dlZC4gIEknbSBkb2luZyB0aGlzIGJ5IGVmZmVjdGl2ZWx5CisgICAgICAgIHJvbGxpbmcgb3V0 IG9ubHkgdGhlIGNoYW5nZXMgaW4gRlRMQ2FwYWJpbGl0aWVzLmNwcC4KKworICAgICAgICAqIGZ0 bC9GVExDYXBhYmlsaXRpZXMuY3BwOgorICAgICAgICAoSlNDOjpGVEw6OmNhbkNvbXBpbGUpOgor CiAyMDE1LTEwLTI5ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAg QWlyIG5lZWRzIHN5bnRheCBmb3IgZXNjYXBpbmcgU3RhY2tTbG90cwpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL2Z0bC9GVExDYXBhYmlsaXRpZXMuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMQ2FwYWJpbGl0aWVzLmNwcAkocmV2aXNpb24gMTkxNzQ4 KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExDYXBhYmlsaXRpZXMuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC04NCw3ICs4NCw2IEBAIGlubGluZSBDYXBhYmlsaXR5TGV2ZWwgY2FuQ29t cGlsZShOb2RlKiAKICAgICBjYXNlIFN0ckNhdDoKICAgICBjYXNlIEFyaXRoQWRkOgogICAgIGNh c2UgQXJpdGhDbHozMjoKLSAgICBjYXNlIEFyaXRoU3ViOgogICAgIGNhc2UgQXJpdGhNdWw6CiAg ICAgY2FzZSBBcml0aERpdjoKICAgICBjYXNlIEFyaXRoTW9kOgpAQCAtMjEyLDYgKzIxMSwxMCBA QCBpbmxpbmUgQ2FwYWJpbGl0eUxldmVsIGNhbkNvbXBpbGUoTm9kZSogCiAgICAgY2FzZSBQdXRT ZXR0ZXJCeVZhbDoKICAgICAgICAgLy8gVGhlc2UgYXJlIE9LLgogICAgICAgICBicmVhazsKKyAg ICBjYXNlIEFyaXRoU3ViOgorICAgICAgICBpZiAobm9kZS0+cmVzdWx0KCkgPT0gTm9kZVJlc3Vs dEpTKQorICAgICAgICAgICAgcmV0dXJuIENhbm5vdENvbXBpbGU7CisgICAgICAgIGJyZWFrOwog CiAgICAgY2FzZSBJZGVudGl0eToKICAgICAgICAgLy8gTm8gYmFja2VuZCBoYW5kbGVzIHRoaXMg YmVjYXVzZSBpdCB3aWxsIGJlIG9wdGltaXplZCBvdXQuIEJ1dCB3ZSBtYXkgY2hlY2sK