150680 2015-10-29 10:57:11 -0700 Remove a never used SPI delegate method 2015-10-29 11:31:36 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca bdakin oldest_to_newest 1137565 0 andersca 2015-10-29 10:57:11 -0700 Remove a never used SPI delegate method 1137566 1 264324 andersca 2015-10-29 10:59:20 -0700 Created attachment 264324 Patch 1137571 2 264324 bdakin 2015-10-29 11:11:31 -0700 Comment on attachment 264324 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264324&action=review > Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:92 > void WebContextMenuClient::contextMenuItemSelected(ContextMenuItem* item, const ContextMenu* parentMenu) Why did you leave an empty stub of this function? 1137580 3 264324 andersca 2015-10-29 11:31:34 -0700 Comment on attachment 264324 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264324&action=review >> Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:92 >> void WebContextMenuClient::contextMenuItemSelected(ContextMenuItem* item, const ContextMenu* parentMenu) > > Why did you leave an empty stub of this function? Because it's a client member function and we must have an implementation of it. 1137581 4 andersca 2015-10-29 11:31:36 -0700 Committed r191739: <http://trac.webkit.org/changeset/191739> 264324 2015-10-29 10:59:20 -0700 2015-10-29 11:11:31 -0700 Patch bug-150680-20151029105829.patch text/plain 4763 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxNzMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggNGY5YzU1ZTRh NDE3MjI1ZjY5MTg5MmI0MDY2OTU1ZjI3MDlkMDQzYS4uOTRmNDc3NWVjOThmNDk1NDdlODdjZDFj NjE5YjU3ZjNiZDYxZDY3ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE1 LTEwLTI5ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAg UmVtb3ZlIGEgbmV2ZXIgdXNlZCBTUEkgZGVsZWdhdGUgbWV0aG9kCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTA2ODAKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgd2ViVmlldzpjb250ZXh0TWVudUl0 ZW1TZWxlY3RlZDpmb3JFbGVtZW50OiBtZXRob2Qgd2FzIGFkZGVkIDkgeWVhcnMgYWdvLCBzZWVt aW5nbHkgZm9yIGZlYXR1cmUgcGFyaXR5IHdpdGggdGhlIFdpbmRvd3MgcG9ydC4KKyAgICAgICAg VGhlIGRlbGVnYXRlIG1ldGhvZCB3aWxsIG5ldmVyIGJlIGNhbGxlZCB1bmxlc3MgYSBtZW51IGl0 ZW0gaGFzIHRoZSBpbnRlcm5hbCBXZWJLaXQgYWN0aW9uL3RhcmdldCBwYWlyLCBhbmQgYSB0YWcg dGhhdCAKKyAgICAgICAgaXMgc2V0IHRvID49IENvbnRleHRNZW51SXRlbUJhc2VBcHBsaWNhdGlv blRhZy4gQmVjYXVzZSBvZiB0aGlzLCB3ZSBjYW4gc2FmZWx5IHJlbW92ZSBpdC4KKworICAgICAg ICAqIERlZmF1bHREZWxlZ2F0ZXMvV2ViRGVmYXVsdFVJRGVsZWdhdGUubToKKyAgICAgICAgKC1b V2ViRGVmYXVsdFVJRGVsZWdhdGUgd2ViVmlldzp3aWxsUG9wdXBNZW51Ol0pOgorICAgICAgICAo LVtXZWJEZWZhdWx0VUlEZWxlZ2F0ZSB3ZWJWaWV3OmRpZERyYXdSZWN0Ol0pOgorICAgICAgICAo LVtXZWJEZWZhdWx0VUlEZWxlZ2F0ZSB3ZWJWaWV3OmRpZFNjcm9sbERvY3VtZW50SW5GcmFtZVZp ZXc6XSk6CisgICAgICAgICgtW1dlYkRlZmF1bHRVSURlbGVnYXRlIHdlYlZpZXc6Y29udGV4dE1l bnVJdGVtU2VsZWN0ZWQ6Zm9yRWxlbWVudDpdKTogRGVsZXRlZC4KKyAgICAgICAgKiBXZWJDb3Jl U3VwcG9ydC9XZWJDb250ZXh0TWVudUNsaWVudC5tbToKKyAgICAgICAgKFdlYkNvbnRleHRNZW51 Q2xpZW50Ojpjb250ZXh0TWVudUl0ZW1TZWxlY3RlZCk6IERlbGV0ZWQuCisgICAgICAgICogV2Vi Vmlldy9XZWJVSURlbGVnYXRlUHJpdmF0ZS5oOgorCiAyMDE1LTEwLTI4ICBBbmRlcnMgQ2FybHNz b24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViS2l0LCBub3QgV2ViQ29yZSwg c2hvdWxkIGRvIGNvbnRleHQgbWVudSBjb252ZXJzaW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L21hYy9EZWZhdWx0RGVsZWdhdGVzL1dlYkRlZmF1bHRVSURlbGVnYXRlLm0gYi9Tb3VyY2Uv V2ViS2l0L21hYy9EZWZhdWx0RGVsZWdhdGVzL1dlYkRlZmF1bHRVSURlbGVnYXRlLm0KaW5kZXgg YWE0NGE3MGMwNDdjZTdhOGY5YTVhNDJkYzcyN2Y4MjBlMjdkZTJkNi4uOTAwZjNhYTgwMTNhOTJj YjFlZGYxNjM2YjAyOThiNDZkMmZlNWY0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMv RGVmYXVsdERlbGVnYXRlcy9XZWJEZWZhdWx0VUlEZWxlZ2F0ZS5tCisrKyBiL1NvdXJjZS9XZWJL aXQvbWFjL0RlZmF1bHREZWxlZ2F0ZXMvV2ViRGVmYXVsdFVJRGVsZWdhdGUubQpAQCAtMjQyLDI1 ICsyNDIsMTkgQEAgLSAoTlNVSW50ZWdlcil3ZWJWaWV3OihXZWJWaWV3ICopd2ViVmlldyBkcmFn U291cmNlQWN0aW9uTWFza0ZvclBvaW50OihOU1BvaW50KXAKIC0gKHZvaWQpd2ViVmlldzooV2Vi VmlldyAqKXdlYlZpZXcgd2lsbFBlcmZvcm1EcmFnU291cmNlQWN0aW9uOihXZWJEcmFnU291cmNl QWN0aW9uKWFjdGlvbiBmcm9tUG9pbnQ6KE5TUG9pbnQpcG9pbnQgd2l0aFBhc3RlYm9hcmQ6KE5T UGFzdGVib2FyZCAqKXBhc3RlYm9hcmQKIHsKIH0KLSNlbmRpZgogCi0tICh2b2lkKXdlYlZpZXc6 KFdlYlZpZXcgKilzZW5kZXIgZGlkRHJhd1JlY3Q6KE5TUmVjdClyZWN0Ci17Ci19Ci0KLS0gKHZv aWQpd2ViVmlldzooV2ViVmlldyAqKXNlbmRlciBkaWRTY3JvbGxEb2N1bWVudEluRnJhbWVWaWV3 OihXZWJGcmFtZVZpZXcgKilmcmFtZVZpZXcKKy0gKHZvaWQpd2ViVmlldzooV2ViVmlldyAqKXNl bmRlciB3aWxsUG9wdXBNZW51OihOU01lbnUgKiltZW51CiB7CiB9CisjZW5kaWYKIAotI2lmICFQ TEFURk9STShJT1MpCi0tICh2b2lkKXdlYlZpZXc6KFdlYlZpZXcgKilzZW5kZXIgd2lsbFBvcHVw TWVudTooTlNNZW51ICopbWVudQorLSAodm9pZCl3ZWJWaWV3OihXZWJWaWV3ICopc2VuZGVyIGRp ZERyYXdSZWN0OihOU1JlY3QpcmVjdAogewogfQogCi0tICh2b2lkKXdlYlZpZXc6KFdlYlZpZXcg KilzZW5kZXIgY29udGV4dE1lbnVJdGVtU2VsZWN0ZWQ6KE5TTWVudUl0ZW0gKilpdGVtIGZvckVs ZW1lbnQ6KE5TRGljdGlvbmFyeSAqKWVsZW1lbnQKKy0gKHZvaWQpd2ViVmlldzooV2ViVmlldyAq KXNlbmRlciBkaWRTY3JvbGxEb2N1bWVudEluRnJhbWVWaWV3OihXZWJGcmFtZVZpZXcgKilmcmFt ZVZpZXcKIHsKIH0KLSNlbmRpZgogCiAtICh2b2lkKXdlYlZpZXc6KFdlYlZpZXcgKilzZW5kZXIg ZXhjZWVkZWRBcHBsaWNhdGlvbkNhY2hlT3JpZ2luUXVvdGFGb3JTZWN1cml0eU9yaWdpbjooV2Vi U2VjdXJpdHlPcmlnaW4gKilvcmlnaW4gdG90YWxTcGFjZU5lZWRlZDooTlNVSW50ZWdlcil0b3Rh bFNwYWNlTmVlZGVkCiB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3Vw cG9ydC9XZWJDb250ZXh0TWVudUNsaWVudC5tbSBiL1NvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVT dXBwb3J0L1dlYkNvbnRleHRNZW51Q2xpZW50Lm1tCmluZGV4IDdiZGFhNGUxODk5ZjBlMmFkNjM0 YWVmYzRiYmU2NjE2OGMxN2M4YzQuLjRhZDFhNWE0ZDY0ZGYzOWJjNmJhNjUyZTFkYzU3NzBiNmEz YWQ0MmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkNv bnRleHRNZW51Q2xpZW50Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0 L1dlYkNvbnRleHRNZW51Q2xpZW50Lm1tCkBAIC05MSwxNSArOTEsNiBAQCB2b2lkIFdlYkNvbnRl eHRNZW51Q2xpZW50Ojpjb250ZXh0TWVudURlc3Ryb3llZCgpCiAKIHZvaWQgV2ViQ29udGV4dE1l bnVDbGllbnQ6OmNvbnRleHRNZW51SXRlbVNlbGVjdGVkKENvbnRleHRNZW51SXRlbSogaXRlbSwg Y29uc3QgQ29udGV4dE1lbnUqIHBhcmVudE1lbnUpCiB7Ci0gICAgaWQgZGVsZWdhdGUgPSBbbV93 ZWJWaWV3IFVJRGVsZWdhdGVdOwotICAgIFNFTCBzZWxlY3RvciA9IEBzZWxlY3Rvcih3ZWJWaWV3 OmNvbnRleHRNZW51SXRlbVNlbGVjdGVkOmZvckVsZW1lbnQ6KTsKLSAgICBpZiAoW2RlbGVnYXRl IHJlc3BvbmRzVG9TZWxlY3RvcjpzZWxlY3Rvcl0pIHsKLSAgICAgICAgTlNEaWN0aW9uYXJ5ICpl bGVtZW50ID0gW1tXZWJFbGVtZW50RGljdGlvbmFyeSBhbGxvY10gaW5pdFdpdGhIaXRUZXN0UmVz dWx0OlttX3dlYlZpZXcgcGFnZV0tPmNvbnRleHRNZW51Q29udHJvbGxlcigpLmhpdFRlc3RSZXN1 bHQoKV07Ci0KLSAgICAgICAgQ2FsbFVJRGVsZWdhdGUobV93ZWJWaWV3LCBzZWxlY3RvciwgaXRl bS0+cGxhdGZvcm1EZXNjcmlwdGlvbigpLCBlbGVtZW50KTsKLQotICAgICAgICBbZWxlbWVudCBy ZWxlYXNlXTsKLSAgICB9CiB9CiAKIHZvaWQgV2ViQ29udGV4dE1lbnVDbGllbnQ6OmRvd25sb2Fk VVJMKGNvbnN0IFVSTCYgdXJsKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9tYWMvV2ViVmll dy9XZWJVSURlbGVnYXRlUHJpdmF0ZS5oIGIvU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJV SURlbGVnYXRlUHJpdmF0ZS5oCmluZGV4IDViZTY3YjIwYTkyYTliZmQwNTdmMmQxNDc4ZjkyYTFm OTIzNWE4ZTYuLjlmNDI1OWIzOTA0MjYxNzhkNjIxNzcxOWQwN2E4OWEzOWEwOTU0MjQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViVUlEZWxlZ2F0ZVByaXZhdGUuaAor KysgYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlVJRGVsZWdhdGVQcml2YXRlLmgKQEAg LTIxNiw3ICsyMTYsNiBAQCBleHRlcm4gTlNTdHJpbmcgKldlYkNvbnNvbGVNZXNzYWdlRXJyb3JN ZXNzYWdlTGV2ZWw7CiAtICh2b2lkKXdlYlZpZXc6KFdlYlZpZXcgKilzZW5kZXIgZGlkU2Nyb2xs RG9jdW1lbnRJbkZyYW1lVmlldzooV2ViRnJhbWVWaWV3ICopZnJhbWVWaWV3OwogI2lmICFUQVJH RVRfT1NfSVBIT05FCiAtICh2b2lkKXdlYlZpZXc6KFdlYlZpZXcgKilzZW5kZXIgd2lsbFBvcHVw TWVudTooTlNNZW51ICopbWVudTsKLS0gKHZvaWQpd2ViVmlldzooV2ViVmlldyAqKXNlbmRlciBj b250ZXh0TWVudUl0ZW1TZWxlY3RlZDooTlNNZW51SXRlbSAqKWl0ZW0gZm9yRWxlbWVudDooTlNE aWN0aW9uYXJ5ICopZWxlbWVudDsKIC0gKHZvaWQpd2ViVmlldzooV2ViVmlldyAqKXNlbmRlciBz YXZlRnJhbWVWaWV3OihXZWJGcmFtZVZpZXcgKilmcmFtZVZpZXcgc2hvd2luZ1BhbmVsOihCT09M KXNob3dpbmdQYW5lbDsKIAogLy8gRklYTUU6IFJlbmFtZSB0aGlzIGJlY2F1c2UgaXQncyBvbmx5 IHVzZWQgYnkgaW1tZWRpYXRlIGFjdGlvbiBjb2RlLgo=