150662 2015-10-28 21:29:19 -0700 [CoordinatedGraphics] invisible webview should not paint the content 2015-11-03 15:40:35 -0800 1 1 1 Unclassified WebKit WebKit EFL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi commit-queue lucas.de.marchi oldest_to_newest 1137442 0 ryuan.choi 2015-10-28 21:29:19 -0700 CoordinatedDrawingArea can suspend or resume the painting when visibility of webpage is changed. But, CoordinatedDrawingArea does not suspend the painting when invisible webview is created. 1137445 1 264296 ryuan.choi 2015-10-28 21:35:18 -0700 Created attachment 264296 Patch 1138197 2 264296 darin 2015-10-31 14:32:03 -0700 Comment on attachment 264296 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264296&action=review > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:-72 > - , m_isPaintingSuspended(!(parameters.viewState & ViewState::IsVisible)) Not sure why we are changing the code to not initialize this. We need to give it some value at this point. > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:79 > + m_isPaintingSuspended = parameters.viewState & ViewState::IsVisible; This doesn’t look right for the visible case. It’s going to set m_isPaintingSuspended to true in that case. > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:81 > + if (!m_isPaintingSuspended) > + suspendPainting(); Seems like what we actually want to do is to initialize m_isPaintingSuspended to false, and then write: if (!(parameters.viewState & ViewState::IsVisible)) suspendPainting(); Also would be good to come up with a way to do a regression test. 1138299 3 264513 ryuan.choi 2015-11-01 03:54:25 -0800 Created attachment 264513 Patch 1138300 4 264296 ryuan.choi 2015-11-01 03:58:52 -0800 Comment on attachment 264296 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264296&action=review >> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:-72 >> - , m_isPaintingSuspended(!(parameters.viewState & ViewState::IsVisible)) > > Not sure why we are changing the code to not initialize this. We need to give it some value at this point. OK, I tried as another approach. >> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:81 >> + suspendPainting(); > > Seems like what we actually want to do is to initialize m_isPaintingSuspended to false, and then write: > > if (!(parameters.viewState & ViewState::IsVisible)) > suspendPainting(); > > Also would be good to come up with a way to do a regression test. I followed like you mentioned. But, I don't have idea to test this. This is not to draw anything when view is created without visibility. 1138351 5 264513 darin 2015-11-01 12:47:33 -0800 Comment on attachment 264513 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264513&action=review > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:80 > + if (!(parameters.viewState & ViewState::IsVisible)) > + suspendPainting(); I suggest initializing m_isPaintingSuspended to false, instead of initializing it based on the IsVisible flag. > Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:-408 > - ASSERT(!m_isPaintingSuspended); I suggest leaving this assertion in. 1138883 6 264677 ryuan.choi 2015-11-03 02:04:39 -0800 Created attachment 264677 Patch 1139133 7 264677 commit-queue 2015-11-03 15:40:30 -0800 Comment on attachment 264677 Patch Clearing flags on attachment: 264677 Committed r191987: <http://trac.webkit.org/changeset/191987> 1139134 8 commit-queue 2015-11-03 15:40:35 -0800 All reviewed patches have been landed. Closing bug. 264296 2015-10-28 21:35:18 -0700 2015-11-01 03:54:19 -0800 Patch bug-150662-20151029133426.patch text/plain 2370 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxNjUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOGE4MGM2ZWE1ZGM5ZDFj YjI5M2YzYmNjODA4ZmUzYWMxNzMzNWMxNy4uOWZjOWU2OTE2ODY2YjgzNWVkYzg4NzdjOTk5NzIx ODkwODg3ZDVkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTEwLTI4ICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBuYXZlcmNvcnAuY29tPgorCisgICAgICAgIFtDb29yZGluYXRl ZEdyYXBoaWNzXSBpbnZpc2libGUgd2VidmlldyBzaG91bGQgbm90IHBhaW50IHRoZSBjb250ZW50 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTA2NjIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb29yZGlu YXRlZERyYXdpbmdBcmVhIGNhbiBzdXNwZW5kIG9yIHJlc3VtZSB0aGUgcGFpbnRpbmcgd2hlbiB0 aGUgdmlzaWJpbGl0eQorICAgICAgICBvZiB3ZWJwYWdlIGlzIGNoYW5nZWQuIEJ1dCwgQ29vcmRp bmF0ZWREcmF3aW5nQXJlYSBkb2VzIG5vdCBzdXNwZW5kCisgICAgICAgIHRoZSBwYWludGluZyBi dXQganVzdCBtYXJrcyB0aGUgZmxhZyB3aGVuIGludmlzaWJsZSB3ZWJ2aWV3IGlzIGNyZWF0ZWQu CisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29y ZGluYXRlZERyYXdpbmdBcmVhLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q29vcmRpbmF0ZWREcmF3 aW5nQXJlYTo6Q29vcmRpbmF0ZWREcmF3aW5nQXJlYSk6CisgICAgICAgIENhbGwgc3VzcGVuZFBh aW50aW5nKCkgaW4gY29uc3RydWN0b3Igd2hlbiB3ZWJwYWdlIGlzIG5vdCB2aXNpYmxlLgorCiAy MDE1LTEwLTI3ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAg ICAgIEZpeCB0aGUgMzItYml0IGJ1aWxkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWREcmF3aW5nQXJl YS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFw aGljcy9Db29yZGluYXRlZERyYXdpbmdBcmVhLmNwcAppbmRleCBmNzRlODAwMWIxN2YwZmI5NDc3 MjdhMWM3ZWY5MDRjODExMjExOTZiLi45YTg2ZGJhZTk0ZTMxMTk5YjkwMWVmMzJkNzUyOTA0OGE0 ZGQ0ZjRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29v cmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZERyYXdpbmdBcmVhLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRl ZERyYXdpbmdBcmVhLmNwcApAQCAtNjksMTIgKzY5LDE2IEBAIENvb3JkaW5hdGVkRHJhd2luZ0Fy ZWE6OkNvb3JkaW5hdGVkRHJhd2luZ0FyZWEoV2ViUGFnZSYgd2ViUGFnZSwgY29uc3QgV2ViUGFn ZUNyCiAgICAgLCBtX2NvbXBvc2l0aW5nQWNjb3JkaW5nVG9Qcm94eU1lc3NhZ2VzKGZhbHNlKQog ICAgICwgbV9sYXllclRyZWVTdGF0ZUlzRnJvemVuKGZhbHNlKQogICAgICwgbV93YW50c1RvRXhp dEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdNb2RlKGZhbHNlKQotICAgICwgbV9pc1BhaW50aW5nU3Vz cGVuZGVkKCEocGFyYW1ldGVycy52aWV3U3RhdGUgJiBWaWV3U3RhdGU6OklzVmlzaWJsZSkpCiAg ICAgLCBtX2Rpc3BsYXlUaW1lcihSdW5Mb29wOjptYWluKCksIHRoaXMsICZDb29yZGluYXRlZERy YXdpbmdBcmVhOjpkaXNwbGF5VGltZXJGaXJlZCkKICAgICAsIG1fZXhpdENvbXBvc2l0aW5nVGlt ZXIoUnVuTG9vcDo6bWFpbigpLCB0aGlzLCAmQ29vcmRpbmF0ZWREcmF3aW5nQXJlYTo6ZXhpdEFj Y2VsZXJhdGVkQ29tcG9zaXRpbmdNb2RlKQogewogICAgIC8vIEFsd2F5cyB1c2UgY29tcG9zaXRp bmcgaW4gQ29vcmRpbmF0ZWRHcmFwaGljcwogICAgIGVudGVyQWNjZWxlcmF0ZWRDb21wb3NpdGlu Z01vZGUoMCk7CisKKyAgICAvLyBzdXNwZW5kUGFpbnRpbmcoKSB3aWxsIHRvZ2dsZSBtX2lzUGFp bnRpbmdTdXNwZW5kZWQuCisgICAgbV9pc1BhaW50aW5nU3VzcGVuZGVkID0gcGFyYW1ldGVycy52 aWV3U3RhdGUgJiBWaWV3U3RhdGU6OklzVmlzaWJsZTsKKyAgICBpZiAoIW1faXNQYWludGluZ1N1 c3BlbmRlZCkKKyAgICAgICAgc3VzcGVuZFBhaW50aW5nKCk7CiB9CiAKIHZvaWQgQ29vcmRpbmF0 ZWREcmF3aW5nQXJlYTo6c2V0TmVlZHNEaXNwbGF5KCkK 264513 2015-11-01 03:54:25 -0800 2015-11-03 02:04:31 -0800 Patch bug-150662-20151101205330.patch text/plain 2071 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxODU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggN2RmNjc2YTVlNjcwNmRj OWZhNzE1YTZlMDE5MjZhOGY3MGE1YmU1Zi4uNmRjOWY4NWZlYzk0MzQxMmVhZWNmYTYwNThjMGJi OWRhZGQxZDRjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTExLTAxICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBuYXZlcmNvcnAuY29tPgorCisgICAgICAgIFtDb29yZGluYXRl ZEdyYXBoaWNzXSBpbnZpc2libGUgd2VidmlldyBzaG91bGQgbm90IHBhaW50IHRoZSBjb250ZW50 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTA2NjIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb29yZGlu YXRlZERyYXdpbmdBcmVhIGNhbiBzdXNwZW5kIG9yIHJlc3VtZSB0aGUgcGFpbnRpbmcgd2hlbiB0 aGUgdmlzaWJpbGl0eQorICAgICAgICBvZiB3ZWJwYWdlIGlzIGNoYW5nZWQuIEJ1dCwgQ29vcmRp bmF0ZWREcmF3aW5nQXJlYSBkb2VzIG5vdCBzdXNwZW5kCisgICAgICAgIHRoZSBwYWludGluZyBi dXQganVzdCBtYXJrcyB0aGUgZmxhZyB3aGVuIGludmlzaWJsZSB3ZWJ2aWV3IGlzIGNyZWF0ZWQu CisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29y ZGluYXRlZERyYXdpbmdBcmVhLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q29vcmRpbmF0ZWREcmF3 aW5nQXJlYTo6Q29vcmRpbmF0ZWREcmF3aW5nQXJlYSk6CisgICAgICAgIChXZWJLaXQ6OkNvb3Jk aW5hdGVkRHJhd2luZ0FyZWE6OnN1c3BlbmRQYWludGluZyk6CisKIDIwMTUtMTEtMDEgIENhcmxv cyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFVz ZSBSdW5Mb29wOjpUaW1lciBpbiBQbHVnaW5JbmZvQ2FjaGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVk RHJhd2luZ0FyZWEuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3Jk aW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWREcmF3aW5nQXJlYS5jcHAKaW5kZXggZjc0ZTgwMDFi MTdmMGZiOTQ3NzI3YTFjN2VmOTA0YzgxMTIxMTk2Yi4uOTU0OGY4OWRjN2I3ZTQzZDNlMDhjZDIw MGZiYTlkNjY2NDE0MjA1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWREcmF3aW5nQXJlYS5jcHAKKysr IGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3Mv Q29vcmRpbmF0ZWREcmF3aW5nQXJlYS5jcHAKQEAgLTc1LDYgKzc1LDkgQEAgQ29vcmRpbmF0ZWRE cmF3aW5nQXJlYTo6Q29vcmRpbmF0ZWREcmF3aW5nQXJlYShXZWJQYWdlJiB3ZWJQYWdlLCBjb25z dCBXZWJQYWdlQ3IKIHsKICAgICAvLyBBbHdheXMgdXNlIGNvbXBvc2l0aW5nIGluIENvb3JkaW5h dGVkR3JhcGhpY3MKICAgICBlbnRlckFjY2VsZXJhdGVkQ29tcG9zaXRpbmdNb2RlKDApOworCisg ICAgaWYgKCEocGFyYW1ldGVycy52aWV3U3RhdGUgJiBWaWV3U3RhdGU6OklzVmlzaWJsZSkpCisg ICAgICAgIHN1c3BlbmRQYWludGluZygpOwogfQogCiB2b2lkIENvb3JkaW5hdGVkRHJhd2luZ0Fy ZWE6OnNldE5lZWRzRGlzcGxheSgpCkBAIC00MDUsOCArNDA4LDYgQEAgdm9pZCBDb29yZGluYXRl ZERyYXdpbmdBcmVhOjpkaWRVcGRhdGUoKQogCiB2b2lkIENvb3JkaW5hdGVkRHJhd2luZ0FyZWE6 OnN1c3BlbmRQYWludGluZygpCiB7Ci0gICAgQVNTRVJUKCFtX2lzUGFpbnRpbmdTdXNwZW5kZWQp OwotCiAgICAgaWYgKG1fbGF5ZXJUcmVlSG9zdCkKICAgICAgICAgbV9sYXllclRyZWVIb3N0LT5w YXVzZVJlbmRlcmluZygpOwogCg== 264677 2015-11-03 02:04:39 -0800 2015-11-03 15:40:30 -0800 Patch bug-150662-20151103190342.patch text/plain 2177 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxODU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggN2RmNjc2YTVlNjcwNmRj OWZhNzE1YTZlMDE5MjZhOGY3MGE1YmU1Zi4uMmExODUyMDA5M2Y3ZGVlZWU1NTNlODU3YWE0MjE5 YTVmNDMwMjljMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTExLTAzICBSeXVh biBDaG9pICA8cnl1YW4uY2hvaUBuYXZlcmNvcnAuY29tPgorCisgICAgICAgIFtDb29yZGluYXRl ZEdyYXBoaWNzXSBpbnZpc2libGUgd2VidmlldyBzaG91bGQgbm90IHBhaW50IHRoZSBjb250ZW50 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTA2NjIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTdXNwZW5k IG9yIHJlc3VtZSB0aGUgcGFpbnRpbmcgaW5zdGVhZCBvZiBqdXN0IGluaXRpYWxpemluZyBtX2lz UGFpbnRpbmdTdXNwZW5kZWQgCisgICAgICAgIGZvciBpbnZpc2libGUgd2VidmlldyBub3QgdG8g cGFpbnQgdGhlIGNvbnRlbnQgdW50aWwgdmlzaWJpbGl0eSBpcyBjaGFuZ2VkLgorCisgICAgICAg ICogV2ViUHJvY2Vzcy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvQ29vcmRpbmF0ZWREcmF3 aW5nQXJlYS5jcHA6CisgICAgICAgIChXZWJLaXQ6OkNvb3JkaW5hdGVkRHJhd2luZ0FyZWE6OkNv b3JkaW5hdGVkRHJhd2luZ0FyZWEpOgorCiAyMDE1LTExLTAxICBDYXJsb3MgR2FyY2lhIENhbXBv cyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBVc2UgUnVuTG9vcDo6VGlt ZXIgaW4gUGx1Z2luSW5mb0NhY2hlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9Db29yZGluYXRlZERyYXdpbmdBcmVhLmNw cCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNz L0Nvb3JkaW5hdGVkRHJhd2luZ0FyZWEuY3BwCmluZGV4IGY3NGU4MDAxYjE3ZjBmYjk0NzcyN2Ex YzdlZjkwNGM4MTEyMTE5NmIuLmU1NTE3MjgzZjNhM2NmNTkyN2RlOTMwYjNmYmNhZDlkZWE5Yjhm ODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGlu YXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkRHJhd2luZ0FyZWEuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0Nvb3JkaW5hdGVkRHJh d2luZ0FyZWEuY3BwCkBAIC02OSwxMiArNjksMTUgQEAgQ29vcmRpbmF0ZWREcmF3aW5nQXJlYTo6 Q29vcmRpbmF0ZWREcmF3aW5nQXJlYShXZWJQYWdlJiB3ZWJQYWdlLCBjb25zdCBXZWJQYWdlQ3IK ICAgICAsIG1fY29tcG9zaXRpbmdBY2NvcmRpbmdUb1Byb3h5TWVzc2FnZXMoZmFsc2UpCiAgICAg LCBtX2xheWVyVHJlZVN0YXRlSXNGcm96ZW4oZmFsc2UpCiAgICAgLCBtX3dhbnRzVG9FeGl0QWNj ZWxlcmF0ZWRDb21wb3NpdGluZ01vZGUoZmFsc2UpCi0gICAgLCBtX2lzUGFpbnRpbmdTdXNwZW5k ZWQoIShwYXJhbWV0ZXJzLnZpZXdTdGF0ZSAmIFZpZXdTdGF0ZTo6SXNWaXNpYmxlKSkKKyAgICAs IG1faXNQYWludGluZ1N1c3BlbmRlZChmYWxzZSkKICAgICAsIG1fZGlzcGxheVRpbWVyKFJ1bkxv b3A6Om1haW4oKSwgdGhpcywgJkNvb3JkaW5hdGVkRHJhd2luZ0FyZWE6OmRpc3BsYXlUaW1lckZp cmVkKQogICAgICwgbV9leGl0Q29tcG9zaXRpbmdUaW1lcihSdW5Mb29wOjptYWluKCksIHRoaXMs ICZDb29yZGluYXRlZERyYXdpbmdBcmVhOjpleGl0QWNjZWxlcmF0ZWRDb21wb3NpdGluZ01vZGUp CiB7CiAgICAgLy8gQWx3YXlzIHVzZSBjb21wb3NpdGluZyBpbiBDb29yZGluYXRlZEdyYXBoaWNz CiAgICAgZW50ZXJBY2NlbGVyYXRlZENvbXBvc2l0aW5nTW9kZSgwKTsKKworICAgIGlmICghKHBh cmFtZXRlcnMudmlld1N0YXRlICYgVmlld1N0YXRlOjpJc1Zpc2libGUpKQorICAgICAgICBzdXNw ZW5kUGFpbnRpbmcoKTsKIH0KIAogdm9pZCBDb29yZGluYXRlZERyYXdpbmdBcmVhOjpzZXROZWVk c0Rpc3BsYXkoKQo=