150655 2015-10-28 18:42:56 -0700 we're incorrectly adjusting a stack location with respect to the localsOffset in FTLCompile 2015-10-29 12:15:46 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov keith_miller mark.lam msaboff oliver sukolsak ysuzuki oldest_to_newest 1137412 0 saam 2015-10-28 18:42:56 -0700 we're recomputing this for a *OSRExitDescriptor* for every one of its *OSRExits*. This is having a multiplicative effect on offsets. I'm amazed this didn't break any of our tests. I think I introduced this in: https://bugs.webkit.org/show_bug.cgi?id=149970 1137424 1 264287 saam 2015-10-28 19:12:06 -0700 Created attachment 264287 patch 1137425 2 fpizlo 2015-10-28 19:19:21 -0700 Nice catch! 1137429 3 264287 ggaren 2015-10-28 19:29:04 -0700 Comment on attachment 264287 patch Can haz regression test? 1137454 4 saam 2015-10-28 22:20:21 -0700 (In reply to comment #3) > Comment on attachment 264287 [details] > patch > > Can haz regression test? I'll try to see if I can come up with one before landing this. We will definitely have one once FTL try/catch lands but it will be nice if I can come up with a small and simple reproducible program. This might be a bit tricky to get right. If I can't come up with a small program, I think coming up with a small program for FTL try/catch will be easier because of the nature of OSR exits from from calls and get/put_by_ids. 1137577 5 saam 2015-10-29 11:28:53 -0700 (In reply to comment #4) > (In reply to comment #3) > > Comment on attachment 264287 [details] > > patch > > > > Can haz regression test? > I'll try to see if I can come up with one before landing this. > We will definitely have one once FTL try/catch lands but > it will be nice if I can come up with a small and simple > reproducible program. This might be a bit tricky > to get right. If I can't come up with a small program, > I think coming up with a small program for FTL try/catch > will be easier because of the nature of OSR exits from > from calls and get/put_by_ids. I couldn't get a test case to reproduce this easily. I'm going to defer until FTL try/catch where we definitely will have a test case. 1137584 6 ggaren 2015-10-29 11:35:40 -0700 Okeedokee. 1137607 7 264287 commit-queue 2015-10-29 12:15:37 -0700 Comment on attachment 264287 patch Clearing flags on attachment: 264287 Committed r191744: <http://trac.webkit.org/changeset/191744> 1137608 8 commit-queue 2015-10-29 12:15:46 -0700 All reviewed patches have been landed. Closing bug. 264287 2015-10-28 19:12:06 -0700 2015-10-29 12:15:37 -0700 patch a-backup.diff text/plain 2615 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTkxNzE4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE1LTEwLTI4ICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IHdlJ3JlIGluY29ycmVjdGx5IGFkanVzdGluZyBhIHN0YWNrIGxvY2F0aW9uIHdpdGggcmVzcGVj dCB0byB0aGUgbG9jYWxzT2Zmc2V0IGluIEZUTENvbXBpbGUKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDY1NQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlJ3JlIHJlY29tcHV0aW5nIHRoaXMgdmFsdWUg Zm9yIGFuICpPU1JFeGl0RGVzY3JpcHRvciogZm9yIGV2ZXJ5IG9uZQorICAgICAgICBvZiBpdHMg Y29ycmVzcG9uZGluZyAqT1NSRXhpdHMqLiBUaGlzIGlzIGhhdmluZyBhIG11bHRpcGxpY2F0aXZl CisgICAgICAgIGVmZmVjdCBvbiBvZmZzZXRzIGJlY2F1c2UgZWFjaCBjb21wdXRhdGlvbiBpcyBy ZWxhdGl2ZSB0byB0aGUgcHJldmlvdXMKKyAgICAgICAgdmFsdWUuIFdlIG11c3QgZG8gdGhpcyBj b21wdXRhdGlvbiBqdXN0IG9uY2UgcGVyIE9TUkV4aXREZXNjcmlwdG9yLgorCisgICAgICAgICog ZnRsL0ZUTENvbXBpbGUuY3BwOgorICAgICAgICAoSlNDOjpGVEw6Om1tQWxsb2NhdGVEYXRhU2Vj dGlvbik6CisKIDIwMTUtMTAtMjggIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAog ICAgICAgICBCMzo6cmVkdWNlU3RyZW5ndGgoKSBzaG91bGQgZG8gRENFCkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvZnRsL0ZUTENvbXBpbGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9mdGwvRlRMQ29tcGlsZS5jcHAJKHJldmlzaW9uIDE5MTcxOCkKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMQ29tcGlsZS5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTU2Myw2ICs1NjMsMTEgQEAgc3RhdGljIHZvaWQgZml4RnVuY3Rpb25CYXNlZE9uU3RhY2tNYXBz KAogICAgICAgICAgICAgY29udGludWU7CiAgICAgICAgIH0KIAorICAgICAgICBmb3IgKHVuc2ln bmVkIGogPSBleGl0RGVzY3JpcHRvci5tX3ZhbHVlcy5zaXplKCk7IGotLTspCisgICAgICAgICAg ICBleGl0RGVzY3JpcHRvci5tX3ZhbHVlc1tqXSA9IGV4aXREZXNjcmlwdG9yLm1fdmFsdWVzW2pd LndpdGhMb2NhbHNPZmZzZXQobG9jYWxzT2Zmc2V0KTsKKyAgICAgICAgZm9yIChFeGl0VGltZU9i amVjdE1hdGVyaWFsaXphdGlvbiogbWF0ZXJpYWxpemF0aW9uIDogZXhpdERlc2NyaXB0b3IubV9t YXRlcmlhbGl6YXRpb25zKQorICAgICAgICAgICAgbWF0ZXJpYWxpemF0aW9uLT5hY2NvdW50Rm9y TG9jYWxzT2Zmc2V0KGxvY2Fsc09mZnNldCk7CisKICAgICAgICAgZm9yICh1bnNpZ25lZCBqID0g MDsgaiA8IGl0ZXItPnZhbHVlLnNpemUoKTsgaisrKSB7CiAgICAgICAgICAgICB1aW50MzJfdCBz dGFja21hcFJlY29yZEluZGV4ID0gaXRlci0+dmFsdWVbal0uaW5kZXg7CiAgICAgICAgICAgICBP U1JFeGl0IGV4aXQoZXhpdERlc2NyaXB0b3IsIHN0YWNrbWFwUmVjb3JkSW5kZXgpOwpAQCAtNTk0 LDExICs1OTksNiBAQCBzdGF0aWMgdm9pZCBmaXhGdW5jdGlvbkJhc2VkT25TdGFja01hcHMoCiAg ICAgICAgICAgICBpbmZvLm1fdGh1bmtBZGRyZXNzID0gbGlua0J1ZmZlci0+bG9jYXRpb25PZihp bmZvLm1fdGh1bmtMYWJlbCk7CiAgICAgICAgICAgICBleGl0Lm1fcGF0Y2hhYmxlQ29kZU9mZnNl dCA9IGxpbmtCdWZmZXItPm9mZnNldE9mKGluZm8ubV90aHVua0p1bXApOwogICAgICAgICAgICAg Ci0gICAgICAgICAgICBmb3IgKHVuc2lnbmVkIGogPSBleGl0Lm1fZGVzY3JpcHRvci5tX3ZhbHVl cy5zaXplKCk7IGotLTspCi0gICAgICAgICAgICAgICAgZXhpdC5tX2Rlc2NyaXB0b3IubV92YWx1 ZXNbal0gPSBleGl0Lm1fZGVzY3JpcHRvci5tX3ZhbHVlc1tqXS53aXRoTG9jYWxzT2Zmc2V0KGxv Y2Fsc09mZnNldCk7Ci0gICAgICAgICAgICBmb3IgKEV4aXRUaW1lT2JqZWN0TWF0ZXJpYWxpemF0 aW9uKiBtYXRlcmlhbGl6YXRpb24gOiBleGl0Lm1fZGVzY3JpcHRvci5tX21hdGVyaWFsaXphdGlv bnMpCi0gICAgICAgICAgICAgICAgbWF0ZXJpYWxpemF0aW9uLT5hY2NvdW50Rm9yTG9jYWxzT2Zm c2V0KGxvY2Fsc09mZnNldCk7Ci0gICAgICAgICAgICAKICAgICAgICAgICAgIGlmICh2ZXJib3Nl Q29tcGlsYXRpb25FbmFibGVkKCkpIHsKICAgICAgICAgICAgICAgICBEdW1wQ29udGV4dCBjb250 ZXh0OwogICAgICAgICAgICAgICAgIGRhdGFMb2coIiAgICBFeGl0IHZhbHVlczogIiwgaW5Db250 ZXh0KGV4aXQubV9kZXNjcmlwdG9yLm1fdmFsdWVzLCAmY29udGV4dCksICJcbiIpOwo=