150652 2015-10-28 17:51:13 -0700 Web Inspector: Add "revert" to CSS value autocompletion 2015-10-28 18:25:25 -0700 1 1 1 Unclassified WebKit Web Inspector Other All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts hyatt joepeck mattbaker nvasilyev rniwa simon.fraser timothy webkit-bug-importer oldest_to_newest 1137385 0 joepeck 2015-10-28 17:51:13 -0700 * SUMMARY Add "revert" to CSS value autocompletion. Just like "unset", "revert" is a valid value supported on all properties. Add it everywhere "unset" was just added. 1137386 1 webkit-bug-importer 2015-10-28 17:51:38 -0700 <rdar://problem/23307649> 1137387 2 264279 joepeck 2015-10-28 17:52:28 -0700 Created attachment 264279 [PATCH] Proposed Fix 1137401 3 264279 commit-queue 2015-10-28 18:25:21 -0700 Comment on attachment 264279 [PATCH] Proposed Fix Clearing flags on attachment: 264279 Committed r191715: <http://trac.webkit.org/changeset/191715> 1137402 4 commit-queue 2015-10-28 18:25:25 -0700 All reviewed patches have been landed. Closing bug. 264279 2015-10-28 17:52:28 -0700 2015-10-28 18:25:21 -0700 [PATCH] Proposed Fix revert.patch text/plain 4782 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDIxNzE2NjguLjVjY2E2NTkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE1LTEwLTI4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQWRkICJy ZXZlcnQiIHRvIENTUyB2YWx1ZSBhdXRvY29tcGxldGlvbgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwNjUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL01vZGVscy9DU1NDb21w bGV0aW9ucy5qczoKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL01vZGVscy9DU1NLZXl3b3JkQ29t cGxldGlvbnMuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ1NTS2V5d29yZENvbXBsZXRpb25z LmZvclByb3BlcnR5KToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1Zpc3VhbFN0eWxl RGV0YWlsc1BhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlZpc3VhbFN0eWxlRGV0YWls c1BhbmVsKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5WaXN1YWxTdHlsZURldGFpbHNQYW5lbC5w cm90b3R5cGUuX3BvcHVsYXRlRGlzcGxheVNlY3Rpb24pOgorICAgICAgICAoV2ViSW5zcGVjdG9y LlZpc3VhbFN0eWxlRGV0YWlsc1BhbmVsLnByb3RvdHlwZS5fcG9wdWxhdGVBbGlnbm1lbnRTZWN0 aW9uKToKKyAgICAgICAgVHJlYXQgInJldmVydCIgbGlrZSBpbml0aWFsIGFuZCB1bnNldC4gSXQg aXMgdmFsaWQgb24gYWxsIHByb3BlcnRpZXMuCisKKzIwMTUtMTAtMjggIEpvc2VwaCBQZWNvcmFy byAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBTaG93IFRp bWVsaW5lIE1hcmtlcnMgYWdhaW4gKERPTUNvbnRlbnRMb2FkZWQsIExvYWQsIGNvbnNvbGUudGlt ZVN0YW1wKQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTUwNjEyCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L01vZGVscy9DU1NDb21wbGV0aW9ucy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL01vZGVscy9DU1NDb21wbGV0aW9ucy5qcwppbmRleCA3YWFmNDIxLi4yNzU1ZWI1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQ1NT Q29tcGxldGlvbnMuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv TW9kZWxzL0NTU0NvbXBsZXRpb25zLmpzCkBAIC05Nyw3ICs5Nyw3IEBAIFdlYkluc3BlY3Rvci5D U1NDb21wbGV0aW9ucyA9IGNsYXNzIENTU0NvbXBsZXRpb25zCiAgICAgICAgICAgICAgICAgcmV0 dXJuOwogCiAgICAgICAgICAgICB2YXIgcHJvcGVydHlOYW1lc0ZvckNvZGVNaXJyb3IgPSB7fTsK LSAgICAgICAgICAgIHZhciB2YWx1ZUtleXdvcmRzRm9yQ29kZU1pcnJvciA9IHsiaW5oZXJpdCI6 IHRydWUsICJpbml0aWFsIjogdHJ1ZSwgInVuc2V0IjogdHJ1ZX07CisgICAgICAgICAgICB2YXIg dmFsdWVLZXl3b3Jkc0ZvckNvZGVNaXJyb3IgPSB7ImluaGVyaXQiOiB0cnVlLCAiaW5pdGlhbCI6 IHRydWUsICJ1bnNldCI6IHRydWUsICJyZXZlcnQiOiB0cnVlfTsKICAgICAgICAgICAgIHZhciBj b2xvcktleXdvcmRzRm9yQ29kZU1pcnJvciA9IHt9OwogCiAgICAgICAgICAgICBmdW5jdGlvbiBu YW1lRm9yQ29kZU1pcnJvcihuYW1lKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvTW9kZWxzL0NTU0tleXdvcmRDb21wbGV0aW9ucy5qcyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9DU1NLZXl3b3JkQ29tcGxldGlvbnMu anMKaW5kZXggZGQ3MjlkOC4uY2JmNjg1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0NTU0tleXdvcmRDb21wbGV0aW9ucy5qcworKysgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQ1NTS2V5d29yZENvbXBs ZXRpb25zLmpzCkBAIC0zMyw3ICszMyw3IEBAIFdlYkluc3BlY3Rvci5DU1NLZXl3b3JkQ29tcGxl dGlvbnMgPSB7fTsKIAogV2ViSW5zcGVjdG9yLkNTU0tleXdvcmRDb21wbGV0aW9ucy5mb3JQcm9w ZXJ0eSA9IGZ1bmN0aW9uKHByb3BlcnR5TmFtZSkKIHsKLSAgICBsZXQgYWNjZXB0ZWRLZXl3b3Jk cyA9IFsiaW5pdGlhbCIsICJ1bnNldCJdOworICAgIGxldCBhY2NlcHRlZEtleXdvcmRzID0gWyJp bml0aWFsIiwgInVuc2V0IiwgInJldmVydCJdOwogICAgIGxldCBpc05vdFByZWZpeGVkID0gcHJv cGVydHlOYW1lLmNoYXJBdCgwKSAhPT0gIi0iOwogCiAgICAgaWYgKHByb3BlcnR5TmFtZSBpbiBX ZWJJbnNwZWN0b3IuQ1NTS2V5d29yZENvbXBsZXRpb25zLl9wcm9wZXJ0eUtleXdvcmRNYXApCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9WaXN1 YWxTdHlsZURldGFpbHNQYW5lbC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL1Zpc3VhbFN0eWxlRGV0YWlsc1BhbmVsLmpzCmluZGV4IGJjYjIzOTUuLjJlZDc2 YzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1Zpc3VhbFN0eWxlRGV0YWlsc1BhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL1Zpc3VhbFN0eWxlRGV0YWlsc1BhbmVsLmpzCkBAIC0zOSw3ICsz OSw3IEBAIFdlYkluc3BlY3Rvci5WaXN1YWxTdHlsZURldGFpbHNQYW5lbCA9IGNsYXNzIFZpc3Vh bFN0eWxlRGV0YWlsc1BhbmVsIGV4dGVuZHMgV2ViCiAgICAgICAgIHRoaXMuX2F1dG9jb21wbGV0 aW9uUHJvcGVydHlFZGl0b3JzID0ge307CiAKICAgICAgICAgLy8gVGhlc2Uga2V5d29yZHMsIGFz IHdlbGwgYXMgdGhlIHZhbHVlcyBiZWxvdywgYXJlIG5vdCBsb2NhbGl6ZWQgYXMgdGhleSBtdXN0 IG1hdGNoIHRoZSBDU1Mgc3BlYy4KLSAgICAgICAgdGhpcy5fa2V5d29yZHMuZGVmYXVsdHMgPSBb IkluaGVyaXQiLCAiSW5pdGlhbCIsICJVbnNldCJdOworICAgICAgICB0aGlzLl9rZXl3b3Jkcy5k ZWZhdWx0cyA9IFsiSW5oZXJpdCIsICJJbml0aWFsIiwgIlVuc2V0IiwgIlJldmVydCJdOwogICAg ICAgICB0aGlzLl9rZXl3b3Jkcy5ib3hNb2RlbCA9IHRoaXMuX2tleXdvcmRzLmRlZmF1bHRzLmNv bmNhdChbIkF1dG8iXSk7CiAgICAgICAgIHRoaXMuX2tleXdvcmRzLmJvcmRlclN0eWxlID0gewog ICAgICAgICAgICAgYmFzaWM6IHRoaXMuX2tleXdvcmRzLmRlZmF1bHRzLmNvbmNhdChbIk5vbmUi LCAiSGlkZGVuIiwgIlNvbGlkIl0pLApAQCAtMzMzLDcgKzMzMyw3IEBAIFdlYkluc3BlY3Rvci5W aXN1YWxTdHlsZURldGFpbHNQYW5lbCA9IGNsYXNzIFZpc3VhbFN0eWxlRGV0YWlsc1BhbmVsIGV4 dGVuZHMgV2ViCiAKICAgICAgICAgcHJvcGVydGllcy5vcGFjaXR5ID0gbmV3IFdlYkluc3BlY3Rv ci5WaXN1YWxTdHlsZVVuaXRTbGlkZXIoIm9wYWNpdHkiLCBXZWJJbnNwZWN0b3IuVUlTdHJpbmco Ik9wYWNpdHkiKSk7CiAgICAgICAgIHByb3BlcnRpZXMub3ZlcmZsb3cgPSBuZXcgV2ViSW5zcGVj dG9yLlZpc3VhbFN0eWxlS2V5d29yZFBpY2tlcihbIm92ZXJmbG93LXgiLCAib3ZlcmZsb3cteSJd LCBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIk92ZXJmbG93IiksIHsKLSAgICAgICAgICAgIGJhc2lj OiBbIkluaXRpYWwiLCAiVW5zZXQiLCAiQXV0byIsICJIaWRkZW4iLCAiU2Nyb2xsIiwgIlZpc2li bGUiXSwKKyAgICAgICAgICAgIGJhc2ljOiBbIkluaXRpYWwiLCAiVW5zZXQiLCAiUmV2ZXJ0Iiwg IkF1dG8iLCAiSGlkZGVuIiwgIlNjcm9sbCIsICJWaXNpYmxlIl0sCiAgICAgICAgICAgICBhZHZh bmNlZDogWyJNYXJxdWVlIiwgIk92ZXJsYXkiLCAiIFdlYktpdCBQYWdlZCBYIiwgIiBXZWJLaXQg UGFnZWQgWSJdCiAgICAgICAgIH0pOwogCkBAIC01ODEsNyArNTgxLDcgQEAgV2ViSW5zcGVjdG9y LlZpc3VhbFN0eWxlRGV0YWlsc1BhbmVsID0gY2xhc3MgVmlzdWFsU3R5bGVEZXRhaWxzUGFuZWwg ZXh0ZW5kcyBXZWIKICAgICB7CiAgICAgICAgIGxldCBncm91cCA9IHRoaXMuX2dyb3Vwcy5hbGln bm1lbnQ7CiAgICAgICAgIGxldCBwcm9wZXJ0aWVzID0gZ3JvdXAucHJvcGVydGllczsKLSAgICAg ICAgbGV0IGFsaWdubWVudEtleXdvcmRzID0gWyJJbml0aWFsIiwgIlVuc2V0IiwgIkF1dG8iLCAi RmxleCBTdGFydCIsICJGbGV4IEVuZCIsICJDZW50ZXIiLCAiU3RyZXRjaCJdOworICAgICAgICBs ZXQgYWxpZ25tZW50S2V5d29yZHMgPSBbIkluaXRpYWwiLCAiVW5zZXQiLCAiUmV2ZXJ0IiwgIkF1 dG8iLCAiRmxleCBTdGFydCIsICJGbGV4IEVuZCIsICJDZW50ZXIiLCAiU3RyZXRjaCJdOwogICAg ICAgICBsZXQgYWR2YW5jZWRBbGlnbm1lbnRLZXl3b3JkcyA9IFsiU3RhcnQiLCAiRW5kIiwgIkxl ZnQiLCAiUmlnaHQiLCAiQmFzZWxpbmUiLCAiTGFzdCBCYXNlbGluZSJdOwogCiAgICAgICAgIGxl dCBjb250ZW50Um93ID0gbmV3IFdlYkluc3BlY3Rvci5EZXRhaWxzU2VjdGlvblJvdzsK