150649 2015-10-28 17:29:59 -0700 [B3] handleCommutativity should canonicalize commutative operations over non-constants 2015-10-28 17:47:13 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 150507 1 fpizlo fpizlo oldest_to_newest 1137377 0 fpizlo 2015-10-28 17:29:59 -0700 Patch forthcoming. 1137378 1 264276 fpizlo 2015-10-28 17:35:22 -0700 Created attachment 264276 the patch 1137379 2 264277 fpizlo 2015-10-28 17:38:43 -0700 Created attachment 264277 the patch 1137380 3 264277 saam 2015-10-28 17:41:15 -0700 Comment on attachment 264277 the patch LGTM 1137382 4 fpizlo 2015-10-28 17:47:13 -0700 Landed in http://trac.webkit.org/changeset/191712 264276 2015-10-28 17:35:22 -0700 2015-10-28 17:38:43 -0700 the patch blah.patch text/plain 2528 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTkxNzEwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE1LTEwLTI4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg W0IzXSBoYW5kbGVDb21tdXRhdGl2aXR5IHNob3VsZCBjYW5vbmljYWxpemUgY29tbXV0YXRpdmUg b3BlcmF0aW9ucyBvdmVyIG5vbi1jb25zdGFudHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDY0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFR1cm4gdGhpczogQWRkKHZhbHVlMSwgdmFsdWUyKQorICAg ICAgICBJbnRvIHRoaXM6IEFkZCh2YWx1ZTIsIHZhbHVlMSkKKworICAgICAgICBCdXQgb255IGlm IHZhbHVlMiBzaG91bGQgY29tZSBiZWZvcmUgdmFsdWUxIGFjY29yZGluZyB0byBvdXIgdG90YWwg b3JkZXJpbmcuIFRoaXMgd2lsbCBhbGxvdworICAgICAgICBDU0UgdG8gb2JzZXJ2ZSB0aGUgZXF1 YWxpdHkgYmV0d2VlbiBjb21tdXRlZCB2ZXJzaW9ucyBvZiB0aGUgc2FtZSBvcGVyYXRpb24sIHNp bmNlIHdlIHdpbGwKKyAgICAgICAgZmlyc3QgY2Fub25pY2FsaXplIHRoZW0gaW50byB0aGUgc2Ft ZSBvcmRlci4KKworICAgICAgICAqIGIzL0IzUmVkdWNlU3RyZW5ndGguY3BwOgorCiAyMDE1LTEw LTI4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdl ZCwgZml4IHRoZSBidWlsZCBmb3IgY2FzZSBzZW5zaXRpdmUgZmlsZSBzeXN0ZW1zLgpJbmRleDog U291cmNlL0phdmFTY3JpcHRDb3JlL2IzL0IzUmVkdWNlU3RyZW5ndGguY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9CM1JlZHVjZVN0cmVuZ3RoLmNwcAkocmV2aXNp b24gMTkxNzA1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL0IzUmVkdWNlU3RyZW5ndGgu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC03NiwxMCArNzYsNiBAQCBwcml2YXRlOgogICAgICAgICAK ICAgICAgICAgc3dpdGNoIChtX3ZhbHVlLT5vcGNvZGUoKSkgewogICAgICAgICBjYXNlIEFkZDoK LSAgICAgICAgICAgIC8vIFR1cm4gdGhpczogQWRkKGNvbnN0YW50LCB2YWx1ZSkKLSAgICAgICAg ICAgIC8vIEludG8gdGhpczogQWRkKHZhbHVlLCBjb25zdGFudCkKLSAgICAgICAgICAgIC8vCi0g ICAgICAgICAgICAvLyBGSVhNRTogSWYgYm90aCBub24tY29uc3RhbnQsIHdlIHNob3VsZCBzb3J0 IHRoZSBvcGVyYW5kcy4KICAgICAgICAgICAgIGhhbmRsZUNvbW11dGF0aXZpdHkoKTsKIAogICAg ICAgICAgICAgLy8gVHVybiB0aGlzOiBBZGQoQWRkKHZhbHVlLCBjb25zdGFudDEpLCBjb25zdGFu dDIpCkBAIC0xNzQsMTEgKzE3MCwyNyBAQCBwcml2YXRlOgogICAgICAgICB9CiAgICAgfQogCisg ICAgLy8gVHVybiB0aGlzOiBBZGQoY29uc3RhbnQsIHZhbHVlKQorICAgIC8vIEludG8gdGhpczog QWRkKHZhbHVlLCBjb25zdGFudCkKKyAgICAvLworICAgIC8vIEFsc286CisgICAgLy8gVHVybiB0 aGlzOiBBZGQodmFsdWUxLCB2YWx1ZTIpCisgICAgLy8gSW50byB0aGlzOiBBZGQodmFsdWUyLCB2 YWx1ZTEpCisgICAgLy8gSWYgd2UgZGVjaWRlIHRoYXQgdmFsdWUyIGNvbWluZyBmaXJzdCBpcyB0 aGUgY2Fub25pY2FsIG9yZGVyaW5nLgogICAgIHZvaWQgaGFuZGxlQ29tbXV0YXRpdml0eSgpCiAg ICAgewogICAgICAgICBpZiAobV92YWx1ZS0+Y2hpbGQoMCktPmlzQ29uc3RhbnQoKSAmJiAhbV92 YWx1ZS0+Y2hpbGQoMSktPmlzQ29uc3RhbnQoKSkgewogICAgICAgICAgICAgc3RkOjpzd2FwKG1f dmFsdWUtPmNoaWxkKDApLCBtX3ZhbHVlLT5jaGlsZCgxKSk7CiAgICAgICAgICAgICBtX2NoYW5n ZWQgPSB0cnVlOworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisKKyAgICAgICAgLy8g U29ydCB0aGUgb3BlcmFuZHMuIFRoaXMgaXMgYW4gaW1wb3J0YW50IGNhbm9uaWNhbGl6YXRpb24u IFdlIHVzZSB0aGUgaW5kZXggaW5zdGVhZCBvZgorICAgICAgICAvLyB0aGUgYWRkcmVzcyB0byBt YWtlIHRoaXMgYXQgbGVhc3Qgc2xpZ2h0bHkgZGV0ZXJtaW5pc3RpYy4KKyAgICAgICAgaWYgKG1f dmFsdWUtPmNoaWxkKDApLT5pbmRleCgpID4gbV92YWx1ZS0+Y2hpbGQoMSktPmluZGV4KCkpIHsK KyAgICAgICAgICAgIHN0ZDo6c3dhcChtX3ZhbHVlLT5jaGlsZCgwKSwgbV92YWx1ZS0+Y2hpbGQo MSkpOworICAgICAgICAgICAgbV9jaGFuZ2VkID0gdHJ1ZTsKKyAgICAgICAgICAgIHJldHVybjsK ICAgICAgICAgfQogICAgIH0KIAo= 264277 2015-10-28 17:38:43 -0700 2015-10-28 17:41:15 -0700 the patch blah.patch text/plain 2714 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTkxNzEwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE1LTEwLTI4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg W0IzXSBoYW5kbGVDb21tdXRhdGl2aXR5IHNob3VsZCBjYW5vbmljYWxpemUgY29tbXV0YXRpdmUg b3BlcmF0aW9ucyBvdmVyIG5vbi1jb25zdGFudHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDY0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFR1cm4gdGhpczogQWRkKHZhbHVlMSwgdmFsdWUyKQorICAg ICAgICBJbnRvIHRoaXM6IEFkZCh2YWx1ZTIsIHZhbHVlMSkKKworICAgICAgICBCdXQgb255IGlm IHZhbHVlMiBzaG91bGQgY29tZSBiZWZvcmUgdmFsdWUxIGFjY29yZGluZyB0byBvdXIgdG90YWwg b3JkZXJpbmcuIFRoaXMgd2lsbCBhbGxvdworICAgICAgICBDU0UgdG8gb2JzZXJ2ZSB0aGUgZXF1 YWxpdHkgYmV0d2VlbiBjb21tdXRlZCB2ZXJzaW9ucyBvZiB0aGUgc2FtZSBvcGVyYXRpb24sIHNp bmNlIHdlIHdpbGwKKyAgICAgICAgZmlyc3QgY2Fub25pY2FsaXplIHRoZW0gaW50byB0aGUgc2Ft ZSBvcmRlci4KKworICAgICAgICAqIGIzL0IzUmVkdWNlU3RyZW5ndGguY3BwOgorCiAyMDE1LTEw LTI4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdl ZCwgZml4IHRoZSBidWlsZCBmb3IgY2FzZSBzZW5zaXRpdmUgZmlsZSBzeXN0ZW1zLgpJbmRleDog U291cmNlL0phdmFTY3JpcHRDb3JlL2IzL0IzUmVkdWNlU3RyZW5ndGguY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9CM1JlZHVjZVN0cmVuZ3RoLmNwcAkocmV2aXNp b24gMTkxNzA1KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL0IzUmVkdWNlU3RyZW5ndGgu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC03NiwxMCArNzYsNiBAQCBwcml2YXRlOgogICAgICAgICAK ICAgICAgICAgc3dpdGNoIChtX3ZhbHVlLT5vcGNvZGUoKSkgewogICAgICAgICBjYXNlIEFkZDoK LSAgICAgICAgICAgIC8vIFR1cm4gdGhpczogQWRkKGNvbnN0YW50LCB2YWx1ZSkKLSAgICAgICAg ICAgIC8vIEludG8gdGhpczogQWRkKHZhbHVlLCBjb25zdGFudCkKLSAgICAgICAgICAgIC8vCi0g ICAgICAgICAgICAvLyBGSVhNRTogSWYgYm90aCBub24tY29uc3RhbnQsIHdlIHNob3VsZCBzb3J0 IHRoZSBvcGVyYW5kcy4KICAgICAgICAgICAgIGhhbmRsZUNvbW11dGF0aXZpdHkoKTsKIAogICAg ICAgICAgICAgLy8gVHVybiB0aGlzOiBBZGQoQWRkKHZhbHVlLCBjb25zdGFudDEpLCBjb25zdGFu dDIpCkBAIC0xNzQsMTEgKzE3MCwzMSBAQCBwcml2YXRlOgogICAgICAgICB9CiAgICAgfQogCisg ICAgLy8gVHVybiB0aGlzOiBBZGQoY29uc3RhbnQsIHZhbHVlKQorICAgIC8vIEludG8gdGhpczog QWRkKHZhbHVlLCBjb25zdGFudCkKKyAgICAvLworICAgIC8vIEFsc286CisgICAgLy8gVHVybiB0 aGlzOiBBZGQodmFsdWUxLCB2YWx1ZTIpCisgICAgLy8gSW50byB0aGlzOiBBZGQodmFsdWUyLCB2 YWx1ZTEpCisgICAgLy8gSWYgd2UgZGVjaWRlIHRoYXQgdmFsdWUyIGNvbWluZyBmaXJzdCBpcyB0 aGUgY2Fub25pY2FsIG9yZGVyaW5nLgogICAgIHZvaWQgaGFuZGxlQ29tbXV0YXRpdml0eSgpCiAg ICAgewotICAgICAgICBpZiAobV92YWx1ZS0+Y2hpbGQoMCktPmlzQ29uc3RhbnQoKSAmJiAhbV92 YWx1ZS0+Y2hpbGQoMSktPmlzQ29uc3RhbnQoKSkgeworICAgICAgICAvLyBMZWF2ZSBpdCBhbG9u ZSBpZiB0aGUgcmlnaHQgY2hpbGQgaXMgYSBjb25zdGFudC4KKyAgICAgICAgaWYgKG1fdmFsdWUt PmNoaWxkKDEpLT5pc0NvbnN0YW50KCkpCisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIAor ICAgICAgICBpZiAobV92YWx1ZS0+Y2hpbGQoMCktPmlzQ29uc3RhbnQoKSkgewogICAgICAgICAg ICAgc3RkOjpzd2FwKG1fdmFsdWUtPmNoaWxkKDApLCBtX3ZhbHVlLT5jaGlsZCgxKSk7CiAgICAg ICAgICAgICBtX2NoYW5nZWQgPSB0cnVlOworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9 CisKKyAgICAgICAgLy8gU29ydCB0aGUgb3BlcmFuZHMuIFRoaXMgaXMgYW4gaW1wb3J0YW50IGNh bm9uaWNhbGl6YXRpb24uIFdlIHVzZSB0aGUgaW5kZXggaW5zdGVhZCBvZgorICAgICAgICAvLyB0 aGUgYWRkcmVzcyB0byBtYWtlIHRoaXMgYXQgbGVhc3Qgc2xpZ2h0bHkgZGV0ZXJtaW5pc3RpYy4K KyAgICAgICAgaWYgKG1fdmFsdWUtPmNoaWxkKDApLT5pbmRleCgpID4gbV92YWx1ZS0+Y2hpbGQo MSktPmluZGV4KCkpIHsKKyAgICAgICAgICAgIHN0ZDo6c3dhcChtX3ZhbHVlLT5jaGlsZCgwKSwg bV92YWx1ZS0+Y2hpbGQoMSkpOworICAgICAgICAgICAgbV9jaGFuZ2VkID0gdHJ1ZTsKKyAgICAg ICAgICAgIHJldHVybjsKICAgICAgICAgfQogICAgIH0KIAo=