150648 2015-10-28 17:22:41 -0700 bmalloc: AsyncTask should handle destruction 2015-10-29 11:45:56 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren ggaren oldest_to_newest 1137372 0 ggaren 2015-10-28 17:22:41 -0700 bmalloc: AsyncTask should handle destruction 1137374 1 264275 ggaren 2015-10-28 17:28:05 -0700 Created attachment 264275 Patch 1137536 2 264275 mark.lam 2015-10-29 09:17:18 -0700 Comment on attachment 264275 Patch r=me 1137591 3 ggaren 2015-10-29 11:45:56 -0700 Committed r191741: <http://trac.webkit.org/changeset/191741> 264275 2015-10-28 17:28:05 -0700 2015-10-29 09:17:18 -0700 Patch bug-150648-20151028172712.patch text/plain 6832 ggaren SW5kZXg6IFNvdXJjZS9ibWFsbG9jL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvYm1h bGxvYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MTcxMCkKKysrIFNvdXJjZS9ibWFsbG9jL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDQxIEBACisyMDE1LTEwLTI4ICBHZW9mZnJl eSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgYm1hbGxvYzogQXN5bmNUYXNr IHNob3VsZCBoYW5kbGUgZGVzdHJ1Y3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE1MDY0OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFNvIHdlIGNhbiB1c2UgaXQgaW4gbW9yZSBwbGFjZXMuCisKKyAg ICAgICAgKiBibWFsbG9jL0FzeW5jVGFzay5oOiBVc2Ugc3RkOjp0aHJlYWQgaW5zdGVhZCBvZiBw dGhyZWFkIGJlY2F1c2UgaXQKKyAgICAgICAgc2hvdWxkIGJlIG1vcmUgcG9ydGFibGUuCisKKyAg ICAgICAgKGJtYWxsb2M6OkZ1bmN0aW9uPjo6QXN5bmNUYXNrKTogUmVuYW1lZCBTaWduYWxlZCB0 byBSdW5SZXF1ZXN0ZWQgZm9yCisgICAgICAgIGNsYXJpdHkuIEFkZGVkIGFuIEV4aXRSZXF1ZXN0 ZWQgc3RhdGUuCisKKyAgICAgICAgKGJtYWxsb2M6OkZ1bmN0aW9uPjo6fkFzeW5jVGFzayk6IFdh aXQgZm9yIG91ciBjaGlsZCB0aHJlYWQgdG8gZXhpdAorICAgICAgICBiZWZvcmUgZGVzdHJveWlu ZyBvdXJzZWx2ZXMgYmVjYXVzZSBvdXIgY2hpbGQgdGhyZWFkIHdpbGwgbW9kaWZ5IG91cgorICAg ICAgICBkYXRhIChhbmQgbWlnaHQgbW9kaWZ5IG91ciBjbGllbnQncyBkYXRhKS4gTm90ZSB0aGF0 IHdlIG9ubHkgbmVlZCB0bworICAgICAgICB3YWl0IGZvciB0aGUgbGFzdCBjaGlsZCB0aHJlYWQg c2luY2UgYW55IHByaW9yIGNoaWxkIHRocmVhZCwgaGF2aW5nCisgICAgICAgIHJlYWNoZWQgdGhl IEV4aXRlZCBjb25kaXRpb24sIGlzIGd1YXJhbnRlZWQgbm90IHRvIHJlYWQgb3Igd3JpdGUgYW55 CisgICAgICAgIGRhdGEuCisKKyAgICAgICAgKGJtYWxsb2M6OkZ1bmN0aW9uPjo6cnVuKToKKyAg ICAgICAgKGJtYWxsb2M6OkZ1bmN0aW9uPjo6cnVuU2xvd0Nhc2UpOiBVcGRhdGVkIGZvciBpbnRl cmZhY2UgY2hhbmdlcy4gQWxzbworICAgICAgICBjaGFuZ2VkIHRvIHVzZSBvdXIgV2ViS2l0IHN0 eWxlIGZvciBjb25kaXRpb24gc2lnbmFsOiBIb2xkIHRoZSBsb2NrCisgICAgICAgIGR1cmluZyB0 aGUgc2lnbmFsIGFuZCBhbHdheXMgbm90aWZ5IGFsbC4gVGVjaG5pY2FsbHksIG5laXRoZXIgaXMg bmVjZXNzYXJ5LAorICAgICAgICBidXQgaXQgaXMgZWFzaWVyIHRvIHVuZGVyc3RhbmQgdGhlIGNv ZGUgdGhpcyB3YXksIGFuZCBoYXJkZXIgdG8gbWFrZQorICAgICAgICBtaXN0YWtlcy4KKworICAg ICAgICAoYm1hbGxvYzo6RnVuY3Rpb24+Ojp0aHJlYWRFbnRyeVBvaW50KToKKyAgICAgICAgKGJt YWxsb2M6OkZ1bmN0aW9uPjo6dGhyZWFkUnVuTG9vcCk6IEhhbmRsZSB0aGUgbmV3IEV4aXRSZXF1 ZXN0ZWQgc3RhdGUuCisgICAgICAgIFRlY2huaWNhbGx5LCB0aGlzIHN0YXRlIGhhcyBubyBtZWFu aW5nZnVsIGRpZmZlcmVuY2UgZnJvbSB0aGUgRXhpdGVkCisgICAgICAgIHN0YXRlLCBidXQgaXQg aXMgbmljZSB0byBiZSBleHBsaWNpdC4KKworICAgICAgICAoYm1hbGxvYzo6RnVuY3Rpb24+Ojpq b2luKTogRGVsZXRlZC4KKyAgICAgICAgKGJtYWxsb2M6OkZ1bmN0aW9uPjo6cHRocmVhZEVudHJ5 UG9pbnQpOiBEZWxldGVkLgorICAgICAgICAoYm1hbGxvYzo6RnVuY3Rpb24+OjplbnRyeVBvaW50 KTogRGVsZXRlZC4KKwogMjAxNS0xMC0xNSAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUu Y29tPgogCiAgICAgICAgIGJtYWxsb2M6IHBlci10aHJlYWQgY2FjaGUgZGF0YSBzdHJ1Y3R1cmUg c2hvdWxkIGJlIHNtYWxsZXIKSW5kZXg6IFNvdXJjZS9ibWFsbG9jL2JtYWxsb2MvQXN5bmNUYXNr LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL2JtYWxsb2MvYm1hbGxvYy9Bc3luY1Rhc2suaAkocmV2 aXNpb24gMTkxMjI5KQorKysgU291cmNlL2JtYWxsb2MvYm1hbGxvYy9Bc3luY1Rhc2suaAkod29y a2luZyBjb3B5KQpAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMTQgQXBw bGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDE0LCAyMDE1 IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBh bmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1v ZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29u ZGl0aW9ucwpAQCAtMzEsNyArMzEsNiBAQAogI2luY2x1ZGUgIk11dGV4LmgiCiAjaW5jbHVkZSA8 YXRvbWljPgogI2luY2x1ZGUgPGNvbmRpdGlvbl92YXJpYWJsZT4KLSNpbmNsdWRlIDxwdGhyZWFk Lmg+CiAjaW5jbHVkZSA8dGhyZWFkPgogCiBuYW1lc3BhY2UgYm1hbGxvYyB7CkBAIC00MCwyNSAr MzksMjYgQEAgdGVtcGxhdGU8dHlwZW5hbWUgT2JqZWN0LCB0eXBlbmFtZSBGdW5jdAogY2xhc3Mg QXN5bmNUYXNrIHsKIHB1YmxpYzoKICAgICBBc3luY1Rhc2soT2JqZWN0JiwgY29uc3QgRnVuY3Rp b24mKTsKKyAgICB+QXN5bmNUYXNrKCk7CiAKICAgICB2b2lkIHJ1bigpOwotICAgIHZvaWQgam9p bigpOwogCiBwcml2YXRlOgotICAgIGVudW0gU3RhdGUgeyBFeGl0ZWQsIFNsZWVwaW5nLCBSdW5u aW5nLCBTaWduYWxlZCB9OworICAgIGVudW0gU3RhdGUgeyBFeGl0ZWQsIEV4aXRSZXF1ZXN0ZWQs IFNsZWVwaW5nLCBSdW5uaW5nLCBSdW5SZXF1ZXN0ZWQgfTsKIAogICAgIHN0YXRpYyBjb25zdCBj b25zdGV4cHIgc3RkOjpjaHJvbm86OnNlY29uZHMgZXhpdERlbGF5ID0gc3RkOjpjaHJvbm86OnNl Y29uZHMoMSk7CiAKICAgICB2b2lkIHJ1blNsb3dDYXNlKCk7CiAKLSAgICBzdGF0aWMgdm9pZCog cHRocmVhZEVudHJ5UG9pbnQodm9pZCopOwotICAgIHZvaWQgZW50cnlQb2ludCgpOworICAgIHN0 YXRpYyB2b2lkIHRocmVhZEVudHJ5UG9pbnQoQXN5bmNUYXNrKik7CisgICAgdm9pZCB0aHJlYWRS dW5Mb29wKCk7CiAKICAgICBzdGQ6OmF0b21pYzxTdGF0ZT4gbV9zdGF0ZTsKIAogICAgIE11dGV4 IG1fY29uZGl0aW9uTXV0ZXg7CiAgICAgc3RkOjpjb25kaXRpb25fdmFyaWFibGVfYW55IG1fY29u ZGl0aW9uOwotICAgIHB0aHJlYWRfdCBtX3RocmVhZDsKKworICAgIHN0ZDo6dGhyZWFkIG1fdGhy ZWFkOwogCiAgICAgT2JqZWN0JiBtX29iamVjdDsKICAgICBGdW5jdGlvbiBtX2Z1bmN0aW9uOwpA QCAtNzcsMjIgKzc3LDI3IEBAIEFzeW5jVGFzazxPYmplY3QsIEZ1bmN0aW9uPjo6QXN5bmNUYXNr KE8KIH0KIAogdGVtcGxhdGU8dHlwZW5hbWUgT2JqZWN0LCB0eXBlbmFtZSBGdW5jdGlvbj4KLXZv aWQgQXN5bmNUYXNrPE9iamVjdCwgRnVuY3Rpb24+Ojpqb2luKCkKK0FzeW5jVGFzazxPYmplY3Qs IEZ1bmN0aW9uPjo6fkFzeW5jVGFzaygpCiB7Ci0gICAgaWYgKG1fc3RhdGUgPT0gRXhpdGVkKQot ICAgICAgICByZXR1cm47CisgICAgLy8gUHJldmVudCBvdXIgdGhyZWFkIGZyb20gZW50ZXJpbmcg dGhlIHJ1bm5pbmcgb3Igc2xlZXBpbmcgc3RhdGUuCisgICAgU3RhdGUgb2xkU3RhdGUgPSBtX3N0 YXRlLmV4Y2hhbmdlKEV4aXRSZXF1ZXN0ZWQpOwogCi0gICAgeyBzdGQ6OmxvY2tfZ3VhcmQ8TXV0 ZXg+IGxvY2sobV9jb25kaXRpb25NdXRleCk7IH0KLSAgICBtX2NvbmRpdGlvbi5ub3RpZnlfb25l KCk7CisgICAgLy8gV2FrZSBvdXIgdGhyZWFkIGlmIGl0IHdhcyBhbHJlYWR5IGluIHRoZSBzbGVl cGluZyBzdGF0ZS4KKyAgICBpZiAob2xkU3RhdGUgPT0gU2xlZXBpbmcpIHsKKyAgICAgICAgc3Rk Ojpsb2NrX2d1YXJkPE11dGV4PiBsb2NrKG1fY29uZGl0aW9uTXV0ZXgpOworICAgICAgICBtX2Nv bmRpdGlvbi5ub3RpZnlfYWxsKCk7CisgICAgfQogCi0gICAgd2hpbGUgKG1fc3RhdGUgIT0gRXhp dGVkKQotICAgICAgICBzdGQ6OnRoaXNfdGhyZWFkOjp5aWVsZCgpOworICAgIC8vIFdhaXQgZm9y IG91ciB0aHJlYWQgdG8gZXhpdCBiZWNhdXNlIGl0IHVzZXMgb3VyIGRhdGEgbWVtYmVycyAoYW5k IGl0IG1heQorICAgIC8vIHVzZSBtX29iamVjdCdzIGRhdGEgbWVtYmVycykuCisgICAgaWYgKG1f dGhyZWFkLmpvaW5hYmxlKCkpCisgICAgICAgIG1fdGhyZWFkLmpvaW4oKTsKIH0KIAogdGVtcGxh dGU8dHlwZW5hbWUgT2JqZWN0LCB0eXBlbmFtZSBGdW5jdGlvbj4KIGlubGluZSB2b2lkIEFzeW5j VGFzazxPYmplY3QsIEZ1bmN0aW9uPjo6cnVuKCkKIHsKLSAgICBpZiAobV9zdGF0ZSA9PSBTaWdu YWxlZCkKKyAgICBpZiAobV9zdGF0ZSA9PSBSdW5SZXF1ZXN0ZWQpCiAgICAgICAgIHJldHVybjsK ICAgICBydW5TbG93Q2FzZSgpOwogfQpAQCAtMTAwLDMzICsxMDUsNDAgQEAgaW5saW5lIHZvaWQg QXN5bmNUYXNrPE9iamVjdCwgRnVuY3Rpb24+OgogdGVtcGxhdGU8dHlwZW5hbWUgT2JqZWN0LCB0 eXBlbmFtZSBGdW5jdGlvbj4KIE5PX0lOTElORSB2b2lkIEFzeW5jVGFzazxPYmplY3QsIEZ1bmN0 aW9uPjo6cnVuU2xvd0Nhc2UoKQogewotICAgIFN0YXRlIG9sZFN0YXRlID0gbV9zdGF0ZS5leGNo YW5nZShTaWduYWxlZCk7Ci0gICAgaWYgKG9sZFN0YXRlID09IFNpZ25hbGVkIHx8IG9sZFN0YXRl ID09IFJ1bm5pbmcpCisgICAgU3RhdGUgb2xkU3RhdGUgPSBtX3N0YXRlLmV4Y2hhbmdlKFJ1blJl cXVlc3RlZCk7CisgICAgaWYgKG9sZFN0YXRlID09IFJ1blJlcXVlc3RlZCB8fCBvbGRTdGF0ZSA9 PSBSdW5uaW5nKQogICAgICAgICByZXR1cm47CiAKICAgICBpZiAob2xkU3RhdGUgPT0gU2xlZXBp bmcpIHsKLSAgICAgICAgeyBzdGQ6OmxvY2tfZ3VhcmQ8TXV0ZXg+IGxvY2sobV9jb25kaXRpb25N dXRleCk7IH0KLSAgICAgICAgbV9jb25kaXRpb24ubm90aWZ5X29uZSgpOworICAgICAgICBzdGQ6 OmxvY2tfZ3VhcmQ8TXV0ZXg+IGxvY2sobV9jb25kaXRpb25NdXRleCk7CisgICAgICAgIG1fY29u ZGl0aW9uLm5vdGlmeV9hbGwoKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAogICAgIEJBU1NF UlQob2xkU3RhdGUgPT0gRXhpdGVkKTsKLSAgICBwdGhyZWFkX2NyZWF0ZSgmbV90aHJlYWQsIG51 bGxwdHIsICZwdGhyZWFkRW50cnlQb2ludCwgdGhpcyk7Ci0gICAgcHRocmVhZF9kZXRhY2gobV90 aHJlYWQpOworICAgIGlmIChtX3RocmVhZC5qb2luYWJsZSgpKQorICAgICAgICBtX3RocmVhZC5k ZXRhY2goKTsKKyAgICBtX3RocmVhZCA9IHN0ZDo6dGhyZWFkKCZBc3luY1Rhc2s6OnRocmVhZEVu dHJ5UG9pbnQsIHRoaXMpOwogfQogCiB0ZW1wbGF0ZTx0eXBlbmFtZSBPYmplY3QsIHR5cGVuYW1l IEZ1bmN0aW9uPgotdm9pZCogQXN5bmNUYXNrPE9iamVjdCwgRnVuY3Rpb24+OjpwdGhyZWFkRW50 cnlQb2ludCh2b2lkKiBhc3luY1Rhc2spCit2b2lkIEFzeW5jVGFzazxPYmplY3QsIEZ1bmN0aW9u Pjo6dGhyZWFkRW50cnlQb2ludChBc3luY1Rhc2sqIGFzeW5jVGFzaykKIHsKLSAgICBzdGF0aWNf Y2FzdDxBc3luY1Rhc2sqPihhc3luY1Rhc2spLT5lbnRyeVBvaW50KCk7Ci0gICAgcmV0dXJuIG51 bGxwdHI7CisgICAgYXN5bmNUYXNrLT50aHJlYWRSdW5Mb29wKCk7CiB9CiAKIHRlbXBsYXRlPHR5 cGVuYW1lIE9iamVjdCwgdHlwZW5hbWUgRnVuY3Rpb24+Ci12b2lkIEFzeW5jVGFzazxPYmplY3Qs IEZ1bmN0aW9uPjo6ZW50cnlQb2ludCgpCit2b2lkIEFzeW5jVGFzazxPYmplY3QsIEZ1bmN0aW9u Pjo6dGhyZWFkUnVuTG9vcCgpCiB7CisgICAgLy8gVGhpcyBsb29wIHJhdGNoZXRzIGRvd253YXJk IGZyb20gbW9zdCBhY3RpdmUgdG8gbGVhc3QgYWN0aXZlIHN0YXRlLCBhbmQKKyAgICAvLyBmaW5h bGx5IGV4aXRzLiBXaGlsZSB3ZSByYXRjaGV0IGRvd253YXJkLCBhbnkgb3RoZXIgdGhyZWFkIG1h eSByZXNldCBvdXIKKyAgICAvLyBzdGF0ZSB0byBSdW5SZXF1ZXN0ZWQgb3IgRXhpdFJlcXVlc3Rl ZC4KKyAgICAKKyAgICAvLyBXZSByZXF1aXJlIGFueSBzdGF0ZSBjaGFuZ2Ugd2hpbGUgd2UgYXJl IHNsZWVwaW5nIHRvIHNpZ25hbCB0byBvdXIKKyAgICAvLyBjb25kaXRpb24gdmFyaWFibGUgYW5k IHdha2UgdXMgdXAuCisKICAgICB3aGlsZSAoMSkgewotICAgICAgICBTdGF0ZSBleHBlY3RlZFN0 YXRlID0gU2lnbmFsZWQ7CisgICAgICAgIFN0YXRlIGV4cGVjdGVkU3RhdGUgPSBSdW5SZXF1ZXN0 ZWQ7CiAgICAgICAgIGlmIChtX3N0YXRlLmNvbXBhcmVfZXhjaGFuZ2Vfd2VhayhleHBlY3RlZFN0 YXRlLCBSdW5uaW5nKSkKICAgICAgICAgICAgIChtX29iamVjdC4qbV9mdW5jdGlvbikoKTsKIApA QCAtMTM5LDYgKzE1MSwxMCBAQCB2b2lkIEFzeW5jVGFzazxPYmplY3QsIEZ1bmN0aW9uPjo6ZW50 cnlQCiAgICAgICAgIGV4cGVjdGVkU3RhdGUgPSBTbGVlcGluZzsKICAgICAgICAgaWYgKG1fc3Rh dGUuY29tcGFyZV9leGNoYW5nZV93ZWFrKGV4cGVjdGVkU3RhdGUsIEV4aXRlZCkpCiAgICAgICAg ICAgICByZXR1cm47CisgICAgICAgIAorICAgICAgICBleHBlY3RlZFN0YXRlID0gRXhpdFJlcXVl c3RlZDsKKyAgICAgICAgaWYgKG1fc3RhdGUuY29tcGFyZV9leGNoYW5nZV93ZWFrKGV4cGVjdGVk U3RhdGUsIEV4aXRlZCkpCisgICAgICAgICAgICByZXR1cm47CiAgICAgfQogfQogCg==