150644 2015-10-28 16:46:58 -0700 [Content Filtering] Crash when allowing a 0-byte resource to load 2015-10-28 17:02:20 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aestes aestes ap beidson commit-queue darin ddkilzer japhet kling oldest_to_newest 1137354 0 aestes 2015-10-28 16:46:58 -0700 [Content Filtering] Crash when allowing a 0-byte resource to load 1137355 1 aestes 2015-10-28 16:47:53 -0700 rdar://problem/23288538 1137356 2 264267 aestes 2015-10-28 16:50:54 -0700 Created attachment 264267 Patch 1137360 3 264267 darin 2015-10-28 16:56:41 -0700 Comment on attachment 264267 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264267&action=review > Source/WebCore/loader/ContentFilter.cpp:262 > + if (const SharedBuffer* resourceBuffer = resource.resourceBuffer()) I’d use auto* here instead of const SharedBuffer*. 1137362 4 aestes 2015-10-28 17:02:20 -0700 Committed r191706: <http://trac.webkit.org/changeset/191706> 264267 2015-10-28 16:50:54 -0700 2015-10-28 16:56:41 -0700 Patch bug-150644-20151028165003.patch text/plain 3843 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxNjU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGRhNmYxYmIzMmI0Yzhj YWIwY2U4YzhhMjdkZmI1MmEyOGNhMTlhZS4uMDU2YjMwYzk3NDRiMjJkZDZmMWU4YzI5MmRmNzgz NjgwMjNmNDI5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTEwLTI4ICBBbmR5 IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbQ29udGVudCBGaWx0ZXJpbmdd IENyYXNoIHdoZW4gYWxsb3dpbmcgYSAwLWJ5dGUgcmVzb3VyY2UgdG8gbG9hZAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwNjQ0CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8yMzI4ODUzOD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUZXN0OiBjb250ZW50ZmlsdGVyaW5nL2FsbG93LWVtcHR5LWRvY3Vt ZW50Lmh0bWwKKworICAgICAgICAqIGxvYWRlci9Db250ZW50RmlsdGVyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkNvbnRlbnRGaWx0ZXI6OmRlbGl2ZXJSZXNvdXJjZURhdGEpOiByZXNvdXJjZUJ1 ZmZlciB3aWxsIGJlIG51bGwgaWYgdGhlIHJlc291cmNlIGNvbnRhaW5lZCBubyBkYXRhLgorCiAy MDE1LTEwLTI3ICBIdW5zZW9wIEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KIAogICAg ICAgICBbQ2Fpcm9dIEluY29ycmVjdCBkYXNoZWQgYW5kIGRvdHRlZCBib3JkZXIgcGFpbnRpbmcg YWZ0ZXIgcjE3NzY4Ni4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Db250ZW50 RmlsdGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Db250ZW50RmlsdGVyLmNwcAppbmRl eCAyNWQ3MGVlMjlkMmFmMzdiMGUzNmUyZjAyOTBmOTc4YmJlYTY0MjE0Li41ZWVlMTBkMDk5ZjYz M2EyY2ZmYTc3NDhhM2ZhOGJkM2ZmZjJkYmY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9s b2FkZXIvQ29udGVudEZpbHRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0NvbnRl bnRGaWx0ZXIuY3BwCkBAIC0yNTksOCArMjU5LDggQEAgdm9pZCBDb250ZW50RmlsdGVyOjpkaWRE ZWNpZGUoU3RhdGUgc3RhdGUpCiB2b2lkIENvbnRlbnRGaWx0ZXI6OmRlbGl2ZXJSZXNvdXJjZURh dGEoQ2FjaGVkUmVzb3VyY2UmIHJlc291cmNlKQogewogICAgIEFTU0VSVChyZXNvdXJjZS5kYXRh QnVmZmVyaW5nUG9saWN5KCkgPT0gQnVmZmVyRGF0YSk7Ci0gICAgY29uc3QgU2hhcmVkQnVmZmVy JiByZXNvdXJjZUJ1ZmZlciA9ICpyZXNvdXJjZS5yZXNvdXJjZUJ1ZmZlcigpOwotICAgIG1fZG9j dW1lbnRMb2FkZXIuZGF0YVJlY2VpdmVkKCZyZXNvdXJjZSwgcmVzb3VyY2VCdWZmZXIuZGF0YSgp LCByZXNvdXJjZUJ1ZmZlci5zaXplKCkpOworICAgIGlmIChjb25zdCBTaGFyZWRCdWZmZXIqIHJl c291cmNlQnVmZmVyID0gcmVzb3VyY2UucmVzb3VyY2VCdWZmZXIoKSkKKyAgICAgICAgbV9kb2N1 bWVudExvYWRlci5kYXRhUmVjZWl2ZWQoJnJlc291cmNlLCByZXNvdXJjZUJ1ZmZlci0+ZGF0YSgp LCByZXNvdXJjZUJ1ZmZlci0+c2l6ZSgpKTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CmluZGV4IDhiMmYxMWYwYWJkNzRjYWE4NzIzMzBlNjAwYmNjNjJjMzJjYTgyNDMuLjhkZjI3Yzg0 MTJmZjlmNTYxYzEzNjk5NWU5ZDRjNzdhNzc1NGIyYzcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAor MjAxNS0xMC0yOCAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CisKKyAgICAgICAgW0Nv bnRlbnQgRmlsdGVyaW5nXSBDcmFzaCB3aGVuIGFsbG93aW5nIGEgMC1ieXRlIHJlc291cmNlIHRv IGxvYWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1 MDY0NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjMyODg1Mzg+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBjb250ZW50ZmlsdGVyaW5nL2FsbG93 LWVtcHR5LWRvY3VtZW50LWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGNvbnRlbnRm aWx0ZXJpbmcvYWxsb3ctZW1wdHktZG9jdW1lbnQuaHRtbDogQWRkZWQuCisgICAgICAgICogY29u dGVudGZpbHRlcmluZy9yZXNvdXJjZXMvZW1wdHkuaHRtbDogQWRkZWQuCisKIDIwMTUtMTAtMjcg IEh1bnNlb3AgSmVvbmcgIDxoczg1Lmplb25nQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtDYWly b10gSW5jb3JyZWN0IGRhc2hlZCBhbmQgZG90dGVkIGJvcmRlciBwYWludGluZyBhZnRlciByMTc3 Njg2LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvY29udGVudGZpbHRlcmluZy9hbGxvdy1lbXB0 eS1kb2N1bWVudC1leHBlY3RlZC5odG1sIGIvTGF5b3V0VGVzdHMvY29udGVudGZpbHRlcmluZy9h bGxvdy1lbXB0eS1kb2N1bWVudC1leHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjBhNmZmMzgxOThh NGU2MjkyYTUzZDZjMWU5ZWVhYWE1ZGIwY2M5NTQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9jb250ZW50ZmlsdGVyaW5nL2FsbG93LWVtcHR5LWRvY3VtZW50LWV4cGVjdGVkLmh0bWwK QEAgLTAsMCArMSwyIEBACis8IURPQ1RZUEUgaHRtbD4KKzxpZnJhbWUgc3JjPSJyZXNvdXJjZXMv ZW1wdHkuaHRtbCI+PC9pZnJhbWU+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9jb250ZW50Zmls dGVyaW5nL2FsbG93LWVtcHR5LWRvY3VtZW50Lmh0bWwgYi9MYXlvdXRUZXN0cy9jb250ZW50Zmls dGVyaW5nL2FsbG93LWVtcHR5LWRvY3VtZW50Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNGYxYzA1MDcyNGE0 ZjUyM2VmNWIwYjg0MTU1NGI1ZjYwYmQ0NDIxZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRl c3RzL2NvbnRlbnRmaWx0ZXJpbmcvYWxsb3ctZW1wdHktZG9jdW1lbnQuaHRtbApAQCAtMCwwICsx LDEwIEBACis8IURPQ1RZUEUgaHRtbD4KKzxzY3JpcHQ+CisgICAgaWYgKHdpbmRvdy5pbnRlcm5h bHMpIHsKKyAgICAgICAgdmFyIHNldHRpbmdzID0gd2luZG93LmludGVybmFscy5tb2NrQ29udGVu dEZpbHRlclNldHRpbmdzOworICAgICAgICBzZXR0aW5ncy5lbmFibGVkID0gdHJ1ZTsKKyAgICAg ICAgc2V0dGluZ3MuZGVjaXNpb25Qb2ludCA9IHNldHRpbmdzLkRFQ0lTSU9OX1BPSU5UX0FGVEVS X0ZJTklTSEVEX0FERElOR19EQVRBOworICAgICAgICBzZXR0aW5ncy5kZWNpc2lvbiA9IHNldHRp bmdzLkRFQ0lTSU9OX0FMTE9XOworICAgIH0KKzwvc2NyaXB0PgorPGlmcmFtZSBzcmM9InJlc291 cmNlcy9lbXB0eS5odG1sIj48L2lmcmFtZT4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2NvbnRl bnRmaWx0ZXJpbmcvcmVzb3VyY2VzL2VtcHR5Lmh0bWwgYi9MYXlvdXRUZXN0cy9jb250ZW50Zmls dGVyaW5nL3Jlc291cmNlcy9lbXB0eS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmU2OWRlMjliYjJkMWQ2NDM0 YjhiMjlhZTc3NWFkOGMyZTQ4YzUzOTEK