150641 2015-10-28 15:48:47 -0700 Rename MacroAssembler::callProbe() to probe(). 2015-10-28 16:02:09 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam commit-queue oldest_to_newest 1137320 0 mark.lam 2015-10-28 15:48:47 -0700 Because probe() is easier to use than callProbe() (and cooler too). 1137327 1 264258 mark.lam 2015-10-28 15:55:16 -0700 Created attachment 264258 the patch. 1137331 2 commit-queue 2015-10-28 15:56:35 -0700 Attachment 264258 did not pass style-queue: ERROR: Source/JavaScriptCore/assembler/MacroAssembler.cpp:42: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/JavaScriptCore/assembler/MacroAssembler.h:1595: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style. 1137332 3 264258 saam 2015-10-28 15:56:49 -0700 Comment on attachment 264258 the patch. r=me 1137333 4 264258 mark.lam 2015-10-28 15:57:21 -0700 Comment on attachment 264258 the patch. Thanks for the review. Will land manually. 1137339 5 mark.lam 2015-10-28 16:02:09 -0700 Landed in r191700: <http://trac.webkit.org/r191700>. 264258 2015-10-28 15:55:16 -0700 2015-10-28 15:57:21 -0700 the patch. bug-150641.patch text/plain 6283 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTkxNjk2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMyIEBA CisyMDE1LTEwLTI4ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBS ZW5hbWUgTWFjcm9Bc3NlbWJsZXI6OmNhbGxQcm9iZSgpIHRvIHByb2JlKCkuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTA2NDEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUbyBkbyB0aGlzLCBJIG5lZWRl ZCB0byBkaXNhbWJpZ3VhdGUgYmV0d2VlbiB0aGUgbG93LWxldmVsIHByb2JlKCkgZnJvbSB0aGUK KyAgICAgICAgaGlnaC1sZXZlbCB2ZXJzaW9uIHRoYXQgdGFrZXMgYSBzdGQ6OmZ1bmN0aW9uLiAg SSBkaWQgdGhpcyBieSBjaGFuZ2luZyB0aGUgbG93LQorICAgICAgICBsZXZlbCB2ZXJzaW9uIHRv IG5vdCB0YWtlIGRlZmF1bHQgYXJncyBhbnltb3JlLgorCisgICAgICAgICogYXNzZW1ibGVyL0Fi c3RyYWN0TWFjcm9Bc3NlbWJsZXIuaDoKKyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJs ZXIuY3BwOgorICAgICAgICAoSlNDOjpzdGRGdW5jdGlvbkNhbGxiYWNrKToKKyAgICAgICAgKEpT Qzo6TWFjcm9Bc3NlbWJsZXI6OnByb2JlKToKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXI6 OmNhbGxQcm9iZSk6IERlbGV0ZWQuCisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVy Lmg6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyOjp1cnNoaWZ0MzIpOgorICAgICAgICAq IGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5oOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2Vt YmxlckFSTTo6cmVwYXRjaENhbGwpOgorICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxl ckFSTTY0Lmg6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJNNjQ6OnJlcGF0Y2hDYWxs KToKKyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk12Ny5oOgorICAgICAgICAo SlNDOjpNYWNyb0Fzc2VtYmxlckFSTXY3OjpyZXBhdGNoQ2FsbCk6CisgICAgICAgICogYXNzZW1i bGVyL01hY3JvQXNzZW1ibGVyUHJpbnRlci5oOgorICAgICAgICAoSlNDOjpNYWNyb0Fzc2VtYmxl clByaW50ZXI6OnByaW50KToKKyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJYODZD b21tb24uaDoKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJYODZDb21tb246Om1heEp1bXBS ZXBsYWNlbWVudFNpemUpOgorCiAyMDE1LTEwLTI4ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5 QGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBqc21pbi5weSBtaXN0YWtlbmx5 IHJlbW92ZXMgd2hpdGVzcGFjZSBmcm9tIHRlbXBsYXRlIGxpdGVyYWwgc3RyaW5ncwpJbmRleDog U291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BYnN0cmFjdE1hY3JvQXNzZW1ibGVyLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BYnN0cmFjdE1h Y3JvQXNzZW1ibGVyLmgJKHJldmlzaW9uIDE5MTY5NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvQWJzdHJhY3RNYWNyb0Fzc2VtYmxlci5oCSh3b3JraW5nIGNvcHkpCkBAIC05 NDAsNyArOTQwLDcgQEAgcHVibGljOgogICAgIC8vIE5vdGU6IHByb2JlKCkgc2hvdWxkIGJlIGlt cGxlbWVudGVkIGJ5IHRoZSB0YXJnZXQgc3BlY2lmaWMgTWFjcm9Bc3NlbWJsZXIuCiAgICAgLy8g VGhpcyBwcm90b3R5cGUgaXMgb25seSBwcm92aWRlZCBoZXJlIHRvIGRvY3VtZW50IHRoZSBpbnRl cmZhY2UuCiAKLSAgICB2b2lkIHByb2JlKFByb2JlRnVuY3Rpb24sIHZvaWQqIGFyZzEgPSAwLCB2 b2lkKiBhcmcyID0gMCk7CisgICAgdm9pZCBwcm9iZShQcm9iZUZ1bmN0aW9uLCB2b2lkKiBhcmcx LCB2b2lkKiBhcmcyKTsKIAogI2VuZGlmIC8vIEVOQUJMRShNQVNNX1BST0JFKQogCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyLmNw cAkocmV2aXNpb24gMTkxNjk2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9N YWNyb0Fzc2VtYmxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM5LDkgKzM5LDkgQEAgc3RhdGlj IHZvaWQgc3RkRnVuY3Rpb25DYWxsYmFjayhNYWNyb0FzcwogICAgICgqZnVuYykoY29udGV4dCk7 CiB9CiAgICAgCi12b2lkIE1hY3JvQXNzZW1ibGVyOjpjYWxsUHJvYmUoc3RkOjpmdW5jdGlvbjx2 b2lkIChNYWNyb0Fzc2VtYmxlcjo6UHJvYmVDb250ZXh0Kik+IGZ1bmMpCit2b2lkIE1hY3JvQXNz ZW1ibGVyOjpwcm9iZShzdGQ6OmZ1bmN0aW9uPHZvaWQgKE1hY3JvQXNzZW1ibGVyOjpQcm9iZUNv bnRleHQqKT4gZnVuYykKIHsKLSAgICBwcm9iZShzdGRGdW5jdGlvbkNhbGxiYWNrLCBuZXcgc3Rk OjpmdW5jdGlvbjx2b2lkIChNYWNyb0Fzc2VtYmxlcjo6UHJvYmVDb250ZXh0Kik+KGZ1bmMpKTsK KyAgICBwcm9iZShzdGRGdW5jdGlvbkNhbGxiYWNrLCBuZXcgc3RkOjpmdW5jdGlvbjx2b2lkIChN YWNyb0Fzc2VtYmxlcjo6UHJvYmVDb250ZXh0Kik+KGZ1bmMpLCAwKTsKIH0KICNlbmRpZiAvLyBF TkFCTEUoTUFTTV9QUk9CRSkKIApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxl ci9NYWNyb0Fzc2VtYmxlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9h c3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXIuaAkocmV2aXNpb24gMTkxNjk2KQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlci5oCSh3b3JraW5nIGNvcHkpCkBA IC0xNTg1LDEyICsxNTg1LDE0IEBAIHB1YmxpYzoKICAgICB9CiAKICNpZiBFTkFCTEUoTUFTTV9Q Uk9CRSkKKyAgICB1c2luZyBNYWNyb0Fzc2VtYmxlckJhc2U6OnByb2JlOworCiAgICAgLy8gTGV0 J3MgeW91IHByaW50IGZyb20geW91ciBKSVQgZ2VuZXJhdGVkIGNvZGUuCiAgICAgLy8gU2VlIGNv bW1lbnRzIGluIE1hY3JvQXNzZW1ibGVyUHJpbnRlci5oIGZvciBleGFtcGxlcyBvZiBob3cgdG8g dXNlIHRoaXMuCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUuLi4gQXJndW1lbnRzPgogICAgIHZvaWQg cHJpbnQoQXJndW1lbnRzLi4uIGFyZ3MpOwogCi0gICAgdm9pZCBjYWxsUHJvYmUoc3RkOjpmdW5j dGlvbjx2b2lkIChQcm9iZUNvbnRleHQqKT4pOworICAgIHZvaWQgcHJvYmUoc3RkOjpmdW5jdGlv bjx2b2lkIChQcm9iZUNvbnRleHQqKT4pOwogI2VuZGlmCiB9OwogCkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNNjQuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNNjQuaAko cmV2aXNpb24gMTkxNjk2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNy b0Fzc2VtYmxlckFSTTY0LmgJKHdvcmtpbmcgY29weSkKQEAgLTI1MzMsNyArMjUzMyw3IEBAIHB1 YmxpYzoKICAgICB9CiAKICNpZiBFTkFCTEUoTUFTTV9QUk9CRSkKLSAgICB2b2lkIHByb2JlKFBy b2JlRnVuY3Rpb24sIHZvaWQqIGFyZzEgPSAwLCB2b2lkKiBhcmcyID0gMCk7CisgICAgdm9pZCBw cm9iZShQcm9iZUZ1bmN0aW9uLCB2b2lkKiBhcmcxLCB2b2lkKiBhcmcyKTsKICNlbmRpZiAvLyBF TkFCTEUoTUFTTV9QUk9CRSkKIAogcHJvdGVjdGVkOgpJbmRleDogU291cmNlL0phdmFTY3JpcHRD b3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaAkocmV2aXNpb24gMTkx Njk2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFS TS5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNDQ4LDcgKzE0NDgsNyBAQCBwdWJsaWM6CiAgICAgfQog CiAjaWYgRU5BQkxFKE1BU01fUFJPQkUpCi0gICAgdm9pZCBwcm9iZShQcm9iZUZ1bmN0aW9uLCB2 b2lkKiBhcmcxID0gMCwgdm9pZCogYXJnMiA9IDApOworICAgIHZvaWQgcHJvYmUoUHJvYmVGdW5j dGlvbiwgdm9pZCogYXJnMSwgdm9pZCogYXJnMik7CiAjZW5kaWYgLy8gRU5BQkxFKE1BU01fUFJP QkUpCiAKIHByb3RlY3RlZDoKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIv TWFjcm9Bc3NlbWJsZXJBUk12Ny5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk12Ny5oCShyZXZpc2lvbiAxOTE2OTYpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNdjcuaAkod29y a2luZyBjb3B5KQpAQCAtMTkxOCw3ICsxOTE4LDcgQEAgcHVibGljOgogICAgIH0KIAogI2lmIEVO QUJMRShNQVNNX1BST0JFKQotICAgIHZvaWQgcHJvYmUoUHJvYmVGdW5jdGlvbiwgdm9pZCogYXJn MSA9IDAsIHZvaWQqIGFyZzIgPSAwKTsKKyAgICB2b2lkIHByb2JlKFByb2JlRnVuY3Rpb24sIHZv aWQqIGFyZzEsIHZvaWQqIGFyZzIpOwogI2VuZGlmIC8vIEVOQUJMRShNQVNNX1BST0JFKQogCiBw cm90ZWN0ZWQ6CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNz ZW1ibGVyUHJpbnRlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3Nl bWJsZXIvTWFjcm9Bc3NlbWJsZXJQcmludGVyLmgJKHJldmlzaW9uIDE5MTY5NikKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJQcmludGVyLmgJKHdvcmtp bmcgY29weSkKQEAgLTE2OSw3ICsxNjksNyBAQCBwdWJsaWM6CiAgICAgewogICAgICAgICBhdXRv IGFyZ3NMaXN0ID0gc3RkOjptYWtlX3VuaXF1ZTxQcmludEFyZ3NMaXN0PigpOwogICAgICAgICBh cHBlbmRQcmludEFyZyhhcmdzTGlzdC5nZXQoKSwgYXJncy4uLik7Ci0gICAgICAgIG1hc20tPnBy b2JlKHByaW50Q2FsbGJhY2ssIGFyZ3NMaXN0LnJlbGVhc2UoKSk7CisgICAgICAgIG1hc20tPnBy b2JlKHByaW50Q2FsbGJhY2ssIGFyZ3NMaXN0LnJlbGVhc2UoKSwgMCk7CiAgICAgfQogICAgIAog cHJpdmF0ZToKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3Nl bWJsZXJYODZDb21tb24uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNz ZW1ibGVyL01hY3JvQXNzZW1ibGVyWDg2Q29tbW9uLmgJKHJldmlzaW9uIDE5MTY5NikKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJYODZDb21tb24uaAko d29ya2luZyBjb3B5KQpAQCAtMTQ5Niw3ICsxNDk2LDcgQEAgcHVibGljOgogICAgIH0KIAogI2lm IEVOQUJMRShNQVNNX1BST0JFKQotICAgIHZvaWQgcHJvYmUoUHJvYmVGdW5jdGlvbiwgdm9pZCog YXJnMSA9IDAsIHZvaWQqIGFyZzIgPSAwKTsKKyAgICB2b2lkIHByb2JlKFByb2JlRnVuY3Rpb24s IHZvaWQqIGFyZzEsIHZvaWQqIGFyZzIpOwogI2VuZGlmIC8vIEVOQUJMRShNQVNNX1BST0JFKQog CiBwcm90ZWN0ZWQ6Cg==