150637 2015-10-28 14:37:24 -0700 Web Inspector: Zoom never goes back to 100% size 2015-10-28 15:51:38 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1137296 0 timothy 2015-10-28 14:37:24 -0700 If you use Command-Plus or Command-Minus you can never get back to 100% scale unless you close and reopen the Inspector. This happens because we scale by multiplying the current zoom by a percentage. That is not undoable by doing the reverse. Instead we should add or subtract from the current zoom level. 1137297 1 webkit-bug-importer 2015-10-28 14:37:42 -0700 <rdar://problem/23303488> 1137303 2 264252 timothy 2015-10-28 14:55:24 -0700 Created attachment 264252 Patch 1137308 3 264252 joepeck 2015-10-28 15:05:46 -0700 Comment on attachment 264252 Patch r=me 1137323 4 264252 commit-queue 2015-10-28 15:51:34 -0700 Comment on attachment 264252 Patch Clearing flags on attachment: 264252 Committed r191697: <http://trac.webkit.org/changeset/191697> 1137324 5 commit-queue 2015-10-28 15:51:38 -0700 All reviewed patches have been landed. Closing bug. 264252 2015-10-28 14:55:24 -0700 2015-10-28 15:51:34 -0700 Patch bug-150637-20151028145433.patch text/plain 1887 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxNjk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA2 YzYyZWRkN2MyMGM3YjM1NjVkYjkyNzAxNjRiNjRlODNiMjE4ODEyLi45YzBjMGQxODEwM2E2MzBj OTU0M2E0YzQzN2VkMjlkMWY4ZDg2YTNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNS0xMC0yOCAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogWm9vbSBuZXZlciBnb2VzIGJhY2sgdG8gMTAw JSBzaXplCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NTA2MzcKKworICAgICAgICBBZGQgYW5kIHN1YnRyYWN0IDIwJSBmcm9tIHRoZSB6b29tIGxldmVs IHNvIHRoZSB6b29tIGZhY3RvciBjYW4gcmV0dXJuCisgICAgICAgIHRvIHRoZSAxIHN0YXJ0aW5n IHpvb20gZmFjdG9yIGlmIHlvdSBnbyBiYWNrIHRoZSBvdGhlciBkaXJlY3Rpb24uCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNl L0Jhc2UvTWFpbi5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5faW5jcmVhc2Vab29tKTogQWRk IDAuMiBpbnN0ZWFkIG9mIG11bHRpcGx5aW5nIDEuMi4KKyAgICAgICAgKFdlYkluc3BlY3Rvci5f ZGVjcmVhc2Vab29tKTogU3VidHJhY3QgMC4yIGluc3RlYWQgb2YgbXVsdGlwbHlpbmcgMC44Lgor CiAyMDE1LTEwLTI3ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KIAogICAg ICAgICBXZWIgSW5zcGVjdG9yOiBSZW1vdmUgaW1hZ2UgZ2VuZXJhdG9ycyBhbmQgdXNlIFNWRyBk aXJlY3RseQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv QmFzZS9NYWluLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9N YWluLmpzCmluZGV4IDFjNWIxNWUzMTVmZmQ4Y2QzYzFlMGRkOTNiOWY3ZTQyNmU1YjE4ODcuLjI5 OTdkMGJlNGVjZmQ3OGFhMmJkNmE3ZDdhYzNhMWU0Yjc4NDkzYjYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcworKysgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKQEAgLTE4MTgsMTMgKzE4 MTgsMTMgQEAgV2ViSW5zcGVjdG9yLl9jb3B5ID0gZnVuY3Rpb24oZXZlbnQpCiAKIFdlYkluc3Bl Y3Rvci5faW5jcmVhc2Vab29tID0gZnVuY3Rpb24oZXZlbnQpIHsKICAgICBsZXQgY3VycmVudFpv b20gPSBJbnNwZWN0b3JGcm9udGVuZEhvc3Quem9vbUZhY3RvcigpOwotICAgIEluc3BlY3RvckZy b250ZW5kSG9zdC5zZXRab29tRmFjdG9yKGN1cnJlbnRab29tICogMS4yKTsKKyAgICBJbnNwZWN0 b3JGcm9udGVuZEhvc3Quc2V0Wm9vbUZhY3RvcihjdXJyZW50Wm9vbSArIDAuMik7CiAgICAgZXZl bnQucHJldmVudERlZmF1bHQoKTsKIH07CiAKIFdlYkluc3BlY3Rvci5fZGVjcmVhc2Vab29tID0g ZnVuY3Rpb24oZXZlbnQpIHsKICAgICBsZXQgY3VycmVudFpvb20gPSBJbnNwZWN0b3JGcm9udGVu ZEhvc3Quem9vbUZhY3RvcigpOwotICAgIEluc3BlY3RvckZyb250ZW5kSG9zdC5zZXRab29tRmFj dG9yKGN1cnJlbnRab29tICogMC44KTsKKyAgICBJbnNwZWN0b3JGcm9udGVuZEhvc3Quc2V0Wm9v bUZhY3RvcihjdXJyZW50Wm9vbSAtIDAuMik7CiAgICAgZXZlbnQucHJldmVudERlZmF1bHQoKTsK IH07CiAK