150633 2015-10-28 12:52:40 -0700 Web Inspector: Timeline recording start button missing when WEB_REPLAY disabled (no ReplayAgent) 2015-10-28 13:42:48 -0700 1 1 1 Unclassified WebKit Web Inspector Other All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1137225 0 joepeck 2015-10-28 12:52:40 -0700 * SUMMARY Timeline recording start button missing when WEB_REPLAY disabled (no ReplayAgent). No replay agent was causing us to do: element.classList.toggle("foo", undefined) Which seems turns the class on. Correct this code to ensure we pass `false`. 1137226 1 webkit-bug-importer 2015-10-28 12:53:02 -0700 <rdar://problem/23301173> 1137227 2 264234 joepeck 2015-10-28 12:54:57 -0700 Created attachment 264234 [PATCH] Proposed Fix 1137228 3 264234 timothy 2015-10-28 12:55:56 -0700 Comment on attachment 264234 [PATCH] Proposed Fix Makes me wonder if we should audit all our classList.toggle calls. 1137260 4 264234 commit-queue 2015-10-28 13:42:44 -0700 Comment on attachment 264234 [PATCH] Proposed Fix Clearing flags on attachment: 264234 Committed r191689: <http://trac.webkit.org/changeset/191689> 1137261 5 commit-queue 2015-10-28 13:42:48 -0700 All reviewed patches have been landed. Closing bug. 264234 2015-10-28 12:54:57 -0700 2015-10-28 13:42:44 -0700 [PATCH] Proposed Fix replay.patch text/plain 1783 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDBiZTUzM2EuLjJiY2E0ZjcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTEwLTI4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVGltZWxp bmUgcmVjb3JkaW5nIHN0YXJ0IGJ1dHRvbiBtaXNzaW5nIHdoZW4gV0VCX1JFUExBWSBkaXNhYmxl ZCAobm8gUmVwbGF5QWdlbnQpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNTA2MzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVTaWRlYmFyUGFuZWwuanM6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVTaWRlYmFyUGFuZWwucHJvdG90eXBlLl91 cGRhdGVSZXBsYXlJbnRlcmZhY2VWaXNpYmlsaXR5KToKKyAgICAgICAgRW5zdXJlIHdlIHBhc3Mg YSBib29sZWFuIHRvIGNsYXNzTGlzdC50b2dnbGUuCisKIDIwMTUtMTAtMjcgIEpvc2VwaCBQZWNv cmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBSZW1v dmUgVGltZWxpbmUgTWFya0RPTUNvbnRlbnQgYW5kIE1hcmtMb2FkLCBkYXRhIGlzIGFscmVhZHkg YXZhaWxhYmxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9UaW1lbGluZVNpZGViYXJQYW5lbC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lU2lkZWJhclBhbmVsLmpzCmluZGV4IDQ1NGRmNDcu LjQ4ZGFiM2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL1RpbWVsaW5lU2lkZWJhclBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lU2lkZWJhclBhbmVsLmpzCkBAIC05MzcsNyAr OTM3LDcgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lU2lkZWJhclBhbmVsID0gY2xhc3MgVGltZWxp bmVTaWRlYmFyUGFuZWwgZXh0ZW5kcyBXZWJJbnNwZWMKIAogICAgIF91cGRhdGVSZXBsYXlJbnRl cmZhY2VWaXNpYmlsaXR5KCkKICAgICB7Ci0gICAgICAgIHZhciBzaG91bGRTaG93UmVwbGF5SW50 ZXJmYWNlID0gd2luZG93LlJlcGxheUFnZW50ICYmIFdlYkluc3BlY3Rvci5zaG93UmVwbGF5SW50 ZXJmYWNlU2V0dGluZy52YWx1ZTsKKyAgICAgICAgdmFyIHNob3VsZFNob3dSZXBsYXlJbnRlcmZh Y2UgPSAhISh3aW5kb3cuUmVwbGF5QWdlbnQgJiYgV2ViSW5zcGVjdG9yLnNob3dSZXBsYXlJbnRl cmZhY2VTZXR0aW5nLnZhbHVlKTsKIAogICAgICAgICB0aGlzLl9zdGF0dXNCYXJFbGVtZW50LmNs YXNzTGlzdC50b2dnbGUoV2ViSW5zcGVjdG9yLlRpbWVsaW5lU2lkZWJhclBhbmVsLkhpZGRlblN0 eWxlQ2xhc3NOYW1lLCBzaG91bGRTaG93UmVwbGF5SW50ZXJmYWNlKTsKICAgICAgICAgdGhpcy5f cmVwbGF5TmF2aWdhdGlvbkJhci5lbGVtZW50LmNsYXNzTGlzdC50b2dnbGUoV2ViSW5zcGVjdG9y LlRpbWVsaW5lU2lkZWJhclBhbmVsLkhpZGRlblN0eWxlQ2xhc3NOYW1lLCAhc2hvdWxkU2hvd1Jl cGxheUludGVyZmFjZSk7Cg==