150630 2015-10-28 10:55:58 -0700 Web Inspector: Rendering Frames pie chart does not update during initial selection of a timeline range 2015-10-28 14:56:25 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg mattbaker bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1137190 0 bburg 2015-10-28 10:55:58 -0700 Steps to reproduce: * Get some content in the timeline * Switch to rendering frames view * Mousedown in the ruler and drag left or right Expected: * pie chart should live-update as I drag the selection Actual: * pie chart doesn't update until selection is committed (i.e., mouseup) Notes: It would seem that we don't create an actual selection until the range is committed, so none of the UI knows to update. In the UI, there is no difference between a real and provisional selection. Since all of the UI live-updates when panning an already created selection, I don't think this will cause a meaningful perf regression, except in one case. Selecting a range when a busy ScriptTimelineView will be choppy until we fix other filtering/render performance problems. 1137191 1 webkit-bug-importer 2015-10-28 10:56:41 -0700 <rdar://problem/23298552> 1137252 2 264239 mattbaker 2015-10-28 13:34:00 -0700 Created attachment 264239 [Patch] Proposed Fix 1137255 3 mattbaker 2015-10-28 13:35:57 -0700 The ruler suppresses changed events while adjusting a newly created selection (one that was created by clicking and dragging outside the existing selection). This effected not just the pie chart, but the updating of the data grid and filtered frame bar styles applied to frames outside the current selection. This change also causes the other timelines to update their content views when creating a new selection in the manner described. 1137272 4 264239 ggaren 2015-10-28 14:09:01 -0700 Comment on attachment 264239 [Patch] Proposed Fix r=me 1137304 5 264239 commit-queue 2015-10-28 14:56:21 -0700 Comment on attachment 264239 [Patch] Proposed Fix Clearing flags on attachment: 264239 Committed r191696: <http://trac.webkit.org/changeset/191696> 1137305 6 commit-queue 2015-10-28 14:56:25 -0700 All reviewed patches have been landed. Closing bug. 264239 2015-10-28 13:34:00 -0700 2015-10-28 14:56:21 -0700 [Patch] Proposed Fix bug-150630-20151028133311.patch text/plain 2888 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxNjg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAw YmU1MzNhYjlkNWFlOWY5M2NiNjFmZjEwZTMwYzBhNTAzNjQ1N2VkLi43Y2MyODdmYTdlY2I0OGQx ODVlYjE0MWU2NzU3N2JjNzhhZDc5ZDMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNS0xMC0yOCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVuZGVyaW5nIEZyYW1lcyBwaWUgY2hhcnQgZG9l cyBub3QgdXBkYXRlIGR1cmluZyBpbml0aWFsIHNlbGVjdGlvbiBvZiBhIHRpbWVsaW5lIHJhbmdl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTA2MzAK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBsb25n ZXIgc3VwcHJlc3Mgc2VsZWN0aW9uIGNoYW5nZWQgZXZlbnRzIHdoaWxlIGRyYWdnaW5nIHRvIGNy ZWF0ZSBhIG5ldyBzZWxlY3Rpb24uCisgICAgICAgIFdlIGRpc3BhdGNoIHNlbGVjdGlvbiBjaGFu Z2VkIGV2ZW50cyB3aGVuIGFkanVzdGluZyBhbiBleGlzdGluZyBzZWxlY3Rpb24sIHNvIGl0IG1h a2VzCisgICAgICAgIHNlbnNlIHRvIHRyZWF0IGJvdGggY2FzZXMgaWRlbnRpY2FsbHkuCisKKyAg ICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUnVsZXIuanM6CisgICAgICAgIChX ZWJJbnNwZWN0b3IuVGltZWxpbmVSdWxlcik6IERlbGV0ZWQuCisgICAgICAgIChXZWJJbnNwZWN0 b3IuVGltZWxpbmVSdWxlci5wcm90b3R5cGUuX2Rpc3BhdGNoVGltZVJhbmdlU2VsZWN0aW9uQ2hh bmdlZEV2ZW50KTogRGVsZXRlZC4KKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZVJ1bGVy LnByb3RvdHlwZS5faGFuZGxlTW91c2VNb3ZlKTogRGVsZXRlZC4KKwogMjAxNS0xMC0yNyAgSm9z ZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0 b3I6IFJlbW92ZSBUaW1lbGluZSBNYXJrRE9NQ29udGVudCBhbmQgTWFya0xvYWQsIGRhdGEgaXMg YWxyZWFkeSBhdmFpbGFibGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUnVsZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJ1bGVyLmpzCmluZGV4IDQwOTJkNDIxM2Q1MDJh NmY2NDA0OTU2ZmViNWQyY2Y5MjA4ZGQwOTIuLjUwNWUwMTk3MzYxODEzODlhMzg3MzMxMmI5YTZh NzNhNTQ5NmI1NTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL1RpbWVsaW5lUnVsZXIuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVSdWxlci5qcwpAQCAtNTIsNyArNTIsNiBAQCBXZWJJ bnNwZWN0b3IuVGltZWxpbmVSdWxlciA9IGNsYXNzIFRpbWVsaW5lUnVsZXIgZXh0ZW5kcyBXZWJJ bnNwZWN0b3IuT2JqZWN0CiAgICAgICAgIHRoaXMuX2FsbG93c1RpbWVSYW5nZVNlbGVjdGlvbiA9 IGZhbHNlOwogICAgICAgICB0aGlzLl9taW5pbXVtU2VsZWN0aW9uRHVyYXRpb24gPSAwLjAxOwog ICAgICAgICB0aGlzLl9mb3JtYXRMYWJlbENhbGxiYWNrID0gbnVsbDsKLSAgICAgICAgdGhpcy5f c3VwcHJlc3NOZXh0VGltZVJhbmdlU2VsZWN0aW9uQ2hhbmdlZEV2ZW50ID0gZmFsc2U7CiAgICAg ICAgIHRoaXMuX3RpbWVSYW5nZVNlbGVjdGlvbkNoYW5nZWQgPSBmYWxzZTsKIAogICAgICAgICB0 aGlzLl9tYXJrZXJFbGVtZW50TWFwID0gbmV3IE1hcDsKQEAgLTY0OSwxMSArNjQ4LDYgQEAgV2Vi SW5zcGVjdG9yLlRpbWVsaW5lUnVsZXIgPSBjbGFzcyBUaW1lbGluZVJ1bGVyIGV4dGVuZHMgV2Vi SW5zcGVjdG9yLk9iamVjdAogICAgICAgICBpZiAoIXRoaXMuX3RpbWVSYW5nZVNlbGVjdGlvbkNo YW5nZWQpCiAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgaWYgKHRoaXMuX3N1cHByZXNz TmV4dFRpbWVSYW5nZVNlbGVjdGlvbkNoYW5nZWRFdmVudCkgewotICAgICAgICAgICAgdGhpcy5f c3VwcHJlc3NOZXh0VGltZVJhbmdlU2VsZWN0aW9uQ2hhbmdlZEV2ZW50ID0gZmFsc2U7Ci0gICAg ICAgICAgICByZXR1cm47Ci0gICAgICAgIH0KLQogICAgICAgICB0aGlzLl90aW1lUmFuZ2VTZWxl Y3Rpb25DaGFuZ2VkID0gZmFsc2U7CiAKICAgICAgICAgdGhpcy5kaXNwYXRjaEV2ZW50VG9MaXN0 ZW5lcnMoV2ViSW5zcGVjdG9yLlRpbWVsaW5lUnVsZXIuRXZlbnQuVGltZVJhbmdlU2VsZWN0aW9u Q2hhbmdlZCk7CkBAIC02OTYsOCArNjkwLDYgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUnVsZXIg PSBjbGFzcyBUaW1lbGluZVJ1bGVyIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVjdAogICAgIHsK ICAgICAgICAgY29uc29sZS5hc3NlcnQoZXZlbnQuYnV0dG9uID09PSAwKTsKIAotICAgICAgICB0 aGlzLl9zdXBwcmVzc05leHRUaW1lUmFuZ2VTZWxlY3Rpb25DaGFuZ2VkRXZlbnQgPSAhdGhpcy5f c2VsZWN0aW9uSXNNb3ZlOwotCiAgICAgICAgIGlmICh0aGlzLl9zZWxlY3Rpb25Jc01vdmUpIHsK ICAgICAgICAgICAgIHZhciBjdXJyZW50TW91c2VQb3NpdGlvbiA9IE1hdGgubWF4KHRoaXMuX21v dmVTZWxlY3Rpb25NYXhpbXVtTGVmdE9mZnNldCwgTWF0aC5taW4odGhpcy5fbW92ZVNlbGVjdGlv bk1heGltdW1SaWdodE9mZnNldCwgZXZlbnQucGFnZVgpKTsKIAo=