150625 2015-10-28 07:34:07 -0700 Add WinCairo to list of ports in run-webkit-tests. 2015-10-28 10:53:09 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned achristensen bfulgham commit-queue glenn lforschler ossy oldest_to_newest 1137121 0 peavo 2015-10-28 07:34:07 -0700 Instead of "reusing" the AppleWin port when running tests on WinCairo, we should add it as a port, and add baseline results for it. 1137125 1 264212 peavo 2015-10-28 07:58:30 -0700 Created attachment 264212 Patch 1137133 2 264212 bfulgham 2015-10-28 09:00:49 -0700 Comment on attachment 264212 Patch I would suggest trying to share as much "Apple Windows" and "WinCairo" results as possible, though perhaps in practice there are too many differences in font handling, antialiasing, etc. 1137167 3 peavo 2015-10-28 10:18:41 -0700 (In reply to comment #2) > Comment on attachment 264212 [details] > Patch > Thanks for reviewing :) > I would suggest trying to share as much "Apple Windows" and "WinCairo" > results as possible, though perhaps in practice there are too many > differences in font handling, antialiasing, etc. Thanks, that makes sense :) I assume it means we have to change the fallback order? Currently, on Windows 10, I get the fallback order "wincairo-win10 -> wincairo -> mac -> generic". 1137170 4 bfulgham 2015-10-28 10:28:10 -0700 (In reply to comment #3) > (In reply to comment #2) > > Comment on attachment 264212 [details] > > Patch > > > > Thanks for reviewing :) > > > I would suggest trying to share as much "Apple Windows" and "WinCairo" > > results as possible, though perhaps in practice there are too many > > differences in font handling, antialiasing, etc. > > Thanks, that makes sense :) I assume it means we have to change the fallback > order? > Currently, on Windows 10, I get the fallback order "wincairo-win10 -> > wincairo -> mac -> generic". Yes -- I think we have fewer tests that are compatible with 'mac' now, since the font changes made in Yosemite mean even more things differ. So in practice, the 'mac' fallback may not be that useful anymore. 1137177 5 peavo 2015-10-28 10:35:12 -0700 Ok, thanks :) Btw, are you using the Times font from a Mac computer when you are running the layout tests on AppleWin? I ran some layout tests on AppleWin the other day, and I did not get the expected font metrics for the Times 16 font. 1137187 6 peavo 2015-10-28 10:53:09 -0700 Committed r191678: <http://trac.webkit.org/changeset/191678>. 264212 2015-10-28 07:58:30 -0700 2015-10-28 09:00:49 -0700 Patch bug-150625-20151028155803.patch text/plain 2493 peavo SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE5MTY2OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIxIEBACisyMDE1LTEwLTI4ICBQZXIgQXJuZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNv bT4KKworICAgICAgICBBZGQgV2luQ2Fpcm8gdG8gbGlzdCBvZiBwb3J0cyBpbiBydW4td2Via2l0 LXRlc3RzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTUwNjI1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvcG9ydHMucHk6CisgICAgICAgIChEZXBy ZWNhdGVkUG9ydC5wb3J0KToKKyAgICAgICAgKFdpblBvcnQucnVuX3dlYmtpdF90ZXN0c19jb21t YW5kKToKKyAgICAgICAgKFdpbkNhaXJvUG9ydCk6CisgICAgICAgIChHdGtXSzJQb3J0KToKKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvZmFjdG9yeS5weToKKyAgICAgICAgKFBvcnRG YWN0b3J5KToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvd2luLnB5OgorICAgICAg ICAoV2luUG9ydC5maW5kX3N5c3RlbV9waWQpOgorICAgICAgICAoV2luQ2Fpcm9Qb3J0KToKKwog MjAxNS0xMC0yNyAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAg ICBXZWJLaXRUZXN0UnVubmVyIGxlYWtzIGluIGdlbmVyYXRlV2hpdGVsaXN0KCkKSW5kZXg6IFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9wb3J0cy5weQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jb25maWcvcG9ydHMucHkJKHJldmlzaW9u IDE5MTUzNSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy9wb3J0cy5w eQkod29ya2luZyBjb3B5KQpAQCAtNjgsNiArNjgsNyBAQCBjbGFzcyBEZXByZWNhdGVkUG9ydChv YmplY3QpOgogICAgICAgICAgICAgIm1hYyI6IE1hY1BvcnQsCiAgICAgICAgICAgICAibWFjLXdr MiI6IE1hY1dLMlBvcnQsCiAgICAgICAgICAgICAid2luIjogV2luUG9ydCwKKyAgICAgICAgICAg ICJ3aW5jYWlybyI6IFdpbkNhaXJvUG9ydCwKICAgICAgICAgICAgICJlZmwtd2syIjogRWZsV0sy UG9ydCwKICAgICAgICAgfQogICAgICAgICBkZWZhdWx0X3BvcnQgPSB7CkBAIC0xNTUsNiArMTU2 LDEwIEBAIGNsYXNzIFdpblBvcnQoRGVwcmVjYXRlZFBvcnQpOgogICAgICAgICByZXR1cm4gY29t bWFuZAogCiAKK2NsYXNzIFdpbkNhaXJvUG9ydChEZXByZWNhdGVkUG9ydCk6CisgICAgcG9ydF9m bGFnX25hbWUgPSAid2luY2Fpcm8iCisKKwogY2xhc3MgR3RrV0syUG9ydChEZXByZWNhdGVkUG9y dCk6CiAgICAgcG9ydF9mbGFnX25hbWUgPSAiZ3RrLXdrMiIKIApJbmRleDogVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9wb3J0L2ZhY3RvcnkucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9wb3J0L2ZhY3RvcnkucHkJKHJldmlzaW9uIDE5MTUzNSkKKysrIFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvcG9ydC9mYWN0b3J5LnB5CSh3b3JraW5nIGNvcHkpCkBAIC05NSw2ICs5NSw3 IEBAIGNsYXNzIFBvcnRGYWN0b3J5KG9iamVjdCk6CiAgICAgICAgICdtYWMuTWFjUG9ydCcsCiAg ICAgICAgICdtb2NrX2RydC5Nb2NrRFJUUG9ydCcsCiAgICAgICAgICd0ZXN0LlRlc3RQb3J0JywK KyAgICAgICAgJ3dpbi5XaW5DYWlyb1BvcnQnLAogICAgICAgICAnd2luLldpblBvcnQnLAogICAg ICkKIApJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L3dpbi5weQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvd2luLnB5CShyZXZpc2lvbiAxOTE1MzUp CisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvd2luLnB5CSh3b3JraW5nIGNvcHkpCkBA IC0zNDgsMyArMzQ4LDkgQEAgY2xhc3MgV2luUG9ydChBcHBsZVBvcnQpOgogICAgICAgICAgICAg ICAgIHBhc3MKIAogICAgICAgICByZXR1cm4gc3lzdGVtX3BpZAorCisKK2NsYXNzIFdpbkNhaXJv UG9ydChXaW5Qb3J0KToKKyAgICBwb3J0X25hbWUgPSAid2luY2Fpcm8iCisKKyAgICBWRVJTSU9O X0ZBTExCQUNLX09SREVSID0gWyJ3aW5jYWlyby14cCIsICJ3aW5jYWlyby12aXN0YSIsICJ3aW5j YWlyby03c3AwIiwgIndpbmNhaXJvLXdpbjEwIiwgIndpbmNhaXJvIl0K