150622 2015-10-28 05:02:53 -0700 [EFL] gnutls-3.3.0 jhbuild module build fails on Ubuntu 15.10 2015-11-02 04:39:00 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 150619 1 ossy ossy gyuyoung.kim ossy oldest_to_newest 1137107 0 ossy 2015-10-28 05:02:53 -0700 In file included from sha-padlock.c:29:0: sha-padlock.c: In function 'padlock_sha1_update': sha-padlock.c:81:46: error: 'struct sha1_ctx' has no member named 'count_high' MD_UPDATE(ctx, length, data, SHA1_COMPRESS, MD_INCR(ctx)); ^ sha-padlock.c:81:46: error: 'struct sha1_ctx' has no member named 'count_low' MD_UPDATE(ctx, length, data, SHA1_COMPRESS, MD_INCR(ctx)); ^ sha-padlock.c:81:46: error: 'struct sha1_ctx' has no member named 'count_high' MD_UPDATE(ctx, length, data, SHA1_COMPRESS, MD_INCR(ctx)); ^ sha-padlock.c:81:46: error: 'struct sha1_ctx' has no member named 'count_low' MD_UPDATE(ctx, length, data, SHA1_COMPRESS, MD_INCR(ctx)); ^ sha-padlock.c: In function 'padlock_sha256_update': sha-padlock.c:88:48: error: 'struct sha256_ctx' has no member named 'count_high' MD_UPDATE(ctx, length, data, SHA256_COMPRESS, MD_INCR(ctx)); ^ sha-padlock.c:88:48: error: 'struct sha256_ctx' has no member named 'count_low' MD_UPDATE(ctx, length, data, SHA256_COMPRESS, MD_INCR(ctx)); ^ sha-padlock.c:88:48: error: 'struct sha256_ctx' has no member named 'count_high' MD_UPDATE(ctx, length, data, SHA256_COMPRESS, MD_INCR(ctx)); ^ sha-padlock.c:88:48: error: 'struct sha256_ctx' has no member named 'count_low' MD_UPDATE(ctx, length, data, SHA256_COMPRESS, MD_INCR(ctx)); ^ sha-padlock.c: In function 'padlock_sha1_digest': sha-padlock.c:143:13: error: 'struct sha1_ctx' has no member named 'count_high' high = (ctx->count_high << 9) | (ctx->count_low >> 23); ^ sha-padlock.c:143:38: error: 'struct sha1_ctx' has no member named 'count_low' high = (ctx->count_high << 9) | (ctx->count_low >> 23); ^ sha-padlock.c:144:12: error: 'struct sha1_ctx' has no member named 'count_low' low = (ctx->count_low << 9) | (ctx->index << 3); ^ sha-padlock.c: In function 'padlock_sha256_digest': sha-padlock.c:165:13: error: 'struct sha256_ctx' has no member named 'count_high' high = (ctx->count_high << 9) | (ctx->count_low >> 23); ^ sha-padlock.c:165:38: error: 'struct sha256_ctx' has no member named 'count_low' high = (ctx->count_high << 9) | (ctx->count_low >> 23); ^ sha-padlock.c:166:12: error: 'struct sha256_ctx' has no member named 'count_low' low = (ctx->count_low << 9) | (ctx->index << 3); ^ Makefile:1528: recipe for target 'sha-padlock.lo' failed make[5]: *** [sha-padlock.lo] Error 1 make[5]: *** Waiting for unfinished jobs.... aes-padlock.c: In function 'padlock_aes_cipher_setkey': aes-padlock.c:97:22: error: 'struct aes_ctx' has no member named 'nrounds' pce->ks.rounds = nc.nrounds; ^ Makefile:1528: recipe for target 'aes-padlock.lo' failed make[5]: *** [aes-padlock.lo] Error 1 aes-gcm-padlock.c: In function 'aes_gcm_cipher_setkey': aes-gcm-padlock.c:102:23: error: macro "GCM_SET_KEY" passed 5 arguments, but takes just 4 keysize, userkey); ^ aes-gcm-padlock.c:101:2: error: 'GCM_SET_KEY' undeclared (first use in this function) GCM_SET_KEY(ctx, padlock_aes_set_encrypt_key, padlock_aes_encrypt, ^ aes-gcm-padlock.c:101:2: note: each undeclared identifier is reported only once for each function it appears in Makefile:1528: recipe for target 'aes-gcm-padlock.lo' failed make[5]: *** [aes-gcm-padlock.lo] Error 1 make[5]: Leaving directory '/home/ossy/WebKit/WebKitBuild/DependenciesEFL/Source/gnutls-3.3.0/lib/accelerated/x86' Makefile:1397: recipe for target 'all-recursive' failed make[4]: *** [all-recursive] Error 1 1137254 1 ossy 2015-10-28 13:34:19 -0700 http://trac.webkit.org/changeset/182874 added building gnutls as a jhbuild module to be able to build Chromium and WebKitEFL on the same Ubuntu 14.04 machine. The problem was that Chromium needed libcups2-dev, which depends on libgnutls-dev which is version 2.12. But to build WebKit, we need libgnutls28-dev which is version 3.2.11. Of course libgnutls-dev and libgnutls28-dev are in conflict, it isn't possible to install both of them at the same time, accordingly it wasn't possible to build Chromium and WebKit on the same 14.04 machine ... That's why r182874 added gnutls as jhbuild module to be able to have two different gnutls version. But 14.04 isn't supported since we need at least GCC 4.9, now the reference platform is Ubuntu 15.04. libgnutls-dev and libgnutls28-dev are same on 15.04 (gnutls 3.3.8) and 15.10 too (gnutls 3.3.15) ( http://trac.webkit.org/changeset/188912 https://trac.webkit.org/changeset/187596) I think the proper fix is dropping gnutls from jhbuild modules and adding libgnutls-dev back to install-dependencies script. 1137258 2 264240 ossy 2015-10-28 13:39:42 -0700 Created attachment 264240 Patch Additionally removed nettle-dev from Tools/efl/install-dependencies, libgnutls-dev pulls it in. 1137388 3 264240 gyuyoung.kim 2015-10-28 17:58:18 -0700 Comment on attachment 264240 Patch Thank you for fixing it. 1138505 4 264240 ossy 2015-11-02 02:27:04 -0800 Comment on attachment 264240 Patch Clearing flags on attachment: 264240 Committed r191883: <http://trac.webkit.org/changeset/191883> 1138506 5 ossy 2015-11-02 02:27:11 -0800 All reviewed patches have been landed. Closing bug. 1138508 6 ossy 2015-11-02 02:41:47 -0800 (In reply to comment #4) > Comment on attachment 264240 [details] > Patch > > Clearing flags on attachment: 264240 > > Committed r191883: <http://trac.webkit.org/changeset/191883> It broke the jhbuild step on the EFL buildbot: configure: error: in `/home/gyuyoung/WebKit-BuildSlave/efl-linux-64-release-wk2/build/WebKitBuild/DependenciesEFL/Source/glib-networking-2.41.4': configure: error: "No package 'gnutls' found" See `config.log' for more details It seems libgnutls-dev package was installed on the EWS, but not on the bot. Gyuyoung, could you install this package? 1138521 7 gyuyoung.kim 2015-11-02 04:39:00 -0800 (In reply to comment #6) > (In reply to comment #4) > > Comment on attachment 264240 [details] > > Patch > > > > Clearing flags on attachment: 264240 > > > > Committed r191883: <http://trac.webkit.org/changeset/191883> > > It broke the jhbuild step on the EFL buildbot: > > configure: error: in > `/home/gyuyoung/WebKit-BuildSlave/efl-linux-64-release-wk2/build/WebKitBuild/ > DependenciesEFL/Source/glib-networking-2.41.4': > configure: error: "No package 'gnutls' found" > See `config.log' for more details > > > It seems libgnutls-dev package was installed on the EWS, but not on the bot. > Gyuyoung, could you install this package? I just install the pkg now. 264240 2015-10-28 13:39:42 -0700 2015-11-02 02:27:04 -0800 Patch bug-150622-20151028213851.patch text/plain 2645 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxNjg4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTQ0MDVkYmY4NDRiODcyZTk4OTBiYTJmMDZjYmY4OGU2 ODM3Zjc1MC4uMGUxYTgxNTkwNjY3NzE0NjczNGJjNjBmNGRlMThlZWQ3ZmVjYTllMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE1LTEwLTI4ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgW0VGTF0gZ251dGxzLTMuMy4wIGpoYnVpbGQgbW9kdWxlIGJ1aWxkIGZhaWxzIG9u IFVidW50dSAxNS4xMAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTUwNjIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBlZmwvaW5zdGFsbC1kZXBlbmRlbmNpZXM6CisgICAgICAgICogZWZsL2poYnVpbGQu bW9kdWxlczoKKwogMjAxNS0xMC0yOCAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3 ZWJraXQub3JnPgogCiAgICAgICAgIENvbXBpbGUgYW5kIGxpbmsgd2l0aCBDTWFrZSBvbiBNYWMK ZGlmZiAtLWdpdCBhL1Rvb2xzL2VmbC9pbnN0YWxsLWRlcGVuZGVuY2llcyBiL1Rvb2xzL2VmbC9p bnN0YWxsLWRlcGVuZGVuY2llcwppbmRleCA5Zjc2MTczMGE4MmRjMzg2YmNkYzY1ZDFlOTliZWIz OTc1ZDQ1MTI2Li5iNjMzMmYyZTIyYzI5OTQwNzA3OGJhMDE2N2MxNDYwNjQ3YTBjZTEwIDEwMDc1 NQotLS0gYS9Ub29scy9lZmwvaW5zdGFsbC1kZXBlbmRlbmNpZXMKKysrIGIvVG9vbHMvZWZsL2lu c3RhbGwtZGVwZW5kZW5jaWVzCkBAIC02OSw2ICs2OSw3IEBAIGZ1bmN0aW9uIGluc3RhbGxEZXBl bmRlbmNpZXNXaXRoQXB0IHsKICAgICAgICAgbGliZ2VvY2x1ZS1kZXYgXAogICAgICAgICBsaWJn aWYtZGV2IFwKICAgICAgICAgbGliZ2wxLW1lc2EtZGV2IFwKKyAgICAgICAgbGliZ251dGxzLWRl diBcCiAgICAgICAgIGxpYmdwZy1lcnJvci1kZXYgXAogICAgICAgICBsaWJoeXBoZW4tZGV2IFwK ICAgICAgICAgbGliaWN1LWRldiBcCkBAIC05Nyw3ICs5OCw2IEBAIGZ1bmN0aW9uIGluc3RhbGxE ZXBlbmRlbmNpZXNXaXRoQXB0IHsKICAgICAgICAgbGlieHNzLWRldiBcCiAgICAgICAgIGxpYnh0 LWRldiBcCiAgICAgICAgIGxpYnh0c3QtZGV2IFwKLSAgICAgICAgbmV0dGxlLWRldiBcCiAgICAg ICAgIG5pbmphLWJ1aWxkIFwKICAgICAgICAgcmFnZWwgXAogICAgICAgICBydWJ5IFwKZGlmZiAt LWdpdCBhL1Rvb2xzL2VmbC9qaGJ1aWxkLm1vZHVsZXMgYi9Ub29scy9lZmwvamhidWlsZC5tb2R1 bGVzCmluZGV4IGMzZTIyMzhlNmY2MzhlNzMzZDcwNWJkZWIzYzgxNWZiOGFjZjBhODkuLjA1NzI0 NjAwZGVlZjdiMWQwYmVmNDlhNWM3MGE0YjVjMzBiZmE0ZWUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL2Vm bC9qaGJ1aWxkLm1vZHVsZXMKKysrIGIvVG9vbHMvZWZsL2poYnVpbGQubW9kdWxlcwpAQCAtMTIs NyArMTIsNiBAQAogICAgICAgPGRlcCBwYWNrYWdlPSJmcmVldHlwZTYiLz4KICAgICAgIDxkZXAg cGFja2FnZT0iaGFyZmJ1enoiLz4KICAgICAgIDxkZXAgcGFja2FnZT0iZ2xpYiIvPgotICAgICAg PGRlcCBwYWNrYWdlPSJnbnV0bHMiLz4KICAgICAgIDxkZXAgcGFja2FnZT0iZ2xpYi1uZXR3b3Jr aW5nIi8+CiAgICAgICA8ZGVwIHBhY2thZ2U9ImxpYnNvdXAiLz4KICAgICAgIDxkZXAgcGFja2Fn ZT0iZWxlbWVudGFyeSIvPgpAQCAtNTYsOCArNTUsNiBAQAogICAgICAgaHJlZj0iaHR0cDovL2xs dm0ub3JnL3N2bi9sbHZtLXByb2plY3QvIi8+CiAgIDxyZXBvc2l0b3J5IHR5cGU9InRhcmJhbGwi IG5hbWU9Imxsdm0tdGFyIgogICAgICAgaHJlZj0iaHR0cDovL2xsdm0ub3JnIi8+Ci0gIDxyZXBv c2l0b3J5IHR5cGU9InRhcmJhbGwiIG5hbWU9ImdudXRscyIKLSAgICAgIGhyZWY9ImZ0cDovL2Z0 cC5nbnV0bHMub3JnIi8+CiAKICAgPGF1dG90b29scyBpZD0iY2Fpcm8iIGF1dG9nZW4tc2g9ImNv bmZpZ3VyZSIKICAgICAgICAgICAgICBtYWtlYXJncz0iQ0ZMQUdTPSctZm5vLWx0bycgQ1hYRkxB R1M9Jy1mbm8tbHRvJyBMREZMQUdTPSctZm5vLWx0byciPgpAQCAtMTI4LDEzICsxMjUsNiBAQAog ICAgICAgICAgICAgbWQ1c3VtPSI5NjM2ZjYwZTk5Yjk4ZmQwZmRiNTIzOWY5MDVhYzAwOCIvPgog ICA8L2F1dG90b29scz4KIAotICA8YXV0b3Rvb2xzIGlkPSJnbnV0bHMiIGF1dG9nZW4tc2g9ImNv bmZpZ3VyZSI+Ci0gICAgPGJyYW5jaCBtb2R1bGU9Ii9nY3J5cHQvZ251dGxzL3YzLjMvZ251dGxz LTMuMy4wLnRhci54eiIgdmVyc2lvbj0iMy4zIgotICAgICAgICAgICAgcmVwbz0iZ251dGxzIgot ICAgICAgICAgICAgaGFzaD0ic2hhMjU2OjdiODdhNDMxOWY3NGNhZTNhNWYyMDRiODEwMDAwZjA2 YjhlZmExZWQwZjU3YzY4NGI5YmM0NTRmNDQ0ZmRmMTMiCi0gICAgICAgICAgICBtZDVzdW09IjRh ZWI4MDE0ZmViNDAxNmM3M2E2MGY0ZTFhYzczYzlmIi8+Ci0gIDwvYXV0b3Rvb2xzPgotCiAgIDxh dXRvdG9vbHMgaWQ9ImdsaWItbmV0d29ya2luZyI+CiAgICAgPGRlcGVuZGVuY2llcz4KICAgICAg IDxkZXAgcGFja2FnZT0iZ2xpYiIvPgo=