150577 2015-10-26 15:33:09 -0700 http/tests/contentextensions/async-xhr-onerror.html is flaky on mac-wk2 2015-11-09 13:25:52 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Mac Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=146706 P2 Normal --- 1 ryanhaddad achristensen achristensen beidson commit-queue oldest_to_newest 1136659 0 ryanhaddad 2015-10-26 15:33:09 -0700 http/tests/contentextensions/async-xhr-onerror.html is flaky on mac-wk2 <http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fcontentextensions%2Fasync-xhr-onerror.html> --- /Volumes/Data/slave/mavericks-debug-tests-wk2/build/layout-test-results/http/tests/contentextensions/async-xhr-onerror-expected.txt +++ /Volumes/Data/slave/mavericks-debug-tests-wk2/build/layout-test-results/http/tests/contentextensions/async-xhr-onerror-actual.txt @@ -5,6 +5,7 @@ Asynchronous onreadystatechange status: 0, readyState:1, responseText: Finished runTest. Waiting for callbacks Asynchronous onreadystatechange status: 0, readyState:4, responseText: +timeout - this should not be called. onerror was called. Asynchronous onreadystatechange status: 0, readyState:4, responseText: onerror was called. 1139630 1 ryanhaddad 2015-11-05 09:20:14 -0800 Marked as flaky in <https://trac.webkit.org/r192059> 1140045 2 264954 achristensen 2015-11-06 13:18:49 -0800 Created attachment 264954 Patch 1140067 3 achristensen 2015-11-06 15:23:54 -0800 This should be landed along with marking the test as not flaky any more. 1140216 4 264954 darin 2015-11-07 16:33:47 -0800 Comment on attachment 264954 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=264954&action=review > Source/WebCore/xml/XMLHttpRequest.cpp:786 > + if (m_timeoutTimer.isActive()) > + m_timeoutTimer.stop(); Why do we need the "!isActive" check here? Calling stop should be harmless if the timer is not active. 1140449 5 achristensen 2015-11-09 11:57:01 -0800 (In reply to comment #4) > Comment on attachment 264954 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=264954&action=review > > > Source/WebCore/xml/XMLHttpRequest.cpp:786 > > + if (m_timeoutTimer.isActive()) > > + m_timeoutTimer.stop(); > > Why do we need the "!isActive" check here? Calling stop should be harmless > if the timer is not active. It was done elsewhere in this file. I'll remove it elsewhere. 1140470 6 265081 achristensen 2015-11-09 12:35:32 -0800 Created attachment 265081 Patch 1140500 7 265081 commit-queue 2015-11-09 13:25:47 -0800 Comment on attachment 265081 Patch Clearing flags on attachment: 265081 Committed r192175: <http://trac.webkit.org/changeset/192175> 1140501 8 commit-queue 2015-11-09 13:25:52 -0800 All reviewed patches have been landed. Closing bug. 264954 2015-11-06 13:18:49 -0800 2015-11-09 12:35:29 -0800 Patch bug-150577-20151106131749.patch text/plain 1899 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MjExOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTExLTA2ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgWEhSIHRpbWVv dXRzIHNob3VsZCBub3QgZmlyZSBpZiB0aGVyZSBpcyBhbiBpbW1lZGlhdGUgbmV0d29yayBlcnJv ci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDU3 NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMg Zml4ZXMgZmxha2luZXNzIG9mIGh0dHAvdGVzdHMvY29udGVudGV4dGVuc2lvbnMvYXN5bmMteGhy LW9uZXJyb3IuaHRtbCBzaW5jZSByMTkxMDc3LgorCisgICAgICAgICogeG1sL1hNTEh0dHBSZXF1 ZXN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlhNTEh0dHBSZXF1ZXN0OjpjcmVhdGVSZXF1ZXN0 KToKKyAgICAgICAgSWYgdGhlIHRpbWVvdXQgdGltZXIgaGFzIGJlZW4gc3RhcnRlZCBhbmQgd2Ug YXJlIGdvaW5nIHRvIGltbWVkaWF0ZWx5IHJlcG9ydCBhIG5ldHdvcmsgZXJyb3IsIHRoZW4gc3Rv cCB0aGUgdGltZW91dCB0aW1lci4KKyAgICAgICAgVGhlIHRpbWVvdXQgdGltZXIgc29tZXRpbWVz IGZpcmVkIGJlZm9yZSB0aGUgbmV0d29yayBlcnJvciB0aW1lciBpZiBpdCB3YXMgYSB2ZXJ5IHNo b3J0IHRpbWVvdXQgKHN1Y2ggYXMgMW1zKS4KKwogMjAxNS0xMS0wNiAgTWFyaW8gU2FuY2hleiBQ cmFkYSAgPG1hcmlvQGVuZGxlc3NtLmNvbT4KIAogICAgICAgICBMYXlvdXQgVGVzdCBhY2Nlc3Np YmlsaXR5L3dpbi9saW5rZWQtZWxlbWVudHMuaHRtbCBpcyBjcmFzaGluZyBvbiB3aW4gZGVidWcK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmNwcAkocmV2aXNpb24gMTkyMDkz KQorKysgU291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNzgxLDggKzc4MSwxMSBAQCB2b2lkIFhNTEh0dHBSZXF1ZXN0OjpjcmVhdGVSZXF1ZXN0 KEV4Y2VwCiAgICAgICAgIC8vIGEgcmVxdWVzdCBpcyBpbiBwcm9ncmVzcyBiZWNhdXNlIHdlIG5l ZWQgdG8ga2VlcCB0aGUgbGlzdGVuZXJzIGFsaXZlLAogICAgICAgICAvLyBhbmQgdGhleSBhcmUg cmVmZXJlbmNlZCBieSB0aGUgSmF2YVNjcmlwdCB3cmFwcGVyLgogICAgICAgICBzZXRQZW5kaW5n QWN0aXZpdHkodGhpcyk7Ci0gICAgICAgIGlmICghbV9sb2FkZXIpCisgICAgICAgIGlmICghbV9s b2FkZXIpIHsKKyAgICAgICAgICAgIGlmIChtX3RpbWVvdXRUaW1lci5pc0FjdGl2ZSgpKQorICAg ICAgICAgICAgICAgIG1fdGltZW91dFRpbWVyLnN0b3AoKTsKICAgICAgICAgICAgIG1fbmV0d29y a0Vycm9yVGltZXIuc3RhcnRPbmVTaG90KDApOworICAgICAgICB9CiAgICAgfSBlbHNlIHsKICAg ICAgICAgSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uOjp3aWxsTG9hZFhIUlN5bmNocm9ub3VzbHko c2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpKTsKICAgICAgICAgVGhyZWFkYWJsZUxvYWRlcjo6bG9h ZFJlc291cmNlU3luY2hyb25vdXNseShzY3JpcHRFeGVjdXRpb25Db250ZXh0KCksIHJlcXVlc3Qs ICp0aGlzLCBvcHRpb25zKTsK 265081 2015-11-09 12:35:32 -0800 2015-11-09 13:25:47 -0800 Patch bug-150577-20151109123544.patch text/plain 3883 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MjE3MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE1LTExLTA5ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgWEhSIHRpbWVv dXRzIHNob3VsZCBub3QgZmlyZSBpZiB0aGVyZSBpcyBhbiBpbW1lZGlhdGUgbmV0d29yayBlcnJv ci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDU3 NworCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgorCisgICAgICAgIFRoaXMgZml4 ZXMgZmxha2luZXNzIG9mIGh0dHAvdGVzdHMvY29udGVudGV4dGVuc2lvbnMvYXN5bmMteGhyLW9u ZXJyb3IuaHRtbCBzaW5jZSByMTkxMDc3LgorCisgICAgICAgICogeG1sL1hNTEh0dHBSZXF1ZXN0 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlhNTEh0dHBSZXF1ZXN0OjpjcmVhdGVSZXF1ZXN0KToK KyAgICAgICAgKFdlYkNvcmU6OlhNTEh0dHBSZXF1ZXN0OjppbnRlcm5hbEFib3J0KToKKyAgICAg ICAgKFdlYkNvcmU6OlhNTEh0dHBSZXF1ZXN0OjpkaWRGaW5pc2hMb2FkaW5nKToKKyAgICAgICAg SWYgdGhlIHRpbWVvdXQgdGltZXIgaGFzIGJlZW4gc3RhcnRlZCBhbmQgd2UgYXJlIGdvaW5nIHRv IGltbWVkaWF0ZWx5IHJlcG9ydCBhIG5ldHdvcmsgZXJyb3IsIHRoZW4gc3RvcCB0aGUgdGltZW91 dCB0aW1lci4KKyAgICAgICAgVGhlIHRpbWVvdXQgdGltZXIgc29tZXRpbWVzIGZpcmVkIGJlZm9y ZSB0aGUgbmV0d29yayBlcnJvciB0aW1lciBpZiBpdCB3YXMgYSB2ZXJ5IHNob3J0IHRpbWVvdXQg KHN1Y2ggYXMgMW1zKS4KKyAgICAgICAgQWxzbyBjaGVja3MgdG8gaXNBY3RpdmUgYmVmb3JlIGNh bGxpbmcgc3RvcCBvbiBhIHRpbWVyIGFyZSBub3QgbmVjZXNzYXJ5LgorCiAyMDE1LTExLTA5ICBK aWV3ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CiAKICAgICAgICAgTnVsbCBkZXJlZmVy ZW5jZSBsb2FkaW5nIEJsaW5rIGxheW91dCB0ZXN0IGVkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC1o dG1sLWNyYXNoLTAxLmh0bWwKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVz dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmNw cAkocmV2aXNpb24gMTkyMTY5KQorKysgU291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzgxLDggKzc4MSwxMCBAQCB2b2lkIFhNTEh0dHBSZXF1 ZXN0OjpjcmVhdGVSZXF1ZXN0KEV4Y2VwCiAgICAgICAgIC8vIGEgcmVxdWVzdCBpcyBpbiBwcm9n cmVzcyBiZWNhdXNlIHdlIG5lZWQgdG8ga2VlcCB0aGUgbGlzdGVuZXJzIGFsaXZlLAogICAgICAg ICAvLyBhbmQgdGhleSBhcmUgcmVmZXJlbmNlZCBieSB0aGUgSmF2YVNjcmlwdCB3cmFwcGVyLgog ICAgICAgICBzZXRQZW5kaW5nQWN0aXZpdHkodGhpcyk7Ci0gICAgICAgIGlmICghbV9sb2FkZXIp CisgICAgICAgIGlmICghbV9sb2FkZXIpIHsKKyAgICAgICAgICAgIG1fdGltZW91dFRpbWVyLnN0 b3AoKTsKICAgICAgICAgICAgIG1fbmV0d29ya0Vycm9yVGltZXIuc3RhcnRPbmVTaG90KDApOwor ICAgICAgICB9CiAgICAgfSBlbHNlIHsKICAgICAgICAgSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9u Ojp3aWxsTG9hZFhIUlN5bmNocm9ub3VzbHkoc2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpKTsKICAg ICAgICAgVGhyZWFkYWJsZUxvYWRlcjo6bG9hZFJlc291cmNlU3luY2hyb25vdXNseShzY3JpcHRF eGVjdXRpb25Db250ZXh0KCksIHJlcXVlc3QsICp0aGlzLCBvcHRpb25zKTsKQEAgLTgyOSw4ICs4 MzEsNyBAQCBib29sIFhNTEh0dHBSZXF1ZXN0OjppbnRlcm5hbEFib3J0KCkKIAogICAgIG1fZGVj b2RlciA9IG51bGxwdHI7CiAKLSAgICBpZiAobV90aW1lb3V0VGltZXIuaXNBY3RpdmUoKSkKLSAg ICAgICAgbV90aW1lb3V0VGltZXIuc3RvcCgpOworICAgIG1fdGltZW91dFRpbWVyLnN0b3AoKTsK IAogICAgIGlmICghbV9sb2FkZXIpCiAgICAgICAgIHJldHVybiB0cnVlOwpAQCAtMTEyMSw4ICsx MTIyLDcgQEAgdm9pZCBYTUxIdHRwUmVxdWVzdDo6ZGlkRmluaXNoTG9hZGluZyh1bgogICAgIG1f cmVzcG9uc2VFbmNvZGluZyA9IFN0cmluZygpOwogICAgIG1fZGVjb2RlciA9IG51bGxwdHI7CiAK LSAgICBpZiAobV90aW1lb3V0VGltZXIuaXNBY3RpdmUoKSkKLSAgICAgICAgbV90aW1lb3V0VGlt ZXIuc3RvcCgpOworICAgIG1fdGltZW91dFRpbWVyLnN0b3AoKTsKIAogICAgIGlmIChoYWRMb2Fk ZXIpCiAgICAgICAgIGRyb3BQcm90ZWN0aW9uKCk7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VM b2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxOTIxNzIp CisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBA QAorMjAxNS0xMS0wOSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3Jn PgorCisgICAgICAgIFhIUiB0aW1lb3V0cyBzaG91bGQgbm90IGZpcmUgaWYgdGhlcmUgaXMgYW4g aW1tZWRpYXRlIG5ldHdvcmsgZXJyb3IuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNTA1NzcKKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxl ci4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9uczoKKyAgICAg ICAgaHR0cC90ZXN0cy9jb250ZW50ZXh0ZW5zaW9ucy9hc3luYy14aHItb25lcnJvci5odG1sIHNo b3VsZG4ndCBiZSBmbGFreSBhbnkgbW9yZS4KKwogMjAxNS0xMS0wOSAgSmlld2VuIFRhbiAgPGpp ZXdlbl90YW5AYXBwbGUuY29tPgogCiAgICAgICAgIE51bGwgZGVyZWZlcmVuY2UgbG9hZGluZyBC bGluayBsYXlvdXQgdGVzdCBlZGl0aW5nL2luc2VydGluZy9pbnNlcnQtaHRtbC1jcmFzaC0wMS5o dG1sCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRp b25zCShyZXZpc2lvbiAxOTIxNjkpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rl c3RFeHBlY3RhdGlvbnMJKHdvcmtpbmcgY29weSkKQEAgLTI4Myw4ICsyODMsNiBAQCB3ZWJraXQu b3JnL2IvMTUwMzc4IGh0dHAvdGVzdHMveG1saHR0cHJlCiAKIHdlYmtpdC5vcmcvYi8xNTA3MzYg aHR0cC90ZXN0cy9ub3RpZmljYXRpb25zL2xlZ2FjeS9ldmVudHMuaHRtbCBbIFBhc3MgQ3Jhc2gg XQogCi13ZWJraXQub3JnL2IvMTUwNTc3IGh0dHAvdGVzdHMvY29udGVudGV4dGVuc2lvbnMvYXN5 bmMteGhyLW9uZXJyb3IuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCi0KIHdlYmtpdC5vcmcvYi8xNTA5 NDIgYW5pbWF0aW9ucy9tdWx0aXBsZS1iYWNrZ3JvdW5kcy5odG1sIFsgUGFzcyBJbWFnZU9ubHlG YWlsdXJlIF0KIAogIyMjIEVORCBPRiAoMSkgQ2xhc3NpZmllZCBmYWlsdXJlcyB3aXRoIGJ1ZyBy ZXBvcnRzCg==