150573 2015-10-26 14:27:32 -0700 Web Inspector: Spacebar to start recording should not cause system beep 2015-10-26 17:09:11 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev simon.fraser timothy webkit-bug-importer oldest_to_newest 1136634 0 joepeck 2015-10-26 14:27:32 -0700 * SUMMARY Spacebar to start recording should not cause system beep. * STEPS TO REPRODUCE 1. Open inspector 2. Show Timeline tab 3. Click "Spacebar" to start a recording => System Beep, as if nothing happened. Expected no beep, since it worked. 1136635 1 264076 joepeck 2015-10-26 14:28:45 -0700 Created attachment 264076 [PATCH] Proposed Fix 1136710 2 264076 commit-queue 2015-10-26 17:09:08 -0700 Comment on attachment 264076 [PATCH] Proposed Fix Clearing flags on attachment: 264076 Committed r191613: <http://trac.webkit.org/changeset/191613> 1136711 3 commit-queue 2015-10-26 17:09:11 -0700 All reviewed patches have been landed. Closing bug. 264076 2015-10-26 14:28:45 -0700 2015-10-26 17:09:08 -0700 [PATCH] Proposed Fix no-beep.patch text/plain 1896 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDIxZjQxMmIuLjYwODEwYTUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE1LTEwLTI2ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogU3BhY2Vi YXIgdG8gc3RhcnQgcmVjb3JkaW5nIHNob3VsZCBub3QgY2F1c2Ugc3lzdGVtIGJlZXAKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDU3MworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFj ZS9WaWV3cy9UaW1lbGluZVNpZGViYXJQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5U aW1lbGluZVNpZGViYXJQYW5lbC5wcm90b3R5cGUuX3RvZ2dsZVJlY29yZGluZ09uU3BhY2ViYXIp OgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lU2lkZWJhclBhbmVsLnByb3RvdHlwZS5f dG9nZ2xlTmV3UmVjb3JkaW5nT25TcGFjZWJhcik6CisgICAgICAgIFRoZSBrZXlib2FyZCBzaG9y dGN1dHMgZG8gbm90IGltcGxpY2l0bHkgcHJldmVudCBkZWZhdWx0IGJlY2F1c2UgdGhleSBtYXkg YmFpbC4KKyAgICAgICAgU28gaW4gY2FzZXMgd2hlcmUgdGhleSBkbyBoYW5kbGUgdGhlIGtleSwg cHJldmVudCBkZWZhdWx0IHRvIHByZXZlbnQgc3lzdGVtIGJlZXBzLgorCisyMDE1LTEwLTI2ICBK b3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3Bl Y3RvcjogVGltZWxpbmUgY3VycmVudCB0aW1lIG1hcmtlciBkb2VzIG5vdCBzdGFydCBtb3Zpbmcg d2hlbiBzdGFydGluZyByZWNvcmRpbmcgYWZ0ZXIganVzdCBvcGVuaW5nIGluc3BlY3RvcgogICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwMTc4CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVs aW5lU2lkZWJhclBhbmVsLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvVGltZWxpbmVTaWRlYmFyUGFuZWwuanMKaW5kZXggNDUxYjdlYi4uNDU0ZGY0NyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxp bmVTaWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvVGltZWxpbmVTaWRlYmFyUGFuZWwuanMKQEAgLTUzMiw2ICs1MzIsOCBAQCBXZWJJ bnNwZWN0b3IuVGltZWxpbmVTaWRlYmFyUGFuZWwgPSBjbGFzcyBUaW1lbGluZVNpZGViYXJQYW5l bCBleHRlbmRzIFdlYkluc3BlYwogICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgIHRoaXMu X3RvZ2dsZVJlY29yZGluZygpOworCisgICAgICAgIGV2ZW50LnByZXZlbnREZWZhdWx0KCk7CiAg ICAgfQogCiAgICAgX3RvZ2dsZU5ld1JlY29yZGluZ09uU3BhY2ViYXIoZXZlbnQpCkBAIC01NDAs NiArNTQyLDggQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lU2lkZWJhclBhbmVsID0gY2xhc3MgVGlt ZWxpbmVTaWRlYmFyUGFuZWwgZXh0ZW5kcyBXZWJJbnNwZWMKICAgICAgICAgICAgIHJldHVybjsK IAogICAgICAgICB0aGlzLl90b2dnbGVSZWNvcmRpbmcodHJ1ZSk7CisKKyAgICAgICAgZXZlbnQu cHJldmVudERlZmF1bHQoKTsKICAgICB9CiAKICAgICBfdG9nZ2xlUmVjb3JkaW5nKHNob3VsZENy ZWF0ZVJlY29yZGluZykK