150568 2015-10-26 12:12:24 -0700 Web Inspector: Hundreds of failed assertions after switching to Rendering Frames after recording complete 2015-10-26 17:12:35 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1136587 0 mattbaker 2015-10-26 12:12:24 -0700 * SUMMARY Hundreds of failed assertions switch to Rendering Frames after recording complete. * STEPS TO REPRODUCE 1. Open Inspector -> Timelines 2. Select Timelines view, rather than Rendering Frames 3. Reload page to record data 4. Once recording completes, switch to frames timeline => Inspector² shows hundreds of failed assertions in TimelineRecord.recordWasFiltered. 1136588 1 webkit-bug-importer 2015-10-26 12:13:01 -0700 <rdar://problem/23261902> 1136622 2 264071 mattbaker 2015-10-26 13:33:23 -0700 Created attachment 264071 [Patch] Proposed Fix 1136713 3 264071 commit-queue 2015-10-26 17:12:32 -0700 Comment on attachment 264071 [Patch] Proposed Fix Clearing flags on attachment: 264071 Committed r191614: <http://trac.webkit.org/changeset/191614> 1136714 4 commit-queue 2015-10-26 17:12:35 -0700 All reviewed patches have been landed. Closing bug. 264071 2015-10-26 13:33:23 -0700 2015-10-26 17:12:32 -0700 [Patch] Proposed Fix bug-150568-20151026133235.patch text/plain 4367 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxNTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA2 MTlkMzljOGFiYTkyZTlhZjBlNmFkNWQwNzEwYTA1Mjg5OGQ5ZDU0Li4zYzJhYjI4ZjgyNjc2OGNi ZDdjNzFlMDhmMzNlY2IxMGNhOGNmNzQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxNS0xMC0yNiAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogSHVuZHJlZHMgb2YgZmFpbGVkIGFzc2VydGlvbnMg YWZ0ZXIgc3dpdGNoaW5nIHRvIFJlbmRlcmluZyBGcmFtZXMgYWZ0ZXIgcmVjb3JkaW5nIGNvbXBs ZXRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTA1 NjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVu IHRoZSBUaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3IHJlc3BvbmRzIHRvIHRoZSBjdXJyZW50 IGNvbnRlbnQgdmlldyBjaGFuZ2luZywKKyAgICAgICAgdGhlIFRpbWVsaW5lT3ZlcnZpZXcgbWF5 IGJlIHN3YXBwZWQgb3V0IChpZiBzd2l0Y2hpbmcgZnJvbSBhIFRpbWVsaW5lcyBjb250ZW50IHZp ZXcgdG8gYQorICAgICAgICBSZW5kZXJpbmcgRnJhbWVzIGNvbnRlbnQgdmlldykuIFRoaXMgcGF0 Y2ggaW5zdGFsbHMgYSBuZXcgb3ZlcnZpZXcgKGlmIGl0J3MgY2hhbmdpbmcpIHByaW9yCisgICAg ICAgIHRvIHNldHRpbmcgdGhlIFRpbWVsaW5lU2lkZWJhclBhbmVsJ3MgdHJlZSBvdXRsaW5lLCBh cyBzZXR0aW5nIHRoZSB0cmVlIG91dGxpbmUgZm9yY2VzCisgICAgICAgIGZpbHRlcnMgdG8gcnVu LgorCisgICAgICAgIEZpbHRlcmluZyB0cmVlIGVsZW1lbnRzIHJlcXVpcmVzIHRoYXQgdGhlIHRp bWVsaW5lIG92ZXJ2aWV3IGlzIHVwIHRvIGRhdGUsIHdoaWNoIHdhcyB0aGUKKyAgICAgICAgY2F1 c2UgdGhlIGFzc2VydGlvbiBkZWx1Z2UuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdz L1RpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu VGltZWxpbmVSZWNvcmRpbmdDb250ZW50Vmlldy5wcm90b3R5cGUuX2N1cnJlbnRDb250ZW50Vmll d0RpZENoYW5nZSk6CisKIDIwMTUtMTAtMjQgIE5pa2l0YSBWYXNpbHlldiAgPG52YXNpbHlldkBh cHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjE5MTQxOS4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVs aW5lUmVjb3JkaW5nQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9UaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3LmpzCmluZGV4IDU2MjZl OGY2N2YxNzEwNDUyOWI1NmMzNDdhZDZlMGQ3NmZlMjRkZWEuLjAxY2VlNGZhMDNjYzhkODYwYzUx ZmI2ODhlMzg2NTA1YjcxMzVhMDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcuanMKKysrIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVSZWNvcmRp bmdDb250ZW50Vmlldy5qcwpAQCAtMzI4LDIwICszMjgsMTIgQEAgV2ViSW5zcGVjdG9yLlRpbWVs aW5lUmVjb3JkaW5nQ29udGVudFZpZXcgPSBjbGFzcyBUaW1lbGluZVJlY29yZGluZ0NvbnRlbnRW aWV3IGUKIAogICAgIF9jdXJyZW50Q29udGVudFZpZXdEaWRDaGFuZ2UoZXZlbnQpCiAgICAgewot ICAgICAgICB2YXIgbmV3VGltZWxpbmVPdmVydmlldyA9IHRoaXMuX2xpbmVhclRpbWVsaW5lT3Zl cnZpZXc7Ci0gICAgICAgIHZhciB0aW1lbGluZVZpZXcgPSB0aGlzLmN1cnJlbnRUaW1lbGluZVZp ZXc7Ci0gICAgICAgIGlmICh0aW1lbGluZVZpZXcpIHsKLSAgICAgICAgICAgIHRoaXMuX3RpbWVs aW5lU2lkZWJhclBhbmVsLmNvbnRlbnRUcmVlT3V0bGluZSA9IHRpbWVsaW5lVmlldy5uYXZpZ2F0 aW9uU2lkZWJhclRyZWVPdXRsaW5lOwotICAgICAgICAgICAgdGhpcy5fdGltZWxpbmVTaWRlYmFy UGFuZWwuY29udGVudFRyZWVPdXRsaW5lTGFiZWwgPSB0aW1lbGluZVZpZXcubmF2aWdhdGlvblNp ZGViYXJUcmVlT3V0bGluZUxhYmVsOwotICAgICAgICAgICAgdGhpcy5fdGltZWxpbmVTaWRlYmFy UGFuZWwuY29udGVudFRyZWVPdXRsaW5lU2NvcGVCYXIgPSB0aW1lbGluZVZpZXcubmF2aWdhdGlv blNpZGViYXJUcmVlT3V0bGluZVNjb3BlQmFyOwotCi0gICAgICAgICAgICBpZiAodGltZWxpbmVW aWV3LnJlcHJlc2VudGVkT2JqZWN0LnR5cGUgPT09IFdlYkluc3BlY3Rvci5UaW1lbGluZVJlY29y ZC5UeXBlLlJlbmRlcmluZ0ZyYW1lKQotICAgICAgICAgICAgICAgIG5ld1RpbWVsaW5lT3ZlcnZp ZXcgPSB0aGlzLl9yZW5kZXJpbmdGcmFtZVRpbWVsaW5lT3ZlcnZpZXc7Ci0KLSAgICAgICAgICAg IHRpbWVsaW5lVmlldy5zdGFydFRpbWUgPSBuZXdUaW1lbGluZU92ZXJ2aWV3LnNlbGVjdGlvblN0 YXJ0VGltZTsKLSAgICAgICAgICAgIHRpbWVsaW5lVmlldy5lbmRUaW1lID0gbmV3VGltZWxpbmVP dmVydmlldy5zZWxlY3Rpb25TdGFydFRpbWUgKyBuZXdUaW1lbGluZU92ZXJ2aWV3LnNlbGVjdGlv bkR1cmF0aW9uOwotICAgICAgICAgICAgdGltZWxpbmVWaWV3LmN1cnJlbnRUaW1lID0gdGhpcy5f Y3VycmVudFRpbWU7Ci0gICAgICAgIH0KKyAgICAgICAgbGV0IG5ld1RpbWVsaW5lT3ZlcnZpZXc7 CisgICAgICAgIGxldCB0aW1lbGluZVZpZXcgPSB0aGlzLmN1cnJlbnRUaW1lbGluZVZpZXc7Cisg ICAgICAgIGlmICh0aW1lbGluZVZpZXcgJiYgdGltZWxpbmVWaWV3LnJlcHJlc2VudGVkT2JqZWN0 LnR5cGUgPT09IFdlYkluc3BlY3Rvci5UaW1lbGluZVJlY29yZC5UeXBlLlJlbmRlcmluZ0ZyYW1l KQorICAgICAgICAgICAgbmV3VGltZWxpbmVPdmVydmlldyA9IHRoaXMuX3JlbmRlcmluZ0ZyYW1l VGltZWxpbmVPdmVydmlldzsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgbmV3VGltZWxpbmVP dmVydmlldyA9IHRoaXMuX2xpbmVhclRpbWVsaW5lT3ZlcnZpZXc7CiAKICAgICAgICAgaWYgKG5l d1RpbWVsaW5lT3ZlcnZpZXcgIT09IHRoaXMuX2N1cnJlbnRUaW1lbGluZU92ZXJ2aWV3KSB7CiAg ICAgICAgICAgICB0aGlzLl9jdXJyZW50VGltZWxpbmVPdmVydmlldy5oaWRkZW4oKTsKQEAgLTM1 NSw2ICszNDcsMTYgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcg PSBjbGFzcyBUaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3IGUKICAgICAgICAgICAgIHRoaXMu X3VwZGF0ZVRpbWVsaW5lT3ZlcnZpZXdIZWlnaHQoKTsKICAgICAgICAgfQogCisgICAgICAgIGlm ICh0aW1lbGluZVZpZXcpIHsKKyAgICAgICAgICAgIHRoaXMuX3RpbWVsaW5lU2lkZWJhclBhbmVs LmNvbnRlbnRUcmVlT3V0bGluZSA9IHRpbWVsaW5lVmlldy5uYXZpZ2F0aW9uU2lkZWJhclRyZWVP dXRsaW5lOworICAgICAgICAgICAgdGhpcy5fdGltZWxpbmVTaWRlYmFyUGFuZWwuY29udGVudFRy ZWVPdXRsaW5lTGFiZWwgPSB0aW1lbGluZVZpZXcubmF2aWdhdGlvblNpZGViYXJUcmVlT3V0bGlu ZUxhYmVsOworICAgICAgICAgICAgdGhpcy5fdGltZWxpbmVTaWRlYmFyUGFuZWwuY29udGVudFRy ZWVPdXRsaW5lU2NvcGVCYXIgPSB0aW1lbGluZVZpZXcubmF2aWdhdGlvblNpZGViYXJUcmVlT3V0 bGluZVNjb3BlQmFyOworCisgICAgICAgICAgICB0aW1lbGluZVZpZXcuc3RhcnRUaW1lID0gbmV3 VGltZWxpbmVPdmVydmlldy5zZWxlY3Rpb25TdGFydFRpbWU7CisgICAgICAgICAgICB0aW1lbGlu ZVZpZXcuZW5kVGltZSA9IG5ld1RpbWVsaW5lT3ZlcnZpZXcuc2VsZWN0aW9uU3RhcnRUaW1lICsg bmV3VGltZWxpbmVPdmVydmlldy5zZWxlY3Rpb25EdXJhdGlvbjsKKyAgICAgICAgICAgIHRpbWVs aW5lVmlldy5jdXJyZW50VGltZSA9IHRoaXMuX2N1cnJlbnRUaW1lOworICAgICAgICB9CisKICAg ICAgICAgdGhpcy5kaXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMoV2ViSW5zcGVjdG9yLkNvbnRlbnRW aWV3LkV2ZW50LlNlbGVjdGlvblBhdGhDb21wb25lbnRzRGlkQ2hhbmdlKTsKICAgICAgICAgdGhp cy5kaXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMoV2ViSW5zcGVjdG9yLkNvbnRlbnRWaWV3LkV2ZW50 Lk5hdmlnYXRpb25JdGVtc0RpZENoYW5nZSk7CiAgICAgfQo=