150558 2015-10-26 09:25:06 -0700 [GTK] Allow applications to force Accelerated Compositing mode 2016-02-11 18:32:56 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=154147 Gtk P2 Normal --- 1 mario webkit-unassigned bugs-noreply cgarcia commit-queue mcatanzaro mrobinson tpopela oldest_to_newest 1136526 0 mario 2015-10-26 09:25:06 -0700 As discussed in the mailing list [1], it would be nice in some cases to have a way to tell WebKit to have AC mode enabled all the time, avoiding it to having it repeateadly leaving/re-entering AC mode whenever the conditions that need to be fulfilled change. Originally proposed as a public API, that's perhaps too much, so perhaps something simpler like recognizing a environment variable WEBKIT_FORCE_ACCELERATED_COMPOSITING would be a better option. [1] https://lists.webkit.org/pipermail/webkit-gtk/2015-October/002448.html 1136788 1 tpopela 2015-10-27 01:59:29 -0700 (In reply to comment #0) > Originally proposed as a public API, that's perhaps too much, so perhaps > something simpler like recognizing a environment variable > WEBKIT_FORCE_ACCELERATED_COMPOSITING would be a better option. Wouldn't be better to use WEBKITGTK_ instead of WEBKIT_ as we are not the only WebKit port there.. 1137492 2 mario 2015-10-29 03:47:25 -0700 (In reply to comment #1) > (In reply to comment #0) > > Originally proposed as a public API, that's perhaps too much, so perhaps > > something simpler like recognizing a environment variable > > WEBKIT_FORCE_ACCELERATED_COMPOSITING would be a better option. > > Wouldn't be better to use WEBKITGTK_ instead of WEBKIT_ as we are not the > only WebKit port there.. I don't have a strong opinion on this, but I think WEBKIT_ is the correct prefix here, as this causes a change in behaviour at the level of WebCore, I think, and not just in the port-specific bits. 1137497 3 cgarcia 2015-10-29 04:23:02 -0700 We already use WEBKIT for other thinks like WEBKIT_INSPECTOR_SERVER for example. I don't think that would conflict with any other port installed anyway, since you set the variable per program, but even if it's in your env, other ports will just ignore it. 1146812 4 266764 mario 2015-12-07 03:23:52 -0800 Created attachment 266764 Patch proposal Attached patch proposal. I've tested this locally and seems to work as expected. Please review, thanks! 1146849 5 266764 commit-queue 2015-12-07 08:24:20 -0800 Comment on attachment 266764 Patch proposal Clearing flags on attachment: 266764 Committed r193626: <http://trac.webkit.org/changeset/193626> 1146850 6 commit-queue 2015-12-07 08:24:24 -0800 All reviewed patches have been landed. Closing bug. 266764 2015-12-07 03:23:52 -0800 2015-12-07 08:24:20 -0800 Patch proposal 0001-2015-12-07-Mario-Sanchez-Prada-mario-endlessm.com.patch text/plain 2581 mario RnJvbSAwNzAyZDc4MTRmODlmMDcyZGNjNzk5NDFmYWRiMzFjYmIwNTI4YjI4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtYXJpb0B3ZWJraXQub3Jn PgpEYXRlOiBNb24sIDcgRGVjIDIwMTUgMTI6MjE6MzcgKzAxMDAKU3ViamVjdDogW1BBVENIXSAy MDE1LTEyLTA3ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bWFyaW9AZW5kbGVzc20uY29tPgoKICAg ICAgICBbR1RLXSBBbGxvdyBhcHBsaWNhdGlvbnMgdG8gZm9yY2UgQWNjZWxlcmF0ZWQgQ29tcG9z aXRpbmcgbW9kZQogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNTA1NTgKCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIEVu YWJsZSBmb3JjaW5nIEFjY2VsZXJhdGVkIENvbXBvc2l0aW5nIG1vZGUgdG8gYmUgYWx3YXlzIG9u IGlmCiAgICAgICAgYSBXRUJLSVRfRk9SQ0VfQ09NUE9TSVRJTkdfTU9ERSBlbnZpcm9ubWVudCB2 YXJpYWJsZSBpcyBzZXQuCgogICAgICAgIFRoaXMgY2FuIGJlIHVzZWZ1bCBmb3IgY29udHJvbGxl ZCBlbnZpcm9ubWVudHMgd2hlcmUgd2Uga25vdyB0aGF0CiAgICAgICAgQUMgYWx3YXlzIG9uIHdv cmtzIHdlbGwgZW5vdWdoLCB0byBnZXQgc21vb3RoZXIgYW5pbWF0aW9ucy4KCiAgICAgICAgKiBV SVByb2Nlc3MvZ3RrL1dlYlByZWZlcmVuY2VzR3RrLmNwcDoKICAgICAgICAoV2ViS2l0OjpXZWJQ cmVmZXJlbmNlczo6cGxhdGZvcm1Jbml0aWFsaXplU3RvcmUpOiBTZXQgZm9yY2VDb21wb3NpdGlu Z01vZGUKICAgICAgICBzZXR0aW5nIHRvIHRydWUgaWYgdGhlIGVudmlyb25tZW50IHZhcmlhYmxl IGlzIGZvdW5kLgotLS0KIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAg ICAgICAgICAgIHwgMTcgKysrKysrKysrKysrKysrKysKIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9ndGsvV2ViUHJlZmVyZW5jZXNHdGsuY3BwIHwgIDMgKysrCiAyIGZpbGVzIGNoYW5nZWQsIDIw IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNDgzNmQxMS4uNzA0NzI4ZiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTEyLTA3ICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bWFy aW9AZW5kbGVzc20uY29tPgorCisgICAgICAgIFtHVEtdIEFsbG93IGFwcGxpY2F0aW9ucyB0byBm b3JjZSBBY2NlbGVyYXRlZCBDb21wb3NpdGluZyBtb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTA1NTgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbmFibGUgZm9yY2luZyBBY2NlbGVyYXRlZCBDb21w b3NpdGluZyBtb2RlIHRvIGJlIGFsd2F5cyBvbiBpZgorICAgICAgICBhIFdFQktJVF9GT1JDRV9D T01QT1NJVElOR19NT0RFIGVudmlyb25tZW50IHZhcmlhYmxlIGlzIHNldC4KKworICAgICAgICBU aGlzIGNhbiBiZSB1c2VmdWwgZm9yIGNvbnRyb2xsZWQgZW52aXJvbm1lbnRzIHdoZXJlIHdlIGtu b3cgdGhhdAorICAgICAgICBBQyBhbHdheXMgb24gd29ya3Mgd2VsbCBlbm91Z2gsIHRvIGdldCBz bW9vdGhlciBhbmltYXRpb25zLgorCisgICAgICAgICogVUlQcm9jZXNzL2d0ay9XZWJQcmVmZXJl bmNlc0d0ay5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlByZWZlcmVuY2VzOjpwbGF0Zm9ybUlu aXRpYWxpemVTdG9yZSk6IFNldCBmb3JjZUNvbXBvc2l0aW5nTW9kZQorICAgICAgICBzZXR0aW5n IHRvIHRydWUgaWYgdGhlIGVudmlyb25tZW50IHZhcmlhYmxlIGlzIGZvdW5kLgorCiAyMDE1LTEy LTA3ICBKYWVodW4gTGltICA8bGphZWh1bi5saW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VG TF0gTW92aW5nIHByZWZlcmVuY2Ugc2V0dGluZ3MgZnJvbSBFd2tWaWV3IHRvIFdlYlByZWZlcmVu Y2VzRWZsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYlByZWZl cmVuY2VzR3RrLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvV2ViUHJlZmVyZW5j ZXNHdGsuY3BwCmluZGV4IDFjZGYwN2MuLmU0YTBiN2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9ndGsvV2ViUHJlZmVyZW5jZXNHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9ndGsvV2ViUHJlZmVyZW5jZXNHdGsuY3BwCkBAIC00NSw2ICs0NSw5IEBA IHZvaWQgV2ViUHJlZmVyZW5jZXM6OnBsYXRmb3JtSW5pdGlhbGl6ZVN0b3JlKCkKICNlbmRpZgog I2lmICFFTkFCTEUoT1BFTkdMKQogICAgIHNldEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdFbmFibGVk KGZhbHNlKTsKKyNlbHNlCisgICAgaWYgKGdldGVudigiV0VCS0lUX0ZPUkNFX0NPTVBPU0lUSU5H X01PREUiKSkKKyAgICAgICAgc2V0Rm9yY2VDb21wb3NpdGluZ01vZGUodHJ1ZSk7CiAjZW5kaWYK IH0KIAotLSAKMi41LjAKCg==