150520 2015-10-23 16:59:31 -0700 Fix CMake compile error and add correct null check 2015-10-26 10:24:04 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen commit-queue oldest_to_newest 1136184 0 achristensen 2015-10-23 16:59:31 -0700 Fix CMake compile error and add correct null check 1136185 1 263961 achristensen 2015-10-23 16:59:49 -0700 Created attachment 263961 Patch 1136219 2 263961 commit-queue 2015-10-23 18:12:20 -0700 Comment on attachment 263961 Patch Clearing flags on attachment: 263961 Committed r191528: <http://trac.webkit.org/changeset/191528> 1136220 3 commit-queue 2015-10-23 18:12:24 -0700 All reviewed patches have been landed. Closing bug. 1136283 4 263961 darin 2015-10-24 13:47:04 -0700 Comment on attachment 263961 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263961&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:3217 > - typeof(updateBlock) updateBlockCopy = nil; > + void (^updateBlockCopy)(void) = nil; How is this a “CMake” compile error? Since CMake is not a C compiler, I don’t understand how using CMake causes this to be a compile error when it’s not an error without CMake. Is CMake passing different options to clang? Also, I suggest using auto instead of what we did here. 1136547 5 achristensen 2015-10-26 10:24:04 -0700 (In reply to comment #4) > Comment on attachment 263961 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=263961&action=review > > > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:3217 > > - typeof(updateBlock) updateBlockCopy = nil; > > + void (^updateBlockCopy)(void) = nil; > > How is this a “CMake” compile error? Since CMake is not a C compiler, I > don’t understand how using CMake causes this to be a compile error when it’s > not an error without CMake. Is CMake passing different options to clang? Yes, CMake is currently passing different compile flags, and I'm not sure why this doesn't compile, but with typeof(updateBlock) as the variable type it has unrecognized identifier syntax errors. > > Also, I suggest using auto instead of what we did here. Good idea! 263961 2015-10-23 16:59:49 -0700 2015-10-23 18:12:20 -0700 Patch bug-150520-20151023165903.patch text/plain 1569 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MTUxOCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE1LTEwLTIzICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IENNYWtl IGNvbXBpbGUgZXJyb3IgYW5kIGFkZCBjb3JyZWN0IG51bGwgY2hlY2sKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDUyMAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9X S1dlYlZpZXcubW06CisgICAgICAgICgtW1dLV2ViVmlldyBfZG9BZnRlck5leHRQcmVzZW50YXRp b25VcGRhdGU6XSk6CisKIDIwMTUtMTAtMjMgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5z ZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBQcm9ncmVzcyB0b3dhcmRzIENNYWtlIG9uIE1hYwpJ bmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcu bW0JKHJldmlzaW9uIDE5MTUxOCkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29j b2EvV0tXZWJWaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zMjE0LDEzICszMjE0LDE1IEBAIC0g KENHUG9pbnQpX2NvbnZlcnRQb2ludEZyb21WaWV3VG9Db250ZW4KIC8vIEV4ZWN1dGUgdGhlIHN1 cHBsaWVkIGJsb2NrIGFmdGVyIHRoZSBuZXh0IHRyYW5zYWN0aW9uIGZyb20gdGhlIFdlYlByb2Nl c3MuCiAtICh2b2lkKV9kb0FmdGVyTmV4dFByZXNlbnRhdGlvblVwZGF0ZToodm9pZCAoXikodm9p ZCkpdXBkYXRlQmxvY2sKIHsKLSAgICB0eXBlb2YodXBkYXRlQmxvY2spIHVwZGF0ZUJsb2NrQ29w eSA9IG5pbDsKKyAgICB2b2lkIChedXBkYXRlQmxvY2tDb3B5KSh2b2lkKSA9IG5pbDsKICAgICBp ZiAodXBkYXRlQmxvY2spCiAgICAgICAgIHVwZGF0ZUJsb2NrQ29weSA9IEJsb2NrX2NvcHkodXBk YXRlQmxvY2spOwogCiAgICAgX3BhZ2UtPmNhbGxBZnRlck5leHRQcmVzZW50YXRpb25VcGRhdGUo W3VwZGF0ZUJsb2NrQ29weV0oV2ViS2l0OjpDYWxsYmFja0Jhc2U6OkVycm9yIGVycm9yKSB7Ci0g ICAgICAgIHVwZGF0ZUJsb2NrQ29weSgpOwotICAgICAgICBCbG9ja19yZWxlYXNlKHVwZGF0ZUJs b2NrQ29weSk7CisgICAgICAgIGlmICh1cGRhdGVCbG9ja0NvcHkpIHsKKyAgICAgICAgICAgIHVw ZGF0ZUJsb2NrQ29weSgpOworICAgICAgICAgICAgQmxvY2tfcmVsZWFzZSh1cGRhdGVCbG9ja0Nv cHkpOworICAgICAgICB9CiAgICAgfSk7CiB9CiAK