150514 2015-10-23 15:02:09 -0700 Remove unnecessary details from Other Crashes section 2017-03-15 17:17:15 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain ap commit-queue lforschler oldest_to_newest 1136146 0 aakash_jain 2015-10-23 15:02:09 -0700 Please remove sections like "history", "sample" and trac link from Other Crashes as they are not relevant for other crashes (they are relevant only for tests). 1136148 1 263948 aakash_jain 2015-10-23 15:08:38 -0700 Created attachment 263948 Proposed patch 1136161 2 263948 ap 2015-10-23 16:05:09 -0700 Comment on attachment 263948 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=263948&action=review I wonder if we can further simplify the json format now, getting rid of an empty dictionary. > LayoutTests/fast/harness/results.html:779 > + if (tableId == 'passes-table') { > + html += testLink(test); > + } else if (tableId == 'other-crash-tests-table') { The WebKit style is to not have braces around single-line code blocks. 1136172 3 ap 2015-10-23 16:42:02 -0700 <rdar://problem/23235458> 1136179 4 263958 aakash_jain 2015-10-23 16:53:41 -0700 Created attachment 263958 Updated patch Updated the style. This patch helps little bit towards ability to further simplify json, but more changes (both in javascript and webkitpy) would be required for that. I would work on that in separate patch. 1136207 5 263958 commit-queue 2015-10-23 17:46:50 -0700 Comment on attachment 263958 Updated patch Clearing flags on attachment: 263958 Committed r191524: <http://trac.webkit.org/changeset/191524> 1136208 6 commit-queue 2015-10-23 17:46:53 -0700 All reviewed patches have been landed. Closing bug. 263948 2015-10-23 15:08:38 -0700 2015-10-23 16:53:41 -0700 Proposed patch patch_other_crash_table.txt text/plain 3641 aakash_jain SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE5MTUxMikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE1LTEwLTIzICBBYWthc2ggSmFpbiAgPGFh a2FzaF9qYWluQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgdW5uZWNlc3NhcnkgZGV0YWls cyBmcm9tIE90aGVyIENyYXNoZXMgc2VjdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwNTE0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yMzIz NTQ1OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGZhc3QvaGFybmVzcy9yZXN1bHRzLmh0bWw6IENyZWF0ZSBzZXBhcmF0ZSBvdGhlci1jcmFzaC10 ZXN0cy10YWJsZS4KKwogMjAxNS0xMC0yMyAgUm9vcGVzaCBDaGFuZGVyICA8cm9vcEByb29wYy5u ZXQ+CiAKICAgICAgICAgW0NvbnRlbnQgRXh0ZW5zaW9uc10gQWRkIHRlc3QgZm9yIGhpZGluZyBj b250ZW50IG9uIDxhIHBpbmc+IHBpbmdzCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2hhcm5lc3Mv cmVzdWx0cy5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvaGFybmVzcy9yZXN1 bHRzLmh0bWwJKHJldmlzaW9uIDE5MTUxMikKKysrIExheW91dFRlc3RzL2Zhc3QvaGFybmVzcy9y ZXN1bHRzLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTQ5NCw2ICs0OTQsMTEgQEAgZnVuY3Rpb24g dGVzdExpbmtXaXRoRXhwYW5kQnV0dG9uKHRlc3QpCiAgICAgcmV0dXJuICc8c3BhbiBjbGFzcz1l eHBhbmQtYnV0dG9uIG9uY2xpY2s9InRvZ2dsZUV4cGVjdGF0aW9ucyh0aGlzKSI+PHNwYW4gY2xh c3M9ZXhwYW5kLWJ1dHRvbi10ZXh0Pis8L3NwYW4+PC9zcGFuPicgKyB0ZXN0TGluayh0ZXN0KTsK IH0KIAorZnVuY3Rpb24gdGVzdFdpdGhFeHBhbmRCdXR0b24odGVzdCkKK3sKKyAgICByZXR1cm4g JzxzcGFuIGNsYXNzPWV4cGFuZC1idXR0b24gb25jbGljaz0idG9nZ2xlRXhwZWN0YXRpb25zKHRo aXMpIj48c3BhbiBjbGFzcz1leHBhbmQtYnV0dG9uLXRleHQ+Kzwvc3Bhbj48L3NwYW4+JyArIHRl c3Q7Cit9CisKIGZ1bmN0aW9uIHJlc3VsdExpbmsodGVzdFByZWZpeCwgc3VmZml4LCBjb250ZW50 cykKIHsKICAgICByZXR1cm4gJzxhIGNsYXNzPXJlc3VsdC1saW5rIGhyZWY9IicgKyB0ZXN0UHJl Zml4ICsgc3VmZml4ICsgJyIgZGF0YS1wcmVmaXg9IicgKyB0ZXN0UHJlZml4ICsgJyI+JyArIGNv bnRlbnRzICsgJzwvYT4gJzsKQEAgLTc2OSw3ICs3NzQsMTMgQEAgZnVuY3Rpb24gdGVzdExpc3Qo dGVzdHMsIGhlYWRlciwgdGFibGVJZAogICAgICAgICBpZiAoZ2xvYmFsU3RhdGUoKS5yZXN1bHRz LnVzZXNfZXhwZWN0YXRpb25zX2ZpbGUpCiAgICAgICAgICAgICBodG1sICs9ICcgY2xhc3M9Iicg KyAoKHRlc3RPYmplY3QuaXNFeHBlY3RlZCAmJiB0YWJsZUlkICE9ICdzdGRlcnItdGFibGUnKSA/ ICdleHBlY3RlZCcgOiAnJykgKyAnIic7CiAgICAgICAgIGh0bWwgKz0gJz48dHI+PHRkPic7Ci0g ICAgICAgIGh0bWwgKz0gKHRhYmxlSWQgPT0gJ3Bhc3Nlcy10YWJsZScpID8gdGVzdExpbmsodGVz dCkgOiB0ZXN0TGlua1dpdGhFeHBhbmRCdXR0b24odGVzdCk7CisgICAgICAgIGlmICh0YWJsZUlk ID09ICdwYXNzZXMtdGFibGUnKSB7CisgICAgICAgICAgICBodG1sICs9IHRlc3RMaW5rKHRlc3Qp OworICAgICAgICB9IGVsc2UgaWYgKHRhYmxlSWQgPT0gJ290aGVyLWNyYXNoLXRlc3RzLXRhYmxl JykgeworICAgICAgICAgICAgaHRtbCArPSB0ZXN0V2l0aEV4cGFuZEJ1dHRvbih0ZXN0KTsKKyAg ICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIGh0bWwgKz0gdGVzdExpbmtXaXRoRXhwYW5kQnV0 dG9uKHRlc3QpOworICAgICAgICB9CiAgICAgICAgIGh0bWwgKz0gJzwvdGQ+PHRkPic7CiAKICAg ICAgICAgaWYgKHRhYmxlSWQgPT0gJ3N0ZGVyci10YWJsZScpCkBAIC03NzksMTIgKzc5MCwxNSBA QCBmdW5jdGlvbiB0ZXN0TGlzdCh0ZXN0cywgaGVhZGVyLCB0YWJsZUlkCiAgICAgICAgIGVsc2Ug aWYgKHRhYmxlSWQgPT0gJ2NyYXNoLXRlc3RzLXRhYmxlJykgewogICAgICAgICAgICAgaHRtbCAr PSByZXN1bHRMaW5rKHN0cmlwRXh0ZW5zaW9uKHRlc3QpLCAnLWNyYXNoLWxvZy50eHQnLCAnY3Jh c2ggbG9nJyk7CiAgICAgICAgICAgICBodG1sICs9IHJlc3VsdExpbmsoc3RyaXBFeHRlbnNpb24o dGVzdCksICctc2FtcGxlLnR4dCcsICdzYW1wbGUnKTsKKyAgICAgICAgfSBlbHNlIGlmICh0YWJs ZUlkID09ICdvdGhlci1jcmFzaC10ZXN0cy10YWJsZScpIHsKKyAgICAgICAgICAgIGh0bWwgKz0g cmVzdWx0TGluayhzdHJpcEV4dGVuc2lvbih0ZXN0KSwgJy1jcmFzaC1sb2cudHh0JywgJ2NyYXNo IGxvZycpOwogICAgICAgICB9IGVsc2UgaWYgKHRhYmxlSWQgPT0gJ3RpbWVvdXQtdGVzdHMtdGFi bGUnKSB7CiAgICAgICAgICAgICAvLyBGSVhNRTogb25seSBpbmNsdWRlIHRpbWVvdXQgYWN0dWFs L2RpZmYgcmVzdWx0cyBoZXJlIGlmIHdlIGFjdHVhbGx5IHNwaXQgb3V0IHJlc3VsdHMgZm9yIHRp bWVvdXQgdGVzdHMuCiAgICAgICAgICAgICBodG1sICs9IHRleHRSZXN1bHRMaW5rcyhzdHJpcEV4 dGVuc2lvbih0ZXN0KSk7CiAgICAgICAgIH0KIAotICAgICAgICBodG1sICs9ICc8L3RkPjx0ZD48 YSBocmVmPSInICsgZmxha2luZXNzRGFzaGJvYXJkVVJMRm9yVGVzdHMoW3Rlc3RPYmplY3RdKSAr ICciPmhpc3Rvcnk8L2E+PC90ZD4nOworICAgICAgICBpZiAodGFibGVJZCAhPSAnb3RoZXItY3Jh c2gtdGVzdHMtdGFibGUnKQorICAgICAgICAgICAgaHRtbCArPSAnPC90ZD48dGQ+PGEgaHJlZj0i JyArIGZsYWtpbmVzc0Rhc2hib2FyZFVSTEZvclRlc3RzKFt0ZXN0T2JqZWN0XSkgKyAnIj5oaXN0 b3J5PC9hPjwvdGQ+JzsKIAogICAgICAgICBodG1sICs9ICc8L3RyPjwvdGJvZHk+JzsKICAgICB9 CkBAIC0xMzg2LDcgKzE0MDAsNyBAQCBmdW5jdGlvbiBnZW5lcmF0ZVBhZ2UoKQogICAgICAgICBo dG1sICs9IHRlc3RMaXN0KGdsb2JhbFN0YXRlKCkuY3Jhc2hUZXN0cywgJ1Rlc3RzIHRoYXQgY3Jh c2hlZCcsICdjcmFzaC10ZXN0cy10YWJsZScpOwogCiAgICAgaWYgKGdsb2JhbFN0YXRlKCkuY3Jh c2hPdGhlci5sZW5ndGgpCi0gICAgICAgIGh0bWwgKz0gdGVzdExpc3QoZ2xvYmFsU3RhdGUoKS5j cmFzaE90aGVyLCAnT3RoZXIgQ3Jhc2hlcycsICdjcmFzaC10ZXN0cy10YWJsZScpOworICAgICAg ICBodG1sICs9IHRlc3RMaXN0KGdsb2JhbFN0YXRlKCkuY3Jhc2hPdGhlciwgJ090aGVyIENyYXNo ZXMnLCAnb3RoZXItY3Jhc2gtdGVzdHMtdGFibGUnKTsKIAogICAgIGh0bWwgKz0gZmFpbGluZ1Rl c3RzVGFibGUoZ2xvYmFsU3RhdGUoKS5mYWlsaW5nVGVzdHMsCiAgICAgICAgICdUZXN0cyB0aGF0 IGZhaWxlZCB0ZXh0L3BpeGVsL2F1ZGlvIGRpZmYnLCAncmVzdWx0cy10YWJsZScpOwo= 263958 2015-10-23 16:53:41 -0700 2015-10-23 17:46:50 -0700 Updated patch patch_other_crash_table1.txt text/plain 3609 aakash_jain SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE5MTUxMikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE1LTEwLTIzICBBYWthc2ggSmFpbiAgPGFh a2FzaF9qYWluQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgdW5uZWNlc3NhcnkgZGV0YWls cyBmcm9tIE90aGVyIENyYXNoZXMgc2VjdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwNTE0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yMzIz NTQ1OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IGZhc3QvaGFybmVzcy9yZXN1bHRzLmh0bWw6IENyZWF0ZSBzZXBhcmF0ZSBvdGhlci1jcmFzaC10 ZXN0cy10YWJsZS4KKwogMjAxNS0xMC0yMyAgUm9vcGVzaCBDaGFuZGVyICA8cm9vcEByb29wYy5u ZXQ+CiAKICAgICAgICAgW0NvbnRlbnQgRXh0ZW5zaW9uc10gQWRkIHRlc3QgZm9yIGhpZGluZyBj b250ZW50IG9uIDxhIHBpbmc+IHBpbmdzCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2hhcm5lc3Mv cmVzdWx0cy5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvaGFybmVzcy9yZXN1 bHRzLmh0bWwJKHJldmlzaW9uIDE5MTUxMikKKysrIExheW91dFRlc3RzL2Zhc3QvaGFybmVzcy9y ZXN1bHRzLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTQ5NCw2ICs0OTQsMTEgQEAgZnVuY3Rpb24g dGVzdExpbmtXaXRoRXhwYW5kQnV0dG9uKHRlc3QpCiAgICAgcmV0dXJuICc8c3BhbiBjbGFzcz1l eHBhbmQtYnV0dG9uIG9uY2xpY2s9InRvZ2dsZUV4cGVjdGF0aW9ucyh0aGlzKSI+PHNwYW4gY2xh c3M9ZXhwYW5kLWJ1dHRvbi10ZXh0Pis8L3NwYW4+PC9zcGFuPicgKyB0ZXN0TGluayh0ZXN0KTsK IH0KIAorZnVuY3Rpb24gdGVzdFdpdGhFeHBhbmRCdXR0b24odGVzdCkKK3sKKyAgICByZXR1cm4g JzxzcGFuIGNsYXNzPWV4cGFuZC1idXR0b24gb25jbGljaz0idG9nZ2xlRXhwZWN0YXRpb25zKHRo aXMpIj48c3BhbiBjbGFzcz1leHBhbmQtYnV0dG9uLXRleHQ+Kzwvc3Bhbj48L3NwYW4+JyArIHRl c3Q7Cit9CisKIGZ1bmN0aW9uIHJlc3VsdExpbmsodGVzdFByZWZpeCwgc3VmZml4LCBjb250ZW50 cykKIHsKICAgICByZXR1cm4gJzxhIGNsYXNzPXJlc3VsdC1saW5rIGhyZWY9IicgKyB0ZXN0UHJl Zml4ICsgc3VmZml4ICsgJyIgZGF0YS1wcmVmaXg9IicgKyB0ZXN0UHJlZml4ICsgJyI+JyArIGNv bnRlbnRzICsgJzwvYT4gJzsKQEAgLTc2OSwxMyArNzc0LDIxIEBAIGZ1bmN0aW9uIHRlc3RMaXN0 KHRlc3RzLCBoZWFkZXIsIHRhYmxlSWQKICAgICAgICAgaWYgKGdsb2JhbFN0YXRlKCkucmVzdWx0 cy51c2VzX2V4cGVjdGF0aW9uc19maWxlKQogICAgICAgICAgICAgaHRtbCArPSAnIGNsYXNzPSIn ICsgKCh0ZXN0T2JqZWN0LmlzRXhwZWN0ZWQgJiYgdGFibGVJZCAhPSAnc3RkZXJyLXRhYmxlJykg PyAnZXhwZWN0ZWQnIDogJycpICsgJyInOwogICAgICAgICBodG1sICs9ICc+PHRyPjx0ZD4nOwot ICAgICAgICBodG1sICs9ICh0YWJsZUlkID09ICdwYXNzZXMtdGFibGUnKSA/IHRlc3RMaW5rKHRl c3QpIDogdGVzdExpbmtXaXRoRXhwYW5kQnV0dG9uKHRlc3QpOworICAgICAgICBpZiAodGFibGVJ ZCA9PSAncGFzc2VzLXRhYmxlJykKKyAgICAgICAgICAgIGh0bWwgKz0gdGVzdExpbmsodGVzdCk7 CisgICAgICAgIGVsc2UgaWYgKHRhYmxlSWQgPT0gJ290aGVyLWNyYXNoLXRlc3RzLXRhYmxlJykK KyAgICAgICAgICAgIGh0bWwgKz0gdGVzdFdpdGhFeHBhbmRCdXR0b24odGVzdCk7CisgICAgICAg IGVsc2UKKyAgICAgICAgICAgIGh0bWwgKz0gdGVzdExpbmtXaXRoRXhwYW5kQnV0dG9uKHRlc3Qp OworCiAgICAgICAgIGh0bWwgKz0gJzwvdGQ+PHRkPic7CiAKICAgICAgICAgaWYgKHRhYmxlSWQg PT0gJ3N0ZGVyci10YWJsZScpCiAgICAgICAgICAgICBodG1sICs9IHJlc3VsdExpbmsoc3RyaXBF eHRlbnNpb24odGVzdCksICctc3RkZXJyLnR4dCcsICdzdGRlcnInKTsKICAgICAgICAgZWxzZSBp ZiAodGFibGVJZCA9PSAncGFzc2VzLXRhYmxlJykKICAgICAgICAgICAgIGh0bWwgKz0gdGVzdE9i amVjdC5leHBlY3RlZDsKKyAgICAgICAgZWxzZSBpZiAodGFibGVJZCA9PSAnb3RoZXItY3Jhc2gt dGVzdHMtdGFibGUnKSAKKyAgICAgICAgICAgIGh0bWwgKz0gcmVzdWx0TGluayhzdHJpcEV4dGVu c2lvbih0ZXN0KSwgJy1jcmFzaC1sb2cudHh0JywgJ2NyYXNoIGxvZycpOwogICAgICAgICBlbHNl IGlmICh0YWJsZUlkID09ICdjcmFzaC10ZXN0cy10YWJsZScpIHsKICAgICAgICAgICAgIGh0bWwg Kz0gcmVzdWx0TGluayhzdHJpcEV4dGVuc2lvbih0ZXN0KSwgJy1jcmFzaC1sb2cudHh0JywgJ2Ny YXNoIGxvZycpOwogICAgICAgICAgICAgaHRtbCArPSByZXN1bHRMaW5rKHN0cmlwRXh0ZW5zaW9u KHRlc3QpLCAnLXNhbXBsZS50eHQnLCAnc2FtcGxlJyk7CkBAIC03ODQsNyArNzk3LDggQEAgZnVu Y3Rpb24gdGVzdExpc3QodGVzdHMsIGhlYWRlciwgdGFibGVJZAogICAgICAgICAgICAgaHRtbCAr PSB0ZXh0UmVzdWx0TGlua3Moc3RyaXBFeHRlbnNpb24odGVzdCkpOwogICAgICAgICB9CiAKLSAg ICAgICAgaHRtbCArPSAnPC90ZD48dGQ+PGEgaHJlZj0iJyArIGZsYWtpbmVzc0Rhc2hib2FyZFVS TEZvclRlc3RzKFt0ZXN0T2JqZWN0XSkgKyAnIj5oaXN0b3J5PC9hPjwvdGQ+JzsKKyAgICAgICAg aWYgKHRhYmxlSWQgIT0gJ290aGVyLWNyYXNoLXRlc3RzLXRhYmxlJykKKyAgICAgICAgICAgIGh0 bWwgKz0gJzwvdGQ+PHRkPjxhIGhyZWY9IicgKyBmbGFraW5lc3NEYXNoYm9hcmRVUkxGb3JUZXN0 cyhbdGVzdE9iamVjdF0pICsgJyI+aGlzdG9yeTwvYT48L3RkPic7CiAKICAgICAgICAgaHRtbCAr PSAnPC90cj48L3Rib2R5Pic7CiAgICAgfQpAQCAtMTM4Niw3ICsxNDAwLDcgQEAgZnVuY3Rpb24g Z2VuZXJhdGVQYWdlKCkKICAgICAgICAgaHRtbCArPSB0ZXN0TGlzdChnbG9iYWxTdGF0ZSgpLmNy YXNoVGVzdHMsICdUZXN0cyB0aGF0IGNyYXNoZWQnLCAnY3Jhc2gtdGVzdHMtdGFibGUnKTsKIAog ICAgIGlmIChnbG9iYWxTdGF0ZSgpLmNyYXNoT3RoZXIubGVuZ3RoKQotICAgICAgICBodG1sICs9 IHRlc3RMaXN0KGdsb2JhbFN0YXRlKCkuY3Jhc2hPdGhlciwgJ090aGVyIENyYXNoZXMnLCAnY3Jh c2gtdGVzdHMtdGFibGUnKTsKKyAgICAgICAgaHRtbCArPSB0ZXN0TGlzdChnbG9iYWxTdGF0ZSgp LmNyYXNoT3RoZXIsICdPdGhlciBDcmFzaGVzJywgJ290aGVyLWNyYXNoLXRlc3RzLXRhYmxlJyk7 CiAKICAgICBodG1sICs9IGZhaWxpbmdUZXN0c1RhYmxlKGdsb2JhbFN0YXRlKCkuZmFpbGluZ1Rl c3RzLAogICAgICAgICAnVGVzdHMgdGhhdCBmYWlsZWQgdGV4dC9waXhlbC9hdWRpbyBkaWZmJywg J3Jlc3VsdHMtdGFibGUnKTsK