150505 2015-10-23 11:13:29 -0700 Web Inspector: xlink:href should be linkified 2015-10-23 17:25:40 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1136078 0 timothy 2015-10-23 11:13:29 -0700 <svg class="glyph"><use xlink:href="Images/ReloadToolbar.svg"></use></svg> The href isn't linked in source or the DOM because of the attribute namespace. 1136079 1 webkit-bug-importer 2015-10-23 11:13:48 -0700 <rdar://problem/23237970> 1136158 2 263952 joepeck 2015-10-23 16:02:50 -0700 Created attachment 263952 [PATCH] Proposed Fix 1136193 3 263952 commit-queue 2015-10-23 17:25:36 -0700 Comment on attachment 263952 [PATCH] Proposed Fix Clearing flags on attachment: 263952 Committed r191519: <http://trac.webkit.org/changeset/191519> 1136194 4 commit-queue 2015-10-23 17:25:40 -0700 All reviewed patches have been landed. Closing bug. 263952 2015-10-23 16:02:50 -0700 2015-10-23 17:25:36 -0700 [PATCH] Proposed Fix xlink2.patch text/plain 4828 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGYyMWZjOTkuLjFjZjczMjIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE1LTEwLTIzICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogeGxpbms6 aHJlZiBzaG91bGQgYmUgbGlua2lmaWVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNTA1MDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzOgorICAgICAgICBX aGVuIG9wZW5pbmcgYSBVUkwgd2l0aCBhIGZyYWdtZW50LCBwcmVmZXIgb3BlbmluZyBhIHJlc291 cmNlCisgICAgICAgIHRoYXQgaGFzIHRoZSBzYW1lIFVSTCB3aXRob3V0IHRoZSBmcmFnbWVudCwg b3RoZXJ3aXNlIHRoaXMgd291bGQKKyAgICAgICAgb3BlbiBpbiBhIG5ldyB0YWIuCisKKyAgICAg ICAgKiBVc2VySW50ZXJmYWNlL0Jhc2UvVVJMVXRpbGl0aWVzLmpzOgorICAgICAgICAoYWJzb2x1 dGVVUkwpOgorICAgICAgICBCZXR0ZXIgaGFuZGxpbmcgYWJzb2x1dGVVUkwoIiNmcmFnIiwgYmFz ZVVSTCkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0NvZGVNaXJyb3JBZGRpdGlv bnMuanM6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVlRWxlbWVudC5qczoK KyAgICAgICAgKFdlYkluc3BlY3Rvci5ET01UcmVlRWxlbWVudC5wcm90b3R5cGUuX2J1aWxkQXR0 cmlidXRlRE9NKToKKyAgICAgICAgQWxsb3cgZm9yIG1vcmUgImhyZWYiIHN0eWxlIGF0dHJpYnV0 ZXMsIHN1Y2ggYXMgWE1MIG5hbWVzcGFjZWQKKyAgICAgICAgInhsaW5rOmhyZWYiIGF0dHJpYnV0 ZSBuYW1lcy4KKwogMjAxNS0xMC0yMyAgTmlraXRhIFZhc2lseWV2ICA8bnZhc2lseWV2QGFwcGxl LmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBDb21tYW5kLUVudGVyIGluIERlYnVnZ2Vy IHNob3VsZCBzaG93IGEgcG9wb3ZlciB3aXRoIGV2YWx1YXRpb24gcmVzdWx0CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKaW5kZXggYTFkOTU4 NC4uMWM1YjE1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvQmFzZS9NYWluLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L0Jhc2UvTWFpbi5qcwpAQCAtNjg4LDcgKzY4OCw4IEBAIFdlYkluc3BlY3Rvci5vcGVuVVJMID0g ZnVuY3Rpb24odXJsLCBmcmFtZSwgYWx3YXlzT3BlbkV4dGVybmFsbHksIGxpbmVOdW1iZXIpCiAg ICAgY29uc29sZS5hc3NlcnQoZnJhbWUpOwogCiAgICAgLy8gV2ViSW5zcGVjdG9yLkZyYW1lLnJl c291cmNlRm9yVVJMIGRvZXMgbm90IGNoZWNrIHRoZSBtYWluIHJlc291cmNlLCBvbmx5IHN1Yi1y ZXNvdXJjZXMuIFNvIGNoZWNrIGJvdGguCi0gICAgdmFyIHJlc291cmNlID0gZnJhbWUudXJsID09 PSB1cmwgPyBmcmFtZS5tYWluUmVzb3VyY2UgOiBmcmFtZS5yZXNvdXJjZUZvclVSTCh1cmwsIHNl YXJjaENoaWxkRnJhbWVzKTsKKyAgICBsZXQgc2ltcGxpZmllZFVSTCA9IHJlbW92ZVVSTEZyYWdt ZW50KHVybCk7CisgICAgdmFyIHJlc291cmNlID0gZnJhbWUudXJsID09PSBzaW1wbGlmaWVkVVJM ID8gZnJhbWUubWFpblJlc291cmNlIDogZnJhbWUucmVzb3VyY2VGb3JVUkwoc2ltcGxpZmllZFVS TCwgc2VhcmNoQ2hpbGRGcmFtZXMpOwogICAgIGlmIChyZXNvdXJjZSkgewogICAgICAgICB2YXIg cG9zaXRpb24gPSBuZXcgV2ViSW5zcGVjdG9yLlNvdXJjZUNvZGVQb3NpdGlvbihsaW5lTnVtYmVy LCAwKTsKICAgICAgICAgdGhpcy5zaG93U291cmNlQ29kZShyZXNvdXJjZSwgcG9zaXRpb24pOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9VUkxV dGlsaXRpZXMuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL1VS TFV0aWxpdGllcy5qcwppbmRleCA1Zjc5MDdjLi5jZjNiNmFiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL1VSTFV0aWxpdGllcy5qcworKysgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL1VSTFV0aWxpdGllcy5qcwpA QCAtMTUzLDYgKzE1MywxMiBAQCBmdW5jdGlvbiBhYnNvbHV0ZVVSTChwYXJ0aWFsVVJMLCBiYXNl VVJMKQogICAgIGlmIChwYXJ0aWFsVVJMWzBdID09PSAiLyIpCiAgICAgICAgIHJldHVybiBiYXNl VVJMUHJlZml4ICsgcmVzb2x2ZURvdHNJblBhdGgocGFydGlhbFVSTCk7CiAKKyAgICAvLyBBIFVS TCB0aGF0IHN0YXJ0cyB3aXRoICIjIiBpcyBqdXN0IGEgZnJhZ21lbnQgdGhhdCBnZXRzIGFwcGxp ZWQgdG8gdGhlIGJhc2UgVVJMIChyZXBsYWNpbmcgdGhlIGJhc2UgVVJMIGZyYWdtZW50LCBtYWlu dGFpbmluZyB0aGUgcXVlcnkgc3RyaW5nKS4KKyAgICBpZiAocGFydGlhbFVSTFswXSA9PT0gIiMi KSB7CisgICAgICAgIGxldCBxdWVyeVN0cmluZ0NvbXBvbmVudCA9IGJhc2VVUkxDb21wb25lbnRz LnF1ZXJ5U3RyaW5nID8gIj8iICsgYmFzZVVSTENvbXBvbmVudHMucXVlcnlTdHJpbmcgOiAiIjsK KyAgICAgICAgcmV0dXJuIGJhc2VVUkxQcmVmaXggKyBiYXNlVVJMQ29tcG9uZW50cy5wYXRoICsg cXVlcnlTdHJpbmdDb21wb25lbnQgKyBwYXJ0aWFsVVJMOworICAgIH0KKwogICAgIC8vIEdlbmVy YXRlIHRoZSBiYXNlIHBhdGggdGhhdCBpcyB1c2VkIGluIHRoZSBmaW5hbCBjYXNlIGJ5IHJlbW92 aW5nIGV2ZXJ5dGhpbmcgYWZ0ZXIgdGhlIGxhc3QgIi8iIGZyb20gdGhlIGJhc2UgVVJMJ3MgcGF0 aC4KICAgICB2YXIgYmFzZVBhdGggPSBiYXNlVVJMQ29tcG9uZW50cy5wYXRoLnN1YnN0cmluZygw LCBiYXNlVVJMQ29tcG9uZW50cy5wYXRoLmxhc3RJbmRleE9mKCIvIikpICsgIi8iOwogICAgIHJl dHVybiBiYXNlVVJMUHJlZml4ICsgcmVzb2x2ZURvdHNJblBhdGgoYmFzZVBhdGggKyBwYXJ0aWFs VVJMKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL0NvZGVNaXJyb3JBZGRpdGlvbnMuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9Db2RlTWlycm9yQWRkaXRpb25zLmpzCmluZGV4IGY5NjNlMmUuLjc2NTE2 NjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L0NvZGVNaXJyb3JBZGRpdGlvbnMuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvQ29kZU1pcnJvckFkZGl0aW9ucy5qcwpAQCAtMTI0LDcgKzEyNCw3IEBA CiAgICAgICAgICAgICAvLyBMb29rIGZvciAiaHJlZiIgb3IgInNyYyIgYXR0cmlidXRlcy4gSWYg Zm91bmQgdGhlbiB3ZSBzaG91bGQKICAgICAgICAgICAgIC8vIGV4cGVjdCBhIHN0cmluZyBsYXRl ciB0aGF0IHNob3VsZCBnZXQgdGhlICJsaW5rIiBzdHlsZSBpbnN0ZWFkLgogICAgICAgICAgICAg dmFyIHRleHQgPSBzdHJlYW0uY3VycmVudCgpLnRvTG93ZXJDYXNlKCk7Ci0gICAgICAgICAgICBp ZiAodGV4dCA9PT0gImhyZWYiIHx8IHRleHQgPT09ICJzcmMiKQorICAgICAgICAgICAgaWYgKHRl eHQgPT09ICJzcmMiIHx8IC9cYmhyZWZcYi8udGVzdCh0ZXh0KSkKICAgICAgICAgICAgICAgICBz dGF0ZS5fZXhwZWN0TGluayA9IHRydWU7CiAgICAgICAgICAgICBlbHNlIGlmICh0ZXh0ID09PSAi c3Jjc2V0IikKICAgICAgICAgICAgICAgICBzdGF0ZS5fZXhwZWN0U3JjU2V0ID0gdHJ1ZTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRy ZWVFbGVtZW50LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv RE9NVHJlZUVsZW1lbnQuanMKaW5kZXggM2JmZWM5NS4uNWMxNGFlZiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZUVsZW1lbnQuanMK KysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZUVs ZW1lbnQuanMKQEAgLTEwOTMsNyArMTA5Myw3IEBAIFdlYkluc3BlY3Rvci5ET01UcmVlRWxlbWVu dCA9IGNsYXNzIERPTVRyZWVFbGVtZW50IGV4dGVuZHMgV2ViSW5zcGVjdG9yLlRyZWVFbGVtCiAg ICAgICAgIGlmIChoYXNUZXh0KQogICAgICAgICAgICAgYXR0clNwYW5FbGVtZW50LmFwcGVuZCgi PVx1MjAwQlwiIik7CiAKLSAgICAgICAgaWYgKG5hbWUgPT09ICJzcmMiIHx8IG5hbWUgPT09ICJo cmVmIikgeworICAgICAgICBpZiAobmFtZSA9PT0gInNyYyIgfHwgL1xiaHJlZlxiLy50ZXN0KG5h bWUpKSB7CiAgICAgICAgICAgICBsZXQgYmFzZVVSTCA9IG5vZGUub3duZXJEb2N1bWVudCA/IG5v ZGUub3duZXJEb2N1bWVudC5kb2N1bWVudFVSTCA6IG51bGw7CiAgICAgICAgICAgICBsZXQgcmV3 cml0dGVuVVJMID0gYWJzb2x1dGVVUkwodmFsdWUsIGJhc2VVUkwpOwogICAgICAgICAgICAgdmFs dWUgPSB2YWx1ZS5pbnNlcnRXb3JkQnJlYWtDaGFyYWN0ZXJzKCk7Cg==