150503 2015-10-23 08:47:30 -0700 [MediaStream] Fix UserMediaPermissionRequestProxy::invalidate 2015-10-27 10:48:16 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue webkit-bug-importer oldest_to_newest 1136043 0 eric.carlson 2015-10-23 08:47:30 -0700 UserMediaPermissionRequestManagerProxy::invalidateRequests calls invalidate on every pending UserMediaPermissionRequestProxy. UserMediaPermissionRequestProxy::invalidate calls UserMediaPermissionRequestManagerProxy::invalidateRequests and bad things happen. 1136044 1 webkit-bug-importer 2015-10-23 08:48:27 -0700 <rdar://problem/23235386> 1136049 2 263929 eric.carlson 2015-10-23 09:11:34 -0700 Created attachment 263929 Proposed patch. 1136098 3 263929 commit-queue 2015-10-23 12:02:17 -0700 Comment on attachment 263929 Proposed patch. Clearing flags on attachment: 263929 Committed r191504: <http://trac.webkit.org/changeset/191504> 1136099 4 commit-queue 2015-10-23 12:02:21 -0700 All reviewed patches have been landed. Closing bug. 263929 2015-10-23 09:11:34 -0700 2015-10-23 12:02:17 -0700 Proposed patch. UserMediaPermissionRequestProxy_patch_1.txt text/plain 3595 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MTQ5NSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE1LTEwLTIzICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNZWRpYVN0cmVhbV0g Rml4IFVzZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0UHJveHk6OmludmFsaWRhdGUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDUwMworICAgICAgICA8 cmRhcjovL3Byb2JsZW0vMjMyMzUzODY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvVXNlck1lZGlhUGVybWlzc2lvblJlcXVlc3RQ cm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OlVzZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0UHJv eHk6OlVzZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0UHJveHkpOiBtX21hbmFnZXIgaXMgYSBwb2lu dGVyLgorICAgICAgICAoV2ViS2l0OjpVc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdFByb3h5Ojph bGxvdyk6IFJldHVybiBlYXJseSBpZiBtX21hbmFnZXIgaXMgbnVsbCwgY2xlYXIgaXQgYWZ0ZXIK KyAgICAgICAgICBjYWxsaW5nIHRoZSBtYW5hZ2VyLgorICAgICAgICAoV2ViS2l0OjpVc2VyTWVk aWFQZXJtaXNzaW9uUmVxdWVzdFByb3h5OjpkZW55KTogRGl0dG8uCisgICAgICAgIChXZWJLaXQ6 OlVzZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0UHJveHk6OmludmFsaWRhdGUpOiBDbGVhciBtX21h bmFnZXIuCisgICAgICAgICogVUlQcm9jZXNzL1VzZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0UHJv eHkuaDogQ2hhbmdlIG1fbWFuYWdlciBmcm9tIGEgcmVmZXJlbmNlIHRvIGEKKyAgICAgICAgICBw b2ludGVyIHNvIGl0IGNhbiBiZSBjbGVhcmVkLgorCiAyMDE1LTEwLTIyICBKb29uZ2h1biBQYXJr ICA8amg3MTgucGFya0BzYW1zdW5nLmNvbT4KIAogICAgICAgICBbR1RLXSBGaXggYnVpbGQgYnJl YWsgc2luY2UgcjE5MTQ3MQpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1VzZXJNZWRp YVBlcm1pc3Npb25SZXF1ZXN0UHJveHkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9Vc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdFByb3h5LmNwcAkocmV2aXNpb24g MTkwNTMxKQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1VzZXJNZWRpYVBlcm1pc3Npb25S ZXF1ZXN0UHJveHkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNyw3ICsyNyw3IEBACiBuYW1lc3Bh Y2UgV2ViS2l0IHsKIAogVXNlck1lZGlhUGVybWlzc2lvblJlcXVlc3RQcm94eTo6VXNlck1lZGlh UGVybWlzc2lvblJlcXVlc3RQcm94eShVc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXJQ cm94eSYgbWFuYWdlciwgdWludDY0X3QgdXNlck1lZGlhSUQsIGNvbnN0IFZlY3RvcjxTdHJpbmc+ JiBhdWRpb0RldmljZVVJRHMsIGNvbnN0IFZlY3RvcjxTdHJpbmc+JiB2aWRlb0RldmljZVVJRHMp Ci0gICAgOiBtX21hbmFnZXIobWFuYWdlcikKKyAgICA6IG1fbWFuYWdlcigmbWFuYWdlcikKICAg ICAsIG1fdXNlck1lZGlhSUQodXNlck1lZGlhSUQpCiAgICAgLCBtX3ZpZGVvRGV2aWNlVUlEcyh2 aWRlb0RldmljZVVJRHMpCiAgICAgLCBtX2F1ZGlvRGV2aWNlVUlEcyhhdWRpb0RldmljZVVJRHMp CkBAIC0zNiwxNyArMzYsMjcgQEAgVXNlck1lZGlhUGVybWlzc2lvblJlcXVlc3RQcm94eTo6VXNl ck1lZAogCiB2b2lkIFVzZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0UHJveHk6OmFsbG93KGNvbnN0 IFN0cmluZyYgYXVkaW9EZXZpY2VVSUQsIGNvbnN0IFN0cmluZyYgdmlkZW9EZXZpY2VVSUQpCiB7 Ci0gICAgbV9tYW5hZ2VyLmRpZFJlY2VpdmVVc2VyTWVkaWFQZXJtaXNzaW9uRGVjaXNpb24obV91 c2VyTWVkaWFJRCwgdHJ1ZSwgYXVkaW9EZXZpY2VVSUQsIHZpZGVvRGV2aWNlVUlEKTsKKyAgICBB U1NFUlQobV9tYW5hZ2VyKTsKKyAgICBpZiAoIW1fbWFuYWdlcikKKyAgICAgICAgcmV0dXJuOwor CisgICAgbV9tYW5hZ2VyLT5kaWRSZWNlaXZlVXNlck1lZGlhUGVybWlzc2lvbkRlY2lzaW9uKG1f dXNlck1lZGlhSUQsIHRydWUsIGF1ZGlvRGV2aWNlVUlELCB2aWRlb0RldmljZVVJRCk7CisgICAg bV9tYW5hZ2VyID0gbnVsbHB0cjsKIH0KIAogdm9pZCBVc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVz dFByb3h5OjpkZW55KCkKIHsKLSAgICBtX21hbmFnZXIuZGlkUmVjZWl2ZVVzZXJNZWRpYVBlcm1p c3Npb25EZWNpc2lvbihtX3VzZXJNZWRpYUlELCBmYWxzZSwgZW1wdHlTdHJpbmcoKSwgZW1wdHlT dHJpbmcoKSk7CisgICAgQVNTRVJUKG1fbWFuYWdlcik7CisgICAgaWYgKCFtX21hbmFnZXIpCisg ICAgICAgIHJldHVybjsKKworICAgIG1fbWFuYWdlci0+ZGlkUmVjZWl2ZVVzZXJNZWRpYVBlcm1p c3Npb25EZWNpc2lvbihtX3VzZXJNZWRpYUlELCBmYWxzZSwgZW1wdHlTdHJpbmcoKSwgZW1wdHlT dHJpbmcoKSk7CisgICAgbV9tYW5hZ2VyID0gbnVsbHB0cjsKIH0KIAogdm9pZCBVc2VyTWVkaWFQ ZXJtaXNzaW9uUmVxdWVzdFByb3h5OjppbnZhbGlkYXRlKCkKIHsKLSAgICBtX21hbmFnZXIuaW52 YWxpZGF0ZVJlcXVlc3RzKCk7CisgICAgbV9tYW5hZ2VyID0gbnVsbHB0cjsKIH0KIAogfSAvLyBu YW1lc3BhY2UgV2ViS2l0CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvVXNlck1lZGlh UGVybWlzc2lvblJlcXVlc3RQcm94eS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9Vc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdFByb3h5LmgJKHJldmlzaW9uIDE5MDUz MSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Vc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVz dFByb3h5LmgJKHdvcmtpbmcgY29weSkKQEAgLTUzLDcgKzUzLDcgQEAgcHVibGljOgogcHJpdmF0 ZToKICAgICBVc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdFByb3h5KFVzZXJNZWRpYVBlcm1pc3Np b25SZXF1ZXN0TWFuYWdlclByb3h5JiwgdWludDY0X3QgdXNlck1lZGlhSUQsIGNvbnN0IFZlY3Rv cjxTdHJpbmc+JiB2aWRlb0RldmljZVVJRHMsIGNvbnN0IFZlY3RvcjxTdHJpbmc+JiBhdWRpb0Rl dmljZVVJRHMpOwogCi0gICAgVXNlck1lZGlhUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyUHJveHkm IG1fbWFuYWdlcjsKKyAgICBVc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXJQcm94eSog bV9tYW5hZ2VyOwogICAgIHVpbnQ2NF90IG1fdXNlck1lZGlhSUQ7CiAgICAgVmVjdG9yPFN0cmlu Zz4gbV92aWRlb0RldmljZVVJRHM7CiAgICAgVmVjdG9yPFN0cmluZz4gbV9hdWRpb0RldmljZVVJ RHM7Cg==