150499 2015-10-23 06:32:51 -0700 [Content Extensions] Add test for hiding content on <a ping> pings 2015-10-23 12:07:09 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 roop+webkit webkit-unassigned achristensen benjamin commit-queue oldest_to_newest 1136030 0 roop+webkit 2015-10-23 06:32:51 -0700 Bug https://bugs.webkit.org/show_bug.cgi?id=149873 addresses the requirement that <a ping> pings should respect content blocking rules. However, one scenario is not handled in tests: the scenario of <a ping> pings causing some content to hide because of a 'css-display-none'. This missed scenario should also be tested. 1136031 1 263921 roop+webkit 2015-10-23 06:40:58 -0700 Created attachment 263921 Patch with the test Adding a patch with a test for ensuring that the 'css-display-none' rule works when a ping is sent from an <a ping> link. The href is a fragment (href="#id"), so that the document remains intact to be able to test that the style change is applied correctly. 1136081 2 263921 achristensen 2015-10-23 11:18:48 -0700 Comment on attachment 263921 Patch with the test r=me 1136101 3 263921 commit-queue 2015-10-23 12:07:06 -0700 Comment on attachment 263921 Patch with the test Clearing flags on attachment: 263921 Committed r191505: <http://trac.webkit.org/changeset/191505> 1136102 4 commit-queue 2015-10-23 12:07:09 -0700 All reviewed patches have been landed. Closing bug. 263921 2015-10-23 06:40:58 -0700 2015-10-23 12:07:06 -0700 Patch with the test roop-150499-OCT23.patch text/plain 3683 roop+webkit SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE5MTQ5NCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE1LTEwLTIzICBSb29wZXNoIENoYW5kZXIg IDxyb29wQHJvb3BjLm5ldD4KKworICAgICAgICBbQ29udGVudCBFeHRlbnNpb25zXSBBZGQgdGVz dCBmb3IgaGlkaW5nIGNvbnRlbnQgb24gPGEgcGluZz4gcGluZ3MKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDQ5OQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3QgZm9yIGVuc3VyaW5nIHRoYXQgPGEg cGluZz4gcGluZ3MgYXJlIHN1YmplY3QgdG8KKyAgICAgICAgJ2Nzcy1kaXNwbGF5LW5vbmUnIGNv bnRlbnQgYmxvY2tpbmcgcnVsZXMuCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL2NvbnRlbnRleHRl bnNpb25zL2hpZGUtb24tcGluZy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGh0dHAv dGVzdHMvY29udGVudGV4dGVuc2lvbnMvaGlkZS1vbi1waW5nLmh0bWw6IEFkZGVkLgorICAgICAg ICAqIGh0dHAvdGVzdHMvY29udGVudGV4dGVuc2lvbnMvaGlkZS1vbi1waW5nLmh0bWwuanNvbjog QWRkZWQuCisKIDIwMTUtMTAtMjMgIEFudG9pbmUgUXVpbnQgIDxncmFvdXRzQGFwcGxlLmNvbT4K IAogICAgICAgICBTdXBwb3J0IGZvciBTVkcgYGJlZ2luRXZlbnRgIGV2ZW50IGFuZCBgb25iZWdp bmAgYXR0cmlidXRlCkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2NvbnRlbnRleHRlbnNp b25zL2hpZGUtb24tcGluZy1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv aHR0cC90ZXN0cy9jb250ZW50ZXh0ZW5zaW9ucy9oaWRlLW9uLXBpbmctZXhwZWN0ZWQudHh0CShy ZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9jb250ZW50ZXh0ZW5zaW9ucy9o aWRlLW9uLXBpbmctZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTAgQEAK K1RoaXMgdGVzdCBmb2xsb3dzIGEgbGluayB3aXRoIGEgcGluZyBhdHRyaWJ1dGUgd2hlcmUgdGhl IHBpbmcgVVJMIG1hdGNoZXMgYSAnY3NzLWRpc3BsYXktbm9uZScgcnVsZS4KK1RoaXMgdGV4dCBz aG91bGQgcmVtYWluIHZpc2libGUuCisgTGluayB3aXRoIHBpbmcKKworCistLS0tLS0tLQorRnJh bWU6ICdyZXN1bHRfZnJhbWUnCistLS0tLS0tLQorUGluZyByZWNlaXZlZC4KK05vIGNvb2tpZXMg aW4gcGluZy4KSW5kZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMvY29udGVudGV4dGVuc2lvbnMv aGlkZS1vbi1waW5nLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9j b250ZW50ZXh0ZW5zaW9ucy9oaWRlLW9uLXBpbmcuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91 dFRlc3RzL2h0dHAvdGVzdHMvY29udGVudGV4dGVuc2lvbnMvaGlkZS1vbi1waW5nLmh0bWwJKHdv cmtpbmcgY29weSkKQEAgLTAsMCArMSw0MSBAQAorPGhlYWQ+Cis8c2NyaXB0PgoraWYgKHdpbmRv dy50ZXN0UnVubmVyKSB7CisgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisgICAgdGVzdFJ1 bm5lci5kdW1wQ2hpbGRGcmFtZXNBc1RleHQoKTsKKyAgICB0ZXN0UnVubmVyLm92ZXJyaWRlUHJl ZmVyZW5jZSgiV2ViS2l0SHlwZXJsaW5rQXVkaXRpbmdFbmFibGVkIiwgMSk7CisgICAgdGVzdFJ1 bm5lci53YWl0VW50aWxEb25lKCk7Cit9CisKK2Z1bmN0aW9uIGNsaWNrT25MaW5rV2l0aFBpbmco KSB7CisgICAgaWYgKHdpbmRvdy5ldmVudFNlbmRlcikgeworICAgICAgICB2YXIgYSA9IGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCJhIik7CisgICAgICAgIHZhciB4ID0gYS5vZmZzZXRMZWZ0ICsg MjsKKyAgICAgICAgdmFyIHkgPSBhLm9mZnNldFRvcCArIDI7CisgICAgICAgIGV2ZW50U2VuZGVy Lm1vdXNlTW92ZVRvKHgsIHkpOworICAgICAgICBldmVudFNlbmRlci5tb3VzZURvd24oKTsKKyAg ICAgICAgZXZlbnRTZW5kZXIubW91c2VVcCgpOworICAgIH0KK30KKworZnVuY3Rpb24gc2hvd1Bp bmdSZXN1bHQoKSB7CisgICAgdmFyIGlmcmFtZSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJy ZXN1bHRfZnJhbWUiKTsKKyAgICBpZnJhbWUub25sb2FkID0gZnVuY3Rpb24oKSB7CisgICAgICAg IGlmICh3aW5kb3cudGVzdFJ1bm5lcikgeyB0ZXN0UnVubmVyLm5vdGlmeURvbmUoKTsgfQorICAg IH0KKyAgICBpZnJhbWUuc3JjID0gInJlc291cmNlcy9nZXQtcGluZy1kYXRhLnBocD90ZXN0PWNv bnRlbnRleHRlbnNpb25zLWhpZGUtb24tcGluZyI7Cit9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKwor PGJvZHk+CitUaGlzIHRlc3QgZm9sbG93cyBhIGxpbmsgd2l0aCBhIHBpbmcgYXR0cmlidXRlIHdo ZXJlIHRoZSBwaW5nIFVSTCBtYXRjaGVzIGEgJ2Nzcy1kaXNwbGF5LW5vbmUnIHJ1bGUuCis8ZGl2 IGNsYXNzPSJmb28iPlRoaXMgdGV4dCBzaG91bGQgYmUgaGlkZGVuIG9uY2UgdGhlIHBpbmcgaXMg c2VudC48L2Rpdj4KKzxkaXYgY2xhc3M9ImJhciI+VGhpcyB0ZXh0IHNob3VsZCByZW1haW4gdmlz aWJsZS48L2Rpdj4KKzxkaXY+Cis8aW1nIHNyYz0icmVzb3VyY2VzL2RlbGV0ZS1waW5nLnBocD90 ZXN0PWNvbnRlbnRleHRlbnNpb25zLWhpZGUtb24tcGluZyIgb25lcnJvcj0iY2xpY2tPbkxpbmtX aXRoUGluZygpOyI+Cis8YSBpZD0iYSIgaHJlZj0iI2EiIHBpbmc9InJlc291cmNlcy9zYXZlLXBp bmcucGhwP3Rlc3Q9Y29udGVudGV4dGVuc2lvbnMtaGlkZS1vbi1waW5nIiBvbmNsaWNrPSJzaG93 UGluZ1Jlc3VsdCgpOyI+TGluayB3aXRoIHBpbmc8L2E+Cis8L2Rpdj4KKzxpZnJhbWUgaWQ9InJl c3VsdF9mcmFtZSI+PCEtLSBXaWxsIGNvbnRhaW4gcGluZyBkYXRhIHJlY2VpdmVkIGJ5IHNlcnZl ciAtLT48L2lmcmFtZT4KKzwvYm9keT4KKwpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9j b250ZW50ZXh0ZW5zaW9ucy9oaWRlLW9uLXBpbmcuaHRtbC5qc29uCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL2h0dHAvdGVzdHMvY29udGVudGV4dGVuc2lvbnMvaGlkZS1vbi1waW5nLmh0bWwu anNvbgkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMvY29udGVudGV4dGVu c2lvbnMvaGlkZS1vbi1waW5nLmh0bWwuanNvbgkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDEx IEBACitbCisgICAgeworICAgICAgICAidHJpZ2dlciI6IHsKKyAgICAgICAgICAgICJ1cmwtZmls dGVyIjogInNhdmUtcGluZy5waHAiCisgICAgICAgIH0sCisgICAgICAgICJhY3Rpb24iOiB7Cisg ICAgICAgICAgICAidHlwZSI6ICJjc3MtZGlzcGxheS1ub25lIiwKKyAgICAgICAgICAgICJzZWxl Y3RvciI6ICIuZm9vIgorICAgICAgICB9CisgICAgfQorXQo=