150465 2015-10-22 13:11:37 -0700 Wait to convert the share menu item to a real share menu until after calling out to the client 2015-10-22 13:14:35 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 1135790 0 andersca 2015-10-22 13:11:37 -0700 Wait to convert the share menu item to a real share menu until after calling out to the client 1135792 1 263849 andersca 2015-10-22 13:12:31 -0700 Created attachment 263849 Patch 1135793 2 andersca 2015-10-22 13:14:35 -0700 Committed r191468: <http://trac.webkit.org/changeset/191468> 263849 2015-10-22 13:12:31 -0700 2015-10-22 13:13:14 -0700 Patch bug-150465-20151022131147.patch text/plain 5795 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxNDY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODBhYmQ2OTZhNWFkMWY1 NmI3MGYyMjNhMWYyMzdlYWY0NzA1OGRjNi4uM2JiZTUwYTljYTE4ZTJiZTRjZGQzYWExOGU2ZDM1 Mzc2YjZiNTc0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTEwLTIyICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgV2FpdCB0byBjb252 ZXJ0IHRoZSBzaGFyZSBtZW51IGl0ZW0gdG8gYSByZWFsIHNoYXJlIG1lbnUgdW50aWwgYWZ0ZXIg Y2FsbGluZyBvdXQgdG8gdGhlIGNsaWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTUwNDY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhpcyB3aWxsIGxldCB1cyBzaW1wbGlmeSBtb3JlIGNvZGUgaW4g dXBjb21pbmcgcGF0Y2hlcy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV2ViQ29udGV4dE1l bnVQcm94eU1hYy5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV2ViQ29udGV4dE1lbnVQcm94 eU1hYy5tbToKKyAgICAgICAgKFdlYktpdDo6bnNNZW51SXRlbSk6CisgICAgICAgIChXZWJLaXQ6 Om5zTWVudUl0ZW1WZWN0b3IpOgorICAgICAgICAoV2ViS2l0OjpXZWJDb250ZXh0TWVudVByb3h5 TWFjOjpzaG93Q29udGV4dE1lbnUpOgorCiAyMDE1LTEwLTIyICBNeWxlcyBDLiBNYXhmaWVsZCAg PG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAgW0NvY29hXSBNaWdyYXRlIFdLU2V0UGF0 dGVyblBoYXNlSW5Vc2VyU3BhY2UoKSBhbmQgV0tHZXRVc2VyVG9CYXNlQ1RNKCkgZnJvbSBXS1NJ CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dlYkNvbnRleHRNZW51 UHJveHlNYWMuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2ViQ29udGV4dE1lbnVQ cm94eU1hYy5oCmluZGV4IDFkOTBkNzA3ZGZiZjA5OTFmOTc0MjRjODhkNWVlNGVmNzU5NjgzYjAu LjViMWQ3NjJmNWZmNTA4Yzk4ZDU0MjdjM2RhMDc2MzZmODI4NTUzYjIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2ViQ29udGV4dE1lbnVQcm94eU1hYy5oCisrKyBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2ViQ29udGV4dE1lbnVQcm94eU1hYy5oCkBA IC02NCw3ICs2NCwxMCBAQCBwcml2YXRlOgogI2lmIEVOQUJMRShTRVJWSUNFX0NPTlRST0xTKQog ICAgIHZvaWQgc2hvd1NlcnZpY2VzTWVudSgpOwogICAgIHZvaWQgc2V0dXBTZXJ2aWNlc01lbnUo KTsKKy8vIEZJWE1FOiBUaGlzIHNob3VsZG4ndCBiZSBwdWJsaWMuCitwdWJsaWM6CiAgICAgV2Vi Q29yZTo6Q29udGV4dE1lbnVJdGVtIHNoYXJlTWVudUl0ZW0oKTsKK3ByaXZhdGU6CiAjZW5kaWYK IAogICAgIFJldGFpblB0cjxOU01lbnU+IG1fbWVudTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9tYWMvV2ViQ29udGV4dE1lbnVQcm94eU1hYy5tbSBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9tYWMvV2ViQ29udGV4dE1lbnVQcm94eU1hYy5tbQppbmRleCAyMDEzNGFj MWJhZDFmNmY4N2NiODVhZDUyNzM2MTVjODNiNjIwM2MzLi5lMDAwZWMwZWE0YWYwMWNhYjkyZGE5 YmJjOTYwZmQ5YTJhZGM0OGRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv bWFjL1dlYkNvbnRleHRNZW51UHJveHlNYWMubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL21hYy9XZWJDb250ZXh0TWVudVByb3h5TWFjLm1tCkBAIC0xODEsMTAgKzE4MSwxNSBAQCBz dGF0aWMgdm9pZCBwb3B1bGF0ZU5TTWVudShOU01lbnUqIG1lbnUsIGNvbnN0IFZlY3RvcjxSZXRh aW5QdHI8TlNNZW51SXRlbT4+JiBtZQogICAgIH0KIH0KIAotdGVtcGxhdGU8dHlwZW5hbWUgSXRl bVR5cGU+IHN0YXRpYyBWZWN0b3I8UmV0YWluUHRyPE5TTWVudUl0ZW0+PiBuc01lbnVJdGVtVmVj dG9yKGNvbnN0IFZlY3RvcjxJdGVtVHlwZT4mKTsKK3RlbXBsYXRlPHR5cGVuYW1lIEl0ZW1UeXBl PiBzdGF0aWMgVmVjdG9yPFJldGFpblB0cjxOU01lbnVJdGVtPj4gbnNNZW51SXRlbVZlY3RvcihX ZWJDb250ZXh0TWVudVByb3h5TWFjJiwgY29uc3QgVmVjdG9yPEl0ZW1UeXBlPiYpOwogCi1zdGF0 aWMgUmV0YWluUHRyPE5TTWVudUl0ZW0+IG5zTWVudUl0ZW0oY29uc3QgV2ViQ29udGV4dE1lbnVJ dGVtRGF0YSYgaXRlbSkKK3N0YXRpYyBSZXRhaW5QdHI8TlNNZW51SXRlbT4gbnNNZW51SXRlbShX ZWJDb250ZXh0TWVudVByb3h5TWFjJiBjb250ZXh0TWVudVByb3h5LCBjb25zdCBXZWJDb250ZXh0 TWVudUl0ZW1EYXRhJiBpdGVtKQogeworI2lmIEVOQUJMRShTRVJWSUNFX0NPTlRST0xTKQorICAg IGlmIChpdGVtLmFjdGlvbigpID09IENvbnRleHRNZW51SXRlbVRhZ1NoYXJlTWVudSkKKyAgICAg ICAgcmV0dXJuIGNvbnRleHRNZW51UHJveHkuc2hhcmVNZW51SXRlbSgpLnBsYXRmb3JtRGVzY3Jp cHRpb24oKTsKKyNlbmRpZgorCiAgICAgc3dpdGNoIChpdGVtLnR5cGUoKSkgewogICAgIGNhc2Ug QWN0aW9uVHlwZToKICAgICBjYXNlIENoZWNrYWJsZUFjdGlvblR5cGU6IHsKQEAgLTIwOCw3ICsy MTMsNyBAQCBzdGF0aWMgUmV0YWluUHRyPE5TTWVudUl0ZW0+IG5zTWVudUl0ZW0oY29uc3QgV2Vi Q29udGV4dE1lbnVJdGVtRGF0YSYgaXRlbSkKICAgICBjYXNlIFN1Ym1lbnVUeXBlOiB7CiAgICAg ICAgIE5TTWVudSogbWVudSA9IFtbTlNNZW51IGFsbG9jXSBpbml0V2l0aFRpdGxlOm5zU3RyaW5n RnJvbVdlYkNvcmVTdHJpbmcoaXRlbS50aXRsZSgpKV07CiAgICAgICAgIFttZW51IHNldEF1dG9l bmFibGVzSXRlbXM6Tk9dOwotICAgICAgICBwb3B1bGF0ZU5TTWVudShtZW51LCBuc01lbnVJdGVt VmVjdG9yKGl0ZW0uc3VibWVudSgpKSk7CisgICAgICAgIHBvcHVsYXRlTlNNZW51KG1lbnUsIG5z TWVudUl0ZW1WZWN0b3IoY29udGV4dE1lbnVQcm94eSwgaXRlbS5zdWJtZW51KCkpKTsKICAgICAg ICAgICAgIAogICAgICAgICBOU01lbnVJdGVtKiBtZW51SXRlbSA9IFtbTlNNZW51SXRlbSBhbGxv Y10gaW5pdFdpdGhUaXRsZTpuc1N0cmluZ0Zyb21XZWJDb3JlU3RyaW5nKGl0ZW0udGl0bGUoKSkg YWN0aW9uOkBzZWxlY3Rvcihmb3J3YXJkQ29udGV4dE1lbnVBY3Rpb246KSBrZXlFcXVpdmFsZW50 OkAiIl07CiAgICAgICAgIFttZW51SXRlbSBzZXRFbmFibGVkOml0ZW0uZW5hYmxlZCgpXTsKQEAg LTIyMiwyMyArMjI3LDIzIEBAIHN0YXRpYyBSZXRhaW5QdHI8TlNNZW51SXRlbT4gbnNNZW51SXRl bShjb25zdCBXZWJDb250ZXh0TWVudUl0ZW1EYXRhJiBpdGVtKQogICAgIH0KIH0KIAotc3RhdGlj IFJldGFpblB0cjxOU01lbnVJdGVtPiBuc01lbnVJdGVtKGNvbnN0IFJlZlB0cjxXZWJDb250ZXh0 TWVudUl0ZW0+JiBpdGVtKQorc3RhdGljIFJldGFpblB0cjxOU01lbnVJdGVtPiBuc01lbnVJdGVt KFdlYkNvbnRleHRNZW51UHJveHlNYWMmIGNvbnRleHRNZW51UHJveHksIGNvbnN0IFJlZlB0cjxX ZWJDb250ZXh0TWVudUl0ZW0+JiBpdGVtKQogewogICAgIGlmIChOYXRpdmVDb250ZXh0TWVudUl0 ZW0qIG5hdGl2ZUl0ZW0gPSBpdGVtLT5uYXRpdmVDb250ZXh0TWVudUl0ZW0oKSkKICAgICAgICAg cmV0dXJuIG5hdGl2ZUl0ZW0tPm5zTWVudUl0ZW0oKTsKIAogICAgIEFTU0VSVChpdGVtLT5kYXRh KCkpOwotICAgIHJldHVybiBuc01lbnVJdGVtKCppdGVtLT5kYXRhKCkpOworICAgIHJldHVybiBu c01lbnVJdGVtKGNvbnRleHRNZW51UHJveHksICppdGVtLT5kYXRhKCkpOwogfQogCi10ZW1wbGF0 ZTx0eXBlbmFtZSBJdGVtVHlwZT4gc3RhdGljIFZlY3RvcjxSZXRhaW5QdHI8TlNNZW51SXRlbT4+ IG5zTWVudUl0ZW1WZWN0b3IoY29uc3QgVmVjdG9yPEl0ZW1UeXBlPiYgaXRlbXMpCit0ZW1wbGF0 ZTx0eXBlbmFtZSBJdGVtVHlwZT4gc3RhdGljIFZlY3RvcjxSZXRhaW5QdHI8TlNNZW51SXRlbT4+ IG5zTWVudUl0ZW1WZWN0b3IoV2ViQ29udGV4dE1lbnVQcm94eU1hYyYgY29udGV4dE1lbnVQcm94 eSwgY29uc3QgVmVjdG9yPEl0ZW1UeXBlPiYgaXRlbXMpCiB7CiAgICAgVmVjdG9yPFJldGFpblB0 cjxOU01lbnVJdGVtPj4gcmVzdWx0OwogCiAgICAgdW5zaWduZWQgc2l6ZSA9IGl0ZW1zLnNpemUo KTsKICAgICByZXN1bHQucmVzZXJ2ZUNhcGFjaXR5KHNpemUpOwogICAgIGZvciAoYXV0byYgaXRl bSA6IGl0ZW1zKQotICAgICAgICByZXN1bHQudW5jaGVja2VkQXBwZW5kKG5zTWVudUl0ZW0oaXRl bSkpOworICAgICAgICByZXN1bHQudW5jaGVja2VkQXBwZW5kKG5zTWVudUl0ZW0oY29udGV4dE1l bnVQcm94eSwgaXRlbSkpOwogCiAgICAgV0tNZW51VGFyZ2V0KiB0YXJnZXQgPSBbV0tNZW51VGFy Z2V0IHNoYXJlZE1lbnVUYXJnZXRdOwogICAgIGZvciAoYXV0byYgaXRlbSA6IHJlc3VsdCkKQEAg LTM4NSwxOCArMzkwLDggQEAgdm9pZCBXZWJDb250ZXh0TWVudVByb3h5TWFjOjpzaG93KCkKIHZv aWQgV2ViQ29udGV4dE1lbnVQcm94eU1hYzo6c2hvd0NvbnRleHRNZW51KCkKIHsKICAgICBWZWN0 b3I8UmVmUHRyPFdlYkNvbnRleHRNZW51SXRlbT4+IHByb3Bvc2VkQVBJSXRlbXM7Ci0gICAgZm9y IChhdXRvJiBpdGVtIDogbV9jb250ZXh0Lm1lbnVJdGVtcygpKSB7Ci0gICAgICAgIGlmIChpdGVt LmFjdGlvbigpICE9IENvbnRleHRNZW51SXRlbVRhZ1NoYXJlTWVudSkgewotICAgICAgICAgICAg cHJvcG9zZWRBUElJdGVtcy5hcHBlbmQoV2ViQ29udGV4dE1lbnVJdGVtOjpjcmVhdGUoaXRlbSkp OwotICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgIH0KLQotI2lmIEVOQUJMRShTRVJWSUNF X0NPTlRST0xTKQotICAgICAgICBDb250ZXh0TWVudUl0ZW0gc2hhcmVJdGVtID0gc2hhcmVNZW51 SXRlbSgpOwotICAgICAgICBpZiAoIXNoYXJlSXRlbS5pc051bGwoKSkKLSAgICAgICAgICAgIHBy b3Bvc2VkQVBJSXRlbXMuYXBwZW5kKFdlYkNvbnRleHRNZW51SXRlbTo6Y3JlYXRlKHNoYXJlSXRl bSkpOwotI2VuZGlmCi0gICAgfQorICAgIGZvciAoYXV0byYgaXRlbSA6IG1fY29udGV4dC5tZW51 SXRlbXMoKSkKKyAgICAgICAgcHJvcG9zZWRBUElJdGVtcy5hcHBlbmQoV2ViQ29udGV4dE1lbnVJ dGVtOjpjcmVhdGUoaXRlbSkpOwogCiAgICAgVmVjdG9yPFJlZlB0cjxXZWJDb250ZXh0TWVudUl0 ZW0+PiBjbGllbnRJdGVtczsKICAgICBib29sIHVzZVByb3Bvc2VkSXRlbXMgPSB0cnVlOwpAQCAt NDEyLDcgKzQwNyw3IEBAIHZvaWQgV2ViQ29udGV4dE1lbnVQcm94eU1hYzo6c2hvd0NvbnRleHRN ZW51KCkKICAgICBtX21lbnUgPSBbW05TTWVudSBhbGxvY10gaW5pdFdpdGhUaXRsZTpAIiJdOwog ICAgIFttX21lbnUgc2V0QXV0b2VuYWJsZXNJdGVtczpOT107CiAKLSAgICBwb3B1bGF0ZU5TTWVu dShtX21lbnUuZ2V0KCksIG5zTWVudUl0ZW1WZWN0b3IoaXRlbXMpKTsKKyAgICBwb3B1bGF0ZU5T TWVudShtX21lbnUuZ2V0KCksIG5zTWVudUl0ZW1WZWN0b3IoKnRoaXMsIGl0ZW1zKSk7CiAKICAg ICBbW1dLTWVudVRhcmdldCBzaGFyZWRNZW51VGFyZ2V0XSBzZXRNZW51UHJveHk6dGhpc107CiAg ICAgW21fbWVudSBwb3BVcE1lbnVQb3NpdGlvbmluZ0l0ZW06bmlsIGF0TG9jYXRpb246bV9jb250 ZXh0Lm1lbnVMb2NhdGlvbigpIGluVmlldzptX3dlYlZpZXddOwo=