150452 2015-10-22 10:55:00 -0700 Web Inspector: Restore :not(:placeholder-shown) behavior on search bars with comments 2015-10-22 11:43:03 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1135733 0 joepeck 2015-10-22 10:55:00 -0700 * SUMMARY Restore :not(:placeholder-shown) behavior on search bars with comments. > > <http://trac.webkit.org/changeset/191071> > > > > 4. Removed some :placeholder-shown CSS that didn't seem to be changing > > behavior, unless I'm missing what it was doing. > > The point of the :placeholder-shown selectors was to style the sidebar inputs with a > white background when they had user typed text, not just when focused. So if you > click/tab away it will stay white. That way the user has an indication a filter is > applied and it won't recess into the sidebar background. 1135734 1 263836 joepeck 2015-10-22 10:56:34 -0700 Created attachment 263836 [PATCH] Proposed Fix 1135758 2 263836 commit-queue 2015-10-22 11:42:58 -0700 Comment on attachment 263836 [PATCH] Proposed Fix Clearing flags on attachment: 263836 Committed r191464: <http://trac.webkit.org/changeset/191464> 1135759 3 commit-queue 2015-10-22 11:43:03 -0700 All reviewed patches have been landed. Closing bug. 263836 2015-10-22 10:56:34 -0700 2015-10-22 11:42:58 -0700 [PATCH] Proposed Fix placeholder-shown.patch text/plain 2284 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDY5NGRhOGUuLmMzMTE3NjUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE1LTEwLTIyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVzdG9y ZSA6bm90KDpwbGFjZWhvbGRlci1zaG93bikgYmVoYXZpb3Igb24gc2VhcmNoIGJhcnMgd2l0aCBj b21tZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTUwNDUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBVc2VySW50ZXJmYWNlL1ZpZXdzL0ZpbmRCYW5uZXIuY3NzOgorICAgICAgICAoLmZpbmQtYmFu bmVyLmNvbnNvbGUtZmluZC1iYW5uZXIgPiBpbnB1dFt0eXBlPSJzZWFyY2giXTpub3QoOnBsYWNl aG9sZGVyLXNob3duKSk6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9TZWFyY2hCYXIu Y3NzOgorICAgICAgICAoLnNlYXJjaC1iYXIgPiBpbnB1dFt0eXBlPSJzZWFyY2giXTpub3QoOnBs YWNlaG9sZGVyLXNob3duKSk6CisgICAgICAgIEFkZCBiYWNrIHRoZSBwbGFjZWhvbGRlci1zaG93 biByZWxhdGVkIHN0eWxlcyBhbmQgYWRkIGEgY29tbWVudCBhYm91dCB3aGF0IHRoZXkgYXJlIGZv ci4KKwogMjAxNS0xMC0yMCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgog CiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEphdmFTY3JpcHRDb3JlIHNob3VsZCBwYXJzZSBzb3Vy Y2VVUkwgYW5kIHNvdXJjZU1hcHBpbmdVUkwgZGlyZWN0aXZlcwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRmluZEJhbm5lci5jc3MgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9GaW5kQmFubmVyLmNzcwppbmRl eCA4ODllZWZhLi42MWJhMDA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9GaW5kQmFubmVyLmNzcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9GaW5kQmFubmVyLmNzcwpAQCAtMjE4LDMgKzIxOCw5IEBA IGJvZHkud2luZG93LWluYWN0aXZlIC5maW5kLWJhbm5lciB7CiAuZmluZC1iYW5uZXIuY29uc29s ZS1maW5kLWJhbm5lciA+IGlucHV0W3R5cGU9InNlYXJjaCJdOmZvY3VzIHsKICAgICBiYWNrZ3Jv dW5kLWNvbG9yOiB3aGl0ZTsKIH0KKworLyogTWFrZSB0aGUgc2VhcmNoIGZpZWxkJ3MgYmFja2dy b3VuZCB3aGl0ZSB3aGVuIGl0IGlzIG5vdCBmb2N1c2VkIGFuZCBoYXMgY29udGVudC4KKyAgIE5l ZWRzIHRvIGJlIGEgc2VwYXJhdGUgcnVsZS4gU2VlIGh0dHA6Ly93ZWJraXQub3JnL2IvMTE4MTYy ICovCisuZmluZC1iYW5uZXIuY29uc29sZS1maW5kLWJhbm5lciA+IGlucHV0W3R5cGU9InNlYXJj aCJdOm5vdCg6cGxhY2Vob2xkZXItc2hvd24pIHsKKyAgICBiYWNrZ3JvdW5kLWNvbG9yOiB3aGl0 ZTsKK30KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL1NlYXJjaEJhci5jc3MgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9TZWFyY2hCYXIuY3NzCmluZGV4IDNiMTAxY2QuLjY2YjA5ZmEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NlYXJjaEJhci5jc3MKKysr IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2VhcmNoQmFyLmNz cwpAQCAtNDYsMyArNDYsOSBAQAogLnNlYXJjaC1iYXIgPiBpbnB1dFt0eXBlPSJzZWFyY2giXTpm b2N1cyB7CiAgICAgYmFja2dyb3VuZC1jb2xvcjogd2hpdGU7CiB9CisKKy8qIE1ha2UgdGhlIHNl YXJjaCBmaWVsZCdzIGJhY2tncm91bmQgd2hpdGUgd2hlbiBpdCBpcyBub3QgZm9jdXNlZCBhbmQg aGFzIGNvbnRlbnQuCisgICBOZWVkcyB0byBiZSBhIHNlcGFyYXRlIHJ1bGUuIFNlZSBodHRwOi8v d2Via2l0Lm9yZy9iLzExODE2MiAqLworLnNlYXJjaC1iYXIgPiBpbnB1dFt0eXBlPSJzZWFyY2gi XTpub3QoOnBsYWNlaG9sZGVyLXNob3duKSB7CisgICAgYmFja2dyb3VuZC1jb2xvcjogd2hpdGU7 Cit9Cg==