150446 2015-10-22 08:14:33 -0700 Clean binding generated code for custom attribute setters and getters 2016-06-21 08:03:13 -0700 1 1 1 Unclassified WebKit WebCore JavaScript WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 158068 P2 Normal --- 1 youennf webkit-unassigned ossy oldest_to_newest 1135687 0 youennf 2015-10-22 08:14:33 -0700 As pointed out by Ossy in bug 150438, the binding generator code for custom attribute getters and/or setters should be fixed: > > Source/WebCore/bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:158 > > +EncodedJSValue jsTestJSBuiltinConstructorTestAttributeCustom(ExecState* state, JSObject* slotBase, EncodedJSValue thisValue, PropertyName) > > +{ > > + UNUSED_PARAM(state); > > + UNUSED_PARAM(slotBase); > > + UNUSED_PARAM(thisValue); > > + auto* castedThis = jsCast<JSTestJSBuiltinConstructor*>(slotBase); > > + return JSValue::encode(castedThis->testAttributeCustom(*state)); > > +} > > state and slotBase parameters are used. thisValue is really unused, > but in this case omitting the parameter name would be better. 1135691 1 youennf 2015-10-22 08:25:25 -0700 After a quick look at the binding generator code for attribute getters/setters, it contains many "if" statements. It is not always easy to identify whether each variable is used or not, depending on the different generation options. Hence the current code I guess. 1204143 2 youennf 2016-06-21 08:03:13 -0700 *** This bug has been marked as a duplicate of bug 158068 ***