<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>150440</bug_id>
          
          <creation_ts>2015-10-22 02:05:05 -0700</creation_ts>
          <short_desc>Style checker didn&apos;t catch single-line if statement</short_desc>
          <delta_ts>2026-01-12 09:01:29 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Antoine Quint">graouts</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ahmad.saleem792</cc>
    
    <cc>ddkilzer</cc>
    
    <cc>graouts</cc>
    
    <cc>gsnedders</cc>
    
    <cc>lforschler</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1135635</commentid>
    <comment_count>0</comment_count>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2015-10-22 02:05:05 -0700</bug_when>
    <thetext>My patch at https://bugs.webkit.org/attachment.cgi?id=263680&amp;action=review had the following code:

    } else if (name == SVGNames::onendAttr) {
        setAttributeEventListener(eventNames().endEventEvent, name, value);
    } else
        SVGElement::parseAttribute(name, value);

I added the else if which should not have used braces, but the style bot didn&apos;t report a failure. This sounds like https://bugs.webkit.org/show_bug.cgi?id=28164 but that bug is marked as fixed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2008881</commentid>
    <comment_count>1</comment_count>
    <who name="Sam Sneddon [:gsnedders]">gsnedders</who>
    <bug_when>2024-01-30 04:33:47 -0800</bug_when>
    <thetext>The test is still there: https://github.com/WebKit/WebKit/blob/b28edead7c0c1615e7f7f934c475245e61742fe7/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py#L5433-L5438

So presumably something specific in this case (the else if?) making it not apply.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>