15043 2007-08-21 17:33:04 -0700 KJS::allocateBlock(): posix_memalign takes a void** as its first parameter 2007-08-29 10:41:53 -0700 1 1 1 Unclassified WebKit JavaScriptCore 523.x (Safari 3) All All RESOLVED FIXED P2 Minor --- 0 leavengood webkit-unassigned oldest_to_newest 1754 0 leavengood 2007-08-21 17:33:04 -0700 This clearly is not code that any current port uses, since it should not compile without the change attached. But my port makes use of this since it was already in the code, instead of making another #elsif. But as shown by the documentation here: http://www.opengroup.org/onlinepubs/000095399/functions/posix_memalign.html the function is being called incorrectly. The simple patch attached corrects that. 1750 1 16066 leavengood 2007-08-21 17:35:04 -0700 Created attachment 16066 Fix to posix_memalign call in KJS::allocateBlock 1752 2 16066 darin 2007-08-21 17:38:53 -0700 Comment on attachment 16066 Fix to posix_memalign call in KJS::allocateBlock I also don't think the reinterpret_cast is needed on the next line. 1753 3 leavengood 2007-08-21 17:45:36 -0700 Would you like me to make that change and create another patch, or could you take care of it? :) 1748 4 16067 leavengood 2007-08-21 18:28:52 -0700 Created attachment 16067 The same patch, with the removal of the reinterpret_cast in the memset call 1741 5 ddkilzer 2007-08-21 21:46:35 -0700 (In reply to comment #0) > This clearly is not code that any current port uses, since it should not > compile without the change attached. But my port makes use of this since it was > already in the code, instead of making another #elsif. [...] What port are you working on? :) 1736 6 leavengood 2007-08-22 06:22:52 -0700 (In reply to comment #5) > > What port are you working on? :) I am porting WebKit to Haiku, http://haiku-os.org. It is a clone of BeOS. 1301 7 16067 mjs 2007-08-28 21:17:07 -0700 Comment on attachment 16067 The same patch, with the removal of the reinterpret_cast in the memset call r=me Probably other ports could use memalign too, but don't set the right ifdef so they get the generic mmap-based version. 1243 8 mrowe 2007-08-29 10:41:53 -0700 Landed in r25296. 16066 2007-08-21 17:35:04 -0700 2007-08-21 21:33:26 -0700 Fix to posix_memalign call in KJS::allocateBlock posix_memalign_patch.txt text/plain 1207 leavengood SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI1MTgxKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDctMDgtMjEgIFJ5YW4gTGVh dmVuZ29vZCA8bGVhdmVuZ29vZEBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgLSBwb3NpeF9tZW1hbGlnbiB0YWtlcyBhIHZvaWQqKiBh cyBpdHMgZmlyc3QgcGFyYW1ldGVyLiBNeSBwb3J0IG1ha2VzIHVzZSBvZiB0aGlzIGZ1bmN0aW9u IGNhbGwuCisKKyAgICAgICAgKiBranMvY29sbGVjdG9yLmNwcDoKKyAgICAgICAgKEtKUzo6YWxs b2NhdGVCbG9jayk6CisKIDIwMDctMDgtMTYgIEtldmluIE1jQ3VsbG91Z2ggIDxrbWNjdWxsb3Vn aEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR2VvZmYgYW5kIEFkYW0uCkluZGV4 OiBKYXZhU2NyaXB0Q29yZS9ranMvY29sbGVjdG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2Ny aXB0Q29yZS9ranMvY29sbGVjdG9yLmNwcAkocmV2aXNpb24gMjUxNDkpCisrKyBKYXZhU2NyaXB0 Q29yZS9ranMvY29sbGVjdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTA5LDcgKzEwOSw3IEBA IHN0YXRpYyBDb2xsZWN0b3JCbG9jayogYWxsb2NhdGVCbG9jaygpCiAgICAgTFBWT0lEIGFkZHJl c3MgPSBWaXJ0dWFsQWxsb2MoTlVMTCwgQkxPQ0tfU0laRSwgTUVNX0NPTU1JVCB8IE1FTV9SRVNF UlZFLCBQQUdFX1JFQURXUklURSk7CiAjZWxpZiBIQVZFKFBPU0lYX01FTUFMSUdOKQogICAgIHZv aWQqIGFkZHJlc3M7Ci0gICAgcG9zaXhfbWVtYWxpZ24oYWRkcmVzcywgQkxPQ0tfU0laRSwgQkxP Q0tfU0laRSk7CisgICAgcG9zaXhfbWVtYWxpZ24oJmFkZHJlc3MsIEJMT0NLX1NJWkUsIEJMT0NL X1NJWkUpOwogICAgIG1lbXNldChyZWludGVycHJldF9jYXN0PHZvaWQqPihhZGRyZXNzKSwgMCwg QkxPQ0tfU0laRSk7CiAjZWxzZQogICAgIHN0YXRpYyBzaXplX3QgcGFnZXNpemUgPSBnZXRwYWdl c2l6ZSgpOwogCg== 16067 2007-08-21 18:28:52 -0700 2007-08-28 21:17:07 -0700 The same patch, with the removal of the reinterpret_cast in the memset call posix_memalign_patch.txt text/plain 1248 leavengood SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI1MTgxKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDctMDgtMjEgIFJ5YW4gTGVh dmVuZ29vZCA8bGVhdmVuZ29vZEBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgLSBwb3NpeF9tZW1hbGlnbiB0YWtlcyBhIHZvaWQqKiBh cyBpdHMgZmlyc3QgcGFyYW1ldGVyLiBNeSBwb3J0IG1ha2VzIHVzZSBvZiB0aGlzIGZ1bmN0aW9u IGNhbGwuCisKKyAgICAgICAgKiBranMvY29sbGVjdG9yLmNwcDoKKyAgICAgICAgKEtKUzo6YWxs b2NhdGVCbG9jayk6CisKIDIwMDctMDgtMTYgIEtldmluIE1jQ3VsbG91Z2ggIDxrbWNjdWxsb3Vn aEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR2VvZmYgYW5kIEFkYW0uCkluZGV4 OiBKYXZhU2NyaXB0Q29yZS9ranMvY29sbGVjdG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2Ny aXB0Q29yZS9ranMvY29sbGVjdG9yLmNwcAkocmV2aXNpb24gMjUxNDkpCisrKyBKYXZhU2NyaXB0 Q29yZS9ranMvY29sbGVjdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTA5LDggKzEwOSw4IEBA IHN0YXRpYyBDb2xsZWN0b3JCbG9jayogYWxsb2NhdGVCbG9jaygpCiAgICAgTFBWT0lEIGFkZHJl c3MgPSBWaXJ0dWFsQWxsb2MoTlVMTCwgQkxPQ0tfU0laRSwgTUVNX0NPTU1JVCB8IE1FTV9SRVNF UlZFLCBQQUdFX1JFQURXUklURSk7CiAjZWxpZiBIQVZFKFBPU0lYX01FTUFMSUdOKQogICAgIHZv aWQqIGFkZHJlc3M7Ci0gICAgcG9zaXhfbWVtYWxpZ24oYWRkcmVzcywgQkxPQ0tfU0laRSwgQkxP Q0tfU0laRSk7Ci0gICAgbWVtc2V0KHJlaW50ZXJwcmV0X2Nhc3Q8dm9pZCo+KGFkZHJlc3MpLCAw LCBCTE9DS19TSVpFKTsKKyAgICBwb3NpeF9tZW1hbGlnbigmYWRkcmVzcywgQkxPQ0tfU0laRSwg QkxPQ0tfU0laRSk7CisgICAgbWVtc2V0KGFkZHJlc3MsIDAsIEJMT0NLX1NJWkUpOwogI2Vsc2UK ICAgICBzdGF0aWMgc2l6ZV90IHBhZ2VzaXplID0gZ2V0cGFnZXNpemUoKTsKICAgICAK