150424 2015-10-21 16:56:04 -0700 Web Inspector: Adjust usages of classList.toggle to ensure a true/false value instead of undefined 2015-10-21 17:27:15 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1135461 0 hi 2015-10-21 16:56:04 -0700 Examples of this issue are in VisualStyleDetailsPanel:158 and VisualStylePropertyEditor.js:68. 1135462 1 webkit-bug-importer 2015-10-21 16:56:36 -0700 <rdar://problem/23211505> 1135471 2 263766 hi 2015-10-21 17:12:11 -0700 Created attachment 263766 Patch 1135472 3 hi 2015-10-21 17:12:35 -0700 I don't think I missed any problematic usages, but I was searching using a regex so it's possible I missed one. This is the regex I used: \.classList\.toggle\([^,\n]+,[^\)\n]+\) 1135483 4 263766 commit-queue 2015-10-21 17:27:11 -0700 Comment on attachment 263766 Patch Clearing flags on attachment: 263766 Committed r191417: <http://trac.webkit.org/changeset/191417> 1135484 5 commit-queue 2015-10-21 17:27:15 -0700 All reviewed patches have been landed. Closing bug. 263766 2015-10-21 17:12:11 -0700 2015-10-21 17:27:11 -0700 Patch bug-150424-20151021171127.patch text/plain 3656 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDQ0MmRmMTc5MjRhZjg2MmM2MGQwM2RkMDkzYmMx OTg1ZjFkNGI1NWMuLmE2NTQ5Zjk1NmU2OGNmY2UzMmVmNzA0MGMxMWE5OWFiMzE2YWMzMGUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE1LTEwLTIxICBEZXZp biBSb3Vzc28gIDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29tPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IEFkanVzdCB1c2FnZXMgb2YgY2xhc3NMaXN0LnRvZ2dsZSB0byBlbnN1cmUgYSB0cnVl L2ZhbHNlIHZhbHVlIGluc3RlYWQgb2YgdW5kZWZpbmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTA0MjQKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRzICIhISIgaW4gZnJvbnQgb2YgZm9yY2UgcGFy YW1ldGVycyBpbiBjbGFzc0xpc3QudG9nZ2xlIGNhbGxzIHRoYXQKKyAgICAgICAgY291bGQgcG9z c2libHkgYmUgdW5kZWZpbmVkICh0aGVyZWJ5IGJyZWFraW5nIHRoZSBVSSkuCisKKyAgICAgICAg KiBVc2VySW50ZXJmYWNlL1ZpZXdzL1Njb3BlQmFySXRlbS5qczoKKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5TY29wZUJhckl0ZW0pOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVmlzdWFs U3R5bGVEZXRhaWxzUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVmlzdWFsU3R5bGVE ZXRhaWxzUGFuZWwucHJvdG90eXBlLl91cGRhdGVTZWN0aW9ucyk6CisgICAgICAgICogVXNlcklu dGVyZmFjZS9WaWV3cy9WaXN1YWxTdHlsZVByb3BlcnR5RWRpdG9yLmpzOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLlZpc3VhbFN0eWxlUHJvcGVydHlFZGl0b3IpOgorCiAyMDE1LTEwLTIxICBKb3Nl cGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rv cjogVXNlIHNvbWUgQ1NTIFZhcmlhYmxlcyBpbiBXZWIgSW5zcGVjdG9yCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TY29wZUJhckl0ZW0uanMg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TY29wZUJhckl0ZW0u anMKaW5kZXggMTQ0NzU1YTBiYWY5NTkwZGQxODRmYzYyZWY2MTg2NGY1NGNhZTU4OS4uMDMwYTRm ZGEwMjNiNGMxOTBkYjYyMGRjNzY0MmY1YjdhNzM2ODU2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2NvcGVCYXJJdGVtLmpzCisrKyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Njb3BlQmFySXRlbS5qcwpA QCAtMzAsNyArMzAsNyBAQCBXZWJJbnNwZWN0b3IuU2NvcGVCYXJJdGVtID0gY2xhc3MgU2NvcGVC YXJJdGVtIGV4dGVuZHMgV2ViSW5zcGVjdG9yLk9iamVjdAogICAgICAgICBzdXBlcigpOwogCiAg ICAgICAgIHRoaXMuX2VsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJsaSIpOwotICAg ICAgICB0aGlzLl9lbGVtZW50LmNsYXNzTGlzdC50b2dnbGUoImV4Y2x1c2l2ZSIsIGV4Y2x1c2l2 ZSk7CisgICAgICAgIHRoaXMuX2VsZW1lbnQuY2xhc3NMaXN0LnRvZ2dsZSgiZXhjbHVzaXZlIiwg ISFleGNsdXNpdmUpOwogICAgICAgICB0aGlzLl9lbGVtZW50LmNsYXNzTGlzdC5hZGQoY2xhc3NO YW1lKTsKICAgICAgICAgdGhpcy5fZWxlbWVudC50ZXh0Q29udGVudCA9IGxhYmVsOwogICAgICAg ICB0aGlzLl9lbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoImNsaWNrIiwgdGhpcy5fY2xpY2tlZC5i aW5kKHRoaXMpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL1Zpc3VhbFN0eWxlRGV0YWlsc1BhbmVsLmpzIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVmlzdWFsU3R5bGVEZXRhaWxzUGFuZWwuanMKaW5kZXgg NWIwODU5OTg0MjQ1M2ZkZjBlNTE5MDRhYWJhNGNiZjliMjQ1YTA2Ny4uNDg2ODViNmE2Mjk0OWJh OWJiNWM0ZmFkMzViMzBhZjM4NjU3MjI1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVmlzdWFsU3R5bGVEZXRhaWxzUGFuZWwuanMKKysrIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVmlzdWFsU3R5bGVEZXRh aWxzUGFuZWwuanMKQEAgLTE1NSw3ICsxNTUsNyBAQCBXZWJJbnNwZWN0b3IuVmlzdWFsU3R5bGVE ZXRhaWxzUGFuZWwgPSBjbGFzcyBWaXN1YWxTdHlsZURldGFpbHNQYW5lbCBleHRlbmRzIFdlYgog ICAgICAgICAgICAgcmV0dXJuOwogCiAgICAgICAgIGxldCBkaXNhYmxlZCA9IHRoaXMuX2N1cnJl bnRTdHlsZVtXZWJJbnNwZWN0b3IuVmlzdWFsU3R5bGVEZXRhaWxzUGFuZWwuU3R5bGVEaXNhYmxl ZFN5bWJvbF07Ci0gICAgICAgIHRoaXMuX2VsZW1lbnQuY2xhc3NMaXN0LnRvZ2dsZSgiZGlzYWJs ZWQiLCBkaXNhYmxlZCk7CisgICAgICAgIHRoaXMuX2VsZW1lbnQuY2xhc3NMaXN0LnRvZ2dsZSgi ZGlzYWJsZWQiLCAhIWRpc2FibGVkKTsKICAgICAgICAgaWYgKGRpc2FibGVkKQogICAgICAgICAg ICAgcmV0dXJuOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9WaXN1YWxTdHlsZVByb3BlcnR5RWRpdG9yLmpzIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVmlzdWFsU3R5bGVQcm9wZXJ0eUVkaXRvci5qcwpp bmRleCBiMDkyMDhhMTE5ZThkZDg0ODk1ZWNhNmNiODRiMGFiNWU0ZjJlMDJmLi45OTc3NGNmY2Fl ZmQxN2I3NGMxNzY2ODVhMzgzYTJlNGIwZjNkMmY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9WaXN1YWxTdHlsZVByb3BlcnR5RWRpdG9yLmpz CisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Zpc3VhbFN0 eWxlUHJvcGVydHlFZGl0b3IuanMKQEAgLTY1LDcgKzY1LDcgQEAgV2ViSW5zcGVjdG9yLlZpc3Vh bFN0eWxlUHJvcGVydHlFZGl0b3IgPSBjbGFzcyBWaXN1YWxTdHlsZVByb3BlcnR5RWRpdG9yIGV4 dGVuZHMKIAogICAgICAgICB0aGlzLl9lbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgi ZGl2Iik7CiAgICAgICAgIHRoaXMuX2VsZW1lbnQuY2xhc3NMaXN0LmFkZCgidmlzdWFsLXN0eWxl LXByb3BlcnR5LWNvbnRhaW5lciIsIGNsYXNzTmFtZSk7Ci0gICAgICAgIHRoaXMuX2VsZW1lbnQu Y2xhc3NMaXN0LnRvZ2dsZSgibGF5b3V0LXJldmVyc2VkIiwgbGF5b3V0UmV2ZXJzZWQpOworICAg ICAgICB0aGlzLl9lbGVtZW50LmNsYXNzTGlzdC50b2dnbGUoImxheW91dC1yZXZlcnNlZCIsICEh bGF5b3V0UmV2ZXJzZWQpOwogCiAgICAgICAgIGlmIChsYWJlbCAmJiBsYWJlbC5sZW5ndGgpIHsK ICAgICAgICAgICAgIGxldCB0aXRsZUNvbnRhaW5lciA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQo ImRpdiIpOwo=