150407 2015-10-21 12:35:49 -0700 run-webkit-tests does not copy all crash logs for layout test failures on Mac 2017-03-15 17:18:57 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=150056 P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue dbates dburkart ddkilzer glenn lforschler rniwa oldest_to_newest 1135331 0 aakash_jain 2015-10-21 12:35:49 -0700 Mac specific implementation for https://bugs.webkit.org/show_bug.cgi?id=150056 1135336 1 263715 aakash_jain 2015-10-21 12:46:44 -0700 Created attachment 263715 Proposed patch 1135337 2 aakash_jain 2015-10-21 12:49:28 -0700 This patch is similar to the iOS specific portion of patch for https://bugs.webkit.org/show_bug.cgi?id=150056 1135421 3 263715 ap 2015-10-21 15:17:14 -0700 Comment on attachment 263715 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=263715&action=review > Tools/Scripts/webkitpy/port/mac.py:223 > + def _merge_crash_logs(self, logs, new_logs, crashed_processes): It would be good to avoid copy/pasting this code, as it appears to be the same on iOS. 1135442 4 263715 commit-queue 2015-10-21 16:06:35 -0700 Comment on attachment 263715 Proposed patch Clearing flags on attachment: 263715 Committed r191410: <http://trac.webkit.org/changeset/191410> 1135443 5 commit-queue 2015-10-21 16:06:41 -0700 All reviewed patches have been landed. Closing bug. 263715 2015-10-21 12:46:44 -0700 2015-10-21 16:06:35 -0700 Proposed patch patch_crashlog_mac1.txt text/plain 2689 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE5MTM5NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE1LTEwLTIxICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBydW4td2Via2l0LXRlc3RzIGRvZXMgbm90IGNvcHkgYWxsIGNyYXNoIGxv Z3MgZm9yIGxheW91dCB0ZXN0IGZhaWx1cmVzIG9uIE1hYworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwNDA3CisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS8yMjIzOTc1MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9tYWMucHk6CisgICAgICAgIChNYWNQb3J0Ll9t ZXJnZV9jcmFzaF9sb2dzKTogTWVyZ2UgdW5pcXVlIGNyYXNoIGxvZ3MgZnJvbSB0d28gZGljdGlv bmFyaWVzLgorICAgICAgICAoTWFjUG9ydC5fbG9va19mb3JfYWxsX2NyYXNoX2xvZ3NfaW5fbG9n X2Rpcik6IEdldCB0aGUgY3Jhc2ggbG9ncyBmcm9tCisgICAgICAgIHRoZSBsb2cgZGlyZWN0b3J5 LgorICAgICAgICAoTWFjUG9ydC5sb29rX2Zvcl9uZXdfY3Jhc2hfbG9ncyk6IFVzZXMgYWJvdmUg bWV0aG9kIHRvIGdldCBjcmFzaCBsb2dzCisgICAgICAgIGZyb20gbG9nIGRpcmVjdG9yeSBhbmQg bWVyZ2UgdGhlbSB3aXRoIHRoZSBsaXN0IG9mIGFscmVhZHkgY3Jhc2hlZCB0ZXN0cy4KKwogMjAx NS0xMC0yMSAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIEZhaWx1 cmVzIGluIFB1dFN0YWNrU2lua2luZ1BoYXNlIHNob3VsZCBiZSBsZXNzIHNldmVyZQpJbmRleDog VG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L21hYy5weQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9T Y3JpcHRzL3dlYmtpdHB5L3BvcnQvbWFjLnB5CShyZXZpc2lvbiAxOTEzOTUpCisrKyBUb29scy9T Y3JpcHRzL3dlYmtpdHB5L3BvcnQvbWFjLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yMjAsNiArMjIw LDIyIEBAIGNsYXNzIE1hY1BvcnQoQXBwbGVQb3J0KToKICAgICAgICAgICAgIHJldHVybiAoc3Rk ZXJyLCBOb25lKQogICAgICAgICByZXR1cm4gKHN0ZGVyciwgY3Jhc2hfbG9nKQogCisgICAgZGVm IF9tZXJnZV9jcmFzaF9sb2dzKHNlbGYsIGxvZ3MsIG5ld19sb2dzLCBjcmFzaGVkX3Byb2Nlc3Nl cyk6CisgICAgICAgIGZvciB0ZXN0LCBjcmFzaF9sb2cgaW4gbmV3X2xvZ3MuaXRlcml0ZW1zKCk6 CisgICAgICAgICAgICB0cnk6CisgICAgICAgICAgICAgICAgcHJvY2Vzc19uYW1lID0gdGVzdC5z cGxpdCgiLSIpWzBdCisgICAgICAgICAgICAgICAgcGlkID0gaW50KHRlc3Quc3BsaXQoIi0iKVsx XSkKKyAgICAgICAgICAgIGV4Y2VwdCBJbmRleEVycm9yOgorICAgICAgICAgICAgICAgIGNvbnRp bnVlCisgICAgICAgICAgICBpZiBub3QgYW55KGVudHJ5WzFdID09IHByb2Nlc3NfbmFtZSBhbmQg ZW50cnlbMl0gPT0gcGlkIGZvciBlbnRyeSBpbiBjcmFzaGVkX3Byb2Nlc3Nlcyk6CisgICAgICAg ICAgICAgICAgIyBpZiB0aGlzIGlzIGEgbmV3IGNyYXNoLCB0aGVuIGFwcGVuZCB0aGUgbG9ncwor ICAgICAgICAgICAgICAgIGxvZ3NbdGVzdF0gPSBjcmFzaF9sb2cKKyAgICAgICAgcmV0dXJuIGxv Z3MKKworICAgIGRlZiBfbG9va19mb3JfYWxsX2NyYXNoX2xvZ3NfaW5fbG9nX2RpcihzZWxmLCBu ZXdlcl90aGFuKToKKyAgICAgICAgY3Jhc2hfbG9nID0gQ3Jhc2hMb2dzKHNlbGYuaG9zdCkKKyAg ICAgICAgcmV0dXJuIGNyYXNoX2xvZy5maW5kX2FsbF9sb2dzKGluY2x1ZGVfZXJyb3JzPVRydWUs IG5ld2VyX3RoYW49bmV3ZXJfdGhhbikKKwogICAgIGRlZiBsb29rX2Zvcl9uZXdfY3Jhc2hfbG9n cyhzZWxmLCBjcmFzaGVkX3Byb2Nlc3Nlcywgc3RhcnRfdGltZSk6CiAgICAgICAgICIiIlNpbmNl IGNyYXNoIGxvZ3MgY2FuIHRha2UgYSBsb25nIHRpbWUgdG8gYmUgd3JpdHRlbiBvdXQgaWYgdGhl IHN5c3RlbSBpcwogICAgICAgICAgICB1bmRlciBzdHJlc3MgZG8gYSBzZWNvbmQgcGFzcyBhdCB0 aGUgZW5kIG9mIHRoZSB0ZXN0IHJ1bi4KQEAgLTIzNiw3ICsyNTIsOCBAQCBjbGFzcyBNYWNQb3J0 KEFwcGxlUG9ydCk6CiAgICAgICAgICAgICBpZiBub3QgY3Jhc2hfbG9nOgogICAgICAgICAgICAg ICAgIGNvbnRpbnVlCiAgICAgICAgICAgICBjcmFzaF9sb2dzW3Rlc3RfbmFtZV0gPSBjcmFzaF9s b2cKLSAgICAgICAgcmV0dXJuIGNyYXNoX2xvZ3MKKyAgICAgICAgYWxsX2NyYXNoX2xvZyA9IHNl bGYuX2xvb2tfZm9yX2FsbF9jcmFzaF9sb2dzX2luX2xvZ19kaXIoc3RhcnRfdGltZSkKKyAgICAg ICAgcmV0dXJuIHNlbGYuX21lcmdlX2NyYXNoX2xvZ3MoY3Jhc2hfbG9ncywgYWxsX2NyYXNoX2xv ZywgY3Jhc2hlZF9wcm9jZXNzZXMpCiAKICAgICBkZWYgbG9va19mb3JfbmV3X3NhbXBsZXMoc2Vs ZiwgdW5yZXNwb25zaXZlX3Byb2Nlc3Nlcywgc3RhcnRfdGltZSk6CiAgICAgICAgIHNhbXBsZV9m aWxlcyA9IHt9Cg==