150404 2015-10-21 12:00:42 -0700 Web Inspector: Array previews with Symbol objects have too few preview values 2015-10-21 12:57:35 -0700 1 1 1 Unclassified WebKit Web Inspector Other All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1135318 0 joepeck 2015-10-21 12:00:42 -0700 * SUMMARY Array previews with Symbol objects have too few preview values * STEPS TO REPRODUCE 1. js> [Symbol(), 1, 2, 3, 4] => [Symbol()], expected [Symbol(), 1, 2, 3, 4] 1135319 1 joepeck 2015-10-21 12:01:14 -0700 I think I see what is wrong. _generatePreview has a `return` instead of a `continue` in a loop when handling Symbol values. 1135320 2 263709 joepeck 2015-10-21 12:08:36 -0700 Created attachment 263709 [PATCH] Proposed Fix 1135346 3 263709 commit-queue 2015-10-21 12:57:32 -0700 Comment on attachment 263709 [PATCH] Proposed Fix Clearing flags on attachment: 263709 Committed r191397: <http://trac.webkit.org/changeset/191397> 1135347 4 commit-queue 2015-10-21 12:57:35 -0700 All reviewed patches have been landed. Closing bug. 263709 2015-10-21 12:08:36 -0700 2015-10-21 12:57:32 -0700 [PATCH] Proposed Fix loop.patch text/plain 1354 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDg0NTUzNzEuLjk4YmJkZTAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE1LTEwLTIxICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQXJyYXkg cHJldmlld3Mgd2l0aCBTeW1ib2wgb2JqZWN0cyBoYXZlIHRvbyBmZXcgcHJldmlldyB2YWx1ZXMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDQwNAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVj dG9yL0luamVjdGVkU2NyaXB0U291cmNlLmpzOgorICAgICAgICAoSW5qZWN0ZWRTY3JpcHQuUmVt b3RlT2JqZWN0LnByb3RvdHlwZS5fYXBwZW5kUHJvcGVydHlQcmV2aWV3cyk6CisgICAgICAgIFdl IHNob3VsZCBiZSBjb250aW51aW5nIGluc2lkZSB0aGlzIGxvb3Agbm90IHJldHVybmluZy4KKwog MjAxNS0xMC0yMSAgR3VpbGxhdW1lIEVtb250ICA8Z3VpamVtb250QGlnYWxpYS5jb20+CiAKICAg ICAgICAgbGxpbnQ6IGFsaWduIHN0YWNrIHBvaW50ZXIgb24gbWlwcyB0b28KZGlmZiAtLWdpdCBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRTb3VyY2UuanMg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0U291cmNlLmpz CmluZGV4IGFlODFkNTEuLmE0NThmNDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRTb3VyY2UuanMKKysrIGIvU291cmNlL0phdmFTY3Jp cHRDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdFNvdXJjZS5qcwpAQCAtMTE4NSw3ICsxMTg1 LDcgQEAgSW5qZWN0ZWRTY3JpcHQuUmVtb3RlT2JqZWN0LnByb3RvdHlwZSA9IHsKICAgICAgICAg ICAgICAgICAgICAgcHJldmlldy5sb3NzbGVzcyA9IGZhbHNlOwogICAgICAgICAgICAgICAgIH0K ICAgICAgICAgICAgICAgICB0aGlzLl9hcHBlbmRQcm9wZXJ0eVByZXZpZXcocHJldmlldywgaW50 ZXJuYWwsIHtuYW1lLCB0eXBlLCB2YWx1ZTogc3ltYm9sU3RyaW5nfSwgcHJvcGVydGllc1RocmVz aG9sZCk7Ci0gICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAgICAgICAgIGNvbnRpbnVl OwogICAgICAgICAgICAgfQogCiAgICAgICAgICAgICAvLyBPYmplY3QuCg==