150400 2015-10-21 11:29:30 -0700 Failures in PutStackSinkingPhase should be less severe 2015-10-21 11:46:52 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo oldest_to_newest 1135297 0 fpizlo 2015-10-21 11:29:30 -0700 Patch forthcoming. 1135301 1 263707 fpizlo 2015-10-21 11:32:39 -0700 Created attachment 263707 the patch 1135306 2 263707 ggaren 2015-10-21 11:36:40 -0700 Comment on attachment 263707 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=263707&action=review r=me > Source/JavaScriptCore/dfg/DFGPutStackSinkingPhase.cpp:254 > + // enabled we silently let this fly and we just abort this phase. enabled => disabled > Source/JavaScriptCore/dfg/DFGPutStackSinkingPhase.cpp:265 > + // Oh noes! Abort!! O HAI IZ LOL CODE? https://esolangs.org/wiki/LOLCODE 1135309 3 fpizlo 2015-10-21 11:37:48 -0700 (In reply to comment #2) > Comment on attachment 263707 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=263707&action=review > > r=me > > > Source/JavaScriptCore/dfg/DFGPutStackSinkingPhase.cpp:254 > > + // enabled we silently let this fly and we just abort this phase. > > enabled => disabled Fixed. > > > Source/JavaScriptCore/dfg/DFGPutStackSinkingPhase.cpp:265 > > + // Oh noes! Abort!! > > O HAI IZ LOL CODE? https://esolangs.org/wiki/LOLCODE Should I fix it? ;-) 1135315 4 fpizlo 2015-10-21 11:46:52 -0700 Landed in http://trac.webkit.org/changeset/191395 263707 2015-10-21 11:32:39 -0700 2015-10-21 11:36:40 -0700 the patch blah.patch text/plain 6500 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTkxMzkxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE1LTEwLTIxICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RmFpbHVyZXMgaW4gUHV0U3RhY2tTaW5raW5nUGhhc2Ugc2hvdWxkIGJlIGxlc3Mgc2V2ZXJlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTA0MDAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIHRoZSBQ dXRTdGFja1NpbmtpbmdQaGFzZSBhYm9ydCBpbnN0ZWFkIG9mIGFzc2VydGluZy4gVG8gdGVzdCB0 aGF0IGl0J3MgT0sgdG8gbm90IGhhdmUKKyAgICAgICAgUHV0U3RhY2tTaW5raW5nUGhhc2UgcnVu LCB0aGlzIGFkZHMgYSB0ZXN0IG1vZGUgd2hlcmUgd2UgcnVuIHdpdGhvdXQgUHV0U3RhY2tTaW5r aW5nUGhhc2UuCisKKyAgICAgICAgKiBkZmcvREZHUGxhbi5jcHA6IE1ha2UgaXQgcG9zc2libGUg dG8gbm90IHJ1biBQdXRTdGFja1NpbmtpbmdQaGFzZSBmb3IgdGVzdHMuCisgICAgICAgIChKU0M6 OkRGRzo6UGxhbjo6Y29tcGlsZUluVGhyZWFkSW1wbCk6CisgICAgICAgICogZGZnL0RGR1B1dFN0 YWNrU2lua2luZ1BoYXNlLmNwcDogUHV0U3RhY2tTaW5raW5nUGhhc2Ugc2hvdWxkIGFib3J0IGlu c3RlYWQgb2YgYXNzZXJ0aW5nLCBleGNlcHQgd2hlbiB2YWxpZGF0aW9uIGlzIGVuYWJsZWQuCisg ICAgICAgICogcnVudGltZS9PcHRpb25zLmg6IEFkZCBhbiBvcHRpb24gZm9yIGRpc2FibGluZyBQ dXRTdGFja1NpbmtpbmdQaGFzZS4KKwogMjAxNS0xMC0yMSAgR3VpbGxhdW1lIEVtb250ICA8Z3Vp amVtb250QGlnYWxpYS5jb20+CiAKICAgICAgICAgbGxpbnQ6IGFsaWduIHN0YWNrIHBvaW50ZXIg b24gbWlwcyB0b28KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHUGxhbi5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdQbGFuLmNwcAkocmV2 aXNpb24gMTkxMzkxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdQbGFuLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMzk0LDcgKzM5NCw4IEBAIFBsYW46OkNvbXBpbGF0aW9uUGF0aCBQ bGFuOjpjb21waWxlSW5UaHIKICAgICAgICAgCiAgICAgICAgIC8vIElkZWFsbHksIHRoZXNlIHdv dWxkIGJlIHJ1biB0byBmaXhwb2ludCB3aXRoIHRoZSBvYmplY3QgYWxsb2NhdGlvbiBzaW5raW5n IHBoYXNlLgogICAgICAgICBwZXJmb3JtQXJndW1lbnRzRWxpbWluYXRpb24oZGZnKTsKLSAgICAg ICAgcGVyZm9ybVB1dFN0YWNrU2lua2luZyhkZmcpOworICAgICAgICBpZiAoT3B0aW9uczo6dXNl UHV0U3RhY2tTaW5raW5nKCkpCisgICAgICAgICAgICBwZXJmb3JtUHV0U3RhY2tTaW5raW5nKGRm Zyk7CiAgICAgICAgIAogICAgICAgICBwZXJmb3JtQ29uc3RhbnRIb2lzdGluZyhkZmcpOwogICAg ICAgICBwZXJmb3JtR2xvYmFsQ1NFKGRmZyk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv ZGZnL0RGR1B1dFN0YWNrU2lua2luZ1BoYXNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR1B1dFN0YWNrU2lua2luZ1BoYXNlLmNwcAkocmV2aXNpb24gMTkx MzkxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdQdXRTdGFja1NpbmtpbmdQaGFz ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIzMywxMCArMjMzLDM5IEBAIHB1YmxpYzoKICAgICAg ICAgICAgICAgICAgICAgICAgIGRhdGFMb2coIkRlZmVycmVkIGF0ICIsIG5vZGUsICI6IiwgZGVm ZXJyZWQsICJcbiIpOwogICAgICAgICAgICAgICAgICAgICAKICAgICAgICAgICAgICAgICAgICAg aWYgKG5vZGUtPm9wKCkgPT0gR2V0U3RhY2spIHsKLSAgICAgICAgICAgICAgICAgICAgICAgIERG R19BU1NFUlQoCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgbV9ncmFwaCwgbm9kZSwKLSAg ICAgICAgICAgICAgICAgICAgICAgICAgICBkZWZlcnJlZC5vcGVyYW5kKG5vZGUtPnN0YWNrQWNj ZXNzRGF0YSgpLT5sb2NhbCkgIT0gQ29uZmxpY3RpbmdGbHVzaCk7CisgICAgICAgICAgICAgICAg ICAgICAgICAvLyBIYW5kbGUgdGhlIGNhc2UgdGhhdCB0aGUgaW5wdXQgZG9lc24ndCBtYXRjaCBv dXIgcmVxdWlyZW1lbnRzLiBUaGlzIGlzCisgICAgICAgICAgICAgICAgICAgICAgICAvLyByZWFs bHkgYSBidWcsIGJ1dCBpdCdzIGEgYmVuaWduIG9uZSBpZiB3ZSBzaW1wbHkgZG9uJ3QgcnVuIHRo aXMgcGhhc2UuCisgICAgICAgICAgICAgICAgICAgICAgICAvLyBJdCB1c3VhbGx5IGFyaXNlcyBi ZWNhdXNlIG9mIHBhdHRlcm5zIGxpa2U6CisgICAgICAgICAgICAgICAgICAgICAgICAvLworICAg ICAgICAgICAgICAgICAgICAgICAgLy8gaWYgKHRoaW5nKQorICAgICAgICAgICAgICAgICAgICAg ICAgLy8gICAgIFB1dFN0YWNrKCkKKyAgICAgICAgICAgICAgICAgICAgICAgIC8vIC4uLgorICAg ICAgICAgICAgICAgICAgICAgICAgLy8gaWYgKHRoaW5nKQorICAgICAgICAgICAgICAgICAgICAg ICAgLy8gICAgIEdldFN0YWNrKCkKKyAgICAgICAgICAgICAgICAgICAgICAgIC8vCisgICAgICAg ICAgICAgICAgICAgICAgICAvLyBPcjoKKyAgICAgICAgICAgICAgICAgICAgICAgIC8vCisgICAg ICAgICAgICAgICAgICAgICAgICAvLyBpZiAobmV2ZXIgaGFwcGVucykKKyAgICAgICAgICAgICAg ICAgICAgICAgIC8vICAgICBHZXRTdGFjaygpCisgICAgICAgICAgICAgICAgICAgICAgICAvLwor ICAgICAgICAgICAgICAgICAgICAgICAgLy8gQmVjYXVzZSB0aGlzIHBoYXNlIHJ1bnMgZWFybHkg aW4gU1NBLCBpdCBzaG91bGQgYmUgc2Vuc2libGUgdG8gZW5mb3JjZQorICAgICAgICAgICAgICAg ICAgICAgICAgLy8gdGhhdCBubyBzdWNoIGNvZGUgcGF0dGVybiBoYXMgYXJpc2VuIHlldC4gU28s IHdoZW4gdmFsaWRhdGlvbiBpcworICAgICAgICAgICAgICAgICAgICAgICAgLy8gZW5hYmxlZCwg d2UgYXNzZXJ0IHRoYXQgd2UgYXJlbid0IHNlZWluZyB0aGlzLiBCdXQgd2l0aCB2YWxpZGF0aW9u CisgICAgICAgICAgICAgICAgICAgICAgICAvLyBlbmFibGVkIHdlIHNpbGVudGx5IGxldCB0aGlz IGZseSBhbmQgd2UganVzdCBhYm9ydCB0aGlzIHBoYXNlLgorICAgICAgICAgICAgICAgICAgICAg ICAgLy8gRklYTUU6IEdldCByaWQgb2YgYWxsIHJlbWFpbmluZyBjYXNlcyBvZiBjb25mbGljdGlu ZyBHZXRTdGFja3MuCisgICAgICAgICAgICAgICAgICAgICAgICAvLyBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwMzk4CisKKyAgICAgICAgICAgICAgICAgICAgICAg IGJvb2wgaXNDb25mbGljdGluZyA9CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgZGVmZXJy ZWQub3BlcmFuZChub2RlLT5zdGFja0FjY2Vzc0RhdGEoKS0+bG9jYWwpID09IENvbmZsaWN0aW5n Rmx1c2g7CiAgICAgICAgICAgICAgICAgICAgICAgICAKKyAgICAgICAgICAgICAgICAgICAgICAg IGlmICh2YWxpZGF0aW9uRW5hYmxlZCgpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgIERG R19BU1NFUlQobV9ncmFwaCwgbm9kZSwgIWlzQ29uZmxpY3RpbmcpOworCisgICAgICAgICAgICAg ICAgICAgICAgICBpZiAoaXNDb25mbGljdGluZykgeworICAgICAgICAgICAgICAgICAgICAgICAg ICAgIC8vIE9oIG5vZXMhIEFib3J0ISEKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICByZXR1 cm4gZmFsc2U7CisgICAgICAgICAgICAgICAgICAgICAgICB9CisKICAgICAgICAgICAgICAgICAg ICAgICAgIC8vIEEgR2V0U3RhY2sgZG9lc24ndCBhZmZlY3QgYW55dGhpbmcsIHNpbmNlIHdlIGtu b3cgd2hpY2ggbG9jYWwgd2UgYXJlIHJlYWRpbmcKICAgICAgICAgICAgICAgICAgICAgICAgIC8v IGZyb20uCiAgICAgICAgICAgICAgICAgICAgICAgICBjb250aW51ZTsKSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL09wdGlvbnMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9PcHRpb25zLmgJKHJldmlzaW9uIDE5MTM5MSkKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09wdGlvbnMuaAkod29ya2luZyBjb3B5KQpAQCAtMjAy LDYgKzIwMiw3IEBAIHR5cGVkZWYgY29uc3QgY2hhciogb3B0aW9uU3RyaW5nOwogICAgIHYoZG91 YmxlLCBtaW5pbXVtQ2FsbFRvS25vd25SYXRlLCAwLjUxLCBudWxscHRyKSBcCiAgICAgdihib29s LCBjcmVhdGVQcmVIZWFkZXJzLCB0cnVlLCBudWxscHRyKSBcCiAgICAgdihib29sLCB1c2VNb3ZI aW50UmVtb3ZhbCwgdHJ1ZSwgbnVsbHB0cikgXAorICAgIHYoYm9vbCwgdXNlUHV0U3RhY2tTaW5r aW5nLCB0cnVlLCBudWxscHRyKSBcCiAgICAgdihib29sLCB1c2VPYmplY3RBbGxvY2F0aW9uU2lu a2luZywgdHJ1ZSwgbnVsbHB0cikgXAogICAgIHYoYm9vbCwgdXNlQ29weUJhcnJpZXJPcHRpbWl6 YXRpb24sIHRydWUsIG51bGxwdHIpIFwKICAgICBcCkluZGV4OiBUb29scy9DaGFuZ2VMb2cKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxOTEzOTIpCisrKyBUb29scy9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxNS0xMC0yMSAgRmls aXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgorCisgICAgICAgIEZhaWx1cmVzIGluIFB1dFN0 YWNrU2lua2luZ1BoYXNlIHNob3VsZCBiZSBsZXNzIHNldmVyZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwNDAwCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgdGVzdCBtb2RlIGZvciBubyBQdXRT dGFja1NpbmtpbmdQaGFzZS4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVz dHM6CisKIDIwMTUtMTAtMjEgIE5hbiBXYW5nICA8bl93YW5nQGFwcGxlLmNvbT4KIAogICAgICAg ICBBWDogRXhwb3NlIHRhYmxlIHNpemUgYW5kIGNlbGwgaW5kZXhlcyBvbiBpT1MKSW5kZXg6IFRv b2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHMKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2Ny aXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwkocmV2aXNpb24gMTkxMzkxKQorKysgVG9vbHMvU2Ny aXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwkod29ya2luZyBjb3B5KQpAQCAtNzQ2LDYgKzc0Niwx MCBAQCBkZWYgcnVuRlRMTm9DSklUVmFsaWRhdGUKICAgICBydW4oImZ0bC1uby1jaml0LXZhbGlk YXRlIiwgIi0tdmFsaWRhdGVHcmFwaD10cnVlIiwgKihGVExfT1BUSU9OUyArIE5PX0NKSVRfT1BU SU9OUykpIGlmICRlbmFibGVGVEwKIGVuZAogCitkZWYgcnVuRlRMTm9DSklUTm9QdXRTdGFja1Zh bGlkYXRlCisgICAgcnVuKCJmdGwtbm8tY2ppdC1uby1wdXQtc3RhY2stdmFsaWRhdGUiLCAiLS12 YWxpZGF0ZUdyYXBoPXRydWUiLCAiLS11c2VQdXRTdGFja1Npbmtpbmc9ZmFsc2UiLCAqKEZUTF9P UFRJT05TICsgTk9fQ0pJVF9PUFRJT05TKSkgaWYgJGVuYWJsZUZUTAorZW5kCisKIGRlZiBydW5G VExOb0NKSVROb0lubGluZVZhbGlkYXRlCiAgICAgcnVuKCJmdGwtbm8tY2ppdC1uby1pbmxpbmUt dmFsaWRhdGUiLCAiLS12YWxpZGF0ZUdyYXBoPXRydWUiLCAiLS1tYXhpbXVtSW5saW5pbmdEZXB0 aD0xIiwgKihGVExfT1BUSU9OUyArIE5PX0NKSVRfT1BUSU9OUykpIGlmICRlbmFibGVGVEwKIGVu ZApAQCAtODIzLDYgKzgyNyw3IEBAIGRlZiBkZWZhdWx0UnVuCiAgICAgICAgICAgICBydW5ERkdF YWdlck5vQ0pJVFZhbGlkYXRlCiAgICAgICAgICAgICBydW5EZWZhdWx0RlRMCiAgICAgICAgICAg ICBydW5GVExOb0NKSVRWYWxpZGF0ZQorICAgICAgICAgICAgcnVuRlRMTm9DSklUTm9QdXRTdGFj a1ZhbGlkYXRlCiAgICAgICAgICAgICBydW5GVExOb0NKSVROb0lubGluZVZhbGlkYXRlCiAgICAg ICAgICAgICBydW5GVExFYWdlcgogICAgICAgICAgICAgcnVuRlRMRWFnZXJOb0NKSVRWYWxpZGF0 ZQo=