150396 2015-10-21 10:09:57 -0700 check-webkit-style complains about missing operator whitespace inside character literal 2015-10-24 16:37:07 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 150394 150451 1 fred.wang fred.wang commit-queue glenn lforschler ossy oldest_to_newest 1135257 0 fred.wang 2015-10-21 10:09:57 -0700 Bug 150394, contains a patch that loads the OS/2 table as follows: CFDataRef os2Table = CGFontCopyTableForTag(m_platformData.cgFont(), 'OS/2') Here 'OS/2' is a character literal (32 bit integer) used as a tag representing the TrueType table. The slash is not used as an operator, however check-webkit-style complains with the following message: ERROR: Source/WebCore/platform/graphics/cocoa/FontCocoa.mm:179: Missing spaces around / [whitespace/operators] [3] 1136257 1 263979 fred.wang 2015-10-24 08:52:58 -0700 Created attachment 263979 Patch 1136259 2 fred.wang 2015-10-24 08:56:24 -0700 Note that the 'OS/2' case is already in the source code: https://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/cocoa/FontCocoa.mm#L284 1136267 3 263979 ossy 2015-10-24 12:21:04 -0700 Comment on attachment 263979 Patch Could you please add a new unittest covers this change? 1136269 4 ossy 2015-10-24 12:22:03 -0700 (In reply to comment #3) > Comment on attachment 263979 [details] > Patch > > Could you please add a new unittest covers this change? Sorry, please ignore this comment. 1136305 5 fred.wang 2015-10-24 16:37:07 -0700 Committed r191538: <http://trac.webkit.org/changeset/191538> 263979 2015-10-24 08:52:58 -0700 2015-10-24 15:40:25 -0700 Patch bug-150396-20151024175211.patch text/plain 2761 fred.wang U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxNTMzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTkwNzJiYTBkZjg3ZDRlYWVlN2ExMzQ2MjQzOGE4OTll MjI2YWIyYi4uN2IwMTRlNmQzOWRiMTM2NDMzOTc1MDg0MWU5YjY3Zjg3MjFjNGZmOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE1LTEwLTI0ICBGcmVkZXJpYyBXYW5nICA8ZnJlZC53YW5nQGZyZWUuZnI+CisKKyAg ICAgICAgY2hlY2std2Via2l0LXN0eWxlIGNvbXBsYWlucyBhYm91dCBtaXNzaW5nIG9wZXJhdG9y IHdoaXRlc3BhY2UgaW5zaWRlIGNoYXJhY3RlciBsaXRlcmFsCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTAzOTYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hl Y2tlcnMvY3BwLnB5OiBJbXByb3ZlIG1hdGNoaW5nIG9mIEMrKyBjaGFyYWN0ZXIgbGl0ZXJhbC4K KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5w eToKKyAgICAgICAgKFdlYktpdFN0eWxlVGVzdC50ZXN0X3NwYWNpbmcpOiBBZGQgYSB0ZXN0IHRv IHZlcmlmeSB0aGF0IHRoZSBzcGFjaW5nIGZvciB0aGUgY2hhcmFjdGVyIGxpdGVyYWwgJ09TLzIn IGlzIG5vdCB0ZXN0ZWQuCisKIDIwMTUtMTAtMjMgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBh cHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjE3OTM1Ny1yMTc5MzU5KTogV2ViQ29u dGVudCBDcmFzaCB1c2luZyBBT0wgTWFpbCBAIGNvbS5hcHBsZS5KYXZhc2NyaXB0Q29yZSBKU0M6 OmxpbmtQb2x5bW9ycGhpY0NhbGwoSlNDOjpFeGVjU3RhdGUqLCBKU0M6OkNhbGxMaW5rSW5mbyYs IEpTQzo6Q2FsbFZhcmlhbnQsIEpTQzo6UmVnaXN0ZXJQcmVzZXJ2YXRpb25Nb2RlKSArIDE1ODQK ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5 IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKaW5kZXggNGVj ZTRiODIxYjk5NThjNWQ3ZWVlMjc4YmYwOTkwOWY3N2Q0ODE2OC4uNjJmMjJlYjhjMzJlMzFlY2Zm Mzc5NDRjOWNmNzQ3MmYxN2YxMjc1ZSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9zdHlsZS9jaGVja2Vycy9jcHAucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHls ZS9jaGVja2Vycy9jcHAucHkKQEAgLTY4NSw3ICs2ODUsNyBAQCBfUkVfUEFUVEVSTl9DTEVBTlNF X0xJTkVfRVNDQVBFUyA9IHJlLmNvbXBpbGUoCiAjIE1hdGNoZXMgc3RyaW5ncy4gIEVzY2FwZSBj b2RlcyBzaG91bGQgYWxyZWFkeSBiZSByZW1vdmVkIGJ5IEVTQ0FQRVMuCiBfUkVfUEFUVEVSTl9D TEVBTlNFX0xJTkVfRE9VQkxFX1FVT1RFUyA9IHJlLmNvbXBpbGUociciW14iXSoiJykKICMgTWF0 Y2hlcyBjaGFyYWN0ZXJzLiAgRXNjYXBlIGNvZGVzIHNob3VsZCBhbHJlYWR5IGJlIHJlbW92ZWQg YnkgRVNDQVBFUy4KLV9SRV9QQVRURVJOX0NMRUFOU0VfTElORV9TSU5HTEVfUVVPVEVTID0gcmUu Y29tcGlsZShyIicuJyIpCitfUkVfUEFUVEVSTl9DTEVBTlNFX0xJTkVfU0lOR0xFX1FVT1RFUyA9 IHJlLmNvbXBpbGUociInW14nXXsxLDR9JyIpCiAjIE1hdGNoZXMgbXVsdGktbGluZSBDKysgY29t bWVudHMuCiAjIFRoaXMgUkUgaXMgYSBsaXR0bGUgYml0IG1vcmUgY29tcGxpY2F0ZWQgdGhhbiBv bmUgbWlnaHQgZXhwZWN0LCBiZWNhdXNlIHdlCiAjIGhhdmUgdG8gdGFrZSBjYXJlIG9mIHNwYWNl IHJlbW92YWxzIHRvb2xzIHNvIHdlIGNhbiBoYW5kbGUgY29tbWVudHMgaW5zaWRlCmRpZmYgLS1n aXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5w eSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5 CmluZGV4IDUzYmUwMTY3ZTk1YmMzMWZlZGE2YmZlMDNlMGFjZjEyZDMwODQ1ZmQuLmYzOWM2Yzg2 Mzg1NGEyOTdjY2UwOTU4MTljMDE2MThlOTEyOTAxMjYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CkBAIC00MDE1LDYg KzQwMTUsMTEgQEAgY2xhc3MgV2ViS2l0U3R5bGVUZXN0KENwcFN0eWxlVGVzdEJhc2UpOgogICAg ICAgICAgICAgWydFeHRyYSBzcGFjZSBhZnRlciAoIGluIGZ1bmN0aW9uIGNhbGwgIFt3aGl0ZXNw YWNlL3BhcmVuc10gWzRdJywKICAgICAgICAgICAgICAnRXh0cmEgc3BhY2UgYmVmb3JlICkgIFt3 aGl0ZXNwYWNlL3BhcmVuc10gWzJdJ10pCiAKKyAgICAgICAgIyBJZ25vcmUgc3BhY2luZyBpbnNp ZGUgZm91ciBjaGFyIGNvZGUuCisgICAgICAgIHNlbGYuYXNzZXJ0X211bHRpX2xpbmVfbGludCgK KyAgICAgICAgICAgICdDVEZvbnRUYWJsZVRhZyBvczJUYWcgPSBcJ09TLzJcJzsnLAorICAgICAg ICAgICAgJycpCisKICAgICBkZWYgdGVzdF9saW5lX2JyZWFraW5nKHNlbGYpOgogICAgICAgICAj IDEuIEVhY2ggc3RhdGVtZW50IHNob3VsZCBnZXQgaXRzIG93biBsaW5lLgogICAgICAgICBzZWxm LmFzc2VydF9tdWx0aV9saW5lX2xpbnQoCg==