150395 2015-10-21 10:00:14 -0700 [iOS] Allow clients to specify a custom input view to be used for a form input session 2015-10-24 08:55:01 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz andersca dbates thorton wenson_hsieh oldest_to_newest 1135242 0 mitz 2015-10-21 10:00:14 -0700 [iOS] Allow clients to specify a custom input view to be used for a form input session 1135249 1 263691 mitz 2015-10-21 10:02:24 -0700 Created attachment 263691 Add customInputView property to _WKFormInputSession 1135268 2 263691 wenson_hsieh 2015-10-21 10:24:58 -0700 Comment on attachment 263691 Add customInputView property to _WKFormInputSession View in context: https://bugs.webkit.org/attachment.cgi?id=263691&action=review > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:236 > + RetainPtr<UIView> _customInputView; Adding the WKFocusedElementInfo here would help third-party clients determine what custom view they want to show, since they won't have access to userObject when (if) we make this public. 1135273 3 mitz 2015-10-21 10:42:42 -0700 (In reply to comment #2) > Comment on attachment 263691 [details] > Add customInputView property to _WKFormInputSession > > View in context: > https://bugs.webkit.org/attachment.cgi?id=263691&action=review > > > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:236 > > + RetainPtr<UIView> _customInputView; > > Adding the WKFocusedElementInfo here would help third-party clients > determine what custom view they want to show, since they won't have access > to userObject when (if) we make this public. Agreed! I should do that in a separate patch. 1136127 4 mitz 2015-10-23 13:40:51 -0700 (In reply to comment #3) > (In reply to comment #2) > > Comment on attachment 263691 [details] > > Add customInputView property to _WKFormInputSession > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=263691&action=review > > > > > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:236 > > > + RetainPtr<UIView> _customInputView; > > > > Adding the WKFocusedElementInfo here would help third-party clients > > determine what custom view they want to show, since they won't have access > > to userObject when (if) we make this public. > > Agreed! I should do that in a separate patch. See bug 150512. 1136258 5 mitz 2015-10-24 08:55:01 -0700 Committed <http://trac.webkit.org/r191534>. 263691 2015-10-21 10:02:24 -0700 2015-10-23 11:25:02 -0700 Add customInputView property to _WKFormInputSession bug-150395-20151021100140.patch text/plain 2884 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MTM4NykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE1LTEwLTIxICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gQWxsb3cgY2xpZW50cyB0 byBzcGVjaWZ5IGEgY3VzdG9tIGlucHV0IHZpZXcgdG8gYmUgdXNlZCBmb3IgYSBmb3JtIGlucHV0 IHNlc3Npb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE1MDM5NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tGb3JtSW5wdXRTZXNzaW9uLmg6IEFkZGVkIGN1c3Rv bUlucHV0VmlldyBwcm9wZXJ0eSB0byB0aGUgcHJvdG9jb2wuCisKKyAgICAgICAgKiBVSVByb2Nl c3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tGb3JtSW5w dXRTZXNzaW9uIGN1c3RvbUlucHV0Vmlld10pOiBBZGRlZCB0aGlzIGdldHRlci4KKyAgICAgICAg KC1bV0tGb3JtSW5wdXRTZXNzaW9uIHNldEN1c3RvbUlucHV0VmlldzpdKTogQWRkZWQgdGhpcyBz ZXR0ZXIsIHdoaWNoIHJlbG9hZHMgdGhlIGlucHV0CisgICAgICAgICAgdmlld3Mgd2hlbiB0aGUg Y3VzdG9tIGlucHV0IHZpZXcgY2hhbmdlcy4KKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBpbnB1 dFZpZXddKTogQ2hhbmdlZCB0byByZXR1cm4gdGhlIGN1c3RvbSB2aWV3IGZyb20gdGhlIGlucHV0 IHNlc3Npb24gaWYKKyAgICAgICAgICB0aGVyZSBpcyBvbmUuCisKIDIwMTUtMTAtMjEgIENhcmxv cyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIE5ldHdvcmtQ cm9jZXNzOiBETlMgcHJlZmV0Y2ggaGFwcGVucyBpbiB0aGUgV2ViIFByb2Nlc3MKSW5kZXg6IFNv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLRm9ybUlucHV0U2Vzc2lvbi5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLRm9ybUlu cHV0U2Vzc2lvbi5oCShyZXZpc2lvbiAxOTEzNjMpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL0NvY29hL19XS0Zvcm1JbnB1dFNlc3Npb24uaAkod29ya2luZyBjb3B5KQpAQCAtMzYs NiArMzYsNyBAQAogCiAjaWYgVEFSR0VUX09TX0lQSE9ORQogQHByb3BlcnR5IChub25hdG9taWMs IGNvcHkpIE5TU3RyaW5nICphY2Nlc3NvcnlWaWV3Q3VzdG9tQnV0dG9uVGl0bGU7CitAcHJvcGVy dHkgKG5vbmF0b21pYywgc3Ryb25nKSBVSVZpZXcgKmN1c3RvbUlucHV0VmlldyBXS19BVkFJTEFC TEUoTkEsIFdLX0lPU19UQkEpOwogI2VuZGlmCiAKIEBlbmQKSW5kZXg6IFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1t CShyZXZpc2lvbiAxOTEzNjMpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29u dGVudFZpZXdJbnRlcmFjdGlvbi5tbQkod29ya2luZyBjb3B5KQpAQCAtMjMzLDYgKzIzMyw3IEBA IC0gKHZvaWQpaW52YWxpZGF0ZTsKIEBpbXBsZW1lbnRhdGlvbiBXS0Zvcm1JbnB1dFNlc3Npb24g ewogICAgIFdLQ29udGVudFZpZXcgKl9jb250ZW50VmlldzsKICAgICBSZXRhaW5QdHI8TlNPYmpl Y3QgPE5TU2VjdXJlQ29kaW5nPj4gX3VzZXJPYmplY3Q7CisgICAgUmV0YWluUHRyPFVJVmlldz4g X2N1c3RvbUlucHV0VmlldzsKIH0KIAogLSAoaW5zdGFuY2V0eXBlKWluaXRXaXRoQ29udGVudFZp ZXc6KFdLQ29udGVudFZpZXcgKil2aWV3IHVzZXJPYmplY3Q6KE5TT2JqZWN0IDxOU1NlY3VyZUNv ZGluZz4gKil1c2VyT2JqZWN0CkBAIC0yNzEsNiArMjcyLDIwIEBAIC0gKHZvaWQpc2V0QWNjZXNz b3J5Vmlld0N1c3RvbUJ1dHRvblRpdGwKICAgICAgICAgW19jb250ZW50VmlldyByZWxvYWRJbnB1 dFZpZXdzXTsKIH0KIAorLSAoVUlWaWV3ICopY3VzdG9tSW5wdXRWaWV3Cit7CisgICAgcmV0dXJu IF9jdXN0b21JbnB1dFZpZXcuZ2V0KCk7Cit9CisKKy0gKHZvaWQpc2V0Q3VzdG9tSW5wdXRWaWV3 OihVSVZpZXcgKiljdXN0b21JbnB1dFZpZXcKK3sKKyAgICBpZiAoY3VzdG9tSW5wdXRWaWV3ID09 IF9jdXN0b21JbnB1dFZpZXcpCisgICAgICAgIHJldHVybjsKKworICAgIF9jdXN0b21JbnB1dFZp ZXcgPSBjdXN0b21JbnB1dFZpZXc7CisgICAgW19jb250ZW50VmlldyByZWxvYWRJbnB1dFZpZXdz XTsKK30KKwogLSAodm9pZClpbnZhbGlkYXRlCiB7CiAgICAgX2NvbnRlbnRWaWV3ID0gbmlsOwpA QCAtOTY3LDcgKzk4Miw3IEBAIC0gKFVJVmlldyAqKWlucHV0VmlldwogICAgIGVsc2UKICAgICAg ICAgW3NlbGYgX2Rpc3BsYXlGb3JtTm9kZUlucHV0Vmlld107CiAKLSAgICByZXR1cm4gW19pbnB1 dFBlcmlwaGVyYWwgYXNzaXN0YW50Vmlld107CisgICAgcmV0dXJuIFtfZm9ybUlucHV0U2Vzc2lv biBjdXN0b21JbnB1dFZpZXddID86IFtfaW5wdXRQZXJpcGhlcmFsIGFzc2lzdGFudFZpZXddOwog fQogCiAtIChDR1JlY3QpX3NlbGVjdGlvbkNsaXBSZWN0Cg==