150393 2015-10-21 08:52:43 -0700 Support for the SVG `onend` attribute 2015-10-22 03:44:27 -0700 1 1 1 Unclassified WebKit SVG WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts commit-queue graouts jonlee sabouhallawa webkit-bug-importer zimmermann oldest_to_newest 1135215 0 graouts 2015-10-21 08:52:43 -0700 While we've added support for the `endEvent` event in SVG (see https://bugs.webkit.org/show_bug.cgi?id=121587), we have not added support for the `onend` attribute which allows a JS event listener to be added declaratively for the `endEvent` event. 1135218 1 263680 graouts 2015-10-21 08:56:28 -0700 Created attachment 263680 Patch 1135219 2 webkit-bug-importer 2015-10-21 08:57:22 -0700 <rdar://problem/23201745> 1135298 3 263680 commit-queue 2015-10-21 11:30:22 -0700 Comment on attachment 263680 Patch Clearing flags on attachment: 263680 Committed r191392: <http://trac.webkit.org/changeset/191392> 1135300 4 commit-queue 2015-10-21 11:30:26 -0700 All reviewed patches have been landed. Closing bug. 1135308 5 263680 sabouhallawa 2015-10-21 11:37:34 -0700 Comment on attachment 263680 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263680&action=review > LayoutTests/svg/animations/end-event-attribute-expected.svg:2 > +<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1 Tiny//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11-tiny.dtd"> I think you do not have to include the tags <?xml> and <!DOCTYPE>. > LayoutTests/svg/animations/end-event-attribute-expected.svg:3 > +<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> You do not need to include xmlns:xlink="http://www.w3.org/1999/xlink" since you are not using this namespace in the SVG. > LayoutTests/svg/animations/end-event-attribute.svg:12 > + document.getElementById("rect").setAttribute("fill", "green"); Do not you need to force layout or setTimeout() before notifyDone() to make sure the test runner captures the page in a steady state? 1135313 6 graouts 2015-10-21 11:45:20 -0700 (In reply to comment #5) > > LayoutTests/svg/animations/end-event-attribute-expected.svg:2 > > +<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1 Tiny//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11-tiny.dtd"> > > I think you do not have to include the tags <?xml> and <!DOCTYPE>. That's true, doesn't hurt. I might update those tests in an upcoming related patch (thinking of implementing the `beginEvent` event and `onbegin` attribute). > > LayoutTests/svg/animations/end-event-attribute-expected.svg:3 > > +<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> > > You do not need to include xmlns:xlink="http://www.w3.org/1999/xlink" since > you are not using this namespace in the SVG. True too. Will look again when adding related features. > > LayoutTests/svg/animations/end-event-attribute.svg:12 > > + document.getElementById("rect").setAttribute("fill", "green"); > > Do not you need to force layout or setTimeout() before notifyDone() to make > sure the test runner captures the page in a steady state? At least on my system, tests have been running reliably without the need for a forced layout. 1135348 7 263680 darin 2015-10-21 13:00:42 -0700 Comment on attachment 263680 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263680&action=review > Source/WebCore/svg/animation/SVGSMILElement.cpp:485 > + } else if (name == SVGNames::onendAttr) { > + setAttributeEventListener(eventNames().endEventEvent, name, value); > } else This looks good, but coding style for a one liner like this is supposed to be no braces. What is going on with the name endEventEvent? What? Is the event named "end" or is it named "endEvent"? 1135636 8 263680 graouts 2015-10-22 02:09:02 -0700 Comment on attachment 263680 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263680&action=review >> Source/WebCore/svg/animation/SVGSMILElement.cpp:485 >> } else > > This looks good, but coding style for a one liner like this is supposed to be no braces. > > What is going on with the name endEventEvent? What? Is the event named "end" or is it named "endEvent"? Can't believe I missed the style compliance. Odd also that the style bot didn't catch my error. Filed https://bugs.webkit.org/show_bug.cgi?id=150440 to follow up on that. I will be making more changes to that area very soon and I will take the time to fix this error as well if that's alright. If you'd rather, I can make a quicker fix dedicated to fixing this. As for the event name, yes, believe it or not, it's called `endEvent` (see http://www.w3.org/TR/SVG/animate.html#InterfaceTimeEvent), but the attribute to register an `endEvent` event listener declaratively is `onend` (see http://www.w3.org/TR/SVG/script.html#AnimationEvents). Not that there is also an `end` event supported by WebKit for speech synthesis. 1135654 9 graouts 2015-10-22 03:44:27 -0700 Said, Darin, I've made the changes you've suggested in the patch for https://bugs.webkit.org/show_bug.cgi?id=150442. 263680 2015-10-21 08:56:28 -0700 2015-10-21 11:30:22 -0700 Patch bug-150393-20151021175543.patch text/plain 9367 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxMzM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTZiZjhiNDJkZWQ3YzQ4 NTk4ZDJjYzBiMzZiMzI2ZWI5ODA4ZGE4OC4uMzM1ODY1NzQ2Y2JhM2Y2MTBmZGZmNjYxMzdiZWY3 NTdkODVmNzE4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE1LTEwLTIxICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgU3VwcG9ydCBmb3IgdGhl IFNWRyBgb25lbmRgIGF0dHJpYnV0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTUwMzkzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQWRkIHN1cHBvcnQgZm9yIHRoZSBTVkcgYG9uZW5kYCBhdHRyaWJ1dGUg dG8gU1ZHIHRpbWluZyBhbmQgYW5pbWF0aW9uIGVsZW1lbnRzLCB3aGljaCBhbGxvdyB0aGUgZGVm aW5pdGlvbgorICAgICAgICBvZiBhIEpTIGV2ZW50IGxpc3RlbmVyIGRlY2xhcmF0aXZlbHkgZm9y IHRoZSBTVkcgYGVuZEV2ZW50YCBldmVudC4KKworICAgICAgICBUZXN0czogc3ZnL2FuaW1hdGlv bnMvZW5kLWV2ZW50LWF0dHJpYnV0ZS1leHBlY3RlZC5zdmcKKyAgICAgICAgICAgICAgIHN2Zy9h bmltYXRpb25zL2VuZC1ldmVudC1hdHRyaWJ1dGUuc3ZnCisgICAgICAgICAgICAgICBzdmcvYW5p bWF0aW9ucy9lbmQtZXZlbnQtc3luY2Jhc2UtZXhwZWN0ZWQuc3ZnCisgICAgICAgICAgICAgICBz dmcvYW5pbWF0aW9ucy9lbmQtZXZlbnQtc3luY2Jhc2Uuc3ZnCisKKyAgICAgICAgKiBkb20vRXZl bnROYW1lcy5oOgorICAgICAgICAqIHN2Zy9hbmltYXRpb24vU1ZHU01JTEVsZW1lbnQuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6U1ZHU01JTEVsZW1lbnQ6OnBhcnNlQXR0cmlidXRlKToKKyAgICAg ICAgKiBzdmcvc3ZnYXR0cnMuaW46CisKIDIwMTUtMTAtMTMgIFNlcmdpbyBWaWxsYXIgU2VuaW4g IDxzdmlsbGFyQGlnYWxpYS5jb20+CiAKICAgICAgICAgQVNTRVJUSU9OIEZBSUxFRDogY29tcHV0 ZU1haW5BeGlzRXh0ZW50Rm9yQ2hpbGQoY2hpbGQsIE1haW5PclByZWZlcnJlZFNpemUsIG1haW5T aXplKSBpbiBXZWJDb3JlOjpSZW5kZXJGbGV4aWJsZUJveDo6YWRqdXN0Q2hpbGRTaXplRm9yTWlu QW5kTWF4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnROYW1lcy5oIGIvU291 cmNlL1dlYkNvcmUvZG9tL0V2ZW50TmFtZXMuaAppbmRleCAxNjU5MjAwMjNiNzQ1MzgwNzdjZmU4 ZTQ2ZTVjOGViNjBlMGI1MzJhLi40ZDE0OWI1YTQzYTdlYTE1MjhlNzU5MTA5NGZkNzI4Mzk5YzVj M2I2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRXZlbnROYW1lcy5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2RvbS9FdmVudE5hbWVzLmgKQEAgLTk2LDYgKzk2LDcgQEAgbmFtZXNwYWNl IFdlYkNvcmUgewogICAgIG1hY3JvKGR1cmF0aW9uY2hhbmdlKSBcCiAgICAgbWFjcm8oZW1wdGll ZCkgXAogICAgIG1hY3JvKGVuZCkgXAorICAgIG1hY3JvKGVuZEV2ZW50KSBcCiAgICAgbWFjcm8o ZW5kZWQpIFwKICAgICBtYWNybyhlbnRlcikgXAogICAgIG1hY3JvKGVycm9yKSBcCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9zdmcvYW5pbWF0aW9uL1NWR1NNSUxFbGVtZW50LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3N2Zy9hbmltYXRpb24vU1ZHU01JTEVsZW1lbnQuY3BwCmluZGV4IGIwOTUw ZTIxZjZlYmIxMTRlZmNmYmVlODNlZjEyYzRkMmY3ODY4YzQuLjUwYzQwZTU1YWNmYzliMzY2NmYw YzE0NjQ4ZGFmOGJiNDQyYzM2ZWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9hbmlt YXRpb24vU1ZHU01JTEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9hbmltYXRp b24vU1ZHU01JTEVsZW1lbnQuY3BwCkBAIC00ODAsNiArNDgwLDggQEAgdm9pZCBTVkdTTUlMRWxl bWVudDo6cGFyc2VBdHRyaWJ1dGUoY29uc3QgUXVhbGlmaWVkTmFtZSYgbmFtZSwgY29uc3QgQXRv bWljU3RyaW4KICAgICAgICAgcGFyc2VCZWdpbk9yRW5kKHZhbHVlLnN0cmluZygpLCBFbmQpOwog ICAgICAgICBpZiAoaW5Eb2N1bWVudCgpKQogICAgICAgICAgICAgY29ubmVjdENvbmRpdGlvbnMo KTsKKyAgICB9IGVsc2UgaWYgKG5hbWUgPT0gU1ZHTmFtZXM6Om9uZW5kQXR0cikgeworICAgICAg ICBzZXRBdHRyaWJ1dGVFdmVudExpc3RlbmVyKGV2ZW50TmFtZXMoKS5lbmRFdmVudEV2ZW50LCBu YW1lLCB2YWx1ZSk7CiAgICAgfSBlbHNlCiAgICAgICAgIFNWR0VsZW1lbnQ6OnBhcnNlQXR0cmli dXRlKG5hbWUsIHZhbHVlKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9zdmdh dHRycy5pbiBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9zdmdhdHRycy5pbgppbmRleCA4YjRjYmQ4Yjdj NDZlOGZiYmJiMTEzNGMzMzIyMWMwYzBhOTgyMjY5Li4zNTE3M2YyNGI1MzAyMDM5M2Q0NDlmNmEx MmM1ZWQ3MGMzNzY4Yjc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdmcvc3ZnYXR0cnMu aW4KKysrIGIvU291cmNlL1dlYkNvcmUvc3ZnL3N2Z2F0dHJzLmluCkBAIC0xMjgsNiArMTI4LDcg QEAgbW9kZQogbmFtZQogbnVtT2N0YXZlcwogb2Zmc2V0CitvbmVuZAogb256b29tCiBvcGFjaXR5 CiBvcGVyYXRvcgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCmluZGV4IDNiYzNkNzQyNzZmM2QwYTMwZTY2MjkxZGRmYTBhOWJkMGYzNTc1 ZjcuLjU0YmE1Y2VhYjgzZmJiYTMxZTRkYTJjYWIwYTQzMDVmZmUxZGU5ZTUgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxNS0xMC0yMSAgQW50b2luZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29t PgorCisgICAgICAgIFN1cHBvcnQgZm9yIHRoZSBTVkcgYG9uZW5kYCBhdHRyaWJ1dGUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDM5MworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENyZWF0ZSBhIG5ldyB0 ZXN0IGZvciB0aGUgYG9uZW5kYCBhdHRyaWJ1dGUgYW5kIHJlbmFtZSB0aGUgcHJldmlvdXNseS1u YW1lZCAiZW5kLWV2ZW50LWRlY2xhcmF0aXZlLnN2ZyIgdGVzdCB0bworICAgICAgICAiZW5kLWV2 ZW50LXN5bmNiYXNlLnN2ZyIgc2luY2UgdGhlIHRlcm0gImRlY2xhcmF0aXZlIiB3YXMgYSBsaXR0 bGUgbG9vc2UuCisKKyAgICAgICAgKiBzdmcvYW5pbWF0aW9ucy9lbmQtZXZlbnQtYXR0cmlidXRl LWV4cGVjdGVkLnN2ZzogQ29waWVkIGZyb20gTGF5b3V0VGVzdHMvc3ZnL2FuaW1hdGlvbnMvZW5k LWV2ZW50LWRlY2xhcmF0aXZlLWV4cGVjdGVkLnN2Zy4KKyAgICAgICAgKiBzdmcvYW5pbWF0aW9u cy9lbmQtZXZlbnQtYXR0cmlidXRlLnN2ZzogQ29waWVkIGZyb20gTGF5b3V0VGVzdHMvc3ZnL2Fu aW1hdGlvbnMvZW5kLWV2ZW50LWRlY2xhcmF0aXZlLnN2Zy4KKyAgICAgICAgKiBzdmcvYW5pbWF0 aW9ucy9lbmQtZXZlbnQtc3luY2Jhc2UtZXhwZWN0ZWQuc3ZnOiBSZW5hbWVkIGZyb20gTGF5b3V0 VGVzdHMvc3ZnL2FuaW1hdGlvbnMvZW5kLWV2ZW50LWRlY2xhcmF0aXZlLWV4cGVjdGVkLnN2Zy4K KyAgICAgICAgKiBzdmcvYW5pbWF0aW9ucy9lbmQtZXZlbnQtc3luY2Jhc2Uuc3ZnOiBSZW5hbWVk IGZyb20gTGF5b3V0VGVzdHMvc3ZnL2FuaW1hdGlvbnMvZW5kLWV2ZW50LWRlY2xhcmF0aXZlLnN2 Zy4KKwogMjAxNS0xMC0yMCAgWGFiaWVyIFJvZHJpZ3VleiBDYWx2YXIgIDxjYWx2YXJpc0BpZ2Fs aWEuY29tPgogCiAgICAgICAgIFtTdHJlYW1zIEFQSV0gVXBkYXRlIHJlYWRhYmxlLXN0cmVhbS10 ZW1wbGF0ZWQgdGVzdHMgdG8gbGF0ZXN0IHNwZWMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N2 Zy9hbmltYXRpb25zL2VuZC1ldmVudC1hdHRyaWJ1dGUtZXhwZWN0ZWQuc3ZnIGIvTGF5b3V0VGVz dHMvc3ZnL2FuaW1hdGlvbnMvZW5kLWV2ZW50LWF0dHJpYnV0ZS1leHBlY3RlZC5zdmcKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uNmE1M2Y2NzAxOGY1ZWI5Njg5MmE2MzIxYjUxZDkzODJlMDE0YWFlMAotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL3N2Zy9hbmltYXRpb25zL2VuZC1ldmVudC1hdHRyaWJ1dGUt ZXhwZWN0ZWQuc3ZnCkBAIC0wLDAgKzEsNSBAQAorPD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGlu Zz0iVVRGLTgiPz4KKzwhRE9DVFlQRSBzdmcgUFVCTElDICItLy9XM0MvL0RURCBTVkcgMS4xIFRp bnkvL0VOIiAiaHR0cDovL3d3dy53My5vcmcvR3JhcGhpY3MvU1ZHLzEuMS9EVEQvc3ZnMTEtdGlu eS5kdGQiPgorPHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHhtbG5zOnhs aW5rPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rIj4KKyAgICA8cmVjdCB4PSIwIiB5PSIw IiB3aWR0aD0iNTAiIGhlaWdodD0iNTAiIGZpbGw9ImdyZWVuIiAvPgorPC9zdmc+ClwgTm8gbmV3 bGluZSBhdCBlbmQgb2YgZmlsZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3ZnL2FuaW1hdGlv bnMvZW5kLWV2ZW50LWF0dHJpYnV0ZS5zdmcgYi9MYXlvdXRUZXN0cy9zdmcvYW5pbWF0aW9ucy9l bmQtZXZlbnQtYXR0cmlidXRlLnN2ZwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5kNTdkOGE1NGI0MmE1ZTRhZjNjZTNh YzQ0MWE2OWYxOTBjMzY5MzNjCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvc3ZnL2Fu aW1hdGlvbnMvZW5kLWV2ZW50LWF0dHJpYnV0ZS5zdmcKQEAgLTAsMCArMSwyMSBAQAorPD94bWwg dmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiPz4KKzwhRE9DVFlQRSBzdmcgUFVCTElDICIt Ly9XM0MvL0RURCBTVkcgMS4xIFRpbnkvL0VOIiAiaHR0cDovL3d3dy53My5vcmcvR3JhcGhpY3Mv U1ZHLzEuMS9EVEQvc3ZnMTEtdGlueS5kdGQiPgorPHN2ZyBvbmxvYWQ9ImxvYWRlZCgpIiB4bWxu cz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHhtbG5zOnhsaW5rPSJodHRwOi8vd3d3Lncz Lm9yZy8xOTk5L3hsaW5rIj4KKzxyZWN0IGlkPSJyZWN0IiB4PSIwIiB5PSIwIiB3aWR0aD0iNTAi IGhlaWdodD0iNTAiIGZpbGw9InJlZCI+CisgICAgPGFuaW1hdGUgaWQ9ImFuaW0iIGF0dHJpYnV0 ZU5hbWU9InZpc2liaWxpdHkiIHRvPSJ2aXNpYmxlIiBiZWdpbj0iMHMiIGVuZD0iMnMiIG9uZW5k PSJoYW5kbGVFbmRFdmVudCgpIiAvPgorPC9yZWN0PgorPHNjcmlwdD4KKyAgICBpZiAod2luZG93 LnRlc3RSdW5uZXIpCisgICAgICAgIHRlc3RSdW5uZXIud2FpdFVudGlsRG9uZSgpOworCisgICAg ZnVuY3Rpb24gaGFuZGxlRW5kRXZlbnQoZXZlbnQpIHsKKyAgICAgICAgZG9jdW1lbnQuZ2V0RWxl bWVudEJ5SWQoInJlY3QiKS5zZXRBdHRyaWJ1dGUoImZpbGwiLCAiZ3JlZW4iKTsKKyAgICAgICAg dGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7CisgICAgfQorCisgICAgZnVuY3Rpb24gbG9hZGVkKCkg eworICAgICAgICBkb2N1bWVudC5kb2N1bWVudEVsZW1lbnQuc2V0Q3VycmVudFRpbWUoMik7Cisg ICAgfQorCis8L3NjcmlwdD4KKzwvc3ZnPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL3N2Zy9hbmltYXRpb25zL2VuZC1ldmVudC1kZWNsYXJhdGl2 ZS1leHBlY3RlZC5zdmcgYi9MYXlvdXRUZXN0cy9zdmcvYW5pbWF0aW9ucy9lbmQtZXZlbnQtZGVj bGFyYXRpdmUtZXhwZWN0ZWQuc3ZnCmRlbGV0ZWQgZmlsZSBtb2RlIDEwMDY0NAppbmRleCA2YTUz ZjY3MDE4ZjVlYjk2ODkyYTYzMjFiNTFkOTM4MmUwMTRhYWUwLi4wMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwCi0tLSBhL0xheW91dFRlc3RzL3N2Zy9hbmltYXRpb25zL2Vu ZC1ldmVudC1kZWNsYXJhdGl2ZS1leHBlY3RlZC5zdmcKKysrIC9kZXYvbnVsbApAQCAtMSw1ICsw LDAgQEAKLTw/eG1sIHZlcnNpb249IjEuMCIgZW5jb2Rpbmc9IlVURi04Ij8+Ci08IURPQ1RZUEUg c3ZnIFBVQkxJQyAiLS8vVzNDLy9EVEQgU1ZHIDEuMSBUaW55Ly9FTiIgImh0dHA6Ly93d3cudzMu b3JnL0dyYXBoaWNzL1NWRy8xLjEvRFREL3N2ZzExLXRpbnkuZHRkIj4KLTxzdmcgeG1sbnM9Imh0 dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiB4bWxuczp4bGluaz0iaHR0cDovL3d3dy53My5vcmcv MTk5OS94bGluayI+Ci0gICAgPHJlY3QgeD0iMCIgeT0iMCIgd2lkdGg9IjUwIiBoZWlnaHQ9IjUw IiBmaWxsPSJncmVlbiIgLz4KLTwvc3ZnPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL3N2Zy9hbmltYXRpb25zL2VuZC1ldmVudC1kZWNsYXJhdGl2 ZS5zdmcgYi9MYXlvdXRUZXN0cy9zdmcvYW5pbWF0aW9ucy9lbmQtZXZlbnQtZGVjbGFyYXRpdmUu c3ZnCmRlbGV0ZWQgZmlsZSBtb2RlIDEwMDY0NAppbmRleCA1OTIzZWJmYmM5NWM2MzJjN2NjNjI3 OGUxMzA1YzIxMmJmZTM2NjMzLi4wMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwCi0tLSBhL0xheW91dFRlc3RzL3N2Zy9hbmltYXRpb25zL2VuZC1ldmVudC1kZWNsYXJhdGl2 ZS5zdmcKKysrIC9kZXYvbnVsbApAQCAtMSwxOSArMCwwIEBACi08P3htbCB2ZXJzaW9uPSIxLjAi IGVuY29kaW5nPSJVVEYtOCI/PgotPCFET0NUWVBFIHN2ZyBQVUJMSUMgIi0vL1czQy8vRFREIFNW RyAxLjEgVGlueS8vRU4iICJodHRwOi8vd3d3LnczLm9yZy9HcmFwaGljcy9TVkcvMS4xL0RURC9z dmcxMS10aW55LmR0ZCI+Ci08c3ZnIG9ubG9hZD0ibG9hZGVkKCkiIHhtbG5zPSJodHRwOi8vd3d3 LnczLm9yZy8yMDAwL3N2ZyIgeG1sbnM6eGxpbms9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGxp bmsiPgotPHJlY3QgeD0iMCIgeT0iMCIgd2lkdGg9IjUwIiBoZWlnaHQ9IjUwIiBmaWxsPSJyZWQi PgotICAgIDxhbmltYXRlIGlkPSJhbmltIiBhdHRyaWJ1dGVOYW1lPSJ2aXNpYmlsaXR5IiB0bz0i dmlzaWJsZSIgYmVnaW49IjBzIiBlbmQ9IjJzIiAvPgotICAgIDxzZXQgYXR0cmlidXRlTmFtZT0i ZmlsbCIgdG89ImdyZWVuIiBiZWdpbj0iYW5pbS5lbmRFdmVudCIgLz4KLTwvcmVjdD4KLTxzY3Jp cHQ+Ci0gICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQotICAgICAgICB0ZXN0UnVubmVyLndhaXRV bnRpbERvbmUoKTsKLQotICAgIGZ1bmN0aW9uIGxvYWRlZCgpIHsKLSAgICAgICAgZG9jdW1lbnQu ZG9jdW1lbnRFbGVtZW50LnNldEN1cnJlbnRUaW1lKDIpOwotCi0gICAgICAgIGlmICh3aW5kb3cu dGVzdFJ1bm5lcikKLSAgICAgICAgICAgIHNldFRpbWVvdXQoZnVuY3Rpb24oKSB7dGVzdFJ1bm5l ci5ub3RpZnlEb25lKCk7fSwgMTAwKTsKLSAgICB9Ci08L3NjcmlwdD4KLTwvc3ZnPgpcIE5vIG5l d2xpbmUgYXQgZW5kIG9mIGZpbGUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N2Zy9hbmltYXRp b25zL2VuZC1ldmVudC1zeW5jYmFzZS1leHBlY3RlZC5zdmcgYi9MYXlvdXRUZXN0cy9zdmcvYW5p bWF0aW9ucy9lbmQtZXZlbnQtc3luY2Jhc2UtZXhwZWN0ZWQuc3ZnCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjZhNTNm NjcwMThmNWViOTY4OTJhNjMyMWI1MWQ5MzgyZTAxNGFhZTAKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9zdmcvYW5pbWF0aW9ucy9lbmQtZXZlbnQtc3luY2Jhc2UtZXhwZWN0ZWQuc3Zn CkBAIC0wLDAgKzEsNSBAQAorPD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiPz4K KzwhRE9DVFlQRSBzdmcgUFVCTElDICItLy9XM0MvL0RURCBTVkcgMS4xIFRpbnkvL0VOIiAiaHR0 cDovL3d3dy53My5vcmcvR3JhcGhpY3MvU1ZHLzEuMS9EVEQvc3ZnMTEtdGlueS5kdGQiPgorPHN2 ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHhtbG5zOnhsaW5rPSJodHRwOi8v d3d3LnczLm9yZy8xOTk5L3hsaW5rIj4KKyAgICA8cmVjdCB4PSIwIiB5PSIwIiB3aWR0aD0iNTAi IGhlaWdodD0iNTAiIGZpbGw9ImdyZWVuIiAvPgorPC9zdmc+ClwgTm8gbmV3bGluZSBhdCBlbmQg b2YgZmlsZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3ZnL2FuaW1hdGlvbnMvZW5kLWV2ZW50 LXN5bmNiYXNlLnN2ZyBiL0xheW91dFRlc3RzL3N2Zy9hbmltYXRpb25zL2VuZC1ldmVudC1zeW5j YmFzZS5zdmcKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uNTkyM2ViZmJjOTVjNjMyYzdjYzYyNzhlMTMwNWMyMTJiZmUz NjYzMwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3N2Zy9hbmltYXRpb25zL2VuZC1l dmVudC1zeW5jYmFzZS5zdmcKQEAgLTAsMCArMSwxOSBAQAorPD94bWwgdmVyc2lvbj0iMS4wIiBl bmNvZGluZz0iVVRGLTgiPz4KKzwhRE9DVFlQRSBzdmcgUFVCTElDICItLy9XM0MvL0RURCBTVkcg MS4xIFRpbnkvL0VOIiAiaHR0cDovL3d3dy53My5vcmcvR3JhcGhpY3MvU1ZHLzEuMS9EVEQvc3Zn MTEtdGlueS5kdGQiPgorPHN2ZyBvbmxvYWQ9ImxvYWRlZCgpIiB4bWxucz0iaHR0cDovL3d3dy53 My5vcmcvMjAwMC9zdmciIHhtbG5zOnhsaW5rPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hsaW5r Ij4KKzxyZWN0IHg9IjAiIHk9IjAiIHdpZHRoPSI1MCIgaGVpZ2h0PSI1MCIgZmlsbD0icmVkIj4K KyAgICA8YW5pbWF0ZSBpZD0iYW5pbSIgYXR0cmlidXRlTmFtZT0idmlzaWJpbGl0eSIgdG89InZp c2libGUiIGJlZ2luPSIwcyIgZW5kPSIycyIgLz4KKyAgICA8c2V0IGF0dHJpYnV0ZU5hbWU9ImZp bGwiIHRvPSJncmVlbiIgYmVnaW49ImFuaW0uZW5kRXZlbnQiIC8+Cis8L3JlY3Q+Cis8c2NyaXB0 PgorICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgICAgdGVzdFJ1bm5lci53YWl0VW50 aWxEb25lKCk7CisKKyAgICBmdW5jdGlvbiBsb2FkZWQoKSB7CisgICAgICAgIGRvY3VtZW50LmRv Y3VtZW50RWxlbWVudC5zZXRDdXJyZW50VGltZSgyKTsKKworICAgICAgICBpZiAod2luZG93LnRl c3RSdW5uZXIpCisgICAgICAgICAgICBzZXRUaW1lb3V0KGZ1bmN0aW9uKCkge3Rlc3RSdW5uZXIu bm90aWZ5RG9uZSgpO30sIDEwMCk7CisgICAgfQorPC9zY3JpcHQ+Cis8L3N2Zz4KXCBObyBuZXds aW5lIGF0IGVuZCBvZiBmaWxlCg==