150391 2015-10-21 05:05:05 -0700 Web Inspector: Typo in a property name: style.inerhited 2015-10-21 14:13:01 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev bburg commit-queue graouts hi joepeck mattbaker nvasilyev ossy timothy webkit-bug-importer oldest_to_newest 1135190 0 nvasilyev 2015-10-21 05:05:05 -0700 Should be "inherited". WebStorm spotted a missing property, otherwise I wouldn't notice. http://trac.webkit.org/changeset/187195 https://github.com/WebKit/webkit/blob/f83708780100ed4be51a136ec33b3ddfdddcc9dd/Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.js#L293 I searched in Source/WebInspectorUI. That's the only place where "inerhited" is used. 1135191 1 webkit-bug-importer 2015-10-21 05:05:42 -0700 <rdar://problem/23199935> 1135193 2 263675 nvasilyev 2015-10-21 05:07:44 -0700 Created attachment 263675 Patch 1135200 3 nvasilyev 2015-10-21 06:03:37 -0700 I've been looking at this over 300 lines long refresh method for a while and I still don't quite understand what difference fixing this typo made. Devin, in insertAllMatchingPseudoStyles(force), what is the point of the force agrument? 1135206 4 263675 commit-queue 2015-10-21 06:37:36 -0700 Comment on attachment 263675 Patch Clearing flags on attachment: 263675 Committed r191387: <http://trac.webkit.org/changeset/191387> 1135207 5 commit-queue 2015-10-21 06:37:39 -0700 All reviewed patches have been landed. Closing bug. 1135252 6 hi 2015-10-21 10:07:31 -0700 (In reply to comment #3) > I've been looking at this over 300 lines long refresh method for a while and > I still don't quite understand what difference fixing this typo made. > > Devin, in insertAllMatchingPseudoStyles(force), what is the point of the > force agrument? The idea behind the force argument was that pseudo-element styles (::before, ::after, etc) should never be seen below user-agent or inherited rules. They should always be inserted before the first of those rules in the absolute worst case. On most websites, there will be a matching rule that doesn't have the pseudo-element, so this is not necessary (like having ".example" and ".example::before"). It is possible, however, to have pseudo-rules without a matching non-pseudo-element rule, and it is for this case that the force was added. Example: on a blank page, create a rule and give it the selector "body::before" (and give the ::before a content). This pseudo-element rule should appear before the user-agent "body" rule. 1135382 7 nvasilyev 2015-10-21 14:13:01 -0700 Thanks Devin, that makes sense now. 263675 2015-10-21 05:07:44 -0700 2015-10-21 06:37:36 -0700 Patch patch.txt text/plain 1638 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGU2ZTM3OTMuLjY3NjkxNTUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE1LTEwLTIxICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFR5cG8g aW4gYSBwcm9wZXJ0eSBuYW1lOiBzdHlsZS5pbmVyaGl0ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDM5MQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9SdWxlc1N0 eWxlRGV0YWlsc1BhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlJ1bGVzU3R5bGVEZXRh aWxzUGFuZWwucHJvdG90eXBlLnJlZnJlc2gpOgorCiAyMDE1LTEwLTE2ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogQWRkICJ1 bnNldCIgdG8gQ1NTIHZhbHVlIGF1dG9jb21wbGV0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SdWxlc1N0eWxlRGV0YWlsc1BhbmVsLmpz IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUnVsZXNTdHlsZURl dGFpbHNQYW5lbC5qcwppbmRleCAxNGIzMDI5Li41ZDQ2MWI2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SdWxlc1N0eWxlRGV0YWlsc1BhbmVs LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1J1bGVz U3R5bGVEZXRhaWxzUGFuZWwuanMKQEAgLTI3Miw3ICsyNzIsNyBAQCBXZWJJbnNwZWN0b3IuUnVs ZXNTdHlsZURldGFpbHNQYW5lbCA9IGNsYXNzIFJ1bGVzU3R5bGVEZXRhaWxzUGFuZWwgZXh0ZW5k cyBXZWJJbgogICAgICAgICB2YXIgb3JkZXJlZFN0eWxlcyA9IHVuaXF1ZU9yZGVyZWRTdHlsZXMo dGhpcy5ub2RlU3R5bGVzLm9yZGVyZWRTdHlsZXMpOwogICAgICAgICBmb3IgKHZhciBzdHlsZSBv ZiBvcmRlcmVkU3R5bGVzKSB7CiAgICAgICAgICAgICB2YXIgaXNVc2VyQWdlbnRTdHlsZSA9IHN0 eWxlLm93bmVyUnVsZSAmJiBzdHlsZS5vd25lclJ1bGUudHlwZSA9PT0gV2ViSW5zcGVjdG9yLkNT U1N0eWxlU2hlZXQuVHlwZS5Vc2VyQWdlbnQ7Ci0gICAgICAgICAgICBpbnNlcnRBbGxNYXRjaGlu Z1BzZXVkb1N0eWxlcy5jYWxsKHRoaXMsIGlzVXNlckFnZW50U3R5bGUgfHwgc3R5bGUuaW5lcmhp dGVkKTsKKyAgICAgICAgICAgIGluc2VydEFsbE1hdGNoaW5nUHNldWRvU3R5bGVzLmNhbGwodGhp cywgaXNVc2VyQWdlbnRTdHlsZSB8fCBzdHlsZS5pbmhlcml0ZWQpOwogCiAgICAgICAgICAgICBp bnNlcnRNZWRpYU9ySW5oZXJpdGFuY2VMYWJlbC5jYWxsKHRoaXMsIHN0eWxlKTsKICAgICAgICAg ICAgIGFwcGVuZFN0eWxlU2VjdGlvbi5jYWxsKHRoaXMsIHN0eWxlKTsK