150380 2015-10-20 17:22:40 -0700 [MIPS] LLInt: align stack pointer on MIPS too 2015-10-22 02:13:09 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Other Unspecified RESOLVED FIXED P2 Normal --- 108664 1 guijemont webkit-unassigned commit-queue oldest_to_newest 1135070 0 guijemont 2015-10-20 17:22:40 -0700 The code in doVMEntry() to align the stack for X86_WIN is also needed on MIPS since C code using the o32 ABI will only align the stack to 8 bytes but JavaScriptCore expects it to be aligned on 16 bytes. 1135073 1 263639 guijemont 2015-10-20 17:31:41 -0700 Created attachment 263639 Patch 1135079 2 263639 msaboff 2015-10-20 17:36:08 -0700 Comment on attachment 263639 Patch r=me 1135228 3 263639 pnormand 2015-10-21 09:26:35 -0700 Comment on attachment 263639 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263639&action=review > Source/JavaScriptCore/ChangeLog:3 > + llint: align stack pointer on mips too that line should be removed. 1135255 4 263639 commit-queue 2015-10-21 10:08:59 -0700 Comment on attachment 263639 Patch Clearing flags on attachment: 263639 Committed r191389: <http://trac.webkit.org/changeset/191389> 1135256 5 commit-queue 2015-10-21 10:09:02 -0700 All reviewed patches have been landed. Closing bug. 263639 2015-10-20 17:31:41 -0700 2015-10-21 10:08:59 -0700 Patch bug-150380-20151020193109.patch text/plain 1504 guijemont U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxMzU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx NTlhM2VjYTVlOGZmYzY1NjUxYzdlZWIyZTA0YzU5NTAxY2FlYzIzLi4yZjFjMDQ1YTJlYTBlMWE3 ZjVmMzBhZTBjNjljNGE4ZWU0YmNkNWQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxNiBAQAogMjAxNS0xMC0yMCAgR3VpbGxhdW1lIEVtb250ICA8Z3VpamVtb250QGlnYWxp YS5jb20+CiAKKyAgICAgICAgbGxpbnQ6IGFsaWduIHN0YWNrIHBvaW50ZXIgb24gbWlwcyB0b28K KworICAgICAgICBbTUlQU10gTExJbnQ6IGFsaWduIHN0YWNrIHBvaW50ZXIgb24gTUlQUyB0b28K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDM4MAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogbGxpbnQv TG93TGV2ZWxJbnRlcnByZXRlcjMyXzY0LmFzbToKKworMjAxNS0xMC0yMCAgR3VpbGxhdW1lIEVt b250ICA8Z3VpamVtb250QGlnYWxpYS5jb20+CisKICAgICAgICAgW01JUFNdIG9mZmxpbmVhc206 IG1vdmUgaW1tZWRpYXRlIHZhbHVlcyBvZiBib29sZWFuIG9wZXJhdGlvbnMgdG8gcmVnaXN0ZXIg aWYgdGhleSBhcmUgb3V0IG9mIHRoZSAwLTB4ZmZmZiByYW5nZQogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwMzc2CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyMzJfNjQuYXNtIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20KaW5k ZXggZTkyYTdhNzI4NDk0ODY3OTEyNzJjNzA0NzI3ZTRjZmRjMDc5MjdiYS4uYTY2Y2VlNjI3YmIw Y2IyOWFmZmMwMWY5YmRhYzhhNTUwYTg4MzQ5YyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20KKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20KQEAgLTEyOSw3 ICsxMjksNyBAQCBtYWNybyBkb1ZNRW50cnkobWFrZUNhbGwpCiAgICAgc3RvcmVwIHQ0LCBWTUVu dHJ5UmVjb3JkOjptX3ByZXZUb3BWTUVudHJ5RnJhbWVbc3BdCiAKICAgICAjIEFsaWduIHN0YWNr IHBvaW50ZXIKLSAgICBpZiBYODZfV0lOCisgICAgaWYgWDg2X1dJTiBvciBNSVBTCiAgICAgICAg IGFkZHAgQ2FsbEZyYW1lQWxpZ25TbG90cyAqIFNsb3RTaXplLCBzcCwgdDMKICAgICAgICAgYW5k cCB+U3RhY2tBbGlnbm1lbnRNYXNrLCB0MwogICAgICAgICBzdWJwIHQzLCBDYWxsRnJhbWVBbGln blNsb3RzICogU2xvdFNpemUsIHNwCg==