150374 2015-10-20 15:15:39 -0700 ASSERT when right clicking on SVG Image generating Share menu - can break Web Inspector 2015-10-20 16:16:44 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck bburg beidson commit-queue timothy oldest_to_newest 1135017 0 joepeck 2015-10-20 15:15:39 -0700 * SUMMARY ASSERT when right clicking on SVG Image generating Share menu - can break Web Inspector. * TEST PAGE <img src="data:image/svg+xml;utf8,<svg xmlns='http://www.w3.org/2000/svg' width='100' height='100'><rect width='100' height='100' style='fill:red'/></svg>"> * STEPS TO REPRODUCE (ASSERT) 1. Open test page 2. Right click SVG => ASSERT * STEPS TO REPRODUCE (Break Inspector) 1. Inspect test page 2. Show image resource for the svg image 3. Right click image content in inspector => Uncaught exception, broken inspector (cannot click anywhere else anymore) * NOTES ASSERTION FAILED: m_nsMenuItem Source/WebKit2/Shared/mac/NativeContextMenuItem.mm(40) : WebKit::NativeContextMenuItem::NativeContextMenuItem(const WebCore::ContextMenuItem &) 1 0x106fa4ae0 WTFCrash 2 0x109482585 WebKit::NativeContextMenuItem::NativeContextMenuItem(WebCore::ContextMenuItem const&) 3 0x1094825dd WebKit::NativeContextMenuItem::NativeContextMenuItem(WebCore::ContextMenuItem const&) 4 0x1098ecab7 std::_Unique_if<WebKit::NativeContextMenuItem>::_Single_object std::make_unique<WebKit::NativeContextMenuItem, WebCore::ContextMenuItem const&>(WebCore::ContextMenuItem const&&&) 5 0x1098ec3e8 WebKit::WebContextMenuItem::WebContextMenuItem(WebCore::ContextMenuItem const&) 6 0x1098ec68d WebKit::WebContextMenuItem::WebContextMenuItem(WebCore::ContextMenuItem const&) 7 0x1098f2443 WebKit::WebContextMenuItem::create(WebCore::ContextMenuItem const&) 8 0x1098f02fc WebKit::WebContextMenuProxyMac::showContextMenu() 9 0x109ade489 WebKit::WebPageProxy::internalShowContextMenu(WebKit::ContextMenuContextData const&, WebKit::UserData const&) 10 0x109ade26c WebKit::WebPageProxy::showContextMenu(WebKit::ContextMenuContextData const&, WebKit::UserData const&) 11 0x109b787c5 void IPC::callMemberFunctionImpl<WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(WebKit::ContextMenuContextData const&, WebKit::UserData const&), std::__1::tuple<WebKit::ContextMenuContextData, WebKit::UserData>, 0ul, 1ul>(WebKit::WebPageProxy*, void (WebKit::WebPageProxy::*)(WebKit::ContextMenuContextData const&, WebKit::UserData const&), std::__1::tuple<WebKit::ContextMenuContextData, WebKit::UserData>&&, std::index_sequence<0ul, 1ul>) 12 0x109b78538 void IPC::callMemberFunction<WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(WebKit::ContextMenuContextData const&, WebKit::UserData const&), std::__1::tuple<WebKit::ContextMenuContextData, WebKit::UserData>, std::make_index_sequence<2ul> >(std::__1::tuple<WebKit::ContextMenuContextData, WebKit::UserData>&&, WebKit::WebPageProxy*, void (WebKit::WebPageProxy::*)(WebKit::ContextMenuContextData const&, WebKit::UserData const&)) 13 0x109b60f52 void IPC::handleMessage<Messages::WebPageProxy::ShowContextMenu, WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(WebKit::ContextMenuContextData const&, WebKit::UserData const&)>(IPC::MessageDecoder&, WebKit::WebPageProxy*, void (WebKit::WebPageProxy::*)(WebKit::ContextMenuContextData const&, WebKit::UserData const&)) 14 0x109b55dda WebKit::WebPageProxy::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&) ... 1135019 1 263620 joepeck 2015-10-20 15:20:58 -0700 Created attachment 263620 [PATCH] Proposed Fix 1135027 2 263620 bburg 2015-10-20 15:31:02 -0700 Comment on attachment 263620 [PATCH] Proposed Fix r=me Would have been easier to catch in review if ContextMenuItem was nullable (a pointer). 1135040 3 263620 commit-queue 2015-10-20 16:16:37 -0700 Comment on attachment 263620 [PATCH] Proposed Fix Clearing flags on attachment: 263620 Committed r191363: <http://trac.webkit.org/changeset/191363> 1135041 4 commit-queue 2015-10-20 16:16:44 -0700 All reviewed patches have been landed. Closing bug. 263620 2015-10-20 15:20:58 -0700 2015-10-20 16:16:37 -0700 [PATCH] Proposed Fix context-menu-1.patch text/plain 2204 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5OGI2MDBiLi44ZjE0MmEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTUtMTAtMjAgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBBU1NFUlQgd2hlbiByaWdodCBjbGlja2luZyBvbiBTVkcgSW1hZ2UgZ2VuZXJhdGlu ZyBTaGFyZSBtZW51IC0gY2FuIGJyZWFrIFdlYiBJbnNwZWN0b3IKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDM3NAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gdGhlcmUgaXMgbm8gYWJzb2x1dGUg VVJMIG9yIGRvd25sb2FkYWJsZSBtZWRpYSBVUkwgbm8gc3lzdGVtIHNoYXJlCisgICAgICAgIG1l bnUgaXMgY3JlYXRlZCwgYnV0IHdlIHdlcmUgc3RpbGwgYXBwZW5kaW5nIHRoZSBudWxsIGNvbnRl eHQgbWVudSB0bworICAgICAgICB0aGUgbGlzdCBvZiBjb250ZXh0IG1lbnUgaXRlbXMuCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvbWFjL1dlYkNvbnRleHRNZW51UHJveHlNYWMubW06CisgICAgICAg IChXZWJLaXQ6OldlYkNvbnRleHRNZW51UHJveHlNYWM6OnNoYXJlTWVudUl0ZW0pOgorICAgICAg ICBCYWlsIGVhcmx5IGlmIHRoZSBjb250ZXh0IG1lbnUgaXMgbnVsbC4KKworICAgICAgICAoV2Vi S2l0OjpXZWJDb250ZXh0TWVudVByb3h5TWFjOjpzaG93Q29udGV4dE1lbnUpOgorICAgICAgICBP bmx5IGFwcGVuZCB0aGUgc2hhcmUgY29udGV4dCBtZW51IGl0ZW0gaWYgaXQgaXMgbm9uLW51bGwu CisgICAgICAgIFRoaXMgbWF0Y2hlcyBDb250ZXh0TWVudUNvbnRyb2xsZXIuY3BwIGluIFdlYkNv cmUuCisKIDIwMTUtMTAtMjAgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3Jn PgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxOTEzMDYuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dlYkNvbnRleHRNZW51UHJveHlNYWMubW0g Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dlYkNvbnRleHRNZW51UHJveHlNYWMubW0K aW5kZXggZjQ3YzNmNS4uMDVhYzgxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL21hYy9XZWJDb250ZXh0TWVudVByb3h5TWFjLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9tYWMvV2ViQ29udGV4dE1lbnVQcm94eU1hYy5tbQpAQCAtMzQxLDYgKzM0MSw4IEBA IENvbnRleHRNZW51SXRlbSBXZWJDb250ZXh0TWVudVByb3h5TWFjOjpzaGFyZU1lbnVJdGVtKCkK ICAgICAgICAgaW1hZ2UgPSBhZG9wdE5TKFtbTlNJbWFnZSBhbGxvY10gaW5pdFdpdGhEYXRhOltO U0RhdGEgZGF0YVdpdGhCeXRlczoodW5zaWduZWQgY2hhciopaGl0VGVzdERhdGEuaW1hZ2VTaGFy ZWRNZW1vcnktPmRhdGEoKSBsZW5ndGg6aGl0VGVzdERhdGEuaW1hZ2VTaXplXV0pOwogCiAgICAg Q29udGV4dE1lbnVJdGVtIGl0ZW0gPSBDb250ZXh0TWVudUl0ZW06OnNoYXJlTWVudUl0ZW0oYWJz b2x1dGVMaW5rVVJMLCBkb3dubG9hZGFibGVNZWRpYVVSTCwgaW1hZ2UuZ2V0KCksIG1fY29udGV4 dC5zZWxlY3RlZFRleHQoKSk7CisgICAgaWYgKGl0ZW0uaXNOdWxsKCkpCisgICAgICAgIHJldHVy biBpdGVtOwogCiAgICAgTlNNZW51SXRlbSAqbnNJdGVtID0gaXRlbS5wbGF0Zm9ybURlc2NyaXB0 aW9uKCk7CiAKQEAgLTM5Nyw3ICszOTksOSBAQCB2b2lkIFdlYkNvbnRleHRNZW51UHJveHlNYWM6 OnNob3dDb250ZXh0TWVudSgpCiAgICAgICAgIH0KIAogI2lmIEVOQUJMRShTRVJWSUNFX0NPTlRS T0xTKQotICAgICAgICBwcm9wb3NlZEFQSUl0ZW1zLmFwcGVuZChXZWJDb250ZXh0TWVudUl0ZW06 OmNyZWF0ZShzaGFyZU1lbnVJdGVtKCkpKTsKKyAgICAgICAgQ29udGV4dE1lbnVJdGVtIHNoYXJl SXRlbSA9IHNoYXJlTWVudUl0ZW0oKTsKKyAgICAgICAgaWYgKCFzaGFyZUl0ZW0uaXNOdWxsKCkp CisgICAgICAgICAgICBwcm9wb3NlZEFQSUl0ZW1zLmFwcGVuZChXZWJDb250ZXh0TWVudUl0ZW06 OmNyZWF0ZShzaGFyZUl0ZW0pKTsKICNlbmRpZgogICAgIH0KIAo=