150361 2015-10-20 05:51:21 -0700 [UNIX] ASSERTION FAILED: m_shouldWaitForSyncReplies in Connection::connectionDidClose() 2015-10-20 08:05:31 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 1 cgarcia webkit-unassigned andersca darin gustavo mrobinson oldest_to_newest 1134870 0 cgarcia 2015-10-20 05:51:21 -0700 This happens sometimes with several layout tests and unit tests in the GTK+ port. It doesn't always happen because it depends on how sockets are closed, and the state of the threads. The problem is that we are not handling the case when the read fails because we closed the connection. In that case we log the error and call Connection::connectionDidClose(). But it was connection didClose() the one closing the socket. So, in this particular case is not an error but a normal termination, and we shouldn't try to close the connection again. Something similar can happen while sending a message, and we get a broken pipe error, but in that case we are only showing the error, so it's harmless. 04:43:46.949 29374 Error receiving IPC message on socket -1 in process 12732: Bad file descriptor 04:43:46.949 29374 ASSERTION FAILED: m_shouldWaitForSyncReplies 04:43:46.949 29374 ../../Source/WebKit2/Platform/IPC/Connection.cpp(766) : void IPC::Connection::connectionDidClose() 04:43:46.950 29374 1 0x2b0713765a83 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(WTFCrash+0x1e) [0x2b0713765a83] 04:43:46.950 29374 2 0x2b070bb1e1e7 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN3IPC10Connection18connectionDidCloseEv+0x7d) [0x2b070bb1e1e7] 04:43:46.950 29374 3 0x2b070bf4713c /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN3IPC10Connection16readyReadHandlerEv+0x11e) [0x2b070bf4713c] 04:43:46.950 29374 4 0x2b070bf47296 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0x4cb0296) [0x2b070bf47296] 04:43:46.950 29374 5 0x2b070bf4852e /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0x4cb152e) [0x2b070bf4852e] 04:43:46.950 29374 6 0x2b070ba988be /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZNKSt8functionIFvvEEclEv+0x32) [0x2b070ba988be] 04:43:46.950 29374 7 0x2b07137b964d /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(_ZN3WTF15GMainLoopSource12voidCallbackEv+0x6d) [0x2b07137b964d] 04:43:46.950 29374 8 0x2b07137b9d51 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(_ZN3WTF15GMainLoopSource18voidSourceCallbackEPS0_+0x23) [0x2b07137b9d51] 04:43:46.950 29374 9 0x2b07168343a5 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/DependenciesGTK/Root/lib64/libglib-2.0.so.0(+0x563a5) [0x2b07168343a5] 04:43:46.950 29374 10 0x2b0716831a26 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/DependenciesGTK/Root/lib64/libglib-2.0.so.0(+0x53a26) [0x2b0716831a26] 04:43:46.950 29374 11 0x2b0716832854 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/DependenciesGTK/Root/lib64/libglib-2.0.so.0(g_main_context_dispatch+0x33) [0x2b0716832854] 04:43:46.950 29374 12 0x2b0716832a39 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/DependenciesGTK/Root/lib64/libglib-2.0.so.0(+0x54a39) [0x2b0716832a39] 04:43:46.950 29374 13 0x2b0716832e60 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/DependenciesGTK/Root/lib64/libglib-2.0.so.0(g_main_loop_run+0x1d7) [0x2b0716832e60] 04:43:46.950 29374 14 0x2b07137bd4d2 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x18324d2) [0x2b07137bd4d2] 04:43:46.950 29374 15 0x2b07137be213 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x1833213) [0x2b07137be213] 04:43:46.950 29374 16 0x2b070ba988be /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZNKSt8functionIFvvEEclEv+0x32) [0x2b070ba988be] 04:43:46.950 29374 17 0x2b0713780aa0 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x17f5aa0) [0x2b0713780aa0] 04:43:46.950 29374 18 0x2b07137b4384 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x1829384) [0x2b07137b4384] 04:43:46.950 29374 19 0x2b07149df0a4 /lib/x86_64-linux-gnu/libpthread.so.0(+0x80a4) [0x2b07149df0a4] 04:43:46.950 29374 20 0x2b071a6df04d /lib/x86_64-linux-gnu/libc.so.6(clone+0x6d) [0x2b071a6df04d] 04:43:46.950 29374 1 0x2b682a669a83 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(WTFCrash+0x1e) [0x2b682a669a83] 04:43:46.950 29374 2 0x2b6822a221e7 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN3IPC10Connection18connectionDidCloseEv+0x7d) [0x2b6822a221e7] 04:43:46.950 29374 3 0x2b6822e4b13c /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN3IPC10Connection16readyReadHandlerEv+0x11e) [0x2b6822e4b13c] 04:43:46.950 29374 4 0x2b6822e4b296 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0x4cb0296) [0x2b6822e4b296] 04:43:46.950 29374 5 0x2b6822e4c52e /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0x4cb152e) [0x2b6822e4c52e] 04:43:46.950 29374 6 0x2b682299c8be /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZNKSt8functionIFvvEEclEv+0x32) [0x2b682299c8be] 04:43:46.950 29374 7 0x2b682a6bd64d /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(_ZN3WTF15GMainLoopSource12voidCallbackEv+0x6d) [0x2b682a6bd64d] 04:43:46.950 29374 8 0x2b682a6bdd51 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(_ZN3WTF15GMainLoopSource18voidSourceCallbackEPS0_+0x23) [0x2b682a6bdd51] 04:43:46.950 29374 9 0x2b682d7383a5 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/DependenciesGTK/Root/lib64/libglib-2.0.so.0(+0x563a5) [0x2b682d7383a5] 04:43:46.950 29374 10 0x2b682d735a26 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/DependenciesGTK/Root/lib64/libglib-2.0.so.0(+0x53a26) [0x2b682d735a26] 04:43:46.950 29374 11 0x2b682d736854 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/DependenciesGTK/Root/lib64/libglib-2.0.so.0(g_main_context_dispatch+0x33) [0x2b682d736854] 04:43:46.950 29374 12 0x2b682d736a39 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/DependenciesGTK/Root/lib64/libglib-2.0.so.0(+0x54a39) [0x2b682d736a39] 04:43:46.950 29374 13 0x2b682d736e60 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/DependenciesGTK/Root/lib64/libglib-2.0.so.0(g_main_loop_run+0x1d7) [0x2b682d736e60] 04:43:46.950 29374 14 0x2b682a6c14d2 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x18324d2) [0x2b682a6c14d2] 04:43:46.950 29374 15 0x2b682a6c2213 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x1833213) [0x2b682a6c2213] 04:43:46.950 29374 16 0x2b682299c8be /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZNKSt8functionIFvvEEclEv+0x32) [0x2b682299c8be] 04:43:46.950 29374 17 0x2b682a684aa0 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x17f5aa0) [0x2b682a684aa0] 04:43:46.950 29374 18 0x2b682a6b8384 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x1829384) [0x2b682a6b8384] 04:43:46.950 29374 19 0x2b682b8e30a4 /lib/x86_64-linux-gnu/libpthread.so.0(+0x80a4) [0x2b682b8e30a4] 04:43:46.950 29374 20 0x2b68315e304d /lib/x86_64-linux-gnu/libc.so.6(clone+0x6d) [0x2b68315e304d] 1134871 1 263575 cgarcia 2015-10-20 05:55:17 -0700 Created attachment 263575 Patch 1134877 2 cgarcia 2015-10-20 08:05:31 -0700 Committed r191341: <http://trac.webkit.org/changeset/191341> 263575 2015-10-20 05:55:17 -0700 2015-10-20 07:19:52 -0700 Patch wk2-closed-connection.diff text/plain 2835 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwZDhlZWQ1Li44MjljZjdjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjkg QEAKIDIwMTUtMTAtMjAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFtVTklYXSBBU1NFUlRJT04gRkFJTEVEOiBtX3Nob3VsZFdhaXRGb3JTeW5j UmVwbGllcyBpbiBDb25uZWN0aW9uOjpjb25uZWN0aW9uRGlkQ2xvc2UoKQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwMzYxCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQgZG9lc24ndCBhbHdheXMgaGFw cGVuIGJlY2F1c2UgaXQgZGVwZW5kcyBvbiBob3cgc29ja2V0cyBhcmUKKyAgICAgICAgY2xvc2Vk LCBhbmQgdGhlIHN0YXRlIG9mIHRoZSB0aHJlYWRzLiBUaGUgcHJvYmxlbSBpcyB0aGF0IHdlIGFy ZQorICAgICAgICBub3QgaGFuZGxpbmcgdGhlIGNhc2Ugd2hlbiB0aGUgcmVhZCBmYWlscyBiZWNh dXNlIHdlIGNsb3NlZCB0aGUKKyAgICAgICAgY29ubmVjdGlvbi4gSW4gdGhhdCBjYXNlIHdlIGxv ZyB0aGUgZXJyb3IgYW5kIGNhbGwKKyAgICAgICAgQ29ubmVjdGlvbjo6Y29ubmVjdGlvbkRpZENs b3NlKCkuIEJ1dCBpdCB3YXMgY29ubmVjdGlvbkRpZENsb3NlKCkKKyAgICAgICAgdGhlIG9uZSBj bG9zaW5nIHRoZSBzb2NrZXQuIFNvLCBpbiB0aGlzIHBhcnRpY3VsYXIgY2FzZSBpdCdzIG5vdCBh bgorICAgICAgICBlcnJvciBidXQgYSBub3JtYWwgdGVybWluYXRpb24sIGFuZCB3ZSBzaG91bGRu J3QgdHJ5IHRvIGNsb3NlIHRoZQorICAgICAgICBjb25uZWN0aW9uIGFnYWluLiBTb21ldGhpbmcg c2ltaWxhciBjYW4gaGFwcGVuIHdoaWxlIHNlbmRpbmcgYQorICAgICAgICBtZXNzYWdlLCBhbmQg d2UgZ2V0IGEgYnJva2VuIHBpcGUgZXJyb3IsIGJ1dCBpbiB0aGF0IGNhc2Ugd2UgYXJlCisgICAg ICAgIG9ubHkgcHJpbnRpbmcgdGhlIGVycm9yLCBzbyBpdCdzIGhhcm1sZXNzLgorCisgICAgICAg ICogUGxhdGZvcm0vSVBDL3VuaXgvQ29ubmVjdGlvblVuaXguY3BwOgorICAgICAgICAoSVBDOjpD b25uZWN0aW9uOjpyZWFkeVJlYWRIYW5kbGVyKTogT25seSBwcmludCBlcnJvciBhbmQgY2FsbAor ICAgICAgICBjb25uZWN0aW9uRGlkQ2xvc2UoKSBpZiB3ZSBhcmUgc3RpbGwgY29ubmVjdGVkIHdo ZW4gcmVhZCBmYWlscy4KKyAgICAgICAgKElQQzo6Q29ubmVjdGlvbjo6c2VuZE91dGdvaW5nTWVz c2FnZSk6IE9ubHkgcHJpbnQgZXJyb3IgaWYgd2UgYXJlCisgICAgICAgIHN0aWxsIGNvbm5lY3Rl ZCB3aGVuIHNlbmQgZmFpbHMuCisKKzIwMTUtMTAtMjAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8 Y2dhcmNpYUBpZ2FsaWEuY29tPgorCiAgICAgICAgIFtHVEtdIEdyYXBoaWNzIGNvcnJ1cHRpb24g d2hlbiBlbnRlcmluZy9sZWF2aW5nIEFDIG1vZGUgcXVpY2tseQogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwMzIzCiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1BsYXRmb3JtL0lQQy91bml4L0Nvbm5lY3Rpb25Vbml4LmNwcCBiL1NvdXJjZS9X ZWJLaXQyL1BsYXRmb3JtL0lQQy91bml4L0Nvbm5lY3Rpb25Vbml4LmNwcAppbmRleCA4Y2Y3ZDJm Li4yZTcyYzU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9JUEMvdW5peC9D b25uZWN0aW9uVW5peC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vSVBDL3VuaXgv Q29ubmVjdGlvblVuaXguY3BwCkBAIC0zMzgsOCArMzM4LDEwIEBAIHZvaWQgQ29ubmVjdGlvbjo6 cmVhZHlSZWFkSGFuZGxlcigpCiAgICAgICAgICAgICBpZiAoZXJybm8gPT0gRUFHQUlOIHx8IGVy cm5vID09IEVXT1VMREJMT0NLKQogICAgICAgICAgICAgICAgIHJldHVybjsKIAotICAgICAgICAg ICAgV1RGTG9nQWx3YXlzKCJFcnJvciByZWNlaXZpbmcgSVBDIG1lc3NhZ2Ugb24gc29ja2V0ICVk IGluIHByb2Nlc3MgJWQ6ICVzIiwgbV9zb2NrZXREZXNjcmlwdG9yLCBnZXRwaWQoKSwgc3RyZXJy b3IoZXJybm8pKTsKLSAgICAgICAgICAgIGNvbm5lY3Rpb25EaWRDbG9zZSgpOworICAgICAgICAg ICAgaWYgKG1faXNDb25uZWN0ZWQpIHsKKyAgICAgICAgICAgICAgICBXVEZMb2dBbHdheXMoIkVy cm9yIHJlY2VpdmluZyBJUEMgbWVzc2FnZSBvbiBzb2NrZXQgJWQgaW4gcHJvY2VzcyAlZDogJXMi LCBtX3NvY2tldERlc2NyaXB0b3IsIGdldHBpZCgpLCBzdHJlcnJvcihlcnJubykpOworICAgICAg ICAgICAgICAgIGNvbm5lY3Rpb25EaWRDbG9zZSgpOworICAgICAgICAgICAgfQogICAgICAgICAg ICAgcmV0dXJuOwogICAgICAgICB9CiAKQEAgLTUxMyw3ICs1MTUsOCBAQCBib29sIENvbm5lY3Rp b246OnNlbmRPdXRnb2luZ01lc3NhZ2Uoc3RkOjp1bmlxdWVfcHRyPE1lc3NhZ2VFbmNvZGVyPiBl bmNvZGVyKQogICAgICAgICAgICAgY29udGludWU7CiAgICAgICAgIH0KIAotICAgICAgICBXVEZM b2dBbHdheXMoIkVycm9yIHNlbmRpbmcgSVBDIG1lc3NhZ2U6ICVzIiwgc3RyZXJyb3IoZXJybm8p KTsKKyAgICAgICAgaWYgKG1faXNDb25uZWN0ZWQpCisgICAgICAgICAgICBXVEZMb2dBbHdheXMo IkVycm9yIHNlbmRpbmcgSVBDIG1lc3NhZ2U6ICVzIiwgc3RyZXJyb3IoZXJybm8pKTsKICAgICAg ICAgcmV0dXJuIGZhbHNlOwogICAgIH0KICAgICByZXR1cm4gdHJ1ZTsK