150349 2015-10-19 17:44:09 -0700 AX: : CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::AccessibilityTable::tableElement const + 116 2016-07-13 13:21:04 -0700 1 1 1 Unclassified WebKit Accessibility Safari 9 All All RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach aboxhall apinheiro ap commit-queue ddkilzer dmazzoni jcraig jdiggs mario samuel_white webkit-bug-importer oldest_to_newest 1134766 0 cfleizach 2015-10-19 17:44:09 -0700 100 com.apple.WebCore: WebCore::AccessibilityTable::tableElement const + 116 <== 100 com.apple.WebCore: WebCore::AccessibilityTable::isDataTable const + 153 100 com.apple.WebCore: WebCore::AccessibilityTable::isTableExposableThroughAccessibility const + 45 100 com.apple.WebCore: WebCore::AccessibilityTable::init + 33 96 com.apple.WebCore: WebCore::AXObjectCache::getOrCreate + 3221 | 83 com.apple.WebCore: WebCore::AccessibilityRenderObject::addChildren + 47 | | 83 com.apple.WebCore: WebCore::AccessibilityNodeObject::insertChild + 76 | | 83 com.apple.WebCore: WebCore::AccessibilityRenderObject::addChildren + 82 <rdar://problem/23103005> 1134767 1 263537 cfleizach 2015-10-19 17:49:02 -0700 Created attachment 263537 patch 1134997 2 263537 bfulgham 2015-10-20 13:50:34 -0700 Comment on attachment 263537 patch This looks reasonable to me. Will 'ancestorsOfType' traverse farther than we intend in this case? Or is that actually a benefit of this change? 1135002 3 cfleizach 2015-10-20 13:55:58 -0700 (In reply to comment #2) > Comment on attachment 263537 [details] > patch > > This looks reasonable to me. Will 'ancestorsOfType' traverse farther than we > intend in this case? Or is that actually a benefit of this change? I think thats actually a benefit here. Thanks! 1135011 4 263537 commit-queue 2015-10-20 14:35:03 -0700 Comment on attachment 263537 patch Clearing flags on attachment: 263537 Committed r191357: <http://trac.webkit.org/changeset/191357> 1135012 5 commit-queue 2015-10-20 14:35:08 -0700 All reviewed patches have been landed. Closing bug. 1210618 6 bfulgham 2016-07-13 13:21:04 -0700 *** Bug 149084 has been marked as a duplicate of this bug. *** 263537 2015-10-19 17:49:02 -0700 2015-10-20 14:35:03 -0700 patch patch text/plain 2186 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5MTMyNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE1LTEwLTE5ICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IENyYXNoVHJhY2Vy OiBjb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQgYXQgY29tLmFwcGxlLldlYkNvcmU6IFdlYkNv cmU6OkFjY2Vzc2liaWxpdHlUYWJsZTo6dGFibGVFbGVtZW50IGNvbnN0ICsgMTE2CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTAzNDkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgY3Jhc2ggcG9pbnQg Zm9yIHRoaXMgYnVnIHNheXMgdGhhdCB0aGUgcGFyZW50RWxlbWVudCBvZiB0aGUgZmlyc3RCb2R5 IGlzIGdhcmJhZ2Ugd2hlbiBpdCdzIGFjY2Vzc2VkLiAKKyAgICAgICAgVW5mb3J0dW5hdGVseSwg SSBjb3VsZCBub3QgcmVwcm9kdWNlIHRoaXMgaW4tc2l0dSBvciB3aXRoIGEgdGVzdC4gCisgICAg ICAgIFNvIG15IHNwZWN1bGF0aXZlIHNvbHV0aW9uIGlzIHRvIHJlY2FsY3VsYXRlIHRob3NlIGJv ZHkgZWxlbWVudHMgdG8gZW5zdXJlIHRoYXQgdGhleSdyZSB2YWxpZCBiZWZvcmUgd2UgYWNjZXNz LgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5VGFibGUuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eVRhYmxlOjp0YWJsZUVsZW1lbnQpOgorICAgICAg ICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eVRhYmxlOjppc0RhdGFUYWJsZSk6CisKIDIwMTUtMTAt MTkgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAgICBI b3N0IEdyYXBoaWNzQ29udGV4dCdzIENUTSBpbnNpZGUgR3JhcGhpY3NDb250ZXh0U3RhdGUKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVRhYmxlLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlU YWJsZS5jcHAJKHJldmlzaW9uIDE5MTA0NikKKysrIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxp dHkvQWNjZXNzaWJpbGl0eVRhYmxlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTAxLDE3ICsxMDEs MTUgQEAKICAgICBpZiAoaXM8SFRNTFRhYmxlRWxlbWVudD4odGFibGUuZWxlbWVudCgpKSkKICAg ICAgICAgcmV0dXJuIGRvd25jYXN0PEhUTUxUYWJsZUVsZW1lbnQ+KHRhYmxlLmVsZW1lbnQoKSk7 CiAgICAgCisgICAgdGFibGUuZm9yY2VTZWN0aW9uc1JlY2FsYygpOworCiAgICAgLy8gSWYgdGhl IHRhYmxlIGhhcyBhIGRpc3BsYXk6dGFibGUtcm93LWdyb3VwLCB0aGVuIHRoZSBSZW5kZXJUYWJs ZSBkb2VzIG5vdCBoYXZlIGEgcG9pbnRlciB0byBpdCdzIEhUTUxUYWJsZUVsZW1lbnQuCiAgICAg Ly8gV2UgY2FuIGluc3RlYWQgZmluZCBpdCBieSBhc2tpbmcgdGhlIGZpcnN0U2VjdGlvbiBmb3Ig aXRzIHBhcmVudC4KICAgICBSZW5kZXJUYWJsZVNlY3Rpb24qIGZpcnN0Qm9keSA9IHRhYmxlLmZp cnN0Qm9keSgpOwogICAgIGlmICghZmlyc3RCb2R5IHx8ICFmaXJzdEJvZHktPmVsZW1lbnQoKSkK ICAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAgICAgCi0gICAgRWxlbWVudCogYWN0dWFsVGFibGUg PSBmaXJzdEJvZHktPmVsZW1lbnQoKS0+cGFyZW50RWxlbWVudCgpOwotICAgIGlmICghaXM8SFRN TFRhYmxlRWxlbWVudD4oYWN0dWFsVGFibGUpKQotICAgICAgICByZXR1cm4gbnVsbHB0cjsKLSAg ICAKLSAgICByZXR1cm4gZG93bmNhc3Q8SFRNTFRhYmxlRWxlbWVudD4oYWN0dWFsVGFibGUpOwor ICAgIHJldHVybiBhbmNlc3RvcnNPZlR5cGU8SFRNTFRhYmxlRWxlbWVudD4oKihmaXJzdEJvZHkt PmVsZW1lbnQoKSkpLmZpcnN0KCk7CiB9CiAgICAgCiBib29sIEFjY2Vzc2liaWxpdHlUYWJsZTo6 aXNEYXRhVGFibGUoKSBjb25zdAo=