150348 2015-10-19 17:31:07 -0700 Media "ended" event incorrectly fires when currentTime is set 2016-01-25 09:55:31 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build All Other RESOLVED FIXED InRadar P2 Major --- 1 andrewleung eric.carlson adesroches commit-queue eric.carlson jer.noble jonlee webkit-bug-importer oldest_to_newest 1134763 0 263535 andrewleung 2015-10-19 17:31:07 -0700 Created attachment 263535 Sample HTML page with an externally-linked audio file to demonstrate the bug The Media "ended" event appears to fire incorrectly when the currentTime property is altered after the media has ended playback. When that happens, the event does not fire properly again until after the playback ends a second time. I attached a sample HTML file to demonstrate the issue. Steps to reproduce: 1. On a page that has a video/audio element, attach an "ended" event listener 2. In the event handler, alert a message 3. In the event handler, sets the currentTime property to 0 4. Play the video/audio until it ends 5. Play the video/audio a second time until it ends Expected results: The message should be alerted only once every time the playback ends. Actual results: The message gets alerted twice at the end of the first playback. The message does not get alerted at all at the end of the second playback. Tested browsers: Safari 8.0.8 on OS X 10.10.5 -- NOT affected Safari 9.0 on OS X 10.10.5 -- affected Safari 9.0 on OS X 10.11 -- affected WebKit r191315 on OS X 10.10.5 -- affected MobileSafari on iOS 8.4.1 -- NOT affected MobileSafari on iOS 9.0.2 -- affected 1156771 1 webkit-bug-importer 2016-01-19 15:49:18 -0800 <rdar://problem/24247974> 1158326 2 269751 eric.carlson 2016-01-25 08:04:21 -0800 Created attachment 269751 Proposed patch. 1158361 3 269751 commit-queue 2016-01-25 09:55:26 -0800 Comment on attachment 269751 Proposed patch. Clearing flags on attachment: 269751 Committed r195540: <http://trac.webkit.org/changeset/195540> 1158362 4 commit-queue 2016-01-25 09:55:31 -0800 All reviewed patches have been landed. Closing bug. 263535 2015-10-19 17:31:07 -0700 2015-10-19 17:31:58 -0700 Sample HTML page with an externally-linked audio file to demonstrate the bug file_150348.txt text/html 631 andrewleung PCFET0NUWVBFIGh0bWw+DQo8aHRtbD4NCjxoZWFkPg0KICA8dGl0bGU+TWVkaWEgYGVuZGVkYCBl dmVudCBidWcgdGVzdDwvdGl0bGU+DQo8L2hlYWQ+DQo8Ym9keT4NCiAgPHA+UGxheSB0aGUgYXVk aW8uIFRoZSBicm93c2VyIHNob3VsZCBhbGVydCAmcXVvdDs8ZW0+VGhlIGF1ZGlvIGhhcyBlbmRl ZDwvZW0+JnF1b3Q7IDxzdHJvbmc+b25seSBvbmNlPC9zdHJvbmc+IGV2ZXJ5IHRpbWUgdGhlIHBs YXliYWNrIGVuZHMuPC9wPg0KICA8YXVkaW8gaWQ9InRlc3RfY2FzZSIgY29udHJvbHM+DQogICAg PHNvdXJjZSBzcmM9Imh0dHA6Ly93d3cudzNzY2hvb2xzLmNvbS90YWdzL2hvcnNlLm1wMyIgdHlw ZT0iYXVkaW8vbXBlZyI+DQogICAgPHNvdXJjZSBzcmM9Imh0dHA6Ly93d3cudzNzY2hvb2xzLmNv bS90YWdzL2hvcnNlLm9nZyIgdHlwZT0iYXVkaW8vb2dnIj4NCiAgPC9hdWRpbz4NCiAgPHNjcmlw dD4NCiAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndGVzdF9jYXNlJykub25lbmRlZCA9IGZ1 bmN0aW9uICgpIHsNCiAgICAgIGFsZXJ0KCdUaGUgYXVkaW8gaGFzIGVuZGVkJyk7DQogICAgICB0 aGlzLmN1cnJlbnRUaW1lID0gMDsNCiAgICB9Ow0KICA8L3NjcmlwdD4NCjwvYm9keT4NCjwvaHRt bD4NCg== 269751 2016-01-25 08:04:21 -0800 2016-01-25 09:55:26 -0800 Proposed patch. ended_event_fired_once_patch_2.txt text/plain 4841 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5NTUzMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTAxLTI1ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIE1lZGlhICJlbmRlZCIg ZXZlbnQgaW5jb3JyZWN0bHkgZmlyZXMgd2hlbiBjdXJyZW50VGltZSBpcyBzZXQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDM0OAorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vMjQyNDc5NzQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGVzdDogbWVkaWEvbWVkaWEtZW5kZWQtZmlyZWQtb25jZS5odG1s CisKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6SFRNTE1lZGlhRWxlbWVudDo6aW52YWxpZGF0ZUNhY2hlZFRpbWUpOiBBbHdheXMgbWFyayBt X2NhY2hlZFRpbWUgYXMgaW52YWxpZC4KKwogMjAxNi0wMS0yNSAgWW91ZW5uIEZhYmxldCAgPHlv dWVubi5mYWJsZXRAY3JmLmNhbm9uLmZyPgogCiAgICAgICAgIFdlYkNvcmVKU0J1aWx0aW5zIGRv IG5vdCB1c2UgdG8gZG8gY29uZGl0aW9uYWwgaW5jbHVkZQpJbmRleDogU291cmNlL1dlYkNvcmUv aHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCShyZXZpc2lvbiAxOTU1MzIpCisrKyBTb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNjg3LDYg KzI2ODcsNyBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OnJlZnJlc2hDYWNoZWRUaW1lCiAKIHZv aWQgSFRNTE1lZGlhRWxlbWVudDo6aW52YWxpZGF0ZUNhY2hlZFRpbWUoKSBjb25zdAogeworICAg IG1fY2FjaGVkVGltZSA9IE1lZGlhVGltZTo6aW52YWxpZFRpbWUoKTsKICAgICBpZiAoIW1fcGxh eWVyIHx8ICFtX3BsYXllci0+bWF4aW11bUR1cmF0aW9uVG9DYWNoZU1lZGlhVGltZSgpKQogICAg ICAgICByZXR1cm47CiAKQEAgLTI3MDEsNyArMjcwMiw2IEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVu dDo6aW52YWxpZGF0ZUNhY2hlZFQKICAgICBzdGF0aWMgY29uc3QgZG91YmxlIG1pbmltdW1UaW1l UGxheWluZ0JlZm9yZUNhY2hlU25hcHNob3QgPSAwLjU7CiAKICAgICBtX21pbmltdW1DbG9ja1Rp bWVUb1VwZGF0ZUNhY2hlZFRpbWUgPSBtb25vdG9uaWNhbGx5SW5jcmVhc2luZ1RpbWUoKSArIG1p bmltdW1UaW1lUGxheWluZ0JlZm9yZUNhY2hlU25hcHNob3Q7Ci0gICAgbV9jYWNoZWRUaW1lID0g TWVkaWFUaW1lOjppbnZhbGlkVGltZSgpOwogfQogCiAvLyBwbGF5YmFjayBzdGF0ZQpJbmRleDog TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxv ZwkocmV2aXNpb24gMTk1NTMyKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTYtMDEtMjUgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2Fy bHNvbkBhcHBsZS5jb20+CisKKyAgICAgICAgTWVkaWEgImVuZGVkIiBldmVudCBpbmNvcnJlY3Rs eSBmaXJlcyB3aGVuIGN1cnJlbnRUaW1lIGlzIHNldAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUwMzQ4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8y NDI0Nzk3ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIG1lZGlhL21lZGlhLWVuZGVkLWZpcmVkLW9uY2UtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAg ICAgICAgKiBtZWRpYS9tZWRpYS1lbmRlZC1maXJlZC1vbmNlLmh0bWw6IEFkZGVkLgorCiAyMDE2 LTAxLTI1ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CiAKICAg ICAgICAgW0ZldGNoIEFQSV0gSW1wbGVtZW50IEZldGNoIEFQSSBIZWFkZXJzCkluZGV4OiBMYXlv dXRUZXN0cy9tZWRpYS9tZWRpYS1lbmRlZC1maXJlZC1vbmNlLWV4cGVjdGVkLnR4dAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9tZWRpYS9tZWRpYS1lbmRlZC1maXJlZC1vbmNlLWV4cGVjdGVk LnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL21lZGlhL21lZGlhLWVuZGVkLWZpcmVk LW9uY2UtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTcgQEAKKworVGVz dCAnZW5kZWQnIGV2ZW50IGJ5OgorCitQbGF5aW5nIHRvIHRoZSBlbmQuCitXaGVuICdlbmRlZCcg ZXZlbnQgZmlyZXMsIHNlZWsgdG8gMC4KK1ZlcmlmeSB0aGF0ICdlbmRlZCcgZXZlbnQgaXMgbm90 IGZpcmVkIGFnYWluLgorCitFVkVOVChjYW5wbGF5dGhyb3VnaCkKK1JVTihhdWRpby5jdXJyZW50 VGltZSA9IDEuMCkKK1JVTihhdWRpby5wbGF5KCkpCisKK0VWRU5UKGVuZGVkKQorRVhQRUNURUQg KGF1ZGlvLmVuZGVkID09ICd0cnVlJykgT0sKK1JVTihhdWRpby5jdXJyZW50VGltZSA9IDApCisK K0VORCBPRiBURVNUCisKSW5kZXg6IExheW91dFRlc3RzL21lZGlhL21lZGlhLWVuZGVkLWZpcmVk LW9uY2UuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9tZWRpYS9tZWRpYS1lbmRlZC1m aXJlZC1vbmNlLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9tZWRpYS9tZWRpYS1l bmRlZC1maXJlZC1vbmNlLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSw1OCBAQAorPCFE T0NUWVBFIGh0bWw+Cis8aHRtbD4KKyAgICA8aGVhZD4KKyAgICAgICAgPHNjcmlwdCBzcmM9bWVk aWEtZmlsZS5qcz48L3NjcmlwdD4KKyAgICAgICAgPHNjcmlwdCBzcmM9dmlkZW8tdGVzdC5qcz48 L3NjcmlwdD4KKworICAgICAgICA8c2NyaXB0PgorICAgICAgICAgICAgdmFyIGVuZGVkQ291bnQg PSAwOworICAgICAgICAgICAgdmFyIGF1ZGlvOworCisgICAgICAgICAgICBmdW5jdGlvbiBzdGFy dCgpCisgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgY29uc29sZVdyaXRlKCIiKTsKKyAg ICAgICAgICAgICAgICBhdWRpbyA9IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoImF1ZGlvIik7Cisg ICAgICAgICAgICAgICAgd2FpdEZvckV2ZW50KCJlbmRlZCIsIGVuZGVkKTsKKyAgICAgICAgICAg ICAgICB3YWl0Rm9yRXZlbnQoImNhbnBsYXl0aHJvdWdoIiwgY2FucGxheXRocm91Z2gpOworCisg ICAgICAgICAgICAgICAgYXVkaW8uc3JjID0gZmluZE1lZGlhRmlsZSgiYXVkaW8iLCAiY29udGVu dC9zaWxlbmNlIikKKyAgICAgICAgICAgIH0KKworICAgICAgICAgICAgZnVuY3Rpb24gY2FucGxh eXRocm91Z2goKQorICAgICAgICAgICAgeworICAgICAgICAgICAgICAgIHJ1bigiYXVkaW8uY3Vy cmVudFRpbWUgPSAxLjAiKTsKKyAgICAgICAgICAgICAgICBydW4oImF1ZGlvLnBsYXkoKSIpOwor ICAgICAgICAgICAgICAgIGNvbnNvbGVXcml0ZSgiIik7CisgICAgICAgICAgICB9CisKKyAgICAg ICAgICAgIGZ1bmN0aW9uIGVuZGVkKCkKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICBz d2l0Y2ggKCsrZW5kZWRDb3VudCkKKyAgICAgICAgICAgICAgICB7CisgICAgICAgICAgICAgICAg ICAgIGNhc2UgMToKKyAgICAgICAgICAgICAgICAgICAgICAgIHRlc3RFeHBlY3RlZCgiYXVkaW8u ZW5kZWQiLCB0cnVlKTsKKworICAgICAgICAgICAgICAgICAgICAgICAgcnVuKCJhdWRpby5jdXJy ZW50VGltZSA9IDAiKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIHNldFRpbWVvdXQoZW5kVGVz dCwgMjAwKTsKKworICAgICAgICAgICAgICAgICAgICAgICAgY29uc29sZVdyaXRlKCIiKTsKKyAg ICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgICAgICAgICBkZWZhdWx0 OgorICAgICAgICAgICAgICAgICAgICAgICAgY29uc29sZVdyaXRlKCIiKTsKKyAgICAgICAgICAg ICAgICAgICAgICAgIGZhaWxUZXN0KCInZW5kZWQnIGV2ZW50IGZpcmVkIGFnYWluIik7CisgICAg ICAgICAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgICAgICB9CisgICAgICAgICAg ICB9CisgICAgICAgIDwvc2NyaXB0PgorICAgIDwvaGVhZD4KKyAgICA8Ym9keSBvbmxvYWQ9InN0 YXJ0KCkiPgorICAgICAgICA8YXVkaW8gY29udHJvbHM+PC9hdWRpbz4KKyAgICAgICAgPHA+PGI+ VGVzdCAnZW5kZWQnIGV2ZW50IGJ5OjwvYj4KKyAgICAgICAgICAgIDxvbD4KKyAgICAgICAgICAg ICAgICA8bGk+UGxheWluZyB0byB0aGUgZW5kLjwvbGk+CisgICAgICAgICAgICAgICAgPGxpPldo ZW4gJ2VuZGVkJyBldmVudCBmaXJlcywgc2VlayB0byAwLjwvbGk+CisgICAgICAgICAgICAgICAg PGxpPlZlcmlmeSB0aGF0ICdlbmRlZCcgZXZlbnQgaXMgbm90IGZpcmVkIGFnYWluLjwvbGk+Cisg ICAgICAgICAgICA8L29sPgorICAgICAgICA8L3A+CisgICAgPC9ib2R5PgorPC9odG1sPgo=