150343 2015-10-19 14:58:34 -0700 Make sure development Safari does not delete the stable Safari cache storage. 2015-10-19 17:02:26 -0700 1 1 1 Unclassified WebKit WebKit2 Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez cgarcia commit-queue koivisto oldest_to_newest 1134708 0 cdumez 2015-10-19 14:58:34 -0700 Make sure development WebKit does not delete the stable WebKit cache storage. Development Safari now uses Version 5, while the last stable Safari uses Version 4. Since the 2 versions can co-exist, it is best not to drop the old cache version (4) at this point. 1134713 1 263516 cdumez 2015-10-19 15:02:22 -0700 Created attachment 263516 Patch 1134723 2 263516 koivisto 2015-10-19 15:24:59 -0700 Comment on attachment 263516 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=263516&action=review > Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:1028 > + const unsigned preservedOldVersion = 4; Might be good to add a comment explaining this. Also we might want to make this PLATFORM(MAC) as this is not useful at least on iOS. 1134737 3 263523 cdumez 2015-10-19 16:14:34 -0700 Created attachment 263523 Patch 1134750 4 263523 commit-queue 2015-10-19 17:02:19 -0700 Comment on attachment 263523 Patch Clearing flags on attachment: 263523 Committed r191321: <http://trac.webkit.org/changeset/191321> 1134751 5 commit-queue 2015-10-19 17:02:26 -0700 All reviewed patches have been landed. Closing bug. 263516 2015-10-19 15:02:22 -0700 2015-10-19 16:14:23 -0700 Patch bug-150343-20151019150140.patch text/plain 1878 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxMzE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzhiMDM4ZDg4Yjg5NDVi ZWE4NWQwOTkxODYwNzA4MTE5NDFjM2FjNC4uYzRmOTA0NDkwNjIwYzQ3NDU5YjQyMzdhOTA3ZDA0 YjJmZDQ3MTg4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTEwLTE5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgTWFrZSBzdXJlIGRldmVsb3Bt ZW50IFNhZmFyaSBkb2VzIG5vdCBkZWxldGUgdGhlIHN0YWJsZSBTYWZhcmkgY2FjaGUgc3RvcmFn ZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDM0 MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2Ug c3VyZSBkZXZlbG9wbWVudCBTYWZhcmkgZG9lcyBub3QgZGVsZXRlIHRoZSBzdGFibGUgU2FmYXJp IGRpc2sgY2FjaGUKKyAgICAgICAgc3RvcmFnZS4gRGV2ZWxvcG1lbnQgU2FmYXJpIG5vdyB1c2Vz IFZlcnNpb24gNSwgd2hpbGUgdGhlIGxhc3Qgc3RhYmxlCisgICAgICAgIFNhZmFyaSB1c2VzIFZl cnNpb24gNC4gU2luY2UgdGhlIDIgdmVyc2lvbnMgY2FuIGNvLWV4aXN0LCBpdCBpcyBiZXN0IG5v dAorICAgICAgICB0byBkcm9wIHRoZSBvbGQgY2FjaGUgdmVyc2lvbiAoNCkgYXQgdGhpcyBwb2lu dC4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZVN0b3JhZ2Uu Y3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrQ2FjaGU6OlN0b3JhZ2U6OmRlbGV0ZU9sZFZl cnNpb25zKToKKwogMjAxNS0xMC0xOSAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtp dC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjE5MTMwNy4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZVN0 b3JhZ2UuY3BwIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0Nh Y2hlU3RvcmFnZS5jcHAKaW5kZXggMDBhNzUxMDA0MTM4MjUyZDZkNTk4N2IyZWE1YmYwODM4M2Rl NzU5OS4uYTllOWEyYTRkMDcyZjczZmRkNzE5ZDk0NDNmMGY2OTIzNmE2YzVjYSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlU3RvcmFn ZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0Nh Y2hlU3RvcmFnZS5jcHAKQEAgLTEwMjUsNyArMTAyNSw4IEBAIHZvaWQgU3RvcmFnZTo6ZGVsZXRl T2xkVmVyc2lvbnMoKQogICAgICAgICAgICAgdW5zaWduZWQgZGlyZWN0b3J5VmVyc2lvbiA9IHZl cnNpb25TdHJpbmcudG9VSW50U3RyaWN0KCZzdWNjZXNzKTsKICAgICAgICAgICAgIGlmICghc3Vj Y2VzcykKICAgICAgICAgICAgICAgICByZXR1cm47Ci0gICAgICAgICAgICBpZiAoZGlyZWN0b3J5 VmVyc2lvbiA+PSB2ZXJzaW9uKQorICAgICAgICAgICAgY29uc3QgdW5zaWduZWQgcHJlc2VydmVk T2xkVmVyc2lvbiA9IDQ7CisgICAgICAgICAgICBpZiAoZGlyZWN0b3J5VmVyc2lvbiA+PSB2ZXJz aW9uIHx8IGRpcmVjdG9yeVZlcnNpb24gPT0gcHJlc2VydmVkT2xkVmVyc2lvbikKICAgICAgICAg ICAgICAgICByZXR1cm47CiAKICAgICAgICAgICAgIGF1dG8gb2xkVmVyc2lvblBhdGggPSBXZWJD b3JlOjpwYXRoQnlBcHBlbmRpbmdDb21wb25lbnQoY2FjaGVQYXRoLCBzdWJkaXJOYW1lKTsK 263523 2015-10-19 16:14:34 -0700 2015-10-19 17:02:19 -0700 Patch bug-150343-20151019161352.patch text/plain 2027 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTkxMzIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYjIxOGIwYTBlZTE3YmRh NGM1OGU2ODQ1YjA2ZWM0YjhlNjBkNDgxMC4uNWQ1YWMwMjBlNDIwOWNiZTBlMGI3ZDgwN2EwYmU2 NjI2ODI5MTUzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE1LTEwLTE5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgTWFrZSBzdXJlIGRldmVsb3Bt ZW50IFNhZmFyaSBkb2VzIG5vdCBkZWxldGUgdGhlIHN0YWJsZSBTYWZhcmkgY2FjaGUgc3RvcmFn ZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MDM0 MworCisgICAgICAgIFJldmlld2VkIGJ5IEFudHRpIEtvaXZpc3RvLgorCisgICAgICAgIE1ha2Ug c3VyZSBkZXZlbG9wbWVudCBTYWZhcmkgZG9lcyBub3QgZGVsZXRlIHRoZSBzdGFibGUgU2FmYXJp IGRpc2sgY2FjaGUKKyAgICAgICAgc3RvcmFnZS4gRGV2ZWxvcG1lbnQgU2FmYXJpIG5vdyB1c2Vz IFZlcnNpb24gNSwgd2hpbGUgdGhlIGxhc3Qgc3RhYmxlCisgICAgICAgIFNhZmFyaSB1c2VzIFZl cnNpb24gNC4gU2luY2UgdGhlIDIgdmVyc2lvbnMgY2FuIGNvLWV4aXN0LCBpdCBpcyBiZXN0IG5v dAorICAgICAgICB0byBkcm9wIHRoZSBvbGQgY2FjaGUgdmVyc2lvbiAoNCkgYXQgdGhpcyBwb2lu dC4KKworICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZVN0b3JhZ2Uu Y3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrQ2FjaGU6OlN0b3JhZ2U6OmRlbGV0ZU9sZFZl cnNpb25zKToKKwogMjAxNS0xMC0xOSAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxl LmNvbT4KIAogICAgICAgICBXS1ZpZXcgYmVpbmcgaW5zaWRlIFdLV2ViVmlldyBsZWFkcyB0byB3 ZWlyZCBBUEkgaXNzdWVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vz cy9jYWNoZS9OZXR3b3JrQ2FjaGVTdG9yYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQ cm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZVN0b3JhZ2UuY3BwCmluZGV4IDAwYTc1MTAwNDEzODI1 MmQ2ZDU5ODdiMmVhNWJmMDgzODNkZTc1OTkuLmU0NzUwMTU5NWVlOGRjNTg0ZDc2MTc4ODhmMTE0 ZTUyYWFhNzFkYjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2Nh Y2hlL05ldHdvcmtDYWNoZVN0b3JhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQ cm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZVN0b3JhZ2UuY3BwCkBAIC0xMDI4LDYgKzEwMjgsMTMg QEAgdm9pZCBTdG9yYWdlOjpkZWxldGVPbGRWZXJzaW9ucygpCiAgICAgICAgICAgICBpZiAoZGly ZWN0b3J5VmVyc2lvbiA+PSB2ZXJzaW9uKQogICAgICAgICAgICAgICAgIHJldHVybjsKIAorI2lm IFBMQVRGT1JNKE1BQykKKyAgICAgICAgICAgIC8vIEFsbG93IHRoZSBsYXN0IHN0YWJsZSB2ZXJz aW9uIG9mIHRoZSBjYWNoZSB0byBjby1leGlzdCB3aXRoIHRoZSBsYXRlc3QgZGV2ZWxvcG1lbnQg b25lIG9uIE1hYy4KKyAgICAgICAgICAgIGNvbnN0IHVuc2lnbmVkIGxhc3RTdGFibGVWZXJzaW9u ID0gNDsKKyAgICAgICAgICAgIGlmIChkaXJlY3RvcnlWZXJzaW9uID09IGxhc3RTdGFibGVWZXJz aW9uKQorICAgICAgICAgICAgICAgIHJldHVybjsKKyNlbmRpZgorCiAgICAgICAgICAgICBhdXRv IG9sZFZlcnNpb25QYXRoID0gV2ViQ29yZTo6cGF0aEJ5QXBwZW5kaW5nQ29tcG9uZW50KGNhY2hl UGF0aCwgc3ViZGlyTmFtZSk7CiAgICAgICAgICAgICBMT0coTmV0d29ya0NhY2hlU3RvcmFnZSwg IihOZXR3b3JrUHJvY2VzcykgZGVsZXRpbmcgb2xkIGNhY2hlIHZlcnNpb24sIHBhdGggJXMiLCBv bGRWZXJzaW9uUGF0aC51dGY4KCkuZGF0YSgpKTsKIAo=